Attention is currently required from: pespin, fixeria.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31126 )
Change subject: abis_rsl: add ericsson specific paging group IE to rsl_ericsson_imm_assign_cmd
......................................................................
Patch Set 4:
(1 comment)
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31126/comment/e837b931_4b6e194b
PS3, Line 484: extract_paging_group
> > Paging group is needed when sending Immediate Assignment over PCH. […]
I am a bit puzzled as well here but I think I remember now. There was the problem with the DL TBF and sending the Immediate Assignment via PCH solved it. So the Immediate assignment here goes through the PCH and not through the AGCH. I have corrected this here for now.
The SAPI PCU_IF_SAPI_AGCH_DT is not used in osmo-pcu.git, thats correct. The patch is still in review, see: I2a78651593323e8b9627c39918d949a33497b70f - but as far as I can see it also still uses the wrong terminology s/AGCH/PCH.
Its the case that we have to use an ericsson proprietary way to handle this. Unfortunately the code seems to be a bit out of place now. Maybe we should add a SAPI PCU_IF_SAPI_PCH_ERIC or so that handles this. I am not entirely sure.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31126
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I4452f4973d1ec69c96aad527b057226e8a6edf99
Gerrit-Change-Number: 31126
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 01 Feb 2023 16:09:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin, fixeria.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31126
to look at the new patch set (#4).
Change subject: abis_rsl: add ericsson specific paging group IE to rsl_ericsson_imm_assign_cmd
......................................................................
abis_rsl: add ericsson specific paging group IE to rsl_ericsson_imm_assign_cmd
The immediate assign command used with ericsson BTSs supports a
proprietary paging group IE, which is required for GPRS support.
Change-Id: I4452f4973d1ec69c96aad527b057226e8a6edf99
Related: OS#5198
---
M include/osmocom/bsc/abis_rsl.h
M src/osmo-bsc/abis_rsl.c
M src/osmo-bsc/pcu_sock.c
3 files changed, 55 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/26/31126/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31126
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I4452f4973d1ec69c96aad527b057226e8a6edf99
Gerrit-Change-Number: 31126
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31148 )
Change subject: pcu_l1_if.cpp: handle immediate assignment confirmation
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
btw, just to make sure you are aware and you are doing it right, iirc this confirmation is only sent to the PCU for ImmAss on the PCH right now (DL TBF), but not for the ones in AGCH (UL TBF).
File src/bts.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/31148/comment/423d0170_f4f2fb80
PS1, Line 718: int bts_rcv_imm_ass_cnf_dt(struct gprs_rlcmac_bts *bts, uint32_t tlli, uint32_t fn)
Can't we simply merge this function with the one above?
In the end the one above takes the TLLI, and both functions are the same.
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31148
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Icf7ca34500984239ee877ee71fd9c126b5eb3480
Gerrit-Change-Number: 31148
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 01 Feb 2023 15:57:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: neels.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/31082
to look at the new patch set (#2).
Change subject: coverity: hnbgw_rua.c: remove redundant check
......................................................................
coverity: hnbgw_rua.c: remove redundant check
'map' is already guaranteed to be not NULL for that message type by the
preceding switch().
Related: CID#307434
Change-Id: Id30f459616391187aa2f8ad400c316e2144154c6
---
M src/osmo-hnbgw/hnbgw_rua.c
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/82/31082/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31082
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Id30f459616391187aa2f8ad400c316e2144154c6
Gerrit-Change-Number: 31082
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newpatchset