Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31148 ) Change subject: pcu_l1_if.cpp: handle immediate assignment confirmation ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: btw, just to make sure you are aware and you are doing it right, iirc this confirmation is only sent to the PCU for ImmAss on the PCH right now (DL TBF), but not for the ones in AGCH (UL TBF). File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31148/comment/423d0170_f4f2fb80 PS1, Line 718: int bts_rcv_imm_ass_cnf_dt(struct gprs_rlcmac_bts *bts, uint32_t tlli, uint32_t fn) Can't we simply merge this function with the one above? In the end the one above takes the TLLI, and both functions are the same. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31148 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Icf7ca34500984239ee877ee71fd9c126b5eb3480 Gerrit-Change-Number: 31148 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 15:57:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment