February 2023 - gerrit-log - lists.osmocom.org

Change in libosmo-gprs[master]: rlcmac: Refactor msg_type enums and value_string

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31152 ) Change subject: rlcmac: Refactor msg_type enums and value_string ...................................................................... Patch Set 4: (1 comment) File include/osmocom/gprs/rlcmac/types.h: https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/87f5ced8_63235f96 PS2, Line 53: OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_DOWNLINK_DUMMY_CONTROL_BLOCK > The new prefix makes these symbols huge and cumbersome to use: […] we could shorten PACKET to PKT but not sure if it's really worth it. Other than that, I think the prefixes need to be kept, specially since they are public. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic55782d90c0d7876fc37d1da130b859857c11447 Gerrit-Change-Number: 31152 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 17:39:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Refactor msg_type enums and value_string

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31152 ) Change subject: rlcmac: Refactor msg_type enums and value_string ...................................................................... Patch Set 4: (1 comment) File include/osmocom/gprs/rlcmac/types.h: https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/5ceeb87f_5ca51590 PS2, Line 53: OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_DOWNLINK_DUMMY_CONTROL_BLOCK The new prefix makes these symbols huge and cumbersome to use: if (msg_type == OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_DOWNLINK_DUMMY_CONTROL_BLOCK) But it looks like there is nothing we can do about that :/ -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic55782d90c0d7876fc37d1da130b859857c11447 Gerrit-Change-Number: 31152 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 17:37:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Refactor msg_type enums and value_string

by pespin

Attention is currently required from: pespin, fixeria. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31152 to look at the new patch set (#4). Change subject: rlcmac: Refactor msg_type enums and value_string ...................................................................... rlcmac: Refactor msg_type enums and value_string Add prefixes, clean formatting, move to proper place, etc. Change-Id: Ic55782d90c0d7876fc37d1da130b859857c11447 --- M include/osmocom/gprs/rlcmac/csn1_defs.h M include/osmocom/gprs/rlcmac/types.h M src/rlcmac/csn1_ts_44_060.c M src/rlcmac/ts_44_060.c 4 files changed, 199 insertions(+), 191 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/52/31152/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic55782d90c0d7876fc37d1da130b859857c11447 Gerrit-Change-Number: 31152 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Refactor msg_type enums and value_string

by Jenkins Builder

Attention is currently required from: fixeria. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31152 ) Change subject: rlcmac: Refactor msg_type enums and value_string ...................................................................... Patch Set 3: (3 comments) File src/rlcmac/ts_44_060.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3201): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/b2f95953_f25d5380 PS3, Line 80: { OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_DOWNLINK_ACK_NACK , "Pkt DL ACK/NACK" }, space prohibited before that ',' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3201): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/6a560397_62844f5a PS3, Line 88: { OSMO_GPRS_RLCMAC_UL_MSGT_PACKET_ENHANCED_MEASUREMENT_REPORT, "Pkt Enchanced Meas Report" }, 'Enchanced' may be misspelled - perhaps 'Enhanced'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3201): https://gerrit.osmocom.org/c/libosmo-gprs/+/31152/comment/94d41a1b_61ddb597 PS3, Line 92: { OSMO_GPRS_RLCMAC_UL_MSGT_ENHANCED_MEASUREMENT_REPORT, "Enchanced Meas Report" }, 'Enchanced' may be misspelled - perhaps 'Enhanced'? -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic55782d90c0d7876fc37d1da130b859857c11447 Gerrit-Change-Number: 31152 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 17:25:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Rename gprs_rlcmac.h -> csn1_defs.h

by pespin

Attention is currently required from: fixeria. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31149 to look at the new patch set (#2). Change subject: rlcmac: Rename gprs_rlcmac.h -> csn1_defs.h ...................................................................... rlcmac: Rename gprs_rlcmac.h -> csn1_defs.h That header is used (and should only be used) to contain CSN1 related code for the encoder/decoder. Hence rename it, otherwise it looks like a general placeholder for any kind of stuff. Change-Id: I84ea63ed0b804699fd995a2e0c07ced17b3ad4c8 --- M .checkpatch.conf M debian/copyright M include/osmocom/gprs/rlcmac/Makefile.am R include/osmocom/gprs/rlcmac/csn1_defs.h M src/rlcmac/ts_24_008.c M src/rlcmac/ts_44_018.c M src/rlcmac/ts_44_060.c M tests/rlcmac/ts_44_018_test.c M tests/rlcmac/ts_44_060_test.c 9 files changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/49/31149/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31149 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I84ea63ed0b804699fd995a2e0c07ced17b3ad4c8 Gerrit-Change-Number: 31149 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Rename ts_*.c -> csn1_ts_*.c

by pespin

Attention is currently required from: fixeria. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31150 to look at the new patch set (#2). Change subject: rlcmac: Rename ts_*.c -> csn1_ts_*.c ...................................................................... rlcmac: Rename ts_*.c -> csn1_ts_*.c Done for files containing mostly (99%) of CSN1 related structrs and encdec functions. File ts_44_064.c is kept as is since it's not CSN1 related. File csn1_ts_44_060.c still contains some enums and value_string which will be split into ts_44_060.c in a follow up commit. Change-Id: I93ad9f90e7496b81ccfe679a614589373f244166 --- M .checkpatch.conf M src/rlcmac/Makefile.am R src/rlcmac/csn1_ts_24_008.c R src/rlcmac/csn1_ts_44_018.c R src/rlcmac/csn1_ts_44_060.c M tests/rlcmac/Makefile.am R tests/rlcmac/csn1_ts_44_018_test.c R tests/rlcmac/csn1_ts_44_018_test.err R tests/rlcmac/csn1_ts_44_018_test.ok R tests/rlcmac/csn1_ts_44_060_test.c R tests/rlcmac/csn1_ts_44_060_test.err R tests/rlcmac/csn1_ts_44_060_test.ok M tests/testsuite.at 13 files changed, 26 insertions(+), 26 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/50/31150/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I93ad9f90e7496b81ccfe679a614589373f244166 Gerrit-Change-Number: 31150 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Move spec related definitions for general use to types.h

by pespin

Attention is currently required from: fixeria. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31151 to look at the new patch set (#2). Change subject: rlcmac: Move spec related definitions for general use to types.h ...................................................................... rlcmac: Move spec related definitions for general use to types.h Move types defined by spec not directly/solely intended for the CSN1 encoder/decoder operation to a separate types.h header. More and more types will be added there which will be used by the data domain inside and outside the library. Change-Id: Ib0fdae48fc3e76d701d21644826e5ffd8553fecb --- M include/osmocom/gprs/rlcmac/Makefile.am M include/osmocom/gprs/rlcmac/csn1_defs.h M include/osmocom/gprs/rlcmac/llc_queue.h M include/osmocom/gprs/rlcmac/rlcmac.h A include/osmocom/gprs/rlcmac/types.h M src/rlcmac/Makefile.am M src/rlcmac/csn1_ts_44_060.c A src/rlcmac/ts_44_060.c M src/rlcmac/ts_44_064.c M tests/rlcmac/csn1_ts_44_060_test.c 10 files changed, 72 insertions(+), 44 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/51/31151/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31151 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ib0fdae48fc3e76d701d21644826e5ffd8553fecb Gerrit-Change-Number: 31151 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Refactor msg_type enums and value_string

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31152 ) Change subject: rlcmac: Refactor msg_type enums and value_string ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > You simply need to update .checkpatch.conf in I93ad9f90e7496b81ccfe679a614589373f244166. ACK, I already noticed when I saw previous patch review, thanks! -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic55782d90c0d7876fc37d1da130b859857c11447 Gerrit-Change-Number: 31152 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 17:24:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Move spec related definitions for general use to types.h

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31151 ) Change subject: rlcmac: Move spec related definitions for general use to types.h ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-gprs/+/31151/comment/4c5e4365_57882bce PS1, Line 7: types.h > This sounds too generic, IMO. Maybe common_defs.h? Not critical. common_defs.h sounds even more generic :P -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31151 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ib0fdae48fc3e76d701d21644826e5ffd8553fecb Gerrit-Change-Number: 31151 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 17:24:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Refactor msg_type enums and value_string

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31152 ) Change subject: rlcmac: Refactor msg_type enums and value_string ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: > Adding verified +1, since all those errors are from existing code which were exported from osmo-pcu […] You simply need to update .checkpatch.conf in I93ad9f90e7496b81ccfe679a614589373f244166. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic55782d90c0d7876fc37d1da130b859857c11447 Gerrit-Change-Number: 31152 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Feb 2023 17:23:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023