Attention is currently required from: msuraev.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31299 )
Change subject: socket: propagate error to the caller
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
commitlog should mention the function this commit is touching.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31299
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia90d2ca3106b58dc5953d930f13df829d5b6966f
Gerrit-Change-Number: 31299
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 12 Feb 2023 16:36:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels, fixeria, msuraev.
Hello Jenkins Builder, neels, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/28997
to look at the new patch set (#17).
Change subject: Add osmo_sock_get_name_multiaddr_buf()
......................................................................
Add osmo_sock_get_name_multiaddr_buf()
It's similar to osmo_sock_get_name_buf() but supports multi-homed SCTP sockets
bound to several addresses.
Related: OS#5581
Change-Id: If76595ebd1cf26ba904887a36c4cc14a1b5c4521
---
M include/osmocom/core/socket.h
M src/core/socket.c
M tests/socket/socket_sctp_test.c
M tests/socket/socket_sctp_test.ok
4 files changed, 102 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/97/28997/17
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28997
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If76595ebd1cf26ba904887a36c4cc14a1b5c4521
Gerrit-Change-Number: 28997
Gerrit-PatchSet: 17
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: neels, fixeria, msuraev.
Hello Jenkins Builder, neels, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/28997
to look at the new patch set (#16).
Change subject: Add osmo_sock_get_name_multiaddr_buf()
......................................................................
Add osmo_sock_get_name_multiaddr_buf()
It's similar to osmo_sock_get_name_buf() but supports multi-homed SCTP sockets
bound to several addresses.
Related: OS#5581
Change-Id: If76595ebd1cf26ba904887a36c4cc14a1b5c4521
---
M include/osmocom/core/socket.h
M src/core/socket.c
M tests/socket/socket_sctp_test.c
M tests/socket/socket_sctp_test.ok
4 files changed, 102 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/97/28997/16
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28997
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If76595ebd1cf26ba904887a36c4cc14a1b5c4521
Gerrit-Change-Number: 28997
Gerrit-PatchSet: 16
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: newpatchset