February 2023 - gerrit-log - lists.osmocom.org

Change in ...osmo-python-tests[master]: scripts/osmotestconfig.py: Fix tests failing due to attempted copy on...

by neels

Attention is currently required from: arehbein, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980 ) Change subject: scripts/osmotestconfig.py: Fix tests failing due to attempted copy on socket files ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Patchset: PS5: i'm not aware of these dummy sockets but if this fixes a problem, looks good to me -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I3a3cc7ed135b60b97eb901cfc20fdcb924e4f664 Gerrit-Change-Number: 30980 Gerrit-PatchSet: 5 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Feb 2023 01:20:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-sccp[master]: SS7: do not attempt transfer if AS is down

by neels

Attention is currently required from: laforge, msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31295 ) Change subject: SS7: do not attempt transfer if AS is down ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/osmo_ss7_hmrt.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/31295/comment/b6a14c04_41615c2d PS2, Line 234: return -ENETDOWN; ENETDOWN "Network is down" seems drastic? maybe ENOLINK Link has been severed EHOSTDOWN Host is down ENOTCONN The socket is not connected not sure if it matters -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31295 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0d5f3b6265e7fdaa79e32fbc30f829ef79e7dad1 Gerrit-Change-Number: 31295 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Feb 2023 01:17:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-bts[master]: Includes: Remove enum defs, instead include them

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/31305 ) Change subject: Includes: Remove enum defs, instead include them ...................................................................... Includes: Remove enum defs, instead include them gprs/rlc related enum defs have been moved to libosmocore <osmocom/gprs/gprs_rlc.h> Related change: I1ec2e52ad7fa625c08fe9df04d4a4f5323bf609c Related: OS#5335 Change-Id: I4b51dfd7e2d0770b0f63c9317c3503e7d0175845 --- M include/osmo-bts/gsm_data.h 1 file changed, 1 insertion(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/05/31305/1 diff --git a/include/osmo-bts/gsm_data.h b/include/osmo-bts/gsm_data.h index dcb357f..f11b781 100644 --- a/include/osmo-bts/gsm_data.h +++ b/include/osmo-bts/gsm_data.h @@ -10,6 +10,7 @@ #include <osmocom/core/utils.h> #include <osmocom/core/linuxlist.h> #include <osmocom/core/tdef.h> +#include <osmocom/gprs/gprs_rlc.h> #include <osmocom/gsm/gsm23003.h> #include <osmocom/gsm/gsm0502.h> #include <osmocom/gsm/gsm_utils.h> @@ -122,38 +123,6 @@ struct gsm_lchan lchan[TS_MAX_LCHAN]; }; -enum gprs_rlc_par { - RLC_T3142, - RLC_T3169, - RLC_T3191, - RLC_T3193, - RLC_T3195, - RLC_N3101, - RLC_N3103, - RLC_N3105, - CV_COUNTDOWN, - T_DL_TBF_EXT, /* ms */ - T_UL_TBF_EXT, /* ms */ - _NUM_RLC_PAR -}; - -enum gprs_cs { - GPRS_CS1, - GPRS_CS2, - GPRS_CS3, - GPRS_CS4, - GPRS_MCS1, - GPRS_MCS2, - GPRS_MCS3, - GPRS_MCS4, - GPRS_MCS5, - GPRS_MCS6, - GPRS_MCS7, - GPRS_MCS8, - GPRS_MCS9, - _NUM_GRPS_CS -}; - /* The amount of time within which a sudden disconnect of a newly established * OML connection will cause a special warning to be logged. */ #define OSMO_BTS_OML_CONN_EARLY_DISCONNECT 10 /* in seconds */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31305 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4b51dfd7e2d0770b0f63c9317c3503e7d0175845 Gerrit-Change-Number: 31305 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: Includes: Remove enum defs, instead include them

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31304 ) Change subject: Includes: Remove enum defs, instead include them ...................................................................... Includes: Remove enum defs, instead include them gprs/rlc related enum defs have been moved to libosmocore <osmocom/gprs/gprs_rlc.h> Related change: I1ec2e52ad7fa625c08fe9df04d4a4f5323bf609c Related: OS#5335 Change-Id: I2883aee12b501a717d5acecd5638882724336e72 --- M include/osmocom/bsc/gsm_data.h 1 file changed, 1 insertion(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/04/31304/1 diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index 44a9d5e..cc6928d 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -16,6 +16,7 @@ #include <osmocom/gsm/protocol/gsm_48_049.h> #include <osmocom/gsm/gsm0808.h> #include <osmocom/gsm/gsm48.h> +#include <osmocom/gprs/gprs_rlc.h> #include <osmocom/core/fsm.h> #include <osmocom/core/tdef.h> #include <osmocom/core/time_cc.h> @@ -636,38 +637,6 @@ struct gsm_abis_mo mo; }; -enum gprs_rlc_par { - RLC_T3142, - RLC_T3169, - RLC_T3191, - RLC_T3193, - RLC_T3195, - RLC_N3101, - RLC_N3103, - RLC_N3105, - CV_COUNTDOWN, - T_DL_TBF_EXT, /* ms */ - T_UL_TBF_EXT, /* ms */ - _NUM_RLC_PAR -}; - -enum gprs_cs { - GPRS_CS1, - GPRS_CS2, - GPRS_CS3, - GPRS_CS4, - GPRS_MCS1, - GPRS_MCS2, - GPRS_MCS3, - GPRS_MCS4, - GPRS_MCS5, - GPRS_MCS6, - GPRS_MCS7, - GPRS_MCS8, - GPRS_MCS9, - _NUM_GRPS_CS -}; - struct gprs_rlc_cfg { uint16_t parameter[_NUM_RLC_PAR]; struct { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31304 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2883aee12b501a717d5acecd5638882724336e72 Gerrit-Change-Number: 31304 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in libosmocore[master]: Includes: Add gprs/rlc related enums

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31303 ) Change subject: Includes: Add gprs/rlc related enums ...................................................................... Includes: Add gprs/rlc related enums These enums have been present in both osmo-bts and osmo-bsc. This commit is part of a series of commits moving these enums to libosmocore Related: OS#5335 Change-Id: I1ec2e52ad7fa625c08fe9df04d4a4f5323bf609c --- M include/osmocom/gprs/gprs_rlc.h 1 file changed, 32 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/03/31303/1 diff --git a/include/osmocom/gprs/gprs_rlc.h b/include/osmocom/gprs/gprs_rlc.h index b74f9e4..519227a 100644 --- a/include/osmocom/gprs/gprs_rlc.h +++ b/include/osmocom/gprs/gprs_rlc.h @@ -44,6 +44,38 @@ _NUM_OSMO_GPRS_CS }; +enum gprs_rlc_par { + RLC_T3142, + RLC_T3169, + RLC_T3191, + RLC_T3193, + RLC_T3195, + RLC_N3101, + RLC_N3103, + RLC_N3105, + CV_COUNTDOWN, + T_DL_TBF_EXT, /* ms */ + T_UL_TBF_EXT, /* ms */ + _NUM_RLC_PAR +}; + +enum gprs_cs { + GPRS_CS1, + GPRS_CS2, + GPRS_CS3, + GPRS_CS4, + GPRS_MCS1, + GPRS_MCS2, + GPRS_MCS3, + GPRS_MCS4, + GPRS_MCS5, + GPRS_MCS6, + GPRS_MCS7, + GPRS_MCS8, + GPRS_MCS9, + _NUM_GRPS_CS +}; + int egprs_get_cps(struct egprs_cps *cps, uint8_t type, uint8_t bits); int osmo_gprs_ul_block_size_bits(enum osmo_gprs_cs cs); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31303 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1ec2e52ad7fa625c08fe9df04d4a4f5323bf609c Gerrit-Change-Number: 31303 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in ...osmo-python-tests[master]: scripts/osmotestconfig.py: Fix tests failing due to attempted copy on...

by arehbein

Attention is currently required from: pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980 ) Change subject: scripts/osmotestconfig.py: Fix tests failing due to attempted copy on socket files ...................................................................... Patch Set 5: (1 comment) File scripts/osmotestconfig.py: https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980/comment/844c4… PS5, Line 80: ign = shutil.ignore_patterns('*.cfg', '*tmp_dummy_sock') > So who is creating this tmp_dummy_sock? I don't find any other reference to it in osmo-python-tests. The files are created by the `ctrl_test_runner.py` scripts of several projects through binaries that support the `-r` option for creating command listener sockets. ``` $ ag tmp_dummy_sock osmo-bsc-nat/tests/ctrl_test_runner.py 150: os.unlink("tmp_dummy_sock") 153: return ["./src/osmo-bsc-nat/osmo-bsc-nat", "-r", "tmp_dummy_sock", "-c", osmo-hnbgw/tests/ctrl_test_runner.py 150: os.unlink("tmp_dummy_sock") 153: return ["./src/osmo-hnbgw/osmo-hnbgw", "-r", "tmp_dummy_sock", "-c", docker-playground/osmo-bsc-master/osmo-bsc/tests/ctrl_test_runner.py 150: os.unlink("tmp_dummy_sock") 153: return ["./src/osmo-bsc/osmo-bsc", "-r", "tmp_dummy_sock", "-c", 573: os.unlink("tmp_dummy_sock") 576: return ["./src/osmo-bsc/osmo-bsc", "-r", "tmp_dummy_sock", "-c", 610: os.unlink("tmp_dummy_sock") 613: return ["./src/osmo-bsc/osmo-bsc", "-r", "tmp_dummy_sock", "-c", osmo-bsc/tests/ctrl_test_runner.py 150: os.unlink("tmp_dummy_sock") 153: return ["./src/osmo-bsc/osmo-bsc", "-r", "tmp_dummy_sock", "-c", 573: os.unlink("tmp_dummy_sock") 576: return ["./src/osmo-bsc/osmo-bsc", "-r", "tmp_dummy_sock", "-c", 610: os.unlink("tmp_dummy_sock") 613: return ["./src/osmo-bsc/osmo-bsc", "-r", "tmp_dummy_sock", "-c", openbsc/openbsc/tests/ctrl_test_runner.py 155: os.unlink("tmp_dummy_sock") 158: return ["./src/osmo-bsc/osmo-bsc-sccplite", "-r", "tmp_dummy_sock", "-c", ``` -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I3a3cc7ed135b60b97eb901cfc20fdcb924e4f664 Gerrit-Change-Number: 30980 Gerrit-PatchSet: 5 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 12 Feb 2023 20:30:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-pfcp[master]: add doc/charts/pfcp_msgs*.msc

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31294 ) Change subject: add doc/charts/pfcp_msgs*.msc ...................................................................... add doc/charts/pfcp_msgs*.msc (I used these while implementing libosmo-pfcp and osmo-upf, but never submitted them.) Change-Id: I8d2343224d02d728e2eee2090ee2d4c6bec79e78 --- A doc/charts/pfcp_msgs.msc A doc/charts/pfcp_msgs_gtp.msc 2 files changed, 151 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/doc/charts/pfcp_msgs.msc b/doc/charts/pfcp_msgs.msc new file mode 100644 index 0000000..afcca18 --- /dev/null +++ b/doc/charts/pfcp_msgs.msc @@ -0,0 +1,60 @@ +msc { + hscale="1"; + upf[label="User Plane function"],cpf[label="Control Plane function"]; + + cpf rbox cpf [label="Look up UPF,\npick any one of the available\nIP addrs for the UPF"]; + + ...; + upf abox cpf [label="not yet associated"]; + upf rbox cpf [label="reject any session related msgs"]; + ...; + + upf <<= cpf [label="PFCP Association Setup Request\nCP function Node Id, features"]; + upf =>> cpf [label="PFCP Association Setup Response\nUP function Node Id, features"]; + upf abox cpf [label="associated"]; + upf rbox cpf [label="start Heartbeat checking"]; + ...; + upf <<= cpf [label="Heartbeat Request"]; + upf =>> cpf [label="Heartbeat Response"]; + ...; + upf =>> cpf [label="Heartbeat Request"]; + upf <<= cpf [label="Heartbeat Response"]; + ...; + + upf <<= cpf [label="Session Establishment Request\nCP Node-Id\nCP F-SEID\n1+ Packet Detection Rule(s)\n1+ Forward Action Rule(s)"]; + upf =>> cpf [label="Session Establishment Response"]; + + upf <<= cpf [label="Session Modification Request"]; + upf =>> cpf [label="Session Modification Response"]; + + upf <<= cpf [label="Session Deletion Request"]; + upf =>> cpf [label="Session Deletion Response"]; + + ...; + upf rbox cpf [label="F-SEID: accept any other IP addrs than peer's Node Id"]; + ...; + + --- [label="Graceful release initiated by CP"]; + + upf <<= cpf [label="Association Update Request\nwith PFCP Association Release Preparation Start = 1"]; + upf =>> cpf [label="Association Update Response"]; + upf =>> cpf [label="Session Report Request\nto report non-zero usage reports,\nat least one message per PFCP Session"]; + upf <<= cpf [label="Association Release Request"]; + upf =>> cpf [label="Association Release Response"]; + + --- [label="Graceful release initiated by UP"]; + + upf =>> cpf [label="Association Update Request\nwith PFCP Association Release Preparation = 1"]; + cpf abox cpf [label="refrain from establishing sessions"]; + upf <<= cpf [label="Association Update Response"]; + upf <<= cpf [label="Session Deletion Request(s)\nto collect usage reports\nper session"]; + upf =>> cpf [label="Session Deletion Response(s)"]; + cpf rbox cpf [label="wait Graceful Release Period"]; + upf <<= cpf [label="Association Release Request"]; + upf =>> cpf [label="Association Release Response"]; + + --- [label="Release (immediate)"]; + + upf <<= cpf [label="Association Release Request"]; + upf =>> cpf [label="Association Release Response"]; +} diff --git a/doc/charts/pfcp_msgs_gtp.msc b/doc/charts/pfcp_msgs_gtp.msc new file mode 100644 index 0000000..f59412c --- /dev/null +++ b/doc/charts/pfcp_msgs_gtp.msc @@ -0,0 +1,91 @@ +msc { + hscale="1"; + sgsn[label="SGSN\n123.44.0.9"],sgwc[label="SGW-C\n123.44.0.5"],sgwu[label="SGW-U\n123.44.0.6"],pgwc[label="PGW-C\n123.44.0.7"],pgwu[label="PGW-U\n123.44.0.8"]; + + sgsn <=> sgwc [label="S4-C GTPv2-C"]; + sgwc <=> sgwu [label="Sxa PFCP"]; + sgsn <=> sgwu [label="S4-U GTPv1-U"]; + sgwc <=> pgwc [label="S5-C GTPv2-C"]; + pgwc <=> pgwu [label="Sxb PFCP"]; + sgwu <=> pgwu [label="S5-U GTPv1-U"]; + + ...; + + sgsn => sgwc [label="GTP Create Session Request"]; + sgsn note sgwc [label="F-TEID S11 = 123.44.0.9,0x004\nF-TEID S5 = 123.44.0.7,0x000\nPDN addr alloc = IPv4 192.168.100.2"]; + + |||; + |||; + + sgwc => sgwu [label="PFCP Session Establishment Request"]; + sgwc note sgwu [label="2x Create PDR\nF-TEID = CHOOSE\nFAR = NOCP,BUFF"]; + + |||; + |||; + + sgwc <= sgwu [label="PFCP Session Establishment Response"]; + sgwc note sgwu [label="Created PDR F-TEID 123.44.0.6,0x015\nCreated PDR F-TEID 123.44.0.6,0x016"]; + + |||; + |||; + + sgwc => pgwc [label="GTP Create Session Request"]; + sgwc note pgwc [label="F-TEID S5 = 123.44.0.5,0x00b\nPDN addr alloc = IPv4 192.168.100.2\nBearer Ctx: F-TEID S5 = 123.44.0.6,0x015"]; + + |||; + |||; + + pgwc => pgwu [label="PFCP Session Establishment Request"]; + pgwc note pgwu [label="Create PDR 1:\nPDI: src-iface Core, UE IPv4 192.168.100.2\nFAR-1: FORW, dst-iface Access,\nhdr creation: GTP-U 123.44.0.6,0x015\n\nCreate PDR 2:\nPDI: src-iface Access, F-TEID = CHOOSE id:05\nhdr removal: GTP-U\nFAR-2: FORW, dst-iface Core\n\nCreate PDR 3:\nPDI: src-iface CP-function, F-TEID = CHOOSE\nhdr removal: GTP-U\nFAR-1\n\nCreate PDR 4:\nPDI: src-iface Access, F-TEID = CHOOSE id:05, SDF Filter\nhdr removal: GTP-U\nFAR-3: FORW, dst-iface CP-Function,\nhdr creation: GTP-U 123.44.0.7,0x00b"]; + + |||; + + pgwc <= pgwu [label="PFCP Session Establishment Response"]; + pgwc note pgwu [label="Created PDR-1\nCreated PDR-2: F-TEID = 123.44.0.8,0x01e\nCreated PDR-3: F-TEID = 123.44.0.8,0x01f\nCreated PDR-4: F-TEID = 123.44.0.8,0x01e"]; + + |||; + |||; + + sgwc <= pgwc [label="GTP Create Session Response"]; + sgwc note pgwc [label="TEID: 0x00b\nF-TEID: 123.44.0.7,0x00b\nPDN Addr: 192.168.100.2\nBearer Ctx: F-TEID S5 123.44.0.8,0x01e"]; + + |||; + |||; + + sgwc => sgwu [label="PFCP Session Modification Request"]; + sgwc note sgwu [label="Update FAR-2: FORW, dst-iface Core,\nhdr creation GTP-U 123.44.0.8,0x01e"]; + + |||; + + sgwc <= sgwu [label="PFCP Session Modification Response"]; + + |||; + |||; + + sgsn <= sgwc [label="GTP Create Session Response"]; + sgsn note sgwc [label="TEID: 0x004\nF-TEID S11/S4: 123.44.0.5,0x007\nF-TEID S5/S8: 123.44.0.7,0x00b\nPDN Addr: 192.168.100.2\nBearer Ctx:\nF-TEID S1-U: 123.44.0.6,0x016\nF-TEID S5/S8: 123.44.0.8,0x01e"]; + + |||; + |||; + + sgsn => sgwc [label="GTP Modify Bearer Request"]; + sgsn note sgwc [label="TEID: 0x007\nBearer Ctx:\nF-TEID S1-U: 192.168.104.167,0x32adb2ad"]; + + |||; + |||; + + sgwc => sgwu [label="PFCP Session Modification Request"]; + sgwc note sgwu [label="Update FAR-1: FORW, dst-iface Access,\nhdr creation: GTP-U 192.168.104.167,0x32adb2ad"]; + + |||; + |||; + + + sgwc <= sgwu [label="PFCP Session Modification Response"]; + + |||; + + sgsn <= sgwc [label="GTP Modify Bearer Response"]; + sgsn note sgwc [label="TEID: 0x004\nBearer Ctx:\nF-TEID S1-U: 192.168.104.167,0x32adb2ad"]; + +} -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31294 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I8d2343224d02d728e2eee2090ee2d4c6bec79e78 Gerrit-Change-Number: 31294 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Initial ul_tbf data support

by msuraev

Attention is currently required from: pespin, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31170 ) Change subject: rlcmac: Initial ul_tbf data support ...................................................................... Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I0a01d79d16bbfc63aa88e6bb0f432f3772645730 Gerrit-Change-Number: 31170 Gerrit-PatchSet: 10 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 12 Feb 2023 19:50:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Implement GMMRR-ASSIGN.req

by msuraev

Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31285 ) Change subject: rlcmac: Implement GMMRR-ASSIGN.req ...................................................................... Patch Set 3: (1 comment) File include/osmocom/gprs/rlcmac/rlcmac_prim.h: https://gerrit.osmocom.org/c/libosmo-gprs/+/31285/comment/06da3c4a_eec30af0 PS3, Line 189: struct osmo_gprs_rlcmac_prim *osmo_gprs_rlcmac_prim_alloc_gmmrr_assign_req( That should either be a separate patch or correction to earlier patch in this series which added typo. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I3178aa1af4a6c05c84253c6befcd4c786b8dd8e9 Gerrit-Change-Number: 31285 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 12 Feb 2023 19:49:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Introduce DL TBF creation through PCH ImmAss

by msuraev

Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31286 ) Change subject: rlcmac: Introduce DL TBF creation through PCH ImmAss ...................................................................... Patch Set 5: (4 comments) File include/osmocom/gprs/rlcmac/tbf_dl.h: https://gerrit.osmocom.org/c/libosmo-gprs/+/31286/comment/b6643bee_c4015a4c PS5, Line 9: //#include <osmocom/gprs/rlcmac/tbf_dl_fsm.h> What's the point of commented include? Just drop it if it's unused. https://gerrit.osmocom.org/c/libosmo-gprs/+/31286/comment/d277c586_806a9aad PS5, Line 16: //struct gprs_rlcmac_tbf_dl_fsm_ctx state_fsm; Same here. File src/rlcmac/rlcmac.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/31286/comment/a3ea83e9_a35ef15f PS5, Line 278: OSMO_ASSERT(bv); I think so far common practice was to log memory allocation errors and shutdown gracefully. Why the use of assert in here? File src/rlcmac/tbf_dl.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/31286/comment/3aeaa564_9eef1242 PS5, Line 37: //rc = gprs_rlcmac_tbf_dl_fsm_constructor(dl_tbf); That looks odd. Is this an artifact from patch split? -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31286 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I7f98e3456ef35d80becdad3481afeb771457b0ef Gerrit-Change-Number: 31286 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 12 Feb 2023 19:43:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023