February 2023 - gerrit-log - lists.osmocom.org

Change in libosmo-sccp[master]: SS7: do not attempt transfer if AS is down

by msuraev

Attention is currently required from: laforge. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31295 ) Change subject: SS7: do not attempt transfer if AS is down ...................................................................... Patch Set 2: (1 comment) File src/osmo_ss7_hmrt.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/31295/comment/9313d56e_69728c0d PS1, Line 232: LOGP(DLSS7, LOGL_ERROR, "The AS %s is down\n", as->cfg.name); > I think the log line could benefit from some context like "canout route" or "cannot send packet" or […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31295 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0d5f3b6265e7fdaa79e32fbc30f829ef79e7dad1 Gerrit-Change-Number: 31295 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 12 Feb 2023 19:34:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-sccp[master]: SS7: do not attempt transfer if AS is down

by msuraev

Attention is currently required from: msuraev. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31295 to look at the new patch set (#2). Change subject: SS7: do not attempt transfer if AS is down ...................................................................... SS7: do not attempt transfer if AS is down The attempt to route message via AS which is down will fail anyway: let's make it explicit. Add osmo_ss7_as_down() and use it to check AS state before transferring the message. Change-Id: I0d5f3b6265e7fdaa79e32fbc30f829ef79e7dad1 --- M include/osmocom/sigtran/osmo_ss7.h M src/osmo_ss7.c M src/osmo_ss7_hmrt.c 3 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/95/31295/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31295 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0d5f3b6265e7fdaa79e32fbc30f829ef79e7dad1 Gerrit-Change-Number: 31295 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in libosmocore[master]: socket: propagate error in osmo_sock_unix_init() to the caller

by fixeria

Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31299 ) Change subject: socket: propagate error in osmo_sock_unix_init() to the caller ...................................................................... Patch Set 2: Code-Review-1 (3 comments) File src/core/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/31299/comment/ee38ed76_7172f2d3 PS1, Line 1422: return -1; Removing this looks unrelated. Why not just 'return rc'? https://gerrit.osmocom.org/c/libosmocore/+/31299/comment/c15e7bca_7c589734 PS1, Line 1396: sfd This is not really a change: according to the manpage, in case of an error "a value of -1 shall be returned and errno set to indicate the error." So it was -1, and will be -1 after your change. You should return -errno instead. https://gerrit.osmocom.org/c/libosmocore/+/31299/comment/589b4147_5d49176a PS1, Line 1420: sfd = rc; If you keep the 'err' label, you can just do 'goto' here. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31299 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia90d2ca3106b58dc5953d930f13df829d5b6966f Gerrit-Change-Number: 31299 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 12 Feb 2023 19:28:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: Debian: fix broken SNDCP install

by msuraev

msuraev has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31297 ) Change subject: Debian: fix broken SNDCP install ...................................................................... Debian: fix broken SNDCP install Change-Id: Id1691e2a69954cb187d885a60134bb5ec5fe3200 --- A debian/libosmo-gprs-sndcp-dev.install A debian/libosmo-gprs-sndcp0.install 2 files changed, 6 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/debian/libosmo-gprs-sndcp-dev.install b/debian/libosmo-gprs-sndcp-dev.install new file mode 100644 index 0000000..d7ea19a --- /dev/null +++ b/debian/libosmo-gprs-sndcp-dev.install @@ -0,0 +1,5 @@ +usr/include/osmocom/gprs/sndcp +usr/lib/*/libosmo-gprs-sndcp*.a +usr/lib/*/libosmo-gprs-sndcp*.so +usr/lib/*/libosmo-gprs-sndcp*.la +usr/lib/*/pkgconfig/libosmo-gprs-sndcp.pc diff --git a/debian/libosmo-gprs-sndcp0.install b/debian/libosmo-gprs-sndcp0.install new file mode 100644 index 0000000..4d6ab35 --- /dev/null +++ b/debian/libosmo-gprs-sndcp0.install @@ -0,0 +1 @@ +usr/lib/*/libosmo-gprs-sndcp*.so.* -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31297 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Id1691e2a69954cb187d885a60134bb5ec5fe3200 Gerrit-Change-Number: 31297 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in osmocom-bb[master]: mobile: add optional statsd support

by msuraev

Attention is currently required from: fixeria, pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31298 ) Change subject: mobile: add optional statsd support ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/31298/comment/39a1856b_e586fc48 PS1, Line 7: statsd support > You're not adding any actual stats items, but adding the VTY commands only. […] No such plans at the moment. File src/host/layer23/include/osmocom/bb/common/l23_app.h: https://gerrit.osmocom.org/c/osmocom-bb/+/31298/comment/82367cc9_77037949 PS1, Line 17: L23_OPT_STAT > Why making this optional command line option? If some app indicates L23_OPT_VTY, then I guess it mak […] I'm fine with adding stats commands to all apps with vty as well. What others think - how fine-grained should it be? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31298 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7905b44478dcb9bcf0a1a68fde95f470c07edca3 Gerrit-Change-Number: 31298 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 12 Feb 2023 19:27:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmocore[master]: socket: propagate error in osmo_sock_unix_init() to the caller

by msuraev

Attention is currently required from: msuraev. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/31299 to look at the new patch set (#2). Change subject: socket: propagate error in osmo_sock_unix_init() to the caller ...................................................................... socket: propagate error in osmo_sock_unix_init() to the caller Change-Id: Ia90d2ca3106b58dc5953d930f13df829d5b6966f --- M src/core/socket.c 1 file changed, 10 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/99/31299/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31299 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia90d2ca3106b58dc5953d930f13df829d5b6966f Gerrit-Change-Number: 31299 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: PCU_Tests: remove unnecessary valueof() in NACC TCs

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31300 ) Change subject: PCU_Tests: remove unnecessary valueof() in NACC TCs ...................................................................... PCU_Tests: remove unnecessary valueof() in NACC TCs A string literal is already a value, valueof() is for templates. Change-Id: I86970bb422ad1693829fd20ecf5ee34ef77f30af --- M pcu/PCU_Tests.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/00/31300/1 diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 15ea195..833f317 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -5775,7 +5775,7 @@ f_sleep(0.2); /* let some time to avoid race conditons between CTRL and RLCMAC */ if (use_old_ctrl_iface) { - IPA_CTRL.send(ts_CtrlMsgGetRepl(rx_ctrl.cmd.id, valueof(ctrl_var), valueof("023-43-423-2-5"))); + IPA_CTRL.send(ts_CtrlMsgGetRepl(rx_ctrl.cmd.id, ctrl_var, "023-43-423-2-5")); } else { BTS.send(ts_PCUIF_NEIGH_ADDR_CNF(0, pcu_msg.u.container.u.neigh_addr_req, 0, 23, 43, 0, 423, 2, 5)); } @@ -6160,7 +6160,7 @@ f_ms_tx_ul_block(ms, ts_RLC_UL_CTRL_ACK(cell_chf_notif), 0, nr := f_ms_tx_TsTrxBtsNum(ms)); f_sleep(0.2); /* let some time to avoid race conditons between CTRL and RLCMAC */ if (use_old_ctrl_iface) { - IPA_CTRL.send(ts_CtrlMsgGetRepl(rx_ctrl.cmd.id, valueof(ctrl_var), valueof("023-43-423-2-5"))); + IPA_CTRL.send(ts_CtrlMsgGetRepl(rx_ctrl.cmd.id, ctrl_var, "023-43-423-2-5")); } else { BTS.send(ts_PCUIF_NEIGH_ADDR_CNF(0, pcu_msg.u.container.u.neigh_addr_req, 0, 23, 43, 0, 423, 2, 5)); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31300 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I86970bb422ad1693829fd20ecf5ee34ef77f30af Gerrit-Change-Number: 31300 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: PCU_Tests: fix TC_nacc_outbound_si_resolve_timeout

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31301 ) Change subject: PCU_Tests: fix TC_nacc_outbound_si_resolve_timeout ...................................................................... PCU_Tests: fix TC_nacc_outbound_si_resolve_timeout This patch fixes TC_nacc_outbound_si_resolve_timeout, which is still using old hard-coded MCC/MNC values. The altstep does the same, but relies on the updated values from ts_BssgpCellIdDstAddr_default. Change-Id: I9f6dbe97e9a494a4e8fdb441a70999d3040f6cfd Related: OS#5901 --- M pcu/PCU_Tests.ttcn 1 file changed, 1 insertion(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/01/31301/1 diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 833f317..439ffea 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -5647,16 +5647,6 @@ var GsmArfcn req_arfcn := 862; var uint6_t req_bsic := 43; var boolean use_old_ctrl_iface := mp_ctrl_neigh_ip != ""; - var BssgpCellId src := valueof(ts_BssgpCellId(ts_RAI(ts_LAI(f_build_BcdMccMnc_int(info_ind.mcc, info_ind.mnc, info_ind.mnc_3_digits == 1), /* '262F42'H */ - info_ind.lac), - info_ind.rac), - info_ind.cell_id)); - var BssgpCellId dst := valueof(ts_BssgpCellId(ts_RAI(ts_LAI('023F43'H, /* Decided by test itself (emulating BSC) */ - 423), - 2), - 5)); - var template RIM_Routing_Address src_addr := t_RIM_Routing_Address_cid(src); - var template RIM_Routing_Address dst_addr := t_RIM_Routing_Address_cid(dst); if (use_old_ctrl_iface) { /* Initialize osmo-bsc emulation neighbor resolution CTRL port */ @@ -5692,9 +5682,7 @@ f_handle_nacc_rac_ci_query(info_ind, req_arfcn, req_bsic, true, use_old_ctrl_iface); /* RIM procedure: */ - RIM.receive(tr_RAN_INFORMATION_REQUEST(tr_RIM_Routing_Information(RIM_ADDR_GERAN_CELL_ID, dst_addr), - tr_RIM_Routing_Information(RIM_ADDR_GERAN_CELL_ID, src_addr), - tr_RAN_Information_Request_RIM_Container)); + as_outbound_nacc_rim_resolve(info_ind, do_answer := false); /* We never answer the RIM procude -> PCU timeouts and should send Pkt Cell Chg continue */ /* Wait until we receive something non-dummy */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9f6dbe97e9a494a4e8fdb441a70999d3040f6cfd Gerrit-Change-Number: 31301 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: PCU_Tests: fix TC_nacc_outbound_pkt_cell_chg_notif_dup

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31302 ) Change subject: PCU_Tests: fix TC_nacc_outbound_pkt_cell_chg_notif_dup ...................................................................... PCU_Tests: fix TC_nacc_outbound_pkt_cell_chg_notif_dup The TC_nacc_outbound_pkt_cell_chg_notif_dup is currently failing because in [1] we changed the default hard-coded MCC/MNC values in ts_BssgpCellIdDstAddr_default, however these it's still using hardcoded MCC=023/MNC=43. I overlooked this in [2]. Let's split up the f_handle_nacc_rac_ci_query() into four functions: * f_ctrl_rx_nacc_rac_ci_req() / f_ctrl_tx_nacc_rac_ci_rsp(), * f_pcuif_rx_nacc_rac_ci_req() / f_pcuif_tx_nacc_rac_ci_rsp(), and use them in TC_nacc_outbound_pkt_cell_chg_notif_dup. Also employ them in TC_nacc_outbound_pkt_cell_chg_notif_twice. Change-Id: I3e84f55eedd278fb239600d6a0465bd34fd8cd0b Related: [1] 03f74d413258a125d6e64a4241a82d8384693895 Fixes: [2] 7295661af52ab397acd7376023817b64e1db5a66 Related: OS#5901 --- M pcu/PCU_Tests.ttcn 1 file changed, 61 insertions(+), 44 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/02/31302/1 diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 439ffea..954216f 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -5189,38 +5189,67 @@ } } +private function f_ctrl_rx_nacc_rac_ci_req(out CtrlMessage ctrl_req, + PCUIF_info_ind info_ind, + GsmArfcn req_arfcn, + uint6_t req_bsic) +runs on RAW_PCU_Test_CT { + var charstring ctrl_var := "neighbor_resolve_cgi_ps_from_lac_ci." & + int2str(info_ind.lac) & "." & + int2str(info_ind.cell_id) & "." & + int2str(req_arfcn) & "." & + int2str(req_bsic); + f_ipa_ctrl_wait_link_up(); + IPA_CTRL.receive(tr_CtrlMsgGet(?, ctrl_var)) -> value ctrl_req; +} + +private function f_ctrl_tx_nacc_rac_ci_rsp(in CtrlMessage ctrl_req) +runs on RAW_PCU_Test_CT { + var BssgpCellId addr := valueof(ts_BssgpCellIdDstAddr_default); + IPA_CTRL.send(ts_CtrlMsgGetRepl(ctrl_req.cmd.id, + ctrl_req.cmd.variable, + hex2str(c_BssgpCellMcc) & "-" & + hex2str(c_BssgpCellMnc) & "-" & + int2str(addr.ra_id.lai.lac) & "-" & + int2str(addr.ra_id.rac) & "-" & + int2str(addr.cell_id))); +} + +private function f_pcuif_rx_nacc_rac_ci_req(out PCUIF_Message addr_req, + PCUIF_info_ind info_ind, + GsmArfcn req_arfcn, + uint6_t req_bsic) +runs on RAW_PCU_Test_CT { + BTS.receive(tr_PCUIF_NEIGH_ADDR_REQ(0, info_ind.lac, info_ind.cell_id, + req_arfcn, req_bsic)) -> value addr_req; +} + +private function f_pcuif_tx_nacc_rac_ci_rsp(in PCUIF_Message addr_req) +runs on RAW_PCU_Test_CT { + var BssgpCellId addr := valueof(ts_BssgpCellIdDstAddr_default); + BTS.send(ts_PCUIF_NEIGH_ADDR_CNF(0, addr_req.u.container.u.neigh_addr_req, 0, + str2int(hex2str(c_BssgpCellMcc)), + str2int(hex2str(c_BssgpCellMnc)), + lengthof(c_BssgpCellMnc) - 2, + addr.ra_id.lai.lac, + addr.ra_id.rac, + addr.cell_id)); +} + private function f_handle_nacc_rac_ci_query(PCUIF_info_ind info_ind, GsmArfcn req_arfcn, uint6_t req_bsic, boolean answer := true, boolean use_old_ctrl_iface := false) runs on RAW_PCU_Test_CT { if (use_old_ctrl_iface == true) { - f_ipa_ctrl_wait_link_up(); - var charstring ctrl_var := "neighbor_resolve_cgi_ps_from_lac_ci." & - int2str(info_ind.lac) & "." & - int2str(info_ind.cell_id) & "." & - int2str(req_arfcn) & "." & - int2str(req_bsic); + var CtrlMessage ctrl_req; + f_ctrl_rx_nacc_rac_ci_req(ctrl_req, info_ind, req_arfcn, req_bsic); if (answer) { - var BssgpCellId addr := valueof(ts_BssgpCellIdDstAddr_default); - f_ctrl_exp_get(IPA_CTRL, ctrl_var, hex2str(c_BssgpCellMcc) & "-" & - hex2str(c_BssgpCellMnc) & "-" & - int2str(addr.ra_id.lai.lac) & "-" & - int2str(addr.ra_id.rac) & "-" & - int2str(addr.cell_id)); - } else { - f_ctrl_exp_get(IPA_CTRL, ctrl_var, omit); + f_ctrl_tx_nacc_rac_ci_rsp(ctrl_req); } } else { - var PCUIF_Message pcu_msg; - BTS.receive(tr_PCUIF_NEIGH_ADDR_REQ(0, info_ind.lac, info_ind.cell_id, req_arfcn, req_bsic)) -> value pcu_msg; + var PCUIF_Message pcuif_req; + f_pcuif_rx_nacc_rac_ci_req(pcuif_req, info_ind, req_arfcn, req_bsic); if (answer) { - var BssgpCellId addr := valueof(ts_BssgpCellIdDstAddr_default); - BTS.send(ts_PCUIF_NEIGH_ADDR_CNF(0, pcu_msg.u.container.u.neigh_addr_req, 0, - str2int(hex2str(c_BssgpCellMcc)), - str2int(hex2str(c_BssgpCellMnc)), - lengthof(c_BssgpCellMnc) - 2, - addr.ra_id.lai.lac, - addr.ra_id.rac, - addr.cell_id)); + f_pcuif_tx_nacc_rac_ci_rsp(pcuif_req); } } } @@ -5747,15 +5776,9 @@ /* osmo-pcu should now ask for resolution: */ if (use_old_ctrl_iface) { - f_ipa_ctrl_wait_link_up(); - ctrl_var := "neighbor_resolve_cgi_ps_from_lac_ci." & - int2str(info_ind.lac) & "." & - int2str(info_ind.cell_id) & "." & - int2str(req_arfcn) & "." & - int2str(req_bsic); - IPA_CTRL.receive(tr_CtrlMsgGet(?, ctrl_var)) -> value rx_ctrl; + f_ctrl_rx_nacc_rac_ci_req(rx_ctrl, info_ind, req_arfcn, req_bsic); } else { - BTS.receive(tr_PCUIF_NEIGH_ADDR_REQ(0, info_ind.lac, info_ind.cell_id, req_arfcn, req_bsic)) -> value pcu_msg; + f_pcuif_rx_nacc_rac_ci_req(pcu_msg, info_ind, req_arfcn, req_bsic); } /* Before receiving CTRL response, MS retransmits Pkt cell Chg Notif */ @@ -5763,9 +5786,9 @@ f_sleep(0.2); /* let some time to avoid race conditons between CTRL and RLCMAC */ if (use_old_ctrl_iface) { - IPA_CTRL.send(ts_CtrlMsgGetRepl(rx_ctrl.cmd.id, ctrl_var, "023-43-423-2-5")); + f_ctrl_tx_nacc_rac_ci_rsp(rx_ctrl); } else { - BTS.send(ts_PCUIF_NEIGH_ADDR_CNF(0, pcu_msg.u.container.u.neigh_addr_req, 0, 23, 43, 0, 423, 2, 5)); + f_pcuif_tx_nacc_rac_ci_rsp(pcu_msg); } timer T := 2.0; @@ -6133,24 +6156,18 @@ /* osmo-pcu should now ask for resolution: */ if (use_old_ctrl_iface) { - f_ipa_ctrl_wait_link_up(); - ctrl_var := "neighbor_resolve_cgi_ps_from_lac_ci." & - int2str(info_ind.lac) & "." & - int2str(info_ind.cell_id) & "." & - int2str(req_arfcn) & "." & - int2str(req_bsic); - IPA_CTRL.receive(tr_CtrlMsgGet(?, ctrl_var)) -> value rx_ctrl; + f_ctrl_rx_nacc_rac_ci_req(rx_ctrl, info_ind, req_arfcn, req_bsic); } else { - BTS.receive(tr_PCUIF_NEIGH_ADDR_REQ(0, info_ind.lac, info_ind.cell_id, req_arfcn, req_bsic)) -> value pcu_msg; + f_pcuif_rx_nacc_rac_ci_req(pcu_msg, info_ind, req_arfcn, req_bsic); } /* Before receiving CTRL response, MS retransmits Pkt cell Chg Notif with different tgt arfcn */ cell_chf_notif := ts_RlcMacUlCtrl_PKT_CELL_CHG_NOTIF(ms.ul_tbf.tfi, req_arfcn + 1, req_bsic + 1); f_ms_tx_ul_block(ms, ts_RLC_UL_CTRL_ACK(cell_chf_notif), 0, nr := f_ms_tx_TsTrxBtsNum(ms)); f_sleep(0.2); /* let some time to avoid race conditons between CTRL and RLCMAC */ if (use_old_ctrl_iface) { - IPA_CTRL.send(ts_CtrlMsgGetRepl(rx_ctrl.cmd.id, ctrl_var, "023-43-423-2-5")); + f_ctrl_tx_nacc_rac_ci_rsp(rx_ctrl); } else { - BTS.send(ts_PCUIF_NEIGH_ADDR_CNF(0, pcu_msg.u.container.u.neigh_addr_req, 0, 23, 43, 0, 423, 2, 5)); + f_pcuif_tx_nacc_rac_ci_rsp(pcu_msg); } /* We should now receive a 2nd CTRL request with the new ARFCN+BSIC */ f_handle_nacc_rac_ci_query(info_ind, req_arfcn + 1, req_bsic + 1, true, use_old_ctrl_iface); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3e84f55eedd278fb239600d6a0465bd34fd8cd0b Gerrit-Change-Number: 31302 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmocom-bb[master]: mobile: add optional statsd support

by fixeria

Attention is currently required from: pespin, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31298 ) Change subject: mobile: add optional statsd support ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/31298/comment/5f9f83e8_8f7c02b2 PS1, Line 7: statsd support You're not adding any actual stats items, but adding the VTY commands only. Are you planning to implement them soon? What ticket is this related to? File src/host/layer23/include/osmocom/bb/common/l23_app.h: https://gerrit.osmocom.org/c/osmocom-bb/+/31298/comment/d513fb93_b64fdaaa PS1, Line 17: L23_OPT_STAT Why making this optional command line option? If some app indicates L23_OPT_VTY, then I guess it makes sense to install the necessary VTY commands without relying on a separate flag? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31298 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7905b44478dcb9bcf0a1a68fde95f470c07edca3 Gerrit-Change-Number: 31298 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 12 Feb 2023 19:03:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023