February 2023 - gerrit-log - lists.osmocom.org

Change in pysim[master]: cards: sysmo-isim-sja2: make sure an ADF is present in EF.DIR before ...

by laforge

Attention is currently required from: fixeria, pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31288 ) Change subject: cards: sysmo-isim-sja2: make sure an ADF is present in EF.DIR before selecting it ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'd appreciate if you wouldn't use the topic "fix". It leads to the confusing 33 patches "same topic", which means I'm trying to find related patches there, but those are completely unrelated patches of other projects. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31288 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icf6f6b36f246398af408ec432d493fe3f22963dd Gerrit-Change-Number: 31288 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 11 Feb 2023 09:14:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in pysim[master]: cards: sysmo-isim-sja2: make sure an ADF is present in EF.DIR before ...

by laforge

Attention is currently required from: fixeria, pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31288 ) Change subject: cards: sysmo-isim-sja2: make sure an ADF is present in EF.DIR before selecting it ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31288 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icf6f6b36f246398af408ec432d493fe3f22963dd Gerrit-Change-Number: 31288 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 11 Feb 2023 09:13:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Emulation: initiate CER/CEA exchange in client mode

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31292 ) Change subject: library/DIAMETER_Emulation: initiate CER/CEA exchange in client mode ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31292 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7537b306c2a569e2232597f21e15d3cf4ec9a12c Gerrit-Change-Number: 31292 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 11 Feb 2023 09:12:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Emulation: f_diameter_xceive(): ignore unexpected PDUs

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31291 ) Change subject: library/DIAMETER_Emulation: f_diameter_xceive(): ignore unexpected PDUs ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I would think that for a *test suite* it is questionable to ignore any and all unknown/unexpected packets. Normally we should have an expectation what (if anything at all) to receive, and we should only ever accept things we are accepting. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31291 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6dbc646d5f036f454f197137373796f40c4c9e74 Gerrit-Change-Number: 31291 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 11 Feb 2023 09:11:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: add send template for CER

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31290 ) Change subject: library/DIAMETER_Templates: add send template for CER ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31290 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I58690decfe0ec54da76af6dcfb108f2d78322e9c Gerrit-Change-Number: 31290 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 11 Feb 2023 09:10:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-pfcp[master]: add doc/charts/pfcp_msgs*.msc

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31294 ) Change subject: add doc/charts/pfcp_msgs*.msc ...................................................................... add doc/charts/pfcp_msgs*.msc (I used these while implementing libosmo-pfcp and osmo-upf, but never submitted them.) Change-Id: I8d2343224d02d728e2eee2090ee2d4c6bec79e78 --- A doc/charts/pfcp_msgs.msc A doc/charts/pfcp_msgs_gtp.msc 2 files changed, 151 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/94/31294/1 diff --git a/doc/charts/pfcp_msgs.msc b/doc/charts/pfcp_msgs.msc new file mode 100644 index 0000000..afcca18 --- /dev/null +++ b/doc/charts/pfcp_msgs.msc @@ -0,0 +1,60 @@ +msc { + hscale="1"; + upf[label="User Plane function"],cpf[label="Control Plane function"]; + + cpf rbox cpf [label="Look up UPF,\npick any one of the available\nIP addrs for the UPF"]; + + ...; + upf abox cpf [label="not yet associated"]; + upf rbox cpf [label="reject any session related msgs"]; + ...; + + upf <<= cpf [label="PFCP Association Setup Request\nCP function Node Id, features"]; + upf =>> cpf [label="PFCP Association Setup Response\nUP function Node Id, features"]; + upf abox cpf [label="associated"]; + upf rbox cpf [label="start Heartbeat checking"]; + ...; + upf <<= cpf [label="Heartbeat Request"]; + upf =>> cpf [label="Heartbeat Response"]; + ...; + upf =>> cpf [label="Heartbeat Request"]; + upf <<= cpf [label="Heartbeat Response"]; + ...; + + upf <<= cpf [label="Session Establishment Request\nCP Node-Id\nCP F-SEID\n1+ Packet Detection Rule(s)\n1+ Forward Action Rule(s)"]; + upf =>> cpf [label="Session Establishment Response"]; + + upf <<= cpf [label="Session Modification Request"]; + upf =>> cpf [label="Session Modification Response"]; + + upf <<= cpf [label="Session Deletion Request"]; + upf =>> cpf [label="Session Deletion Response"]; + + ...; + upf rbox cpf [label="F-SEID: accept any other IP addrs than peer's Node Id"]; + ...; + + --- [label="Graceful release initiated by CP"]; + + upf <<= cpf [label="Association Update Request\nwith PFCP Association Release Preparation Start = 1"]; + upf =>> cpf [label="Association Update Response"]; + upf =>> cpf [label="Session Report Request\nto report non-zero usage reports,\nat least one message per PFCP Session"]; + upf <<= cpf [label="Association Release Request"]; + upf =>> cpf [label="Association Release Response"]; + + --- [label="Graceful release initiated by UP"]; + + upf =>> cpf [label="Association Update Request\nwith PFCP Association Release Preparation = 1"]; + cpf abox cpf [label="refrain from establishing sessions"]; + upf <<= cpf [label="Association Update Response"]; + upf <<= cpf [label="Session Deletion Request(s)\nto collect usage reports\nper session"]; + upf =>> cpf [label="Session Deletion Response(s)"]; + cpf rbox cpf [label="wait Graceful Release Period"]; + upf <<= cpf [label="Association Release Request"]; + upf =>> cpf [label="Association Release Response"]; + + --- [label="Release (immediate)"]; + + upf <<= cpf [label="Association Release Request"]; + upf =>> cpf [label="Association Release Response"]; +} diff --git a/doc/charts/pfcp_msgs_gtp.msc b/doc/charts/pfcp_msgs_gtp.msc new file mode 100644 index 0000000..f59412c --- /dev/null +++ b/doc/charts/pfcp_msgs_gtp.msc @@ -0,0 +1,91 @@ +msc { + hscale="1"; + sgsn[label="SGSN\n123.44.0.9"],sgwc[label="SGW-C\n123.44.0.5"],sgwu[label="SGW-U\n123.44.0.6"],pgwc[label="PGW-C\n123.44.0.7"],pgwu[label="PGW-U\n123.44.0.8"]; + + sgsn <=> sgwc [label="S4-C GTPv2-C"]; + sgwc <=> sgwu [label="Sxa PFCP"]; + sgsn <=> sgwu [label="S4-U GTPv1-U"]; + sgwc <=> pgwc [label="S5-C GTPv2-C"]; + pgwc <=> pgwu [label="Sxb PFCP"]; + sgwu <=> pgwu [label="S5-U GTPv1-U"]; + + ...; + + sgsn => sgwc [label="GTP Create Session Request"]; + sgsn note sgwc [label="F-TEID S11 = 123.44.0.9,0x004\nF-TEID S5 = 123.44.0.7,0x000\nPDN addr alloc = IPv4 192.168.100.2"]; + + |||; + |||; + + sgwc => sgwu [label="PFCP Session Establishment Request"]; + sgwc note sgwu [label="2x Create PDR\nF-TEID = CHOOSE\nFAR = NOCP,BUFF"]; + + |||; + |||; + + sgwc <= sgwu [label="PFCP Session Establishment Response"]; + sgwc note sgwu [label="Created PDR F-TEID 123.44.0.6,0x015\nCreated PDR F-TEID 123.44.0.6,0x016"]; + + |||; + |||; + + sgwc => pgwc [label="GTP Create Session Request"]; + sgwc note pgwc [label="F-TEID S5 = 123.44.0.5,0x00b\nPDN addr alloc = IPv4 192.168.100.2\nBearer Ctx: F-TEID S5 = 123.44.0.6,0x015"]; + + |||; + |||; + + pgwc => pgwu [label="PFCP Session Establishment Request"]; + pgwc note pgwu [label="Create PDR 1:\nPDI: src-iface Core, UE IPv4 192.168.100.2\nFAR-1: FORW, dst-iface Access,\nhdr creation: GTP-U 123.44.0.6,0x015\n\nCreate PDR 2:\nPDI: src-iface Access, F-TEID = CHOOSE id:05\nhdr removal: GTP-U\nFAR-2: FORW, dst-iface Core\n\nCreate PDR 3:\nPDI: src-iface CP-function, F-TEID = CHOOSE\nhdr removal: GTP-U\nFAR-1\n\nCreate PDR 4:\nPDI: src-iface Access, F-TEID = CHOOSE id:05, SDF Filter\nhdr removal: GTP-U\nFAR-3: FORW, dst-iface CP-Function,\nhdr creation: GTP-U 123.44.0.7,0x00b"]; + + |||; + + pgwc <= pgwu [label="PFCP Session Establishment Response"]; + pgwc note pgwu [label="Created PDR-1\nCreated PDR-2: F-TEID = 123.44.0.8,0x01e\nCreated PDR-3: F-TEID = 123.44.0.8,0x01f\nCreated PDR-4: F-TEID = 123.44.0.8,0x01e"]; + + |||; + |||; + + sgwc <= pgwc [label="GTP Create Session Response"]; + sgwc note pgwc [label="TEID: 0x00b\nF-TEID: 123.44.0.7,0x00b\nPDN Addr: 192.168.100.2\nBearer Ctx: F-TEID S5 123.44.0.8,0x01e"]; + + |||; + |||; + + sgwc => sgwu [label="PFCP Session Modification Request"]; + sgwc note sgwu [label="Update FAR-2: FORW, dst-iface Core,\nhdr creation GTP-U 123.44.0.8,0x01e"]; + + |||; + + sgwc <= sgwu [label="PFCP Session Modification Response"]; + + |||; + |||; + + sgsn <= sgwc [label="GTP Create Session Response"]; + sgsn note sgwc [label="TEID: 0x004\nF-TEID S11/S4: 123.44.0.5,0x007\nF-TEID S5/S8: 123.44.0.7,0x00b\nPDN Addr: 192.168.100.2\nBearer Ctx:\nF-TEID S1-U: 123.44.0.6,0x016\nF-TEID S5/S8: 123.44.0.8,0x01e"]; + + |||; + |||; + + sgsn => sgwc [label="GTP Modify Bearer Request"]; + sgsn note sgwc [label="TEID: 0x007\nBearer Ctx:\nF-TEID S1-U: 192.168.104.167,0x32adb2ad"]; + + |||; + |||; + + sgwc => sgwu [label="PFCP Session Modification Request"]; + sgwc note sgwu [label="Update FAR-1: FORW, dst-iface Access,\nhdr creation: GTP-U 192.168.104.167,0x32adb2ad"]; + + |||; + |||; + + + sgwc <= sgwu [label="PFCP Session Modification Response"]; + + |||; + + sgsn <= sgwc [label="GTP Modify Bearer Response"]; + sgsn note sgwc [label="TEID: 0x004\nBearer Ctx:\nF-TEID S1-U: 192.168.104.167,0x32adb2ad"]; + +} -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31294 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I8d2343224d02d728e2eee2090ee2d4c6bec79e78 Gerrit-Change-Number: 31294 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Emulation: f_diameter_xceive(): ignore unexpected PDUs

by fixeria

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31291 to look at the new patch set (#2). Change subject: library/DIAMETER_Emulation: f_diameter_xceive(): ignore unexpected PDUs ...................................................................... library/DIAMETER_Emulation: f_diameter_xceive(): ignore unexpected PDUs Currently an unexpected PDU will trigger a DTE (no matching alt). Change-Id: I6dbc646d5f036f454f197137373796f40c4c9e74 Related: SYS#5602, SYS#6333 --- M library/DIAMETER_Emulation.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/91/31291/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31291 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6dbc646d5f036f454f197137373796f40c4c9e74 Gerrit-Change-Number: 31291 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Emulation: initiate CER/CEA exchange in client mode

by fixeria

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31292 to look at the new patch set (#2). Change subject: library/DIAMETER_Emulation: initiate CER/CEA exchange in client mode ...................................................................... library/DIAMETER_Emulation: initiate CER/CEA exchange in client mode Change-Id: I7537b306c2a569e2232597f21e15d3cf4ec9a12c Related: SYS#5602, SYS#6333 --- M library/DIAMETER_Emulation.ttcn 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/92/31292/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31292 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7537b306c2a569e2232597f21e15d3cf4ec9a12c Gerrit-Change-Number: 31292 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: add send template for CER

by fixeria

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31290 to look at the new patch set (#2). Change subject: library/DIAMETER_Templates: add send template for CER ...................................................................... library/DIAMETER_Templates: add send template for CER Change-Id: I58690decfe0ec54da76af6dcfb108f2d78322e9c Related: SYS#5602, SYS#6333 --- M library/DIAMETER_Templates.ttcn 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/90/31290/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31290 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I58690decfe0ec54da76af6dcfb108f2d78322e9c Gerrit-Change-Number: 31290 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in osmo-hnbgw[master]: UE state leak: when HNB re-registers, discard previous UE state

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31293 ) Change subject: UE state leak: when HNB re-registers, discard previous UE state ...................................................................... UE state leak: when HNB re-registers, discard previous UE state User reports show leaked UE contexts over time, in a scenario where HNB regularly disconnect and reconnect. So far, when we receive a HNB REGISTER REQ, we log as "duplicated" and continue to use the hnb_context unchanged. But it seems obvious that a HNB that registers does not expect any UE state to remain. It will obviously not tear down UE contexts (HNBAP or RUA) that have been established before the HNB REGISTER REQUEST. These hence remain in osmo-hnbgw indefinitely. When receiving a HNB REGISTER REQUEST, release all its previous UE state. Allow the HNB to register with a clean slate. The aim is to alleviate the observed build-up of apparently orphaned UE contexts, in order to avoid gradual memory exhaustion. Related: SYS#6297 Change-Id: I7fa8a04cc3b2dfba263bda5b410961c77fbed332 --- M include/osmocom/hnbgw/hnbgw.h M src/osmo-hnbgw/hnbgw.c M src/osmo-hnbgw/hnbgw_hnbap.c 3 files changed, 21 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/93/31293/1 diff --git a/include/osmocom/hnbgw/hnbgw.h b/include/osmocom/hnbgw/hnbgw.h index 8adefea..ed18ca4 100644 --- a/include/osmocom/hnbgw/hnbgw.h +++ b/include/osmocom/hnbgw/hnbgw.h @@ -188,6 +188,7 @@ struct hnb_context *hnb_context_alloc(struct hnb_gw *gw, struct osmo_stream_srv_link *link, int new_fd); void hnb_context_release(struct hnb_context *ctx); +void hnb_context_release_ue_state(struct hnb_context *ctx); void hnbgw_vty_init(struct hnb_gw *gw, void *tall_ctx); int hnbgw_vty_go_parent(struct vty *vty); diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index 5dba1e3..3a6879e 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -395,15 +395,10 @@ return umts_cell_id_name(&ctx->id); } -void hnb_context_release(struct hnb_context *ctx) +void hnb_context_release_ue_state(struct hnb_context *ctx) { struct hnbgw_context_map *map, *map2; - LOGHNB(ctx, DMAIN, LOGL_INFO, "Releasing HNB context\n"); - - /* remove from the list of HNB contexts */ - llist_del(&ctx->list); - /* deactivate all context maps */ llist_for_each_entry_safe(map, map2, &ctx->map_list, hnb_list) { /* remove it from list, as HNB context will soon be @@ -414,6 +409,16 @@ context_map_deactivate(map); } ue_context_free_by_hnb(ctx->gw, ctx); +} + +void hnb_context_release(struct hnb_context *ctx) +{ + LOGHNB(ctx, DMAIN, LOGL_INFO, "Releasing HNB context\n"); + + /* remove from the list of HNB contexts */ + llist_del(&ctx->list); + + hnb_context_release_ue_state(ctx); if (ctx->conn) { /* we own a conn, we must free it: */ LOGHNB(ctx, DMAIN, LOGL_INFO, "Closing HNB SCTP connection %s\n", diff --git a/src/osmo-hnbgw/hnbgw_hnbap.c b/src/osmo-hnbgw/hnbgw_hnbap.c index 4aefe2b..19ebd38 100644 --- a/src/osmo-hnbgw/hnbgw_hnbap.c +++ b/src/osmo-hnbgw/hnbgw_hnbap.c @@ -467,7 +467,15 @@ LOGHNB(ctx, DHNBAP, LOGL_DEBUG, "HNB-REGISTER-REQ %s MCC=%u,MNC=%u,LAC=%u,RAC=%u,SAC=%u,CID=%u from %s%s\n", ctx->identity_info, ctx->id.mcc, ctx->id.mnc, ctx->id.lac, ctx->id.rac, ctx->id.sac, ctx->id.cid, - name, ctx->hnb_registered ? " (duplicated)" : ""); + name, ctx->hnb_registered ? " (re-connecting)" : ""); + + if (ctx->hnb_registered) { + /* The HNB is already registered, and we are seeing a new HNB Register Request. The HNB has restarted + * without us noticing. Clearly, the HNB does not expect any UE state to be active here, so discard any + * UE contexts and SCCP connections associated with this HNB. */ + LOGHNB(ctx, DHNBAP, LOGL_NOTICE, "HNB reconnecting, discarding all previous UE state\n"); + hnb_context_release_ue_state(ctx); + } ctx->hnb_registered = true; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31293 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I7fa8a04cc3b2dfba263bda5b410961c77fbed332 Gerrit-Change-Number: 31293 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023