February 2023 - gerrit-log - lists.osmocom.org

Change in osmo-pcu[master]: pcu_l1_if: move direct phy l1if functions to dedicated header file

by dexter

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/31314 to look at the new patch set (#2). Change subject: pcu_l1_if: move direct phy l1if functions to dedicated header file ...................................................................... pcu_l1_if: move direct phy l1if functions to dedicated header file The function headers for the direct phy related functions (l1if_...) are currently directly listed in pcu_l1_if.cpp and osmobts_sock.c. Those functions are basically the API interface definition between the platform independed PCU code and the platform dependant direct phy code. Lets put them into a dedicated header file. Change-Id: Id54b96a4cd498a9860f3f209498132455e2aa6f8 Related: OS#5198 --- M src/Makefile.am M src/osmobts_sock.c M src/pcu_l1_if.cpp A src/pcu_l1_if_phy.h 4 files changed, 12 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/14/31314/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31314 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id54b96a4cd498a9860f3f209498132455e2aa6f8 Gerrit-Change-Number: 31314 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: fsms: use configurable timers instead of T23042

by osmith

Attention is currently required from: laforge, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30307 ) Change subject: fsms: use configurable timers instead of T23042 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > what is holding this change back from getting rebased + merged? A new ttcn-3 test as mentioned in https://gerrit.osmocom.org/c/osmo-bsc/+/30307/1//COMMIT_MSG#46 needs to be implemented, so X30 can be dropped. I'll look into it. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id0d4d0788f609f3272fc81c80a754383dde25c16 Gerrit-Change-Number: 30307 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Feb 2023 12:55:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-pcu[master]: pcu_l1_if: move direct phy l1if functions to dedicated header file

by pespin

Attention is currently required from: laforge, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31314 ) Change subject: pcu_l1_if: move direct phy l1if functions to dedicated header file ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/pcu_l1_if_phy.h: https://gerrit.osmocom.org/c/osmo-pcu/+/31314/comment/52af1896_9d0a0aae PS1, Line 3: void *l1if_open_pdch(uint8_t trx_no, uint32_t hlayer1, struct gsmtap_inst *gsmtap); missing #include <stdint.h> -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31314 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id54b96a4cd498a9860f3f209498132455e2aa6f8 Gerrit-Change-Number: 31314 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Feb 2023 12:43:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-mgw[master]: mgcp_e1: fix log output

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31308 ) Change subject: mgcp_e1: fix log output ...................................................................... mgcp_e1: fix log output Its not the E1 timeslot that is updated, its the E1 line instead (which includes the timeslot) Change-Id: Ic72cf90ebdba1b5e395089417c6df5b962f8ffc8 --- M src/libosmo-mgcp/mgcp_e1.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_e1.c b/src/libosmo-mgcp/mgcp_e1.c index 7f30c1d..24f297f 100644 --- a/src/libosmo-mgcp/mgcp_e1.c +++ b/src/libosmo-mgcp/mgcp_e1.c @@ -401,7 +401,7 @@ } rc = e1inp_line_update(e1_line); if (rc < 0) { - LOGPTRUNK(trunk, DE1, LOGL_ERROR, "failed to update E1 timeslot %u.\n", ts_nr); + LOGPTRUNK(trunk, DE1, LOGL_ERROR, "failed to update E1 line %u.\n", ts_nr); return -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31308 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic72cf90ebdba1b5e395089417c6df5b962f8ffc8 Gerrit-Change-Number: 31308 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in osmo-pcu[master]: pcu_l1_if: move direct phy l1if functions to dedicated header file

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31314 ) Change subject: pcu_l1_if: move direct phy l1if functions to dedicated header file ...................................................................... pcu_l1_if: move direct phy l1if functions to dedicated header file The function headers for the direct phy related functions (l1if_...) are currently directly listed in pcu_l1_if.cpp and osmobts_sock.c. Those functions are basically the API interface definition between the platform independed PCU code and the platform dependant direct phy code. Lets put them into a dedicated header file. Change-Id: Id54b96a4cd498a9860f3f209498132455e2aa6f8 Related: OS#5198 --- M src/osmobts_sock.c M src/pcu_l1_if.cpp A src/pcu_l1_if_phy.h 3 files changed, 9 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/14/31314/1 diff --git a/src/osmobts_sock.c b/src/osmobts_sock.c index 1cbd1a0..282e33f 100644 --- a/src/osmobts_sock.c +++ b/src/osmobts_sock.c @@ -30,6 +30,7 @@ #include <pcu_l1_if.h> +#include <pcu_l1_if_phy.h> #include <gprs_debug.h> #include <gprs_bssgp_pcu.h> #include <osmocom/pcu/pcuif_proto.h> @@ -37,8 +38,6 @@ #include <tbf.h> #include <pdch.h> -int l1if_close_pdch(void *obj); - /* * osmo-bts PCU socket functions */ diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index 02f56ac..62f02d9 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -43,6 +43,7 @@ #include <osmocom/gsm/gsm0502.h> #include <nacc_fsm.h> +#include <pcu_l1_if_phy.h> } #include <gprs_rlcmac.h> @@ -56,15 +57,6 @@ #include <tbf_dl.h> #include <gprs_ms_storage.h> -// FIXME: move this, when changed from c++ to c. -extern "C" { -void *l1if_open_pdch(uint8_t trx_no, uint32_t hlayer1, - struct gsmtap_inst *gsmtap); -int l1if_connect_pdch(void *obj, uint8_t ts); -int l1if_pdch_req(void *obj, uint8_t ts, int is_ptcch, uint32_t fn, - uint16_t arfcn, uint8_t block_nr, uint8_t *data, uint8_t len); -} - extern void *tall_pcu_ctx; #define PAGING_GROUP_LEN 3 diff --git a/src/pcu_l1_if_phy.h b/src/pcu_l1_if_phy.h new file mode 100644 index 0000000..683882a --- /dev/null +++ b/src/pcu_l1_if_phy.h @@ -0,0 +1,7 @@ +#pragma once + +void *l1if_open_pdch(uint8_t trx_no, uint32_t hlayer1, struct gsmtap_inst *gsmtap); +int l1if_connect_pdch(void *obj, uint8_t ts); +int l1if_pdch_req(void *obj, uint8_t ts, int is_ptcch, uint32_t fn, uint16_t arfcn, uint8_t block_nr, uint8_t *data, + uint8_t len); +int l1if_close_pdch(void *obj); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31314 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id54b96a4cd498a9860f3f209498132455e2aa6f8 Gerrit-Change-Number: 31314 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-ci[master]: repo-install-test: run uname -a

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31313 ) Change subject: repo-install-test: run uname -a ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31313 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic111ac8eda11c5609ec6ce7cf8a22584d32ed567 Gerrit-Change-Number: 31313 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Feb 2023 12:30:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-ci[master]: repo-install-test: add DOMAIN variable

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31312 ) Change subject: repo-install-test: add DOMAIN variable ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31312 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I36bc0eae9fdee75512c1dbdca84cd6224b8c192a Gerrit-Change-Number: 31312 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Feb 2023 12:30:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-ci[master]: repo-install-test: update tests for e1d/ggsn/pfcp

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31311 ) Change subject: repo-install-test: update tests for e1d/ggsn/pfcp ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31311 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2452993abc1c0fe78bef464f1a62fe578b48016b Gerrit-Change-Number: 31311 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Feb 2023 12:29:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-ci[master]: repo-install-test: disable osmo-upf service check

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31309 ) Change subject: repo-install-test: disable osmo-upf service check ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31309 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I970cad1bdb4586afa8ba5b4dac31bb9ac02b7b2d Gerrit-Change-Number: 31309 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Feb 2023 12:29:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-ci[master]: repo-install-test: adjust to 2023-02 releases

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31310 ) Change subject: repo-install-test: adjust to 2023-02 releases ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31310 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic1d912efbe504b6e35b59e31d12b983b9d924355 Gerrit-Change-Number: 31310 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Feb 2023 12:29:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023