February 2023 - gerrit-log - lists.osmocom.org

Change in osmo-pcu[master]: pcu_l1_if.cpp: handle TLLI based IMMEDIATE ASSIGNMENT confirmation

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31148 ) Change subject: pcu_l1_if.cpp: handle TLLI based IMMEDIATE ASSIGNMENT confirmation ...................................................................... pcu_l1_if.cpp: handle TLLI based IMMEDIATE ASSIGNMENT confirmation The IMMEDIATE ASSIGNMENT for downlink TBFs must be confirmed by the receiving end (BSC/BTS) in order to set the timers in the PCU correctly. When the PCU is used in a BSC co-located scheme (Ericsson RBS). The TLLI is used as an identifier to confirm a specific IMMEDIATE ASSIGNMENT. Change-Id: Icf7ca34500984239ee877ee71fd9c126b5eb3480 Related: OS#5198 --- M src/bts.cpp M src/bts.h M src/pcu_l1_if.cpp 3 files changed, 61 insertions(+), 11 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/bts.cpp b/src/bts.cpp index d06c9d0..33ad4a6 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -668,13 +668,10 @@ return best_first_tfi; } -int bts_rcv_imm_ass_cnf(struct gprs_rlcmac_bts *bts, const uint8_t *data, uint32_t fn) +static int tlli_from_imm_ass(uint32_t *tlli, const uint8_t *data, uint32_t fn) { - struct gprs_rlcmac_dl_tbf *dl_tbf; const struct gsm48_imm_ass *imm_ass = (struct gsm48_imm_ass *)data; uint8_t plen; - uint32_t tlli; - GprsMs *ms; /* Move to IA Rest Octets: TS 44.018 9.1.18 "The L2 pseudo length of * this message is the sum of lengths of all information elements @@ -692,12 +689,41 @@ } /* get TLLI from downlink assignment */ - tlli = (uint32_t)((*data++) & 0xf) << 28; - tlli |= (*data++) << 20; - tlli |= (*data++) << 12; - tlli |= (*data++) << 4; - tlli |= (*data++) >> 4; + *tlli = (uint32_t)((*data++) & 0xf) << 28; + *tlli |= (*data++) << 20; + *tlli |= (*data++) << 12; + *tlli |= (*data++) << 4; + *tlli |= (*data++) >> 4; + return 0; +} + +int bts_rcv_imm_ass_cnf(struct gprs_rlcmac_bts *bts, const uint8_t *data, uint32_t tlli, uint32_t fn) +{ + struct gprs_rlcmac_dl_tbf *dl_tbf; + GprsMs *ms; + int rc; + + /* NOTE: A confirmation for a downlink IMMEDIATE ASSIGNMENT can be received using two different methods. + * One way is to send the whole IMMEDIATE ASSIGNMENT back to the PCU and the TLLI, which we use as + * reference is extracted from the rest octets of this message. Alternatively the TLLI may be sent as + * confirmation directly. */ + + /* Extract TLLI from the presented IMMEDIATE ASSIGNMENT + * (if present and only when TLLI that is supplied as function parameter is valid.) */ + if (data && tlli == GSM_RESERVED_TMSI) { + rc = tlli_from_imm_ass(&tlli, data, fn); + if (rc != 0) + return -EINVAL; + } + + /* Make sure TLLI is valid */ + if (tlli == GSM_RESERVED_TMSI) { + LOGP(DTBFDL, LOGL_ERROR, "FN=%u Got IMM.ASS confirm, but TLLI is invalid!\n", fn); + return -EINVAL; + } + + /* Find related TBF and send confirmation signal to FSM */ ms = bts_ms_by_tlli(bts, tlli, GSM_RESERVED_TMSI); if (!ms) { LOGP(DTBFDL, LOGL_ERROR, "FN=%u Got IMM.ASS confirm for unknown MS with TLLI=%08x\n", fn, tlli); diff --git a/src/bts.h b/src/bts.h index 61c5e43..5efbdad 100644 --- a/src/bts.h +++ b/src/bts.h @@ -315,7 +315,7 @@ int bts_rcv_rach(struct gprs_rlcmac_bts *bts, const struct rach_ind_params *rip); int bts_rcv_ptcch_rach(struct gprs_rlcmac_bts *bts, const struct rach_ind_params *rip); -int bts_rcv_imm_ass_cnf(struct gprs_rlcmac_bts *bts, const uint8_t *data, uint32_t fn); +int bts_rcv_imm_ass_cnf(struct gprs_rlcmac_bts *bts, const uint8_t *data, uint32_t tlli, uint32_t fn); void bts_send_gsmtap(struct gprs_rlcmac_bts *bts, enum pcu_gsmtap_category categ, bool uplink, uint8_t trx_no, diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index 69629db..02f56ac 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -512,7 +512,7 @@ switch (data_cnf->sapi) { case PCU_IF_SAPI_PCH: if (data_cnf->data[2] == GSM48_MT_RR_IMM_ASS) - bts_rcv_imm_ass_cnf(bts, data_cnf->data, data_cnf->fn); + bts_rcv_imm_ass_cnf(bts, data_cnf->data, GSM_RESERVED_TMSI, data_cnf->fn); break; default: LOGP(DL1IF, LOGL_ERROR, "Received PCU data confirm with " @@ -523,6 +523,26 @@ return rc; } +static int pcu_rx_data_cnf_dt(struct gprs_rlcmac_bts *bts, struct gsm_pcu_if_data_cnf_dt *data_cnf_dt) +{ + int rc = 0; + int current_fn = bts_current_frame_number(bts); + + LOGP(DL1IF, LOGL_DEBUG, "Data confirm received: sapi=%d fn=%d cur_fn=%d\n", + data_cnf_dt->sapi, data_cnf_dt->fn, current_fn); + + switch (data_cnf_dt->sapi) { + case PCU_IF_SAPI_PCH: + bts_rcv_imm_ass_cnf(bts, NULL, data_cnf_dt->tlli, data_cnf_dt->fn); + break; + default: + LOGP(DL1IF, LOGL_ERROR, "Received PCU data confirm with unsupported sapi %d\n", data_cnf_dt->sapi); + rc = -EINVAL; + } + + return rc; +} + // FIXME: remove this, when changed from c++ to c. int pcu_rx_rts_req_pdtch(struct gprs_rlcmac_bts *bts, uint8_t trx, uint8_t ts, uint32_t fn, uint8_t block_nr) @@ -1133,6 +1153,10 @@ CHECK_IF_MSG_SIZE(pcu_prim_length, pcu_prim->u.data_cnf); rc = pcu_rx_data_cnf(bts, &pcu_prim->u.data_cnf); break; + case PCU_IF_MSG_DATA_CNF_DT: + CHECK_IF_MSG_SIZE(pcu_prim_length, pcu_prim->u.data_cnf_dt); + rc = pcu_rx_data_cnf_dt(bts, &pcu_prim->u.data_cnf_dt); + break; case PCU_IF_MSG_RTS_REQ: CHECK_IF_MSG_SIZE(pcu_prim_length, pcu_prim->u.rts_req); rc = pcu_rx_rts_req(bts, &pcu_prim->u.rts_req); 7 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31148 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Icf7ca34500984239ee877ee71fd9c126b5eb3480 Gerrit-Change-Number: 31148 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in osmo-mgw[master]: mgcp_e1: fix log output

by osmith

Attention is currently required from: dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31308 ) Change subject: mgcp_e1: fix log output ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31308 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic72cf90ebdba1b5e395089417c6df5b962f8ffc8 Gerrit-Change-Number: 31308 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Feb 2023 12:27:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Introduce DL TBF creation through PCH ImmAss

by pespin

Attention is currently required from: neels, msuraev. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31286 to look at the new patch set (#8). Change subject: rlcmac: Introduce DL TBF creation through PCH ImmAss ...................................................................... rlcmac: Introduce DL TBF creation through PCH ImmAss This patch only introduces the gprs_rlcmac_dl_tbf subclass and allocates/frees it based on PCH ImmAss, and adds initial paths for received blocks. It also provides a unit test to showcase the scenario. Change-Id: I7f98e3456ef35d80becdad3481afeb771457b0ef --- M include/osmocom/gprs/rlcmac/Makefile.am M include/osmocom/gprs/rlcmac/coding_scheme.h M include/osmocom/gprs/rlcmac/gre.h M include/osmocom/gprs/rlcmac/rlcmac_private.h A include/osmocom/gprs/rlcmac/tbf_dl.h M include/osmocom/gprs/rlcmac/types_private.h M src/rlcmac/Makefile.am M src/rlcmac/coding_scheme.c M src/rlcmac/gre.c M src/rlcmac/rlcmac.c M src/rlcmac/rlcmac_prim.c A src/rlcmac/tbf_dl.c M tests/rlcmac/Makefile.am M tests/rlcmac/rlcmac_prim_test.c M tests/rlcmac/rlcmac_prim_test.err M tests/rlcmac/rlcmac_prim_test.ok 16 files changed, 489 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/86/31286/8 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31286 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I7f98e3456ef35d80becdad3481afeb771457b0ef Gerrit-Change-Number: 31286 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in osmo-ci[master]: repo-install-test: run uname -a

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/31313 ) Change subject: repo-install-test: run uname -a ...................................................................... repo-install-test: run uname -a Print the kernel version running inside the VM. Change-Id: Ic111ac8eda11c5609ec6ce7cf8a22584d32ed567 --- M scripts/repo-install-test/run-inside.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/13/31313/1 diff --git a/scripts/repo-install-test/run-inside.sh b/scripts/repo-install-test/run-inside.sh index 6fcc391..319e822 100755 --- a/scripts/repo-install-test/run-inside.sh +++ b/scripts/repo-install-test/run-inside.sh @@ -477,6 +477,8 @@ check_env prepare_vm +uname -a + for test in $TESTS; do set +x echo -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31313 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic111ac8eda11c5609ec6ce7cf8a22584d32ed567 Gerrit-Change-Number: 31313 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-ci[master]: repo-install-test: add DOMAIN variable

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/31312 ) Change subject: repo-install-test: add DOMAIN variable ...................................................................... repo-install-test: add DOMAIN variable Allow overriding the downloads.osmocom.org domain of the url where packages are downloaded from, so we can download them from people.osmocom.org instead while developing / debugging, e.g.: https://people.osmocom.org/packages/home:/osmith:/nightly/ Change-Id: I36bc0eae9fdee75512c1dbdca84cd6224b8c192a --- M scripts/repo-install-test.sh M scripts/repo-install-test/run-inside.sh 2 files changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/12/31312/1 diff --git a/scripts/repo-install-test.sh b/scripts/repo-install-test.sh index 38f1a6b..676354a 100755 --- a/scripts/repo-install-test.sh +++ b/scripts/repo-install-test.sh @@ -1,5 +1,6 @@ #!/bin/sh -ex # Environment variables: +# * DOMAIN: default is downloads.osmocom.org, set to people.osmocom.org for testing pkgs from home:… # * FEED: binary package feed (e.g. "latest", "nightly") # * INTERACTIVE: set to 1 to keep an interactive shell open after the script ran (for debugging) # * KEEP_VM: for development: don't kill/start VM if still running @@ -9,6 +10,7 @@ # * TESTS: which tests to run (all by default, see below for possible values) . "$(dirname "$0")/common.sh" +DOMAIN="${DOMAIN:-downloads.osmocom.org}" DISTRO="$1" DISTROS=" centos8 @@ -136,6 +138,7 @@ #!/bin/sh -ex export DISTRO="$DISTRO" + export DOMAIN="$DOMAIN" export FEED="$FEED" export PROJ="$PROJ" export PROJ_CONFLICT="$PROJ_CONFLICT" diff --git a/scripts/repo-install-test/run-inside.sh b/scripts/repo-install-test/run-inside.sh index d959cc0..6fcc391 100755 --- a/scripts/repo-install-test/run-inside.sh +++ b/scripts/repo-install-test/run-inside.sh @@ -108,7 +108,7 @@ # $1: OBS project (e.g. "osmocom:nightly") configure_osmocom_repo_debian() { local proj="$1" - local obs_repo="downloads.osmocom.org/packages/$(proj_with_slashes "$proj")/$DISTRO_OBSDIR/" + local obs_repo="$DOMAIN/packages/$(proj_with_slashes "$proj")/$DISTRO_OBSDIR/" echo "Configuring Osmocom repository" @@ -132,7 +132,7 @@ # $1: OBS project (e.g. "osmocom:nightly") configure_osmocom_repo_centos() { local proj="$1" - local baseurl="https://downloads.osmocom.org/packages/$(proj_with_slashes "$proj")/$DISTRO_OBSDIR" + local baseurl="https://$DOMAIN/packages/$(proj_with_slashes "$proj")/$DISTRO_OBSDIR" echo "Configuring Osmocom repository" # Generate this file, based on the feed: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31312 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I36bc0eae9fdee75512c1dbdca84cd6224b8c192a Gerrit-Change-Number: 31312 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-ci[master]: repo-install-test: disable osmo-upf service check

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/31309 ) Change subject: repo-install-test: disable osmo-upf service check ...................................................................... repo-install-test: disable osmo-upf service check Don't check the osmo-upf service until it's fixed, so we don't miss other errors that repo-install-test may find. Related: OS#5905 Change-Id: I970cad1bdb4586afa8ba5b4dac31bb9ac02b7b2d --- M scripts/repo-install-test/run-inside.sh 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/09/31309/1 diff --git a/scripts/repo-install-test/run-inside.sh b/scripts/repo-install-test/run-inside.sh index 251fa3d..b73b814 100755 --- a/scripts/repo-install-test/run-inside.sh +++ b/scripts/repo-install-test/run-inside.sh @@ -446,7 +446,9 @@ if [ "$DISTRO" != "debian10" ]; then # osmo-upf <= 0.1.1 needs GTP kernel module if [ "$FEED" = "nightly" ]; then - services_feed="$services_feed osmo-upf" + # osmo-upf nightly needs a newer kernel (OS#5905) + # services_feed="$services_feed osmo-upf" + true fi fi -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31309 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I970cad1bdb4586afa8ba5b4dac31bb9ac02b7b2d Gerrit-Change-Number: 31309 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-ci[master]: repo-install-test: update tests for e1d/ggsn/pfcp

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/31311 ) Change subject: repo-install-test: update tests for e1d/ggsn/pfcp ...................................................................... repo-install-test: update tests for e1d/ggsn/pfcp Disable workarounds for OS#5817, where packaging bugs have been fixed. Change-Id: I2452993abc1c0fe78bef464f1a62fe578b48016b --- M scripts/repo-install-test/run-inside.sh 1 file changed, 8 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/11/31311/1 diff --git a/scripts/repo-install-test/run-inside.sh b/scripts/repo-install-test/run-inside.sh index df9b3cf..d959cc0 100755 --- a/scripts/repo-install-test/run-inside.sh +++ b/scripts/repo-install-test/run-inside.sh @@ -11,8 +11,6 @@ # Systemd services that must start up successfully after installing all packages (OS#3369) # Disabled services: # * osmo-ctrl2cgi (missing config: /etc/osmocom/ctrl2cgi.ini, OS#4108) -# * osmo-e1d (missing config, OS#5817) -# * osmo-ggsn (conflicting config, OS#5817) # * osmo-remsim-client (exits immediately without USB device) # * osmo-trap2cgi (missing config: /etc/osmocom/%N.ini, OS#4108) # * osmo-trx-* (exits immediately without trx device) @@ -21,7 +19,9 @@ osmo-bsc osmo-bts-virtual osmo-cbc + osmo-e1d osmo-gbproxy + osmo-ggsn osmo-gtphub osmo-hlr osmo-hnbgw @@ -415,16 +415,17 @@ test_binaries_version \ osmo-trx-usrp1 ;; - centos8*) - # OS#5817: not packaged for debian - test_binaries_version \ - osmo-pfcp-tool - ;; esac if [ "$DISTRO" != "debian10" ]; then test_binaries_version \ osmo-upf + + # OS#5817: not packaged for debian, needs osmo-upf release + if [ "$FEED" = "nightly" ] || [ "$DISTRO" = "centos8" ]; then + test_binaries_version \ + osmo-pfcp-tool + fi fi if [ "$FEED" = "nightly" ]; then @@ -452,10 +453,6 @@ fi fi - # OS#5817: osmo-ggsn conflicts with osmo-gtphub; explicitly stop it - # here until it is fixed, as it gets auto-started after installation - systemctl stop osmo-ggsn - systemctl start $services_feed sleep 2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31311 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2452993abc1c0fe78bef464f1a62fe578b48016b Gerrit-Change-Number: 31311 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-ci[master]: repo-install-test: adjust to 2023-02 releases

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/31310 ) Change subject: repo-install-test: adjust to 2023-02 releases ...................................................................... repo-install-test: adjust to 2023-02 releases Change-Id: Ic1d912efbe504b6e35b59e31d12b983b9d924355 --- M scripts/repo-install-test/run-inside.sh 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/10/31310/1 diff --git a/scripts/repo-install-test/run-inside.sh b/scripts/repo-install-test/run-inside.sh index b73b814..df9b3cf 100755 --- a/scripts/repo-install-test/run-inside.sh +++ b/scripts/repo-install-test/run-inside.sh @@ -384,6 +384,7 @@ osmo-bts-trx \ osmo-bts-virtual \ osmo-cbc \ + osmo-e1d \ osmo-gbproxy \ osmo-ggsn \ osmo-gtphub \ @@ -406,7 +407,8 @@ osmo-smlc \ osmo-stp \ osmo-trx-ipc \ - osmo-trx-uhd + osmo-trx-uhd \ + osmo-uecups-daemon case "$DISTRO" in debian*) @@ -427,9 +429,7 @@ if [ "$FEED" = "nightly" ]; then test_binaries_version \ - osmo-bsc-nat \ - osmo-e1d \ - osmo-uecups-daemon + osmo-bsc-nat fi } -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31310 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic1d912efbe504b6e35b59e31d12b983b9d924355 Gerrit-Change-Number: 31310 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Introduce DL TBF creation through PCH ImmAss

by pespin

Attention is currently required from: neels, msuraev. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31286 to look at the new patch set (#7). Change subject: rlcmac: Introduce DL TBF creation through PCH ImmAss ...................................................................... rlcmac: Introduce DL TBF creation through PCH ImmAss This patch only introduces the gprs_rlcmac_dl_tbf subclass and allocates/frees it based on PCH ImmAss, and adds initial paths for received blocks. It also provides a unit test to showcase the scenario. Change-Id: I7f98e3456ef35d80becdad3481afeb771457b0ef --- M include/osmocom/gprs/rlcmac/Makefile.am M include/osmocom/gprs/rlcmac/coding_scheme.h M include/osmocom/gprs/rlcmac/gre.h M include/osmocom/gprs/rlcmac/rlcmac_private.h A include/osmocom/gprs/rlcmac/tbf_dl.h M src/rlcmac/Makefile.am M src/rlcmac/coding_scheme.c M src/rlcmac/gre.c M src/rlcmac/rlcmac.c M src/rlcmac/rlcmac_prim.c A src/rlcmac/tbf_dl.c M tests/rlcmac/Makefile.am M tests/rlcmac/rlcmac_prim_test.c M tests/rlcmac/rlcmac_prim_test.err M tests/rlcmac/rlcmac_prim_test.ok 15 files changed, 477 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/86/31286/7 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31286 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I7f98e3456ef35d80becdad3481afeb771457b0ef Gerrit-Change-Number: 31286 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Initial ul_tbf data support

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31170 ) Change subject: rlcmac: Initial ul_tbf data support ...................................................................... Patch Set 11: (1 comment) File src/rlcmac/rlc_window.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/31170/comment/3f24f96d_a8f00a50 PS10, Line 77: > linter is requiring them. Indeed. vim does not show a newline at the end of file, Gerrit does. There should be at least one empty line, otherwise git diff will look cumbersome. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I0a01d79d16bbfc63aa88e6bb0f432f3772645730 Gerrit-Change-Number: 31170 Gerrit-PatchSet: 11 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Feb 2023 11:46:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023