February 2023 - gerrit-log - lists.osmocom.org

Change in libosmo-abis[master]: Reworked mi_e1_line_update() and some of its sub routines

by jolly

Attention is currently required from: neels. Hello Jenkins Builder, neels, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/31296 to look at the new patch set (#3). Change subject: Reworked mi_e1_line_update() and some of its sub routines ...................................................................... Reworked mi_e1_line_update() and some of its sub routines Now it closes file descriptor and frees lapd resources, if time slot type changes or if it is released. Local states are reset. Change-Id: Iab0776fce6921661b39e9e53376cf01a80bcd42c --- M src/input/misdn.c 1 file changed, 60 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/96/31296/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31296 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iab0776fce6921661b39e9e53376cf01a80bcd42c Gerrit-Change-Number: 31296 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in libosmo-abis[master]: misdn driver: printf and fprintf are replaced by logging functions

by jolly

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/31319 to look at the new patch set (#2). Change subject: misdn driver: printf and fprintf are replaced by logging functions ...................................................................... misdn driver: printf and fprintf are replaced by logging functions Change-Id: I313c0bf2b8a93febed73b4ea447f6552216095b6 --- M src/input/misdn.c 1 file changed, 28 insertions(+), 37 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/19/31319/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I313c0bf2b8a93febed73b4ea447f6552216095b6 Gerrit-Change-Number: 31319 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in libosmo-abis[master]: Reworked mi_e1_line_update() and some of its sub routines

by jolly

Attention is currently required from: neels. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31296 ) Change subject: Reworked mi_e1_line_update() and some of its sub routines ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-abis/+/31296/comment/a26ad953_9608b118 PS1, Line 12: printf and fprintf are replaced by logging functions. > (would usually be nice to do those things in a separate patch so they don't mix with other changes) Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31296 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iab0776fce6921661b39e9e53376cf01a80bcd42c Gerrit-Change-Number: 31296 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Feb 2023 18:24:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-abis[master]: Add setting of Sa bits to misdn driver

by jolly

Attention is currently required from: neels, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31034 ) Change subject: Add setting of Sa bits to misdn driver ...................................................................... Patch Set 8: (1 comment) File src/input/misdn.c: https://gerrit.osmocom.org/c/libosmo-abis/+/31034/comment/f2300f72_b7dfda78 PS7, Line 314: (sa_bits >> 4) & 1, (sa_bits >> 5) & 1, sa_bits & 1, (sa_bits >> 6) & 1, sa_bits >> 7); > (just saying because it was discussed before: this indent is fine. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31034 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I54205a2534a7638cc071888d853f9d6d312dc9f0 Gerrit-Change-Number: 31034 Gerrit-PatchSet: 8 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Feb 2023 18:24:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-abis[master]: Reworked mi_e1_line_update() and some of its sub routines

by jolly

Attention is currently required from: jolly. Hello Jenkins Builder, neels, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/31296 to look at the new patch set (#2). Change subject: Reworked mi_e1_line_update() and some of its sub routines ...................................................................... Reworked mi_e1_line_update() and some of its sub routines Now it closes file descriptor and frees lapd resources, if time slot type changes or if it is released. Local states are reset. Change-Id: Iab0776fce6921661b39e9e53376cf01a80bcd42c --- M src/input/misdn.c 1 file changed, 62 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/96/31296/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31296 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iab0776fce6921661b39e9e53376cf01a80bcd42c Gerrit-Change-Number: 31296 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in libosmo-abis[master]: Add setting of Sa bits to misdn driver

by jolly

Attention is currently required from: jolly, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/31034 to look at the new patch set (#8). Change subject: Add setting of Sa bits to misdn driver ...................................................................... Add setting of Sa bits to misdn driver Change-Id: I54205a2534a7638cc071888d853f9d6d312dc9f0 --- M src/input/misdn.c 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/34/31034/8 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31034 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I54205a2534a7638cc071888d853f9d6d312dc9f0 Gerrit-Change-Number: 31034 Gerrit-PatchSet: 8 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in libosmo-abis[master]: misdn driver: printf and fprintf are replaced by logging functions

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31319 ) Change subject: misdn driver: printf and fprintf are replaced by logging functions ...................................................................... misdn driver: printf and fprintf are replaced by logging functions Change-Id: I313c0bf2b8a93febed73b4ea447f6552216095b6 --- M src/input/misdn.c 1 file changed, 28 insertions(+), 36 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/19/31319/1 diff --git a/src/input/misdn.c b/src/input/misdn.c index 9c3da98..a651db0 100644 --- a/src/input/misdn.c +++ b/src/input/misdn.c @@ -183,13 +183,13 @@ ret = recvfrom(bfd->fd, msg->data, 300, 0, (struct sockaddr *) &l2addr, &alen); if (ret < 0) { - fprintf(stderr, "recvfrom error %s\n", strerror(errno)); + LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "recvfrom error: %s\n", strerror(errno)); msgb_free(msg); return ret; } if (alen != sizeof(l2addr)) { - fprintf(stderr, "%s error len\n", __func__); + LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "error len\n"); msgb_free(msg); return -EINVAL; } @@ -379,7 +379,7 @@ ret = sendto(bfd->fd, msg->data, msg->len, 0, (struct sockaddr *)&sa, sizeof(sa)); if (ret < 0) - fprintf(stderr, "%s sendto failed %d\n", __func__, ret); + LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "sendto error: %s\n", strerror(errno)); msgb_free(msg); } @@ -460,7 +460,7 @@ ret = recv(bfd->fd, msg->data, TSX_ALLOC_SIZE, 0); if (ret < 0) { - fprintf(stderr, "recvfrom error %s\n", strerror(errno)); + LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "recv error: %s\n", strerror(errno)); return ret; } @@ -547,7 +547,7 @@ ret = recv(bfd->fd, msg->data, TSX_ALLOC_SIZE, 0); if (ret < 0) { - fprintf(stderr, "recvfrom error %s\n", strerror(errno)); + LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "recv error: %s\n", strerror(errno)); return ret; } @@ -635,7 +635,7 @@ ret = recv(bfd->fd, msg->data, TSX_ALLOC_SIZE, 0); if (ret < 0) { - fprintf(stderr, "recvfrom error %s\n", strerror(errno)); + LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "recv error: %s\n", strerror(errno)); return ret; } @@ -710,7 +710,7 @@ rc = handle_ts_hdlc_write(bfd); break; default: - fprintf(stderr, "unknown E1 TS type %u\n", e1i_ts->type); + LOGPITS(e1i_ts, DLMI, LOGL_DEBUG, "unknown E1 TS type %u\n", e1i_ts->type); break; } @@ -725,7 +725,6 @@ struct e1inp_ts *e1i_ts = &line->ts[idx]; struct osmo_fd *bfd = &e1i_ts->driver.misdn.fd; - fprintf(stdout, "activate bchan\n"); if (act) hh.prim = PH_ACTIVATE_REQ; else @@ -733,10 +732,8 @@ hh.id = MISDN_ID_ANY; ret = sendto(bfd->fd, &hh, sizeof(hh), 0, NULL, 0); - if (ret < 0) { - fprintf(stdout, "could not send ACTIVATE_RQ %s\n", - strerror(errno)); - } + if (ret < 0) + LOGPITS(e1i_ts, DLMI, LOGL_DEBUG, "could not send ACTIVATE_RQ %s\n", strerror(errno)); return ret; } @@ -775,7 +772,7 @@ mline->dummy_dchannel = socket(PF_ISDN, SOCK_DGRAM, ISDN_P_NT_E1); if (mline->dummy_dchannel < 0) { - fprintf(stderr, "%s could not open socket %s\n", + LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "%s could not open socket %s\n", __func__, strerror(errno)); return mline->dummy_dchannel; } @@ -788,8 +785,7 @@ ret = bind(mline->dummy_dchannel, (struct sockaddr *) &addr, sizeof(addr)); if (ret < 0) { - fprintf(stderr, "could not bind l2 socket %s\n", - strerror(errno)); + LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "could not bind l2 socket %s\n", strerror(errno)); return -EIO; } } @@ -833,8 +829,7 @@ } if (bfd->fd < 0) { - fprintf(stderr, "%s could not open socket %s\n", - __func__, strerror(errno)); + LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "could not open socket: %s\n", strerror(errno)); return bfd->fd; } @@ -871,7 +866,7 @@ ret = bind(bfd->fd, (struct sockaddr *) &addr, sizeof(addr)); if (ret < 0) { - fprintf(stderr, "could not bind l2 socket %s\n", + LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "could not bind l2 socket %s\n", strerror(errno)); return -EIO; } @@ -880,7 +875,8 @@ if (!mline->use_userspace_lapd) { ret = ioctl(bfd->fd, IMCLEAR_L2, &release_l2); if (ret < 0) { - fprintf(stderr, "could not send IOCTL IMCLEAN_L2 %s\n", strerror(errno)); + LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "could not send IOCTL IMCLEAN_L2 %s\n", + strerror(errno)); return -EIO; } } else @@ -898,8 +894,7 @@ ret = osmo_fd_register(bfd); if (ret < 0) { - fprintf(stderr, "could not register FD: %s\n", - strerror(-ret)); + LOGPITS(e1i_ts, DLINP, LOGL_ERROR, "could not register FD: %s\n", strerror(ret)); return ret; } } @@ -919,41 +914,38 @@ /* open the ISDN card device */ sk = socket(PF_ISDN, SOCK_RAW, ISDN_P_BASE); if (sk < 0) { - fprintf(stderr, "%s could not open socket %s\n", - __func__, strerror(errno)); + LOGPIL(line, DLMI, LOGL_ERROR, "error, could not open socket: %s\n", strerror(errno)); return sk; } ret = ioctl(sk, IMGETCOUNT, &cnt); if (ret) { - fprintf(stderr, "%s error getting interf count: %s\n", - __func__, strerror(errno)); + LOGPIL(line, DLMI, LOGL_ERROR, "error getting interface count: %s\n", strerror(errno)); close(sk); return -ENODEV; } - //LOGPIL(line, DLMI, LOGL_DEBUG, "%d device%s found\n", cnt, (cnt==1)?"":"s"); - printf("%d device%s found\n", cnt, (cnt==1)?"":"s"); + LOGPIL(line, DLMI, LOGL_INFO, "%d device%s found\n", cnt, (cnt == 1) ? "" : "s"); #if 1 memset(&devinfo, 0, sizeof(devinfo)); devinfo.id = line->port_nr; ret = ioctl(sk, IMGETDEVINFO, &devinfo); if (ret < 0) { - fprintf(stdout, "error getting info for device %d: %s\n", - line->port_nr, strerror(errno)); + LOGPIL(line, DLMI, LOGL_ERROR, "error getting info for device %d: %s\n", + line->port_nr, strerror(errno)); close(sk); return -ENODEV; } - fprintf(stdout, " id: %d\n", devinfo.id); - fprintf(stdout, " Dprotocols: %08x\n", devinfo.Dprotocols); - fprintf(stdout, " Bprotocols: %08x\n", devinfo.Bprotocols); - fprintf(stdout, " protocol: %d\n", devinfo.protocol); - fprintf(stdout, " nrbchan: %d\n", devinfo.nrbchan); - fprintf(stdout, " name: %s\n", devinfo.name); + LOGPIL(line, DLMI, LOGL_INFO, " id: %d\n", devinfo.id); + LOGPIL(line, DLMI, LOGL_INFO, " Dprotocols: %08x\n", devinfo.Dprotocols); + LOGPIL(line, DLMI, LOGL_INFO, " Bprotocols: %08x\n", devinfo.Bprotocols); + LOGPIL(line, DLMI, LOGL_INFO, " protocol: %d\n", devinfo.protocol); + LOGPIL(line, DLMI, LOGL_INFO, " nrbchan: %d\n", devinfo.nrbchan); + LOGPIL(line, DLMI, LOGL_INFO, " name: %s\n", devinfo.name); #endif close(sk); if (!(devinfo.Dprotocols & (1 << ISDN_P_NT_E1))) { - fprintf(stderr, "error: card is not of type E1 (NT-mode)\n"); + LOGPIL(line, DLMI, LOGL_ERROR, "error, card is not of type E1 (NT-mode)\n"); return -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I313c0bf2b8a93febed73b4ea447f6552216095b6 Gerrit-Change-Number: 31319 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC: increase BSSMAP RESET-ACK timeout

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29891 ) Change subject: BSC: increase BSSMAP RESET-ACK timeout ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I think it would be very interesting to understand how this phenomenon happens on your system. […] Thanks! So OsmoBSC didn't connect to OsmoSTP at the time when the testsuite was sending its BSSMAP RESET, and OsmoSTP said "MTP-TRANSFER.req for DPC 187: no route!". Follow-up patch: https://gerrit.osmocom.org/c/docker-playground/+/31318 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29891 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I76fa91280472b87235cf985af68bc2a6183d5e4a Gerrit-Change-Number: 29891 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 13 Feb 2023 17:25:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in docker-playground[master]: ttcn3-bsc-test: sleep 1s before starting testsuite

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31318 ) Change subject: ttcn3-bsc-test: sleep 1s before starting testsuite ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31318 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic7f80bdfe2fe58e93c2f2e3baa6d7645fcdc3062 Gerrit-Change-Number: 31318 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Feb 2023 17:24:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in docker-playground[master]: ttcn3-bsc-test: sleep 1s before starting testsuite

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/31318 ) Change subject: ttcn3-bsc-test: sleep 1s before starting testsuite ...................................................................... ttcn3-bsc-test: sleep 1s before starting testsuite Give OsmoBSC time to connect to OsmoSTP, so BSSMAP RESET from the testsuite doesn't fail in OsmoSTP with: MTP-TRANSFER.req for DPC 187: no route! Without this patch, it would fail every other time on my system when only having one test enabled in BSC_Tests.cfg. Change-Id: Ic7f80bdfe2fe58e93c2f2e3baa6d7645fcdc3062 --- M ttcn3-bsc-test/jenkins.sh 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/18/31318/1 diff --git a/ttcn3-bsc-test/jenkins.sh b/ttcn3-bsc-test/jenkins.sh index 26ecce9..0a3128c 100755 --- a/ttcn3-bsc-test/jenkins.sh +++ b/ttcn3-bsc-test/jenkins.sh @@ -65,6 +65,10 @@ >>/data/osmo-bts-omldummy-$1.log 2>&1" done +# Give OsmoBSC time to connect to OsmoSTP, so BSSMAP RESET from the testsuite +# doesn't fail in OsmoSTP with "MTP-TRANSFER.req for DPC 187: no route!" +sleep 1 + echo Starting container with BSC testsuite docker run --rm \ $(docker_network_params $SUBNET 203) \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31318 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic7f80bdfe2fe58e93c2f2e3baa6d7645fcdc3062 Gerrit-Change-Number: 31318 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023