February 2023 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: PCU_Tests: remove unnecessary valueof() in NACC TCs

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31300 ) Change subject: PCU_Tests: remove unnecessary valueof() in NACC TCs ...................................................................... PCU_Tests: remove unnecessary valueof() in NACC TCs A string literal is already a value, valueof() is for templates. Change-Id: I86970bb422ad1693829fd20ecf5ee34ef77f30af --- M pcu/PCU_Tests.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: neels: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 15ea195..833f317 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -5775,7 +5775,7 @@ f_sleep(0.2); /* let some time to avoid race conditons between CTRL and RLCMAC */ if (use_old_ctrl_iface) { - IPA_CTRL.send(ts_CtrlMsgGetRepl(rx_ctrl.cmd.id, valueof(ctrl_var), valueof("023-43-423-2-5"))); + IPA_CTRL.send(ts_CtrlMsgGetRepl(rx_ctrl.cmd.id, ctrl_var, "023-43-423-2-5")); } else { BTS.send(ts_PCUIF_NEIGH_ADDR_CNF(0, pcu_msg.u.container.u.neigh_addr_req, 0, 23, 43, 0, 423, 2, 5)); } @@ -6160,7 +6160,7 @@ f_ms_tx_ul_block(ms, ts_RLC_UL_CTRL_ACK(cell_chf_notif), 0, nr := f_ms_tx_TsTrxBtsNum(ms)); f_sleep(0.2); /* let some time to avoid race conditons between CTRL and RLCMAC */ if (use_old_ctrl_iface) { - IPA_CTRL.send(ts_CtrlMsgGetRepl(rx_ctrl.cmd.id, valueof(ctrl_var), valueof("023-43-423-2-5"))); + IPA_CTRL.send(ts_CtrlMsgGetRepl(rx_ctrl.cmd.id, ctrl_var, "023-43-423-2-5")); } else { BTS.send(ts_PCUIF_NEIGH_ADDR_CNF(0, pcu_msg.u.container.u.neigh_addr_req, 0, 23, 43, 0, 423, 2, 5)); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31300 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I86970bb422ad1693829fd20ecf5ee34ef77f30af Gerrit-Change-Number: 31300 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: PCU_Tests: fix TC_nacc_outbound_si_resolve_timeout

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31301 ) Change subject: PCU_Tests: fix TC_nacc_outbound_si_resolve_timeout ...................................................................... PCU_Tests: fix TC_nacc_outbound_si_resolve_timeout This patch fixes TC_nacc_outbound_si_resolve_timeout, which is still using old hard-coded MCC/MNC values. The altstep does the same, but relies on the updated values from ts_BssgpCellIdDstAddr_default. Change-Id: I9f6dbe97e9a494a4e8fdb441a70999d3040f6cfd Related: OS#5901 --- M pcu/PCU_Tests.ttcn 1 file changed, 1 insertion(+), 13 deletions(-) Approvals: neels: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 833f317..439ffea 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -5647,16 +5647,6 @@ var GsmArfcn req_arfcn := 862; var uint6_t req_bsic := 43; var boolean use_old_ctrl_iface := mp_ctrl_neigh_ip != ""; - var BssgpCellId src := valueof(ts_BssgpCellId(ts_RAI(ts_LAI(f_build_BcdMccMnc_int(info_ind.mcc, info_ind.mnc, info_ind.mnc_3_digits == 1), /* '262F42'H */ - info_ind.lac), - info_ind.rac), - info_ind.cell_id)); - var BssgpCellId dst := valueof(ts_BssgpCellId(ts_RAI(ts_LAI('023F43'H, /* Decided by test itself (emulating BSC) */ - 423), - 2), - 5)); - var template RIM_Routing_Address src_addr := t_RIM_Routing_Address_cid(src); - var template RIM_Routing_Address dst_addr := t_RIM_Routing_Address_cid(dst); if (use_old_ctrl_iface) { /* Initialize osmo-bsc emulation neighbor resolution CTRL port */ @@ -5692,9 +5682,7 @@ f_handle_nacc_rac_ci_query(info_ind, req_arfcn, req_bsic, true, use_old_ctrl_iface); /* RIM procedure: */ - RIM.receive(tr_RAN_INFORMATION_REQUEST(tr_RIM_Routing_Information(RIM_ADDR_GERAN_CELL_ID, dst_addr), - tr_RIM_Routing_Information(RIM_ADDR_GERAN_CELL_ID, src_addr), - tr_RAN_Information_Request_RIM_Container)); + as_outbound_nacc_rim_resolve(info_ind, do_answer := false); /* We never answer the RIM procude -> PCU timeouts and should send Pkt Cell Chg continue */ /* Wait until we receive something non-dummy */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9f6dbe97e9a494a4e8fdb441a70999d3040f6cfd Gerrit-Change-Number: 31301 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: PCU_Tests: fix TC_nacc_outbound_pkt_cell_chg_notif_dup

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31302 ) Change subject: PCU_Tests: fix TC_nacc_outbound_pkt_cell_chg_notif_dup ...................................................................... PCU_Tests: fix TC_nacc_outbound_pkt_cell_chg_notif_dup The TC_nacc_outbound_pkt_cell_chg_notif_dup is currently failing because in [1] we changed the default hard-coded MCC/MNC values in ts_BssgpCellIdDstAddr_default, however these it's still using hardcoded MCC=023/MNC=43. I overlooked this in [2]. Let's split up the f_handle_nacc_rac_ci_query() into four functions: * f_ctrl_rx_nacc_rac_ci_req() / f_ctrl_tx_nacc_rac_ci_rsp(), * f_pcuif_rx_nacc_rac_ci_req() / f_pcuif_tx_nacc_rac_ci_rsp(), and use them in TC_nacc_outbound_pkt_cell_chg_notif_dup. Also employ them in TC_nacc_outbound_pkt_cell_chg_notif_twice. Change-Id: I3e84f55eedd278fb239600d6a0465bd34fd8cd0b Related: [1] 03f74d413258a125d6e64a4241a82d8384693895 Fixes: [2] 7295661af52ab397acd7376023817b64e1db5a66 Related: OS#5901 --- M pcu/PCU_Tests.ttcn 1 file changed, 61 insertions(+), 44 deletions(-) Approvals: neels: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 439ffea..954216f 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -5189,38 +5189,67 @@ } } +private function f_ctrl_rx_nacc_rac_ci_req(out CtrlMessage ctrl_req, + PCUIF_info_ind info_ind, + GsmArfcn req_arfcn, + uint6_t req_bsic) +runs on RAW_PCU_Test_CT { + var charstring ctrl_var := "neighbor_resolve_cgi_ps_from_lac_ci." & + int2str(info_ind.lac) & "." & + int2str(info_ind.cell_id) & "." & + int2str(req_arfcn) & "." & + int2str(req_bsic); + f_ipa_ctrl_wait_link_up(); + IPA_CTRL.receive(tr_CtrlMsgGet(?, ctrl_var)) -> value ctrl_req; +} + +private function f_ctrl_tx_nacc_rac_ci_rsp(in CtrlMessage ctrl_req) +runs on RAW_PCU_Test_CT { + var BssgpCellId addr := valueof(ts_BssgpCellIdDstAddr_default); + IPA_CTRL.send(ts_CtrlMsgGetRepl(ctrl_req.cmd.id, + ctrl_req.cmd.variable, + hex2str(c_BssgpCellMcc) & "-" & + hex2str(c_BssgpCellMnc) & "-" & + int2str(addr.ra_id.lai.lac) & "-" & + int2str(addr.ra_id.rac) & "-" & + int2str(addr.cell_id))); +} + +private function f_pcuif_rx_nacc_rac_ci_req(out PCUIF_Message addr_req, + PCUIF_info_ind info_ind, + GsmArfcn req_arfcn, + uint6_t req_bsic) +runs on RAW_PCU_Test_CT { + BTS.receive(tr_PCUIF_NEIGH_ADDR_REQ(0, info_ind.lac, info_ind.cell_id, + req_arfcn, req_bsic)) -> value addr_req; +} + +private function f_pcuif_tx_nacc_rac_ci_rsp(in PCUIF_Message addr_req) +runs on RAW_PCU_Test_CT { + var BssgpCellId addr := valueof(ts_BssgpCellIdDstAddr_default); + BTS.send(ts_PCUIF_NEIGH_ADDR_CNF(0, addr_req.u.container.u.neigh_addr_req, 0, + str2int(hex2str(c_BssgpCellMcc)), + str2int(hex2str(c_BssgpCellMnc)), + lengthof(c_BssgpCellMnc) - 2, + addr.ra_id.lai.lac, + addr.ra_id.rac, + addr.cell_id)); +} + private function f_handle_nacc_rac_ci_query(PCUIF_info_ind info_ind, GsmArfcn req_arfcn, uint6_t req_bsic, boolean answer := true, boolean use_old_ctrl_iface := false) runs on RAW_PCU_Test_CT { if (use_old_ctrl_iface == true) { - f_ipa_ctrl_wait_link_up(); - var charstring ctrl_var := "neighbor_resolve_cgi_ps_from_lac_ci." & - int2str(info_ind.lac) & "." & - int2str(info_ind.cell_id) & "." & - int2str(req_arfcn) & "." & - int2str(req_bsic); + var CtrlMessage ctrl_req; + f_ctrl_rx_nacc_rac_ci_req(ctrl_req, info_ind, req_arfcn, req_bsic); if (answer) { - var BssgpCellId addr := valueof(ts_BssgpCellIdDstAddr_default); - f_ctrl_exp_get(IPA_CTRL, ctrl_var, hex2str(c_BssgpCellMcc) & "-" & - hex2str(c_BssgpCellMnc) & "-" & - int2str(addr.ra_id.lai.lac) & "-" & - int2str(addr.ra_id.rac) & "-" & - int2str(addr.cell_id)); - } else { - f_ctrl_exp_get(IPA_CTRL, ctrl_var, omit); + f_ctrl_tx_nacc_rac_ci_rsp(ctrl_req); } } else { - var PCUIF_Message pcu_msg; - BTS.receive(tr_PCUIF_NEIGH_ADDR_REQ(0, info_ind.lac, info_ind.cell_id, req_arfcn, req_bsic)) -> value pcu_msg; + var PCUIF_Message pcuif_req; + f_pcuif_rx_nacc_rac_ci_req(pcuif_req, info_ind, req_arfcn, req_bsic); if (answer) { - var BssgpCellId addr := valueof(ts_BssgpCellIdDstAddr_default); - BTS.send(ts_PCUIF_NEIGH_ADDR_CNF(0, pcu_msg.u.container.u.neigh_addr_req, 0, - str2int(hex2str(c_BssgpCellMcc)), - str2int(hex2str(c_BssgpCellMnc)), - lengthof(c_BssgpCellMnc) - 2, - addr.ra_id.lai.lac, - addr.ra_id.rac, - addr.cell_id)); + f_pcuif_tx_nacc_rac_ci_rsp(pcuif_req); } } } @@ -5747,15 +5776,9 @@ /* osmo-pcu should now ask for resolution: */ if (use_old_ctrl_iface) { - f_ipa_ctrl_wait_link_up(); - ctrl_var := "neighbor_resolve_cgi_ps_from_lac_ci." & - int2str(info_ind.lac) & "." & - int2str(info_ind.cell_id) & "." & - int2str(req_arfcn) & "." & - int2str(req_bsic); - IPA_CTRL.receive(tr_CtrlMsgGet(?, ctrl_var)) -> value rx_ctrl; + f_ctrl_rx_nacc_rac_ci_req(rx_ctrl, info_ind, req_arfcn, req_bsic); } else { - BTS.receive(tr_PCUIF_NEIGH_ADDR_REQ(0, info_ind.lac, info_ind.cell_id, req_arfcn, req_bsic)) -> value pcu_msg; + f_pcuif_rx_nacc_rac_ci_req(pcu_msg, info_ind, req_arfcn, req_bsic); } /* Before receiving CTRL response, MS retransmits Pkt cell Chg Notif */ @@ -5763,9 +5786,9 @@ f_sleep(0.2); /* let some time to avoid race conditons between CTRL and RLCMAC */ if (use_old_ctrl_iface) { - IPA_CTRL.send(ts_CtrlMsgGetRepl(rx_ctrl.cmd.id, ctrl_var, "023-43-423-2-5")); + f_ctrl_tx_nacc_rac_ci_rsp(rx_ctrl); } else { - BTS.send(ts_PCUIF_NEIGH_ADDR_CNF(0, pcu_msg.u.container.u.neigh_addr_req, 0, 23, 43, 0, 423, 2, 5)); + f_pcuif_tx_nacc_rac_ci_rsp(pcu_msg); } timer T := 2.0; @@ -6133,24 +6156,18 @@ /* osmo-pcu should now ask for resolution: */ if (use_old_ctrl_iface) { - f_ipa_ctrl_wait_link_up(); - ctrl_var := "neighbor_resolve_cgi_ps_from_lac_ci." & - int2str(info_ind.lac) & "." & - int2str(info_ind.cell_id) & "." & - int2str(req_arfcn) & "." & - int2str(req_bsic); - IPA_CTRL.receive(tr_CtrlMsgGet(?, ctrl_var)) -> value rx_ctrl; + f_ctrl_rx_nacc_rac_ci_req(rx_ctrl, info_ind, req_arfcn, req_bsic); } else { - BTS.receive(tr_PCUIF_NEIGH_ADDR_REQ(0, info_ind.lac, info_ind.cell_id, req_arfcn, req_bsic)) -> value pcu_msg; + f_pcuif_rx_nacc_rac_ci_req(pcu_msg, info_ind, req_arfcn, req_bsic); } /* Before receiving CTRL response, MS retransmits Pkt cell Chg Notif with different tgt arfcn */ cell_chf_notif := ts_RlcMacUlCtrl_PKT_CELL_CHG_NOTIF(ms.ul_tbf.tfi, req_arfcn + 1, req_bsic + 1); f_ms_tx_ul_block(ms, ts_RLC_UL_CTRL_ACK(cell_chf_notif), 0, nr := f_ms_tx_TsTrxBtsNum(ms)); f_sleep(0.2); /* let some time to avoid race conditons between CTRL and RLCMAC */ if (use_old_ctrl_iface) { - IPA_CTRL.send(ts_CtrlMsgGetRepl(rx_ctrl.cmd.id, ctrl_var, "023-43-423-2-5")); + f_ctrl_tx_nacc_rac_ci_rsp(rx_ctrl); } else { - BTS.send(ts_PCUIF_NEIGH_ADDR_CNF(0, pcu_msg.u.container.u.neigh_addr_req, 0, 23, 43, 0, 423, 2, 5)); + f_pcuif_tx_nacc_rac_ci_rsp(pcu_msg); } /* We should now receive a 2nd CTRL request with the new ARFCN+BSIC */ f_handle_nacc_rac_ci_query(info_ind, req_arfcn + 1, req_bsic + 1, true, use_old_ctrl_iface); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3e84f55eedd278fb239600d6a0465bd34fd8cd0b Gerrit-Change-Number: 31302 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: abis_rsl: add support for sending IMMEDIATE ASSIGNMENT through PCH

by dexter

Attention is currently required from: neels, pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31126 ) Change subject: abis_rsl: add support for sending IMMEDIATE ASSIGNMENT through PCH ...................................................................... Patch Set 12: (1 comment) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31126/comment/18b9529f_4c8ea802 PS11, Line 412: * the IMSI, which we need to compute the paging group */ > (you often use a very short line width in comments ... […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31126 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4452f4973d1ec69c96aad527b057226e8a6edf99 Gerrit-Change-Number: 31126 Gerrit-PatchSet: 12 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Feb 2023 11:42:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: abis_rsl: add support for sending IMMEDIATE ASSIGNMENT through PCH

by dexter

Attention is currently required from: neels, pespin, fixeria. Hello Jenkins Builder, neels, laforge, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31126 to look at the new patch set (#12). Change subject: abis_rsl: add support for sending IMMEDIATE ASSIGNMENT through PCH ...................................................................... abis_rsl: add support for sending IMMEDIATE ASSIGNMENT through PCH The IMMEDIATE ASSIGNMENT for downlink TBFs needs to be sent through the PCH instead of the AGCH. Since this method is not specified in RSL, it is usually a vendor specific extension. Change-Id: I4452f4973d1ec69c96aad527b057226e8a6edf99 Related: OS#5198 --- M include/osmocom/bsc/abis_rsl.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/pcu_sock.c 3 files changed, 50 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/26/31126/12 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31126 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4452f4973d1ec69c96aad527b057226e8a6edf99 Gerrit-Change-Number: 31126 Gerrit-PatchSet: 12 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: pcuif_proto: rename PCU_IF_SAPI_AGCH_DT to PCU_IF_SAPI_PCH_DT

by dexter

Attention is currently required from: neels. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31157 ) Change subject: pcuif_proto: rename PCU_IF_SAPI_AGCH_DT to PCU_IF_SAPI_PCH_DT ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > not sure what pespin was referring to; looks good to me The same change also exists in osmo-pcu, its already merged. See: I6dfb8035134bc85a025415bd6c2f9c01987d9268 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31157 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I78abeb62d0267baa31a4727c4bdd027b7230f137 Gerrit-Change-Number: 31157 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Feb 2023 11:34:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-mgw[master]: mgcp_e1: fix log output

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31308 ) Change subject: mgcp_e1: fix log output ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31308 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic72cf90ebdba1b5e395089417c6df5b962f8ffc8 Gerrit-Change-Number: 31308 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Feb 2023 11:24:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-mgw[master]: mgcp_e1: be more frugal withe E1 line resources

by dexter

Attention is currently required from: osmith, laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/31269 to look at the new patch set (#2). Change subject: mgcp_e1: be more frugal withe E1 line resources ...................................................................... mgcp_e1: be more frugal withe E1 line resources At the moment we open an E1 timeslot when needed, but we never close it even when it is not needed anymore. This may block other entities from using it. Lets add some logic to detect whether the E1 timeslot is still needed and make sure that it is closed when it is no longer needed. Change-Id: Ie6a32abbc5cd984f6d72a384e3b47c1b82ce7058 Related: OS#5198 --- M include/osmocom/mgcp/mgcp_e1.h M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/mgcp_e1.c M src/libosmo-mgcp/mgcp_endp.c 4 files changed, 78 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/69/31269/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31269 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie6a32abbc5cd984f6d72a384e3b47c1b82ce7058 Gerrit-Change-Number: 31269 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in osmo-mgw[master]: mgcp_e1: be more frugal withe E1 line resources

by dexter

Attention is currently required from: osmith, laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31269 ) Change subject: mgcp_e1: be more frugal withe E1 line resources ...................................................................... Patch Set 2: (5 comments) File src/libosmo-mgcp/mgcp_e1.c: https://gerrit.osmocom.org/c/osmo-mgw/+/31269/comment/74cc9acb_dc49f4c9 PS1, Line 370: subslot > subslots Done https://gerrit.osmocom.org/c/osmo-mgw/+/31269/comment/59f0c2a9_8fd8fe72 PS1, Line 371: belos > below Done https://gerrit.osmocom.org/c/osmo-mgw/+/31269/comment/8d32f421_eeed9fe0 PS1, Line 432: LOGL_INFO > * if this shouldn't happen, maybe LOGL_ERROR? […] Done https://gerrit.osmocom.org/c/osmo-mgw/+/31269/comment/bdd285db_93824ecd PS1, Line 445: e > it might be cleaner to introduce a e1inp_ts_config_none() api similar to the e1inp_ts_config_{hdlc,i […] Ack https://gerrit.osmocom.org/c/osmo-mgw/+/31269/comment/1ac9ee85_a3d3d68d PS1, Line 657: urad against multiple calls. In case we do > Guard, don't? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31269 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie6a32abbc5cd984f6d72a384e3b47c1b82ce7058 Gerrit-Change-Number: 31269 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 13 Feb 2023 11:22:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-mgw[master]: mgcp_e1: fix log output

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31308 ) Change subject: mgcp_e1: fix log output ...................................................................... mgcp_e1: fix log output Its not the E1 timeslot that is updated, its the E1 line instead (which includes the timeslot) Change-Id: Ic72cf90ebdba1b5e395089417c6df5b962f8ffc8 --- M src/libosmo-mgcp/mgcp_e1.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/08/31308/1 diff --git a/src/libosmo-mgcp/mgcp_e1.c b/src/libosmo-mgcp/mgcp_e1.c index 7f30c1d..24f297f 100644 --- a/src/libosmo-mgcp/mgcp_e1.c +++ b/src/libosmo-mgcp/mgcp_e1.c @@ -401,7 +401,7 @@ } rc = e1inp_line_update(e1_line); if (rc < 0) { - LOGPTRUNK(trunk, DE1, LOGL_ERROR, "failed to update E1 timeslot %u.\n", ts_nr); + LOGPTRUNK(trunk, DE1, LOGL_ERROR, "failed to update E1 line %u.\n", ts_nr); return -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31308 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic72cf90ebdba1b5e395089417c6df5b962f8ffc8 Gerrit-Change-Number: 31308 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023