January 2023 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: contrib/jenkins.sh: make use of $PARALLEL_MAKE

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30819 ) Change subject: contrib/jenkins.sh: make use of $PARALLEL_MAKE ...................................................................... contrib/jenkins.sh: make use of $PARALLEL_MAKE Change-Id: I371a8dca6d992622d005d8c9d84eaaad6f3c7372 --- M contrib/jenkins.sh 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/19/30819/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 4374229..3a05480 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -40,7 +40,7 @@ cd $base/src/host/$dir autoreconf -fi ./configure - make distcheck + $MAKE $PARALLEL_MAKE distcheck done # TODO: make sure 'distcheck' passes also for these @@ -48,7 +48,7 @@ cd $base/src/host/$dir autoreconf -fi ./configure - make + $MAKE $PARALLEL_MAKE done # Build and publish manuals -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30819 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I371a8dca6d992622d005d8c9d84eaaad6f3c7372 Gerrit-Change-Number: 30819 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: contrib/jenkins.sh: build some sub-projects with --enable-werror

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30820 ) Change subject: contrib/jenkins.sh: build some sub-projects with --enable-werror ...................................................................... contrib/jenkins.sh: build some sub-projects with --enable-werror Change-Id: I8976ba3c52a3b4a47c98b9e6e85c7b9dcef4575a --- M contrib/jenkins.sh 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/20/30820/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 3a05480..eee1021 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -39,8 +39,9 @@ for dir in gprsdecode layer23 trxcon virt_phy; do cd $base/src/host/$dir autoreconf -fi - ./configure - $MAKE $PARALLEL_MAKE distcheck + ./configure --enable-werror + $MAKE $PARALLEL_MAKE + DISTCHECK_CONFIGURE_FLAGS="--enable-werror" $MAKE $PARALLEL_MAKE distcheck done # TODO: make sure 'distcheck' passes also for these -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30820 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8976ba3c52a3b4a47c98b9e6e85c7b9dcef4575a Gerrit-Change-Number: 30820 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in libosmo-pfcp[master]: silence compiler warning in gtlv_dec_enc.c

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30815 ) Change subject: silence compiler warning in gtlv_dec_enc.c ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30815 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I8f4c420f2182c607abb1ee5d1c8175eaeda904af Gerrit-Change-Number: 30815 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 13:26:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23/sysinfo: update coding style, make pointers const

by fixeria

Attention is currently required from: pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30810 to look at the new patch set (#2). Change subject: layer23/sysinfo: update coding style, make pointers const ...................................................................... layer23/sysinfo: update coding style, make pointers const Change-Id: Ia518251eae1b45ad573d076d97cba83ed25ea9ea Depends: libosmocore.git Ide9110b984d3302aec6b439c563eb10e2dcdec9e --- M src/host/layer23/include/osmocom/bb/common/sysinfo.h M src/host/layer23/src/common/sysinfo.c 2 files changed, 106 insertions(+), 105 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/10/30810/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30810 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia518251eae1b45ad573d076d97cba83ed25ea9ea Gerrit-Change-Number: 30810 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23/sysinfo: update coding style, make pointers const

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30810 ) Change subject: layer23/sysinfo: update coding style, make pointers const ...................................................................... Patch Set 1: (1 comment) File src/host/layer23/src/common/sysinfo.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30810/comment/6ad35ba6_c8dbea02 PS1, Line 864: > you could fix this one too :) Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30810 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia518251eae1b45ad573d076d97cba83ed25ea9ea Gerrit-Change-Number: 30810 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 13:24:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23/sysinfo: use OSMO_MIN from libosmocore

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30809 ) Change subject: layer23/sysinfo: use OSMO_MIN from libosmocore ...................................................................... layer23/sysinfo: use OSMO_MIN from libosmocore Change-Id: Ic01cadda13a7d7a3d34ddb94bd3964044f38959c --- M src/host/layer23/src/common/sysinfo.c 1 file changed, 11 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/host/layer23/src/common/sysinfo.c b/src/host/layer23/src/common/sysinfo.c index 8103647..7105e09 100644 --- a/src/host/layer23/src/common/sysinfo.c +++ b/src/host/layer23/src/common/sysinfo.c @@ -20,6 +20,7 @@ #include <string.h> #include <arpa/inet.h> +#include <osmocom/core/utils.h> #include <osmocom/core/bitvec.h> #include <osmocom/bb/common/osmocom_data.h> @@ -27,8 +28,6 @@ #include <osmocom/bb/common/logging.h> #include <osmocom/bb/common/sysinfo.h> -#define MIN(a, b) ((a < b) ? a : b) - /* * dumping */ @@ -594,7 +593,7 @@ { int payload_len = len - sizeof(*si); - memcpy(s->si1_msg, si, MIN(len, sizeof(s->si1_msg))); + memcpy(s->si1_msg, si, OSMO_MIN(len, sizeof(s->si1_msg))); /* Cell Channel Description */ decode_freq_list(s->freq, si->cell_channel_description, @@ -621,7 +620,7 @@ int gsm48_decode_sysinfo2(struct gsm48_sysinfo *s, struct gsm48_system_information_type_2 *si, int len) { - memcpy(s->si2_msg, si, MIN(len, sizeof(s->si2_msg))); + memcpy(s->si2_msg, si, OSMO_MIN(len, sizeof(s->si2_msg))); /* Neighbor Cell Description */ s->nb_ext_ind_si2 = (si->bcch_frequency_list[0] >> 6) & 1; @@ -641,7 +640,7 @@ int gsm48_decode_sysinfo2bis(struct gsm48_sysinfo *s, struct gsm48_system_information_type_2bis *si, int len) { - memcpy(s->si2b_msg, si, MIN(len, sizeof(s->si2b_msg))); + memcpy(s->si2b_msg, si, OSMO_MIN(len, sizeof(s->si2b_msg))); /* Neighbor Cell Description */ s->nb_ext_ind_si2bis = (si->bcch_frequency_list[0] >> 6) & 1; @@ -659,7 +658,7 @@ int gsm48_decode_sysinfo2ter(struct gsm48_sysinfo *s, struct gsm48_system_information_type_2ter *si, int len) { - memcpy(s->si2t_msg, si, MIN(len, sizeof(s->si2t_msg))); + memcpy(s->si2t_msg, si, OSMO_MIN(len, sizeof(s->si2t_msg))); /* Neighbor Cell Description 2 */ s->nb_multi_rep_si2ter = (si->ext_bcch_frequency_list[0] >> 6) & 3; @@ -678,7 +677,7 @@ { int payload_len = len - sizeof(*si); - memcpy(s->si3_msg, si, MIN(len, sizeof(s->si3_msg))); + memcpy(s->si3_msg, si, OSMO_MIN(len, sizeof(s->si3_msg))); /* Cell Identity */ s->cell_id = ntohs(si->cell_identity); @@ -713,7 +712,7 @@ uint8_t *data = si->data; struct gsm48_chan_desc *cd; - memcpy(s->si4_msg, si, MIN(len, sizeof(s->si4_msg))); + memcpy(s->si4_msg, si, OSMO_MIN(len, sizeof(s->si4_msg))); /* LAI */ gsm48_decode_lai_hex(&si->lai, &s->mcc, &s->mnc, &s->lac); @@ -768,7 +767,7 @@ int gsm48_decode_sysinfo5(struct gsm48_sysinfo *s, struct gsm48_system_information_type_5 *si, int len) { - memcpy(s->si5_msg, si, MIN(len, sizeof(s->si5_msg))); + memcpy(s->si5_msg, si, OSMO_MIN(len, sizeof(s->si5_msg))); /* Neighbor Cell Description */ s->nb_ext_ind_si5 = (si->bcch_frequency_list[0] >> 6) & 1; @@ -784,7 +783,7 @@ int gsm48_decode_sysinfo5bis(struct gsm48_sysinfo *s, struct gsm48_system_information_type_5bis *si, int len) { - memcpy(s->si5b_msg, si, MIN(len, sizeof(s->si5b_msg))); + memcpy(s->si5b_msg, si, OSMO_MIN(len, sizeof(s->si5b_msg))); /* Neighbor Cell Description */ s->nb_ext_ind_si5bis = (si->bcch_frequency_list[0] >> 6) & 1; @@ -800,7 +799,7 @@ int gsm48_decode_sysinfo5ter(struct gsm48_sysinfo *s, struct gsm48_system_information_type_5ter *si, int len) { - memcpy(s->si5t_msg, si, MIN(len, sizeof(s->si5t_msg))); + memcpy(s->si5t_msg, si, OSMO_MIN(len, sizeof(s->si5t_msg))); /* Neighbor Cell Description */ s->nb_multi_rep_si5ter = (si->bcch_frequency_list[0] >> 6) & 3; @@ -818,7 +817,7 @@ { int payload_len = len - sizeof(*si); - memcpy(s->si6_msg, si, MIN(len, sizeof(s->si6_msg))); + memcpy(s->si6_msg, si, OSMO_MIN(len, sizeof(s->si6_msg))); /* Cell Identity */ if (s->si6 && s->cell_id != ntohs(si->cell_identity)) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30809 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic01cadda13a7d7a3d34ddb94bd3964044f38959c Gerrit-Change-Number: 30809 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: use osmo_stderr_target in misc apps

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30805 ) Change subject: layer23: use osmo_stderr_target in misc apps ...................................................................... layer23: use osmo_stderr_target in misc apps Change-Id: I56770f04fa3c440e6ccabe6f6fccfe171d41d751 --- M src/host/layer23/src/common/main.c M src/host/layer23/src/misc/app_cell_log.c 2 files changed, 8 insertions(+), 11 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/host/layer23/src/common/main.c b/src/host/layer23/src/common/main.c index f3d1ad1..709eead 100644 --- a/src/host/layer23/src/common/main.c +++ b/src/host/layer23/src/common/main.c @@ -29,6 +29,7 @@ #include <osmocom/core/talloc.h> #include <osmocom/core/select.h> #include <osmocom/core/linuxlist.h> +#include <osmocom/core/application.h> #include <osmocom/core/gsmtap_util.h> #include <osmocom/core/gsmtap.h> #include <osmocom/core/utils.h> @@ -43,8 +44,6 @@ #include <fcntl.h> #include <signal.h> -struct log_target *stderr_target; - void *l23_ctx = NULL; static char *layer2_socket_path = "/tmp/osmocom_l2"; @@ -184,7 +183,7 @@ vty_port = atoi(optarg); break; case 'd': - log_parse_category_mask(stderr_target, optarg); + log_parse_category_mask(osmo_stderr_target, optarg); break; default: if (app && app->cfg_handle_opt) @@ -226,13 +225,11 @@ int rc; INIT_LLIST_HEAD(&ms_list); - log_init(&log_info, NULL); - stderr_target = log_target_create_stderr(); - log_add_target(stderr_target); - log_set_all_filter(stderr_target, 1); l23_ctx = talloc_named_const(NULL, 1, "layer2 context"); + osmo_init_logging2(l23_ctx, &log_info); + ms = talloc_zero(l23_ctx, struct osmocom_ms); if (!ms) { fprintf(stderr, "Failed to allocate MS\n"); diff --git a/src/host/layer23/src/misc/app_cell_log.c b/src/host/layer23/src/misc/app_cell_log.c index 069e7d1..abc472d 100644 --- a/src/host/layer23/src/misc/app_cell_log.c +++ b/src/host/layer23/src/misc/app_cell_log.c @@ -28,12 +28,12 @@ #include <osmocom/bb/common/gps.h> #include <osmocom/bb/misc/cell_log.h> +#include <osmocom/core/application.h> #include <osmocom/core/talloc.h> #include <osmocom/core/utils.h> #include <l1ctl_proto.h> -extern struct log_target *stderr_target; extern void *l23_ctx; extern uint16_t basic_band_range[][2]; @@ -66,9 +66,9 @@ srand(time(NULL)); -// log_parse_category_mask(stderr_target, "DL1C:DRSL:DRR:DGPS:DSUM"); - log_parse_category_mask(stderr_target, "DSUM"); - log_set_log_level(stderr_target, LOGL_INFO); +// log_parse_category_mask(osmo_stderr_target, "DL1C:DRSL:DRR:DGPS:DSUM"); + log_parse_category_mask(osmo_stderr_target, "DSUM"); + log_set_log_level(osmo_stderr_target, LOGL_INFO); l23_app_work = _scan_work; l23_app_exit = _scan_exit; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30805 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I56770f04fa3c440e6ccabe6f6fccfe171d41d751 Gerrit-Change-Number: 30805 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: configure pretty logging for misc apps

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30806 ) Change subject: layer23: configure pretty logging for misc apps ...................................................................... layer23: configure pretty logging for misc apps Change-Id: I827055bcf04f8003fcb90e6c8c90813ecda2efed --- M src/host/layer23/src/common/main.c 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/host/layer23/src/common/main.c b/src/host/layer23/src/common/main.c index 709eead..f714010 100644 --- a/src/host/layer23/src/common/main.c +++ b/src/host/layer23/src/common/main.c @@ -230,6 +230,13 @@ osmo_init_logging2(l23_ctx, &log_info); + log_set_print_category_hex(osmo_stderr_target, 0); + log_set_print_category(osmo_stderr_target, 1); + log_set_print_level(osmo_stderr_target, 1); + + log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_BASENAME); + log_set_print_filename_pos(osmo_stderr_target, LOG_FILENAME_POS_HEADER_END); + ms = talloc_zero(l23_ctx, struct osmocom_ms); if (!ms) { fprintf(stderr, "Failed to allocate MS\n"); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30806 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I827055bcf04f8003fcb90e6c8c90813ecda2efed Gerrit-Change-Number: 30806 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: modem: Makefile.am: remove unneeded CFLAGS and LIBS

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30807 ) Change subject: modem: Makefile.am: remove unneeded CFLAGS and LIBS ...................................................................... modem: Makefile.am: remove unneeded CFLAGS and LIBS Change-Id: I2bb04f526c4e3019c548786f2cdfb96b018826ec --- M src/host/layer23/src/modem/Makefile.am 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/host/layer23/src/modem/Makefile.am b/src/host/layer23/src/modem/Makefile.am index 2449d5c..a29cc62 100644 --- a/src/host/layer23/src/modem/Makefile.am +++ b/src/host/layer23/src/modem/Makefile.am @@ -8,9 +8,6 @@ $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOVTY_CFLAGS) \ $(LIBOSMOGSM_CFLAGS) \ - $(LIBOSMOCODEC_CFLAGS) \ - $(LIBGPS_CFLAGS) \ - $(LIBLUA_CFLAGS) \ $(NULL) bin_PROGRAMS = modem @@ -21,7 +18,4 @@ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOVTY_LIBS) \ $(LIBOSMOGSM_LIBS) \ - $(LIBOSMOCODEC_LIBS) \ - $(LIBGPS_LIBS) \ - $(LIBLUA_LIBS) \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30807 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2bb04f526c4e3019c548786f2cdfb96b018826ec Gerrit-Change-Number: 30807 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in libosmo-pfcp[master]: silence compiler warning in gtlv_dec_enc.c

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30815 ) Change subject: silence compiler warning in gtlv_dec_enc.c ...................................................................... silence compiler warning in gtlv_dec_enc.c This was reported with gcc version 12.2.0: /git/libosmo-pfcp/src/libosmo-gtlv/gtlv_dec_enc.c: In function 'osmo_gtlvs_decode_unordered': /git/libosmo-pfcp/src/libosmo-gtlv/gtlv_dec_enc.c:237:42: warning: 'presence_flag_p' may be used uninitialized [-Wmaybe-uninitialized] 237 | *presence_flag_p = true; | ^ /git/libosmo-pfcp/src/libosmo-gtlv/gtlv_dec_enc.c:113:23: note: 'presence_flag_p' was declared here 113 | bool *presence_flag_p; | ^~~~~~~~~~~~~~~ There is no actual code path that will use presence_flag_p uninitialized, but it doesn't hurt to init with NULL. Change-Id: I8f4c420f2182c607abb1ee5d1c8175eaeda904af --- M src/libosmo-gtlv/gtlv_dec_enc.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/15/30815/1 diff --git a/src/libosmo-gtlv/gtlv_dec_enc.c b/src/libosmo-gtlv/gtlv_dec_enc.c index 37e8a51..bbd9db7 100644 --- a/src/libosmo-gtlv/gtlv_dec_enc.c +++ b/src/libosmo-gtlv/gtlv_dec_enc.c @@ -110,7 +110,7 @@ * any). */ for (;;) { int rc; - bool *presence_flag_p; + bool *presence_flag_p = NULL; unsigned int memb_next_array_idx; unsigned int memb_ofs; unsigned int ie_max_allowed_count; -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30815 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I8f4c420f2182c607abb1ee5d1c8175eaeda904af Gerrit-Change-Number: 30815 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023