January 2023 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: layer23/sysinfo: update coding style, make pointers const

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30810 ) Change subject: layer23/sysinfo: update coding style, make pointers const ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30810 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia518251eae1b45ad573d076d97cba83ed25ea9ea Gerrit-Change-Number: 30810 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 16:26:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: bsc: Fix crash if PagingResponse with invalid MobileIdentity is received

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30821 ) Change subject: bsc: Fix crash if PagingResponse with invalid MobileIdentity is received ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bsc/gsm_08_08.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30821/comment/e891dee1_2c9f950b PS1, Line 443: if (conn->bsub) in general osmo-bsc code assumes that the subscriber is non-NULL, we can work around like this, but that probably needs similar checks in many other places to work out as intended. my first impression is that we should ensure that conn->bsub is always valid (error out in 392 above). or maybe making osmo-bsc safe to work without a subscriber is a more stable solution / better fits that a BSC "should" normally not parse DTAP at all? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30821 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If8b439ff74c5dd690d637d3e3278c75d6cd6b928 Gerrit-Change-Number: 30821 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 16:25:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-pfcp[master]: silence compiler warning in gtlv_dec_enc.c

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30815 ) Change subject: silence compiler warning in gtlv_dec_enc.c ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30815 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I8f4c420f2182c607abb1ee5d1c8175eaeda904af Gerrit-Change-Number: 30815 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 16:25:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: bsc: Fix crash if PagingResponse with invalid MobileIdentity is received

by laforge

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30821 ) Change subject: bsc: Fix crash if PagingResponse with invalid MobileIdentity is received ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30821 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If8b439ff74c5dd690d637d3e3278c75d6cd6b928 Gerrit-Change-Number: 30821 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 16:25:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-gprs[master]: tests/llc: Test gprs_llc_is_retransmit()

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30813 ) Change subject: tests/llc: Test gprs_llc_is_retransmit() ...................................................................... Patch Set 2: (2 comments) File tests/llc/llc_test.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/30813/comment/ef91bc3d_965dccd4 PS2, Line 1: codec not true? https://gerrit.osmocom.org/c/libosmo-gprs/+/30813/comment/9168a7cb_6bcf1599 PS2, Line 3: 2022 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> `git blame tests/gprs/gprs_test.c` gives me faf1f64a2: commit faf1f64a2d0a54d37616a8bec8691346ab792cde Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Thu Jun 23 17:53:27 2011 -0400 gprs: Honor GSM 04.64 8.4.2 Receipt of unacknowledged information -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30813 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I4104ee9cc458b7d169ee9761e02369442058675a Gerrit-Change-Number: 30813 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 16:19:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: layer23/sysinfo: implement decoding of SI13 Rest Octets

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30812 ) Change subject: layer23/sysinfo: implement decoding of SI13 Rest Octets ...................................................................... Patch Set 3: (2 comments) File src/host/layer23/include/osmocom/bb/common/sysinfo.h: https://gerrit.osmocom.org/c/osmocom-bb/+/30812/comment/f3f63051_9711ff7e PS2, Line 74: uint8_t supported; > this is really a bool right? Yes, but <stdbool.h> in not used this file. The existing fields are using uint8_t for boolean logic. So I'd better stay consistent. This is not critical, right? File src/host/layer23/src/common/sysinfo.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30812/comment/5a382f01_dfacf9cf PS2, Line 893: s->gprs.ctrl_ack_type = !gco->CONTROL_ACK_TYPE; /* inversed */ > why are you inverting this here? Because I don't want to deal with the inverted logic in code using this field. But looking at it again, I think I should rename it to 'ctrl_ack_type_use_block' like in osmo-bsc.git. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30812 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia6ff7d4e37816c6321b54c1f7f8d7110e557f8c5 Gerrit-Change-Number: 30812 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 16:13:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: bsc: Fix crash if PagingResponse with invalid MobileIdentity is received

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30821 ) Change subject: bsc: Fix crash if PagingResponse with invalid MobileIdentity is received ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30821 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If8b439ff74c5dd690d637d3e3278c75d6cd6b928 Gerrit-Change-Number: 30821 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 16:05:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: bsc: Fix crash if PagingResponse with invalid MobileIdentity is received

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30821 ) Change subject: bsc: Fix crash if PagingResponse with invalid MobileIdentity is received ...................................................................... bsc: Fix crash if PagingResponse with invalid MobileIdentity is received It was found in a BSC on the field that an MS sending an incorrect MobileIdentity IE (wrong length) in PagingResponse was generating a crash on the BSC. When the MobileIdentity cannot be parsed right now we keep on instead of rejecting the conn. This should change in the future, but it needs further improvements in our TTCN3 tests. For now let's simply validate the subscriber is not NULL; since recently paging optimizations made paging_request_stop() require the subscriber to be non-null. Fixes: 27cb5d3e24d0e39d09bddcbea5c059dfe5bbcf3d Related: SYS#6280 Change-Id: If8b439ff74c5dd690d637d3e3278c75d6cd6b928 --- M src/osmo-bsc/gsm_08_08.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/21/30821/1 diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c index 37e00f3..3e0683c 100644 --- a/src/osmo-bsc/gsm_08_08.c +++ b/src/osmo-bsc/gsm_08_08.c @@ -440,7 +440,8 @@ paged_from_msc = NULL; paging_reasons = BSC_PAGING_NONE; if (pdisc == GSM48_PDISC_RR && mtype == GSM48_MT_RR_PAG_RESP) { - paging_request_stop(&paged_from_msc, &paging_reasons, bts, conn->bsub); + if (conn->bsub) + paging_request_stop(&paged_from_msc, &paging_reasons, bts, conn->bsub); if (!paged_from_msc) { /* This looks like an unsolicited Paging Response. It is required to pick any MSC, because any * MT-CSFB calls were Paged by the MSC via SGs, and hence are not listed in the BSC. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30821 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If8b439ff74c5dd690d637d3e3278c75d6cd6b928 Gerrit-Change-Number: 30821 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: contrib/jenkins.sh: build some sub-projects with --enable-werror

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30820 ) Change subject: contrib/jenkins.sh: build some sub-projects with --enable-werror ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30820 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8976ba3c52a3b4a47c98b9e6e85c7b9dcef4575a Gerrit-Change-Number: 30820 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 15:51:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: virt_phy: fix make distcheck: access l1ctl_proto.h via symlink

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30817 ) Change subject: virt_phy: fix make distcheck: access l1ctl_proto.h via symlink ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Please textend the description it's difficult to understand in gerrit. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id64ab161a17d53f5e93cdd100e81d4fb8acfb97a Gerrit-Change-Number: 30817 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 15:50:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023