January 2023 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: bsc: Move hardcoded octetstring to single constant field

by pespin

Attention is currently required from: neels, pespin. Hello Jenkins Builder, neels, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30822 to look at the new patch set (#3). Change subject: bsc: Move hardcoded octetstring to single constant field ...................................................................... bsc: Move hardcoded octetstring to single constant field This makes it easier changing it to be a valid l3 payload in the future. Related: SYS#6280 Change-Id: I888bcc42d4b68bac4c12dfbbf3c74e1734318699 --- M bsc/BSC_Tests.ttcn M bsc/BSC_Tests_CBSP.ttcn M bsc/BSC_Tests_VAMOS.ttcn 3 files changed, 66 insertions(+), 76 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/22/30822/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30822 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I888bcc42d4b68bac4c12dfbbf3c74e1734318699 Gerrit-Change-Number: 30822 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in libosmo-gprs[master]: tests/rlcmac: make linter happy: use const char * const

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30824 ) Change subject: tests/rlcmac: make linter happy: use const char * const ...................................................................... tests/rlcmac: make linter happy: use const char * const Change-Id: I26748681d13441fdfb9c46d9a476ea669b308ff7 --- M tests/rlcmac/ts_44_018_test.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/tests/rlcmac/ts_44_018_test.c b/tests/rlcmac/ts_44_018_test.c index cff153e..a5c4540 100644 --- a/tests/rlcmac/ts_44_018_test.c +++ b/tests/rlcmac/ts_44_018_test.c @@ -31,7 +31,7 @@ { printf("*** %s ***\n", __func__); - static const char *testData[] = { + static const char * const testData[] = { "9000185a6fc9f2b5304208eb2b2b2b2b2b2b2b2b", // osmo-pcu, with EGPRS "a000185a6fc9f14608411b2b2b2b2b2b2b2b2b2b", // osmo-pcu, without EGPRS "90005847eb4a93e51a218a16ab2b2b2b2b2b2b2b", // real network (Iran, Tehran) @@ -60,7 +60,7 @@ { printf("*** %s ***\n", __func__); - static const char *testData[] = { + static const char * const testData[] = { "c8c2859f032b2b2b2b2b", // HH, Packet Uplink Assignment "c1ebb26b2b2b2b2b2b2b", // HH, Packet Uplink Assignment (single block) "dd6e1ae5a8c7841b2b2b", // HH, Packet Downlink Assignment -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30824 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I26748681d13441fdfb9c46d9a476ea669b308ff7 Gerrit-Change-Number: 30824 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in libosmo-gprs[master]: tests/rlcmac: make linter happy: use const char * const

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30824 ) Change subject: tests/rlcmac: make linter happy: use const char * const ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30824 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I26748681d13441fdfb9c46d9a476ea669b308ff7 Gerrit-Change-Number: 30824 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 17:40:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: virt_phy: fix make distcheck: access l1ctl_proto.h via symlink

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30817 ) Change subject: virt_phy: fix make distcheck: access l1ctl_proto.h via symlink ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id64ab161a17d53f5e93cdd100e81d4fb8acfb97a Gerrit-Change-Number: 30817 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 17:40:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: add decoder and test vectors for IA Rest Octets

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30797 ) Change subject: rlcmac: add decoder and test vectors for IA Rest Octets ...................................................................... Patch Set 2: (1 comment) File tests/rlcmac/ts_44_018_test.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/30797/comment/00dfbd42_01e070fd PS1, Line 63: static const char *testData[] = { > The important part is that you fix & re-push it immediatelly after seeing it so that others don't ne […] https://gerrit.osmocom.org/c/libosmo-gprs/+/30824 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30797 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I39a29dc9b5b22ce4374ae33336696014e326d012 Gerrit-Change-Number: 30797 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 17:28:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-gprs[master]: tests/rlcmac: make linter happy: use const char * const

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30824 ) Change subject: tests/rlcmac: make linter happy: use const char * const ...................................................................... tests/rlcmac: make linter happy: use const char * const Change-Id: I26748681d13441fdfb9c46d9a476ea669b308ff7 --- M tests/rlcmac/ts_44_018_test.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/24/30824/1 diff --git a/tests/rlcmac/ts_44_018_test.c b/tests/rlcmac/ts_44_018_test.c index cff153e..a5c4540 100644 --- a/tests/rlcmac/ts_44_018_test.c +++ b/tests/rlcmac/ts_44_018_test.c @@ -31,7 +31,7 @@ { printf("*** %s ***\n", __func__); - static const char *testData[] = { + static const char * const testData[] = { "9000185a6fc9f2b5304208eb2b2b2b2b2b2b2b2b", // osmo-pcu, with EGPRS "a000185a6fc9f14608411b2b2b2b2b2b2b2b2b2b", // osmo-pcu, without EGPRS "90005847eb4a93e51a218a16ab2b2b2b2b2b2b2b", // real network (Iran, Tehran) @@ -60,7 +60,7 @@ { printf("*** %s ***\n", __func__); - static const char *testData[] = { + static const char * const testData[] = { "c8c2859f032b2b2b2b2b", // HH, Packet Uplink Assignment "c1ebb26b2b2b2b2b2b2b", // HH, Packet Uplink Assignment (single block) "dd6e1ae5a8c7841b2b2b", // HH, Packet Downlink Assignment -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30824 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I26748681d13441fdfb9c46d9a476ea669b308ff7 Gerrit-Change-Number: 30824 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: virt_phy: fix make distcheck: access l1ctl_proto.h via symlink

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30817 ) Change subject: virt_phy: fix make distcheck: access l1ctl_proto.h via symlink ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Please textend the description it's difficult to understand in gerrit. Done. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id64ab161a17d53f5e93cdd100e81d4fb8acfb97a Gerrit-Change-Number: 30817 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 17:21:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: layer23/sysinfo: implement decoding of SI13 Rest Octets

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30812 to look at the new patch set (#5). Change subject: layer23/sysinfo: implement decoding of SI13 Rest Octets ...................................................................... layer23/sysinfo: implement decoding of SI13 Rest Octets Change-Id: Ia6ff7d4e37816c6321b54c1f7f8d7110e557f8c5 Related: SYS#5500 --- M src/host/layer23/include/osmocom/bb/common/sysinfo.h M src/host/layer23/src/common/sysinfo.c M src/host/layer23/src/mobile/gsm48_rr.c 3 files changed, 169 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/12/30812/5 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30812 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia6ff7d4e37816c6321b54c1f7f8d7110e557f8c5 Gerrit-Change-Number: 30812 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: virt_phy: fix make distcheck: access l1ctl_proto.h via symlink

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30817 to look at the new patch set (#2). Change subject: virt_phy: fix make distcheck: access l1ctl_proto.h via symlink ...................................................................... virt_phy: fix make distcheck: access l1ctl_proto.h via symlink Accessing a header file from outside of the sub-project requires using the relative path ("-I$(top_srcdir)/../layer23/include"), which does not resolve properly during make distcheck. The '../layer23/include/l1ctl_proto.h' is actually a symlink too. Change-Id: Id64ab161a17d53f5e93cdd100e81d4fb8acfb97a --- M src/host/virt_phy/include/Makefile.am A src/host/virt_phy/include/virtphy/l1ctl_proto.h M src/host/virt_phy/include/virtphy/l1ctl_sap.h M src/host/virt_phy/src/Makefile.am M src/host/virt_phy/src/gsmtapl1_if.c M src/host/virt_phy/src/l1ctl_sap.c M src/host/virt_phy/src/virt_prim_data.c M src/host/virt_phy/src/virt_prim_fbsb.c M src/host/virt_phy/src/virt_prim_pm.c M src/host/virt_phy/src/virt_prim_rach.c M src/host/virt_phy/src/virt_prim_traffic.c 11 files changed, 11 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/17/30817/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id64ab161a17d53f5e93cdd100e81d4fb8acfb97a Gerrit-Change-Number: 30817 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in libosmo-gprs[master]: tests/llc: Test gprs_llc_is_retransmit()

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30813 ) Change subject: tests/llc: Test gprs_llc_is_retransmit() ...................................................................... Patch Set 3: Code-Review+1 (2 comments) File tests/llc/llc_test.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/30813/comment/54c99923_d606854d PS2, Line 1: codec > not true? Done https://gerrit.osmocom.org/c/libosmo-gprs/+/30813/comment/d91257ab_89f681e2 PS2, Line 3: 2022 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> > `git blame tests/gprs/gprs_test.c` gives me faf1f64a2: […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30813 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I4104ee9cc458b7d169ee9761e02369442058675a Gerrit-Change-Number: 30813 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 17:21:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023