January 2023 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: mobile: gapk_io_init_ms(): fix 'phy_fmt' may be used uninitialized

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30816 ) Change subject: mobile: gapk_io_init_ms(): fix 'phy_fmt' may be used uninitialized ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30816 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I193de6e0e831aa4201f5edec80e40abc43f4a861 Gerrit-Change-Number: 30816 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 15:49:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: contrib/jenkins.sh: make use of $PARALLEL_MAKE

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30819 ) Change subject: contrib/jenkins.sh: make use of $PARALLEL_MAKE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30819 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I371a8dca6d992622d005d8c9d84eaaad6f3c7372 Gerrit-Change-Number: 30819 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 15:49:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: contrib/jenkins.sh: also run distcheck for trxcon and virt_phy

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30818 ) Change subject: contrib/jenkins.sh: also run distcheck for trxcon and virt_phy ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30818 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I5664806df4051694a5ce705420cd574f7a7da531 Gerrit-Change-Number: 30818 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 15:48:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23/sysinfo: update coding style, make pointers const

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30810 ) Change subject: layer23/sysinfo: update coding style, make pointers const ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30810 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia518251eae1b45ad573d076d97cba83ed25ea9ea Gerrit-Change-Number: 30810 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 15:48:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: contrib/jenkins.sh: build some sub-projects with --enable-werror

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30820 to look at the new patch set (#2). Change subject: contrib/jenkins.sh: build some sub-projects with --enable-werror ...................................................................... contrib/jenkins.sh: build some sub-projects with --enable-werror Change-Id: I8976ba3c52a3b4a47c98b9e6e85c7b9dcef4575a --- M contrib/jenkins.sh 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/20/30820/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30820 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8976ba3c52a3b4a47c98b9e6e85c7b9dcef4575a Gerrit-Change-Number: 30820 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: gsm48_ie: gsm48_decode_freq_list(): make 'cd' argument const

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30808 ) Change subject: gsm48_ie: gsm48_decode_freq_list(): make 'cd' argument const ...................................................................... gsm48_ie: gsm48_decode_freq_list(): make 'cd' argument const Change-Id: Ide9110b984d3302aec6b439c563eb10e2dcdec9e --- M include/osmocom/gsm/gsm48_ie.h M src/gsm/gsm48_ie.c 2 files changed, 6 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/include/osmocom/gsm/gsm48_ie.h b/include/osmocom/gsm/gsm48_ie.h index b79cbfc..4768283 100644 --- a/include/osmocom/gsm/gsm48_ie.h +++ b/include/osmocom/gsm/gsm48_ie.h @@ -117,8 +117,9 @@ }; /* decode "Cell Channel Description" (10.5.2.1b) and other frequency lists */ -int gsm48_decode_freq_list(struct gsm_sysinfo_freq *f, uint8_t *cd, - uint8_t len, uint8_t mask, uint8_t frqt); +int gsm48_decode_freq_list(struct gsm_sysinfo_freq *f, + const uint8_t *cd, uint8_t len, + uint8_t mask, uint8_t frqt); /* decode "CSN.1 encoded Classmark 3" (10.5.1.7) */ int gsm48_decode_classmark3(struct gsm48_classmark3 *classmark3_out, diff --git a/src/gsm/gsm48_ie.c b/src/gsm/gsm48_ie.c index bbaec3d..5eca978 100644 --- a/src/gsm/gsm48_ie.c +++ b/src/gsm/gsm48_ie.c @@ -880,8 +880,9 @@ * \param[in] cd Cell Channel Description IE * \param[in] len Length of \a cd in bytes * \returns 0 on success; negative on error */ -int gsm48_decode_freq_list(struct gsm_sysinfo_freq *f, uint8_t *cd, - uint8_t len, uint8_t mask, uint8_t frqt) +int gsm48_decode_freq_list(struct gsm_sysinfo_freq *f, + const uint8_t *cd, uint8_t len, + uint8_t mask, uint8_t frqt) { int i; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ide9110b984d3302aec6b439c563eb10e2dcdec9e Gerrit-Change-Number: 30808 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: gsm48_ie: gsm48_decode_freq_list(): make 'cd' argument const

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30808 ) Change subject: gsm48_ie: gsm48_decode_freq_list(): make 'cd' argument const ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: Trivial change. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ide9110b984d3302aec6b439c563eb10e2dcdec9e Gerrit-Change-Number: 30808 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 15:44:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: contrib/jenkins.sh: also run distcheck for trxcon and virt_phy

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30818 ) Change subject: contrib/jenkins.sh: also run distcheck for trxcon and virt_phy ...................................................................... contrib/jenkins.sh: also run distcheck for trxcon and virt_phy Change-Id: I5664806df4051694a5ce705420cd574f7a7da531 --- M contrib/jenkins.sh 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/18/30818/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 2758f4e..4374229 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -36,7 +36,7 @@ # building those sub-projects where 'distcheck' is known-working -for dir in gprsdecode layer23; do +for dir in gprsdecode layer23 trxcon virt_phy; do cd $base/src/host/$dir autoreconf -fi ./configure @@ -44,7 +44,7 @@ done # TODO: make sure 'distcheck' passes also for these -for dir in gsmmap osmocon trxcon virt_phy; do +for dir in gsmmap osmocon; do cd $base/src/host/$dir autoreconf -fi ./configure -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30818 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I5664806df4051694a5ce705420cd574f7a7da531 Gerrit-Change-Number: 30818 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: gapk_io_init_ms(): fix 'phy_fmt' may be used uninitialized

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30816 ) Change subject: mobile: gapk_io_init_ms(): fix 'phy_fmt' may be used uninitialized ...................................................................... mobile: gapk_io_init_ms(): fix 'phy_fmt' may be used uninitialized Change-Id: I193de6e0e831aa4201f5edec80e40abc43f4a861 --- M src/host/layer23/src/mobile/gapk_io.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/16/30816/1 diff --git a/src/host/layer23/src/mobile/gapk_io.c b/src/host/layer23/src/mobile/gapk_io.c index 4e3cd75..0a807ff 100644 --- a/src/host/layer23/src/mobile/gapk_io.c +++ b/src/host/layer23/src/mobile/gapk_io.c @@ -415,6 +415,10 @@ case AUDIO_IOF_TI: phy_fmt = phy_fmt_pick_ti(codec); break; + default: + LOGP(DGAPK, LOGL_ERROR, "Unhandled I/O format %s\n", + audio_io_format_name(set->audio.io_format)); + return -ENOTSUP; } phy_fmt_desc = osmo_gapk_fmt_get_from_type(phy_fmt); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30816 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I193de6e0e831aa4201f5edec80e40abc43f4a861 Gerrit-Change-Number: 30816 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: virt_phy: fix make distcheck: access l1ctl_proto.h via symlink

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30817 ) Change subject: virt_phy: fix make distcheck: access l1ctl_proto.h via symlink ...................................................................... virt_phy: fix make distcheck: access l1ctl_proto.h via symlink Change-Id: Id64ab161a17d53f5e93cdd100e81d4fb8acfb97a --- M src/host/virt_phy/include/Makefile.am A src/host/virt_phy/include/virtphy/l1ctl_proto.h M src/host/virt_phy/include/virtphy/l1ctl_sap.h M src/host/virt_phy/src/gsmtapl1_if.c M src/host/virt_phy/src/l1ctl_sap.c M src/host/virt_phy/src/virt_prim_data.c M src/host/virt_phy/src/virt_prim_fbsb.c M src/host/virt_phy/src/virt_prim_pm.c M src/host/virt_phy/src/virt_prim_rach.c M src/host/virt_phy/src/virt_prim_traffic.c 10 files changed, 10 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/17/30817/1 diff --git a/src/host/virt_phy/include/Makefile.am b/src/host/virt_phy/include/Makefile.am index 6048a4b..ff3e8cb 100644 --- a/src/host/virt_phy/include/Makefile.am +++ b/src/host/virt_phy/include/Makefile.am @@ -1,6 +1,7 @@ noinst_HEADERS = \ virtphy/logging.h \ virtphy/osmo_mcast_sock.h \ + virtphy/l1ctl_proto.h \ virtphy/l1ctl_sock.h \ virtphy/virtual_um.h \ virtphy/gsmtapl1_if.h \ diff --git a/src/host/virt_phy/include/virtphy/l1ctl_proto.h b/src/host/virt_phy/include/virtphy/l1ctl_proto.h new file mode 120000 index 0000000..95d4161 --- /dev/null +++ b/src/host/virt_phy/include/virtphy/l1ctl_proto.h @@ -0,0 +1 @@ +../../../../../include/l1ctl_proto.h \ No newline at end of file diff --git a/src/host/virt_phy/include/virtphy/l1ctl_sap.h b/src/host/virt_phy/include/virtphy/l1ctl_sap.h index d3562a1..6306eeb 100644 --- a/src/host/virt_phy/include/virtphy/l1ctl_sap.h +++ b/src/host/virt_phy/include/virtphy/l1ctl_sap.h @@ -2,7 +2,7 @@ #include <stdint.h> #include <osmocom/core/msgb.h> -#include <l1ctl_proto.h> +#include <virtphy/l1ctl_proto.h> #include <virtphy/virtual_um.h> #include <virtphy/l1ctl_sock.h> #include <virtphy/virt_l1_model.h> diff --git a/src/host/virt_phy/src/gsmtapl1_if.c b/src/host/virt_phy/src/gsmtapl1_if.c index 83b01fe..1496ee9 100644 --- a/src/host/virt_phy/src/gsmtapl1_if.c +++ b/src/host/virt_phy/src/gsmtapl1_if.c @@ -32,7 +32,7 @@ #include <stdlib.h> #include <string.h> #include <errno.h> -#include <l1ctl_proto.h> +#include <virtphy/l1ctl_proto.h> #include <virtphy/virtual_um.h> #include <virtphy/l1ctl_sock.h> #include <virtphy/virt_l1_model.h> diff --git a/src/host/virt_phy/src/l1ctl_sap.c b/src/host/virt_phy/src/l1ctl_sap.c index 35370f0..ffe94ac 100644 --- a/src/host/virt_phy/src/l1ctl_sap.c +++ b/src/host/virt_phy/src/l1ctl_sap.c @@ -29,7 +29,7 @@ #include <osmocom/gsm/rsl.h> #include <osmocom/gprs/gprs_rlc.h> #include <stdio.h> -#include <l1ctl_proto.h> +#include <virtphy/l1ctl_proto.h> #include <netinet/in.h> #include <string.h> #include <virtphy/virtual_um.h> diff --git a/src/host/virt_phy/src/virt_prim_data.c b/src/host/virt_phy/src/virt_prim_data.c index f74a9fa..51f7585 100644 --- a/src/host/virt_phy/src/virt_prim_data.c +++ b/src/host/virt_phy/src/virt_prim_data.c @@ -32,7 +32,7 @@ #include <virtphy/logging.h> #include <virtphy/gsmtapl1_if.h> -#include <l1ctl_proto.h> +#include <virtphy/l1ctl_proto.h> /** * @brief Handler callback function for DATA request. diff --git a/src/host/virt_phy/src/virt_prim_fbsb.c b/src/host/virt_phy/src/virt_prim_fbsb.c index 9637ed9..7c634cb 100644 --- a/src/host/virt_phy/src/virt_prim_fbsb.c +++ b/src/host/virt_phy/src/virt_prim_fbsb.c @@ -29,7 +29,7 @@ #include <virtphy/virt_l1_sched.h> #include <osmocom/core/gsmtap.h> #include <virtphy/logging.h> -#include <l1ctl_proto.h> +#include <virtphy/l1ctl_proto.h> static uint16_t sync_count = 0; diff --git a/src/host/virt_phy/src/virt_prim_pm.c b/src/host/virt_phy/src/virt_prim_pm.c index 5a9a664..bb7875d 100644 --- a/src/host/virt_phy/src/virt_prim_pm.c +++ b/src/host/virt_phy/src/virt_prim_pm.c @@ -29,7 +29,7 @@ #include <virtphy/virt_l1_sched.h> #include <osmocom/core/gsmtap.h> #include <virtphy/logging.h> -#include <l1ctl_proto.h> +#include <virtphy/l1ctl_proto.h> /** * @brief Change the signal strength for a given arfcn. diff --git a/src/host/virt_phy/src/virt_prim_rach.c b/src/host/virt_phy/src/virt_prim_rach.c index 2813458..a8a8ffa 100644 --- a/src/host/virt_phy/src/virt_prim_rach.c +++ b/src/host/virt_phy/src/virt_prim_rach.c @@ -32,7 +32,7 @@ #include <virtphy/logging.h> #include <virtphy/gsmtapl1_if.h> -#include <l1ctl_proto.h> +#include <virtphy/l1ctl_proto.h> /* use if we have a combined uplink (RACH, SDCCH, ...) (see * http://www.rfwireless-world.com/Terminology/GSM-combined-channel-configurat…) diff --git a/src/host/virt_phy/src/virt_prim_traffic.c b/src/host/virt_phy/src/virt_prim_traffic.c index 1686ce9..ae87ad6 100644 --- a/src/host/virt_phy/src/virt_prim_traffic.c +++ b/src/host/virt_phy/src/virt_prim_traffic.c @@ -32,7 +32,7 @@ #include <virtphy/logging.h> #include <virtphy/gsmtapl1_if.h> -#include <l1ctl_proto.h> +#include <virtphy/l1ctl_proto.h> /** * @brief Handler callback function for TRAFFIC request. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id64ab161a17d53f5e93cdd100e81d4fb8acfb97a Gerrit-Change-Number: 30817 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023