January 2023 - gerrit-log - lists.osmocom.org

Change in libosmo-gprs[master]: rlcmac: add decoder and test vectors for IA Rest Octets

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30797 ) Change subject: rlcmac: add decoder and test vectors for IA Rest Octets ...................................................................... Patch Set 1: (1 comment) File tests/rlcmac/ts_44_018_test.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/30797/comment/e2e7db81_9605ce2e PS1, Line 63: static const char *testData[] = { > See my message above. If you think this is really important, it can be done in a separate patch. The important part is that you fix & re-push it immediatelly after seeing it so that others don't need to waste time reviewing or discussing this 😄 Feel free to fix as you want. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30797 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I39a29dc9b5b22ce4374ae33336696014e326d012 Gerrit-Change-Number: 30797 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 12:53:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: rename s/IA_EGPRS_00_t/IA_EGPRS_PktUlAss_t/

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30799 ) Change subject: rlcmac: rename s/IA_EGPRS_00_t/IA_EGPRS_PktUlAss_t/ ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30799 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I884cba359bfda21cf45fa846e5b7ff20d129bdf7 Gerrit-Change-Number: 30799 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 12:51:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: fix coding of EGPRS Packet Uplink Assignment in IA RestOctets

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30798 ) Change subject: rlcmac: fix coding of EGPRS Packet Uplink Assignment in IA RestOctets ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30798 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I7fedbad1ac4d744d1d3941553e573d4202e9d24a Gerrit-Change-Number: 30798 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 12:51:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: add decoder and test vectors for IA Rest Octets

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30797 ) Change subject: rlcmac: add decoder and test vectors for IA Rest Octets ...................................................................... Patch Set 1: (1 comment) File tests/rlcmac/ts_44_018_test.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/30797/comment/790b6ccd_1ccd31b5 PS1, Line 63: static const char *testData[] = { > > static const char * array should probably be static const char * const […] See my message above. If you think this is really important, it can be done in a separate patch. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30797 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I39a29dc9b5b22ce4374ae33336696014e326d012 Gerrit-Change-Number: 30797 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 12:51:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmo-gprs[master]: tests/llc: Test gprs_llc_is_retransmit()

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30813 to look at the new patch set (#2). Change subject: tests/llc: Test gprs_llc_is_retransmit() ...................................................................... tests/llc: Test gprs_llc_is_retransmit() Imported from osmo-sgsn.git 4398ac073b7fc8363882b5f7414470b73d4f446a ./tests/gprs/gprs_test.c. Change-Id: I4104ee9cc458b7d169ee9761e02369442058675a --- M tests/llc/Makefile.am A tests/llc/llc_test.c A tests/llc/llc_test.err A tests/llc/llc_test.ok M tests/testsuite.at 5 files changed, 121 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/13/30813/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30813 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I4104ee9cc458b7d169ee9761e02369442058675a Gerrit-Change-Number: 30813 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in osmo-sgsn[master]: Move gprs_tmr_to_secs() to tests/gprs/gprs_test.c

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/30814 ) Change subject: Move gprs_tmr_to_secs() to tests/gprs/gprs_test.c ...................................................................... Move gprs_tmr_to_secs() to tests/gprs/gprs_test.c That function is only used in the test. Let's hence move the function to the same test file in order to simplify osmo-sgsn code. Change-Id: I69d80810362d75eb93974af34f61639514f99f8a --- M include/osmocom/sgsn/gprs_utils.h M src/gprs/gprs_utils.c M tests/gprs/gprs_test.c 3 files changed, 16 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/14/30814/1 diff --git a/include/osmocom/sgsn/gprs_utils.h b/include/osmocom/sgsn/gprs_utils.h index eacaec7..c05aca6 100644 --- a/include/osmocom/sgsn/gprs_utils.h +++ b/include/osmocom/sgsn/gprs_utils.h @@ -32,7 +32,6 @@ int gprs_str_to_apn(uint8_t *apn_enc, size_t max_len, const char *str); /* GSM 04.08, 10.5.7.3 GPRS Timer */ -int gprs_tmr_to_secs(uint8_t tmr); uint8_t gprs_secs_to_tmr_floor(int secs); int gprs_is_mi_tmsi(const uint8_t *value, size_t value_len); diff --git a/src/gprs/gprs_utils.c b/src/gprs/gprs_utils.c index 632718a..3eac330 100644 --- a/src/gprs/gprs_utils.c +++ b/src/gprs/gprs_utils.c @@ -64,22 +64,6 @@ return len; } -/* GSM 04.08, 10.5.7.3 GPRS Timer */ -int gprs_tmr_to_secs(uint8_t tmr) -{ - switch (tmr & GPRS_TMR_UNIT_MASK) { - case GPRS_TMR_2SECONDS: - return 2 * (tmr & GPRS_TMR_FACT_MASK); - default: - case GPRS_TMR_MINUTE: - return 60 * (tmr & GPRS_TMR_FACT_MASK); - case GPRS_TMR_6MINUTE: - return 360 * (tmr & GPRS_TMR_FACT_MASK); - case GPRS_TMR_DEACTIVATED: - return -1; - } -} - /* This functions returns a tmr value such that * - f is monotonic * - f(s) <= s diff --git a/tests/gprs/gprs_test.c b/tests/gprs/gprs_test.c index 99e3ea5..89dac07 100644 --- a/tests/gprs/gprs_test.c +++ b/tests/gprs/gprs_test.c @@ -48,6 +48,22 @@ ASSERT_FALSE(nu_is_retransmission(479, 511)); // wrapped } +/* GSM 04.08, 10.5.7.3 GPRS Timer */ +static int gprs_tmr_to_secs(uint8_t tmr) +{ + switch (tmr & GPRS_TMR_UNIT_MASK) { + case GPRS_TMR_2SECONDS: + return 2 * (tmr & GPRS_TMR_FACT_MASK); + default: + case GPRS_TMR_MINUTE: + return 60 * (tmr & GPRS_TMR_FACT_MASK); + case GPRS_TMR_6MINUTE: + return 360 * (tmr & GPRS_TMR_FACT_MASK); + case GPRS_TMR_DEACTIVATED: + return -1; + } +} + static void test_gprs_timer_enc_dec(void) { int i, u, secs, tmr; -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30814 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I69d80810362d75eb93974af34f61639514f99f8a Gerrit-Change-Number: 30814 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in libosmo-gprs[master]: tests/llc: Test gprs_llc_is_retransmit()

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30813 ) Change subject: tests/llc: Test gprs_llc_is_retransmit() ...................................................................... Patch Set 1: (9 comments) File tests/llc/llc_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317): https://gerrit.osmocom.org/c/libosmo-gprs/+/30813/comment/5ba18c04_9b2e92dd PS1, Line 29: #define ASSERT_FALSE(x) if (x) { printf("Should have returned false.\n"); abort(); } Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317): https://gerrit.osmocom.org/c/libosmo-gprs/+/30813/comment/75a28e8f_348e2432 PS1, Line 30: #define ASSERT_TRUE(x) if (!x) { printf("Should have returned true.\n"); abort(); } Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317): https://gerrit.osmocom.org/c/libosmo-gprs/+/30813/comment/845cc372_090b4051 PS1, Line 48: ASSERT_TRUE (nu_is_retransmission(0, 1)); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317): https://gerrit.osmocom.org/c/libosmo-gprs/+/30813/comment/c4309079_bef56ec7 PS1, Line 51: ASSERT_TRUE (nu_is_retransmission(0, 1)); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317): https://gerrit.osmocom.org/c/libosmo-gprs/+/30813/comment/fba044ac_c19607db PS1, Line 52: ASSERT_TRUE (nu_is_retransmission(511, 1)); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317): https://gerrit.osmocom.org/c/libosmo-gprs/+/30813/comment/230dc13a_050408a8 PS1, Line 53: ASSERT_TRUE (nu_is_retransmission(483, 1)); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317): https://gerrit.osmocom.org/c/libosmo-gprs/+/30813/comment/cf0f30d9_f9b30b3b PS1, Line 54: ASSERT_TRUE (nu_is_retransmission(482, 1)); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317): https://gerrit.osmocom.org/c/libosmo-gprs/+/30813/comment/784378ab_43ac3427 PS1, Line 62: ASSERT_TRUE (nu_is_retransmission(510, 511)); // behind space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2317): https://gerrit.osmocom.org/c/libosmo-gprs/+/30813/comment/de454c9c_e8ccf652 PS1, Line 63: ASSERT_TRUE (nu_is_retransmission(481, 511)); // behind space prohibited between function name and open parenthesis '(' -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30813 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I4104ee9cc458b7d169ee9761e02369442058675a Gerrit-Change-Number: 30813 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 02 Jan 2023 12:25:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmo-gprs[master]: tests/llc: Test gprs_llc_is_retransmit()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30813 ) Change subject: tests/llc: Test gprs_llc_is_retransmit() ...................................................................... tests/llc: Test gprs_llc_is_retransmit() Imported from osmo-sgsn.git 4398ac073b7fc8363882b5f7414470b73d4f446a ./tests/gprs/gprs_test.c. Change-Id: I4104ee9cc458b7d169ee9761e02369442058675a --- M tests/llc/Makefile.am A tests/llc/llc_test.c A tests/llc/llc_test.err A tests/llc/llc_test.ok M tests/testsuite.at 5 files changed, 121 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/13/30813/1 diff --git a/tests/llc/Makefile.am b/tests/llc/Makefile.am index aa7e3e7..ee57c5f 100644 --- a/tests/llc/Makefile.am +++ b/tests/llc/Makefile.am @@ -10,12 +10,15 @@ $(NULL) check_PROGRAMS = \ + llc_test \ llc_prim_test \ pdu_codec_test \ xid_codec_test \ $(NULL) EXTRA_DIST = \ + llc_test.err \ + llc_test.ok \ llc_prim_test.err \ llc_prim_test.ok \ pdu_codec_test.ok \ @@ -24,6 +27,13 @@ xid_codec_test.err \ $(NULL) +llc_test_SOURCES = llc_test.c +llc_test_LDADD = \ + $(LIBOSMOCORE_LIBS) \ + $(LIBOSMOGSM_LIBS) \ + $(top_builddir)/src/llc/libosmo-gprs-llc.la \ + $(NULL) + llc_prim_test_SOURCES = llc_prim_test.c llc_prim_test_LDADD = \ $(LIBOSMOCORE_LIBS) \ diff --git a/tests/llc/llc_test.c b/tests/llc/llc_test.c new file mode 100644 index 0000000..c5711d7 --- /dev/null +++ b/tests/llc/llc_test.c @@ -0,0 +1,89 @@ +/* LLC PDU codec tests + * + * (C) 2022 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation; either version 2 + * of the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <stdint.h> +#include <stdio.h> + +#include <osmocom/core/application.h> +#include <osmocom/core/logging.h> +#include <osmocom/core/utils.h> +#include <osmocom/core/msgb.h> + +#include <osmocom/gprs/llc/llc.h> +#include <osmocom/gprs/llc/llc_private.h> + +static void *tall_ctx = NULL; + +#define ASSERT_FALSE(x) if (x) { printf("Should have returned false.\n"); abort(); } +#define ASSERT_TRUE(x) if (!x) { printf("Should have returned true.\n"); abort(); } + +/** + * GSM 04.64 8.4.2 Receipt of unacknowledged information + */ +static int nu_is_retransmission(uint16_t nu, uint16_t vur) +{ + int ret = gprs_llc_is_retransmit(nu, vur); + printf("N(U) = %d, V(UR) = %d => %s\n", nu, vur, + ret == 1 ? "retransmit" : "new"); + return ret; +} + +static void test_8_4_2(void) +{ + printf("Testing gprs_llc_is_retransmit.\n"); + + ASSERT_FALSE(nu_is_retransmission(0, 0)); + ASSERT_TRUE (nu_is_retransmission(0, 1)); + + /* expect 1... check for retransmissions */ + ASSERT_TRUE (nu_is_retransmission(0, 1)); + ASSERT_TRUE (nu_is_retransmission(511, 1)); + ASSERT_TRUE (nu_is_retransmission(483, 1)); + ASSERT_TRUE (nu_is_retransmission(482, 1)); + ASSERT_FALSE(nu_is_retransmission(481, 1)); + + /* expect 511... check for retransmissions */ + ASSERT_FALSE(nu_is_retransmission(0, 240)); // ahead + ASSERT_FALSE(nu_is_retransmission(0, 511)); // ahead + ASSERT_FALSE(nu_is_retransmission(1, 511)); // ahead + ASSERT_FALSE(nu_is_retransmission(511, 511)); // same + ASSERT_TRUE (nu_is_retransmission(510, 511)); // behind + ASSERT_TRUE (nu_is_retransmission(481, 511)); // behind + ASSERT_FALSE(nu_is_retransmission(479, 511)); // wrapped +} + +static const struct log_info_cat test_log_categories[] = { }; +static const struct log_info test_log_info = { + .cat = test_log_categories, + .num_cat = ARRAY_SIZE(test_log_categories), +}; + +int main(int argc, char *argv[]) +{ + tall_ctx = talloc_named_const(NULL, 1, __FILE__); + + osmo_init_logging2(tall_ctx, &test_log_info); + log_parse_category_mask(osmo_stderr_target, "DLGLOBAL,1:"); + + log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_NONE); + log_set_print_category_hex(osmo_stderr_target, 0); + log_set_print_category(osmo_stderr_target, 1); + log_set_print_level(osmo_stderr_target, 1); + log_set_use_color(osmo_stderr_target, 0); + + test_8_4_2(); + + talloc_free(tall_ctx); +} diff --git a/tests/llc/llc_test.err b/tests/llc/llc_test.err new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/tests/llc/llc_test.err diff --git a/tests/llc/llc_test.ok b/tests/llc/llc_test.ok new file mode 100644 index 0000000..9f54523 --- /dev/null +++ b/tests/llc/llc_test.ok @@ -0,0 +1,15 @@ +Testing gprs_llc_is_retransmit. +N(U) = 0, V(UR) = 0 => new +N(U) = 0, V(UR) = 1 => retransmit +N(U) = 0, V(UR) = 1 => retransmit +N(U) = 511, V(UR) = 1 => retransmit +N(U) = 483, V(UR) = 1 => retransmit +N(U) = 482, V(UR) = 1 => retransmit +N(U) = 481, V(UR) = 1 => new +N(U) = 0, V(UR) = 240 => new +N(U) = 0, V(UR) = 511 => new +N(U) = 1, V(UR) = 511 => new +N(U) = 511, V(UR) = 511 => new +N(U) = 510, V(UR) = 511 => retransmit +N(U) = 481, V(UR) = 511 => retransmit +N(U) = 479, V(UR) = 511 => new diff --git a/tests/testsuite.at b/tests/testsuite.at index 5bbedf5..84cbb4e 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -1,6 +1,13 @@ AT_INIT AT_BANNER([Regression tests]) +AT_SETUP([llc/llc]) +AT_KEYWORDS([llc llc]) +cat $abs_srcdir/llc/llc_test.ok > expout +cat $abs_srcdir/llc/llc_test.err > experr +AT_CHECK([$abs_top_builddir/tests/llc/llc_test], [0], [expout], [experr]) +AT_CLEANUP + AT_SETUP([llc/llc_prim]) AT_KEYWORDS([llc llc_prim]) cat $abs_srcdir/llc/llc_prim_test.ok > expout -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30813 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I4104ee9cc458b7d169ee9761e02369442058675a Gerrit-Change-Number: 30813 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: coverity: build osmo-trx with MS TRX (--with-mstrx)

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30801 ) Change subject: coverity: build osmo-trx with MS TRX (--with-mstrx) ...................................................................... coverity: build osmo-trx with MS TRX (--with-mstrx) Change-Id: I4fbb052eacd8e6b8ddb8130d2e280a248719b250 Related: OS#5599 --- M coverity/build_Osmocom.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/coverity/build_Osmocom.sh b/coverity/build_Osmocom.sh index da2244a..1c21046 100755 --- a/coverity/build_Osmocom.sh +++ b/coverity/build_Osmocom.sh @@ -112,6 +112,7 @@ build_default osmo-sip-connector build_default osmo-trx \ + --with-mstrx \ --with-usrp1 \ --with-uhd \ --with-lms \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30801 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4fbb052eacd8e6b8ddb8130d2e280a248719b250 Gerrit-Change-Number: 30801 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: coverity: build osmo-trx with MS TRX (--with-mstrx)

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30801 ) Change subject: coverity: build osmo-trx with MS TRX (--with-mstrx) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30801 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4fbb052eacd8e6b8ddb8130d2e280a248719b250 Gerrit-Change-Number: 30801 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 11:21:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023