September 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-abis[master]: ipaccess_close(): No need to lookup already available struct e1i_ts

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/29370 ) Change subject: ipaccess_close(): No need to lookup already available struct e1i_ts ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29370 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I54a69cad5adc3df3f95dd51e00ea68bb04ba9963 Gerrit-Change-Number: 29370 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 12:34:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in libosmo-abis[master]: e1inp_line_ipa_rsl_ts(): Return null instead of reading out of bounds

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/29369 ) Change subject: e1inp_line_ipa_rsl_ts(): Return null instead of reading out of bounds ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: indicate this API change in TODO-RELEASE? -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ic382ab509e4541124f36df153e4b247d9cba35c5 Gerrit-Change-Number: 29369 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 12:31:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in libosmo-abis[master]: ipa: Allow users closing lower layer tcp/ipa connections

by neels

Attention is currently required from: pespin, daniel. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/29365 ) Change subject: ipa: Allow users closing lower layer tcp/ipa connections ...................................................................... Patch Set 2: Code-Review-1 (5 comments) File src/input/ipaccess.c: https://gerrit.osmocom.org/c/libosmo-abis/+/29365/comment/68b329ce_3fa67fa8 PS2, Line 1151: (unrelated ws) https://gerrit.osmocom.org/c/libosmo-abis/+/29365/comment/5d52e9bf_00d81e6e PS2, Line 1174: e1inp_ipa_bts_rsl_close_n(line, trx_nr); handle rc https://gerrit.osmocom.org/c/libosmo-abis/+/29365/comment/2b5a9fbb_3adfc827 PS2, Line 1179: is moving this to above an unrelated change? https://gerrit.osmocom.org/c/libosmo-abis/+/29365/comment/73c1a32a_269522b2 PS2, Line 1208: /* Close the underlaying IPA TCP socket of an RSL link */ "underlying" https://gerrit.osmocom.org/c/libosmo-abis/+/29365/comment/0d6f3e80_6e143005 PS2, Line 1215: "trx_nr (%d) out of range\n", trx_nr); use line width of 120? -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29365 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ia6418321f3b6f1f7274efd414625a4b10a09a362 Gerrit-Change-Number: 29365 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 12:30:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in meta-telephony[201705]: libosmo-netif: update homepage url

by neels

Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/29413 ) Change subject: libosmo-netif: update homepage url ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/29413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I01628200be9f2348eb46e764da6e9f90ffaf789a Gerrit-Change-Number: 29413 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 12:12:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in meta-telephony[201705]: git clones: git.osmocom.org -> gerrit.osmocom.org

by neels

Attention is currently required from: osmith, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/29368 ) Change subject: git clones: git.osmocom.org -> gerrit.osmocom.org ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: i still would prefer that these changes would not be necessary ... but that decision was made, apparently no point in discussing that anymore -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/29368 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I2b9640b542ed68b3f5abf63e774e4f878232211a Gerrit-Change-Number: 29368 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 12:11:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in libosmo-gprs[master]: llc: add definitions of service primitive parameters

by neels

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29411 ) Change subject: llc: add definitions of service primitive parameters ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: would be good to also see usage of the new definitions, or have a commit log hint at which patch will use them -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iaa520a818b05c962e0d3be9607d3a8c5991f539e Gerrit-Change-Number: 29411 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 12:06:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in libosmo-gprs[master]: llc: rename enum osmo_gprs_llc_{primitive->prim_type}

by neels

Attention is currently required from: pespin, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29410 ) Change subject: llc: rename enum osmo_gprs_llc_{primitive->prim_type} ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File include/osmocom/gprs/llc/llc_prim.h: https://gerrit.osmocom.org/c/libosmo-gprs/+/29410/comment/e7bae315_b806ffe5 PS1, Line 5: enum osmo_gprs_llc_prim_type { > I was expecting this sort of change much earlier :) Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ie0f9cd174934c54940217b89e46568a7c1b76b96 Gerrit-Change-Number: 29410 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 12:02:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in libosmo-gprs[master]: llc: separate enum osmo_gprs_llc_primitive to llc_prim.h

by neels

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29409 ) Change subject: llc: separate enum osmo_gprs_llc_primitive to llc_prim.h ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29409 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ida9ce56f48474313064d798ea7b9a72e9b99bb8d Gerrit-Change-Number: 29409 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 12:02:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in libosmo-gprs[master]: tests: reorganize llc/rlcmac specific dirs and files

by neels

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29408 ) Change subject: tests: reorganize llc/rlcmac specific dirs and files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29408 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I8592cea020dbbf64940266cd6af14b14d34be3a6 Gerrit-Change-Number: 29408 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 12:00:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in libosmo-gprs[master]: llc: osmo_gprs_llc_hdr_dump[_buf](): also print SAPI name

by neels

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29404 ) Change subject: llc: osmo_gprs_llc_hdr_dump[_buf](): also print SAPI name ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29404 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I95763e622bb3c3678c06901ddaecfc200d359d8d Gerrit-Change-Number: 29404 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 11:43:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022