September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: ipaccess-config: Initialize RSL ts driver fd to proper value

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29373 ) Change subject: ipaccess-config: Initialize RSL ts driver fd to proper value ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I19eb23a46f89b96dd8d63742ca2078ecd5c9ab6b Gerrit-Change-Number: 29373 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 14:07:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: ipaccess-config: Initiate missing IPA osmo_link

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29372 ) Change subject: ipaccess-config: Initiate missing IPA osmo_link ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/osmo-bsc/bts_ipaccess_nanobts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29372/comment/96d1b1fc_e9bc7eda PS1, Line 619: OSMO_ASSERT(bts->osmo_link); > would it make sense to assert this earlier, while using the link, not only when dropping it? the interesting path here is when dropping it, since other apps may not use it. The main problem here really is ipaccess-config reimplementing all the lowest ipa parts with its own fake code while still hooking in some middle-layer parts. But rewritting that is totally out of the scope of this patchset. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3f63f6827f7c5d7a21ac125b7ca6b35244efbb65 Gerrit-Change-Number: 29372 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 14:06:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: oml: Delay Tx of OPSTART(BBTRANSC) after rx of RSL CONNECT ACK

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29364 ) Change subject: oml: Delay Tx of OPSTART(BBTRANSC) after rx of RSL CONNECT ACK ...................................................................... Patch Set 1: Code-Review+2 (2 comments) File src/osmo-bsc/bts_ipaccess_nanobts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29364/comment/83ca420b_c246797a PS1, Line 453: LOGPFOH(DNM, LOGL_ERROR, foh, "IPACC RSL Connect ACK received on incorrect object class %d!\n", foh->obj_class); > (log string of object class? same below) the obj class string should already be printed as part of LOGPFOH, so printing the string again is not that useful. File src/osmo-bsc/nm_bb_transc_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29364/comment/50cfc49f_6b881dda PS1, Line 254: bb_transc->mo.opstart_sent = false; > (patch would look nicer without move of this line) It still makes sense to move it since it follows better the natural sequence of events on how this flags are used/set. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ief46bad5075b656c13d1f09a0724e33283148236 Gerrit-Change-Number: 29364 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 14:05:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: hnbgw: Unregister HNB if SCTP link is restarted

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29415 ) Change subject: hnbgw: Unregister HNB if SCTP link is restarted ...................................................................... hnbgw: Unregister HNB if SCTP link is restarted Sometimes an hNodeB may reconnect (SCTP INIT) using same SCTP tuple without closing the previous conn. This is handled by the SCTP stack by means of pushing a RESET notification up the stack to the sctp_recvmsg() user. Let's handle this by marking the HNB as unregistered, since most probably a HNB Register Req comes next as the upper layer state is considered lost. Depends: libosmo-netif.git Change-Id I0ee94846a15a23950b9d70eaaef1251267296bdd Related: SYS#6113 Change-Id: Ib22881b1a34b1c3dd350912b3de8904917cf34ef --- M src/osmo-hnbgw/hnbgw.c 1 file changed, 19 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/15/29415/1 diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index 8c2dc64..124a647 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -251,8 +251,25 @@ msg->dst = hnb; rc = osmo_stream_srv_recv(conn, msg); - if (rc == -EAGAIN) { - /* Notification received */ + /* Notification received */ + if (msgb_sctp_msg_flags(msg) & OSMO_STREAM_SCTP_MSG_FLAGS_NOTIFICATION) { + union sctp_notification *notif = (union sctp_notification *)msgb_data(msg); + switch (notif->sn_header.sn_type) { + case SCTP_ASSOC_CHANGE: + switch (notif->sn_assoc_change.sac_state) { + case SCTP_RESTART: + LOGHNB(hnb, DMAIN, LOGL_NOTICE, "HNB SCTP conn RESTARTed, marking as HNBAP-unregistered\n"); + hnb->hnb_registered = false; + break; + } + break; + } + msgb_free(msg); + return 0; + } else if (rc == -EAGAIN) { + /* Older versions of osmo_stream_srv_recv() not supporting + * msgb_sctp_msg_flags() may still return -EAGAIN when an sctp + * notification is received. */ msgb_free(msg); return 0; } else if (rc < 0) { -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib22881b1a34b1c3dd350912b3de8904917cf34ef Gerrit-Change-Number: 29415 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in libosmo-netif[master]: stream: Provide caller with SCTP flags during osmo_stream_*_recv()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29414 ) Change subject: stream: Provide caller with SCTP flags during osmo_stream_*_recv() ...................................................................... stream: Provide caller with SCTP flags during osmo_stream_*_recv() The user may want to check the flags in order to know if the content pointed at by msgb is an sctp_notification structure, and not in-band data. This is useful for the user in order to gain connection state such as SCTP RESET notification, which means the client reconnected reusing the same socket, loosing all higher layers state. The MSG_NOTIFICATION from netinet/sctp.h is not reused, and instead an osmocom specific flag (and bitmask) is used. This is done in order to fit the flags in one byte, since for instance MSG_NOTIFICATION requires 2 bytes in my system (0x8000). Related: SYS#6113 Change-Id: I0ee94846a15a23950b9d70eaaef1251267296bdd --- M include/osmocom/netif/stream.h M src/stream.c 2 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/14/29414/1 diff --git a/include/osmocom/netif/stream.h b/include/osmocom/netif/stream.h index b82dff1..489fc5d 100644 --- a/include/osmocom/netif/stream.h +++ b/include/osmocom/netif/stream.h @@ -9,6 +9,10 @@ * @{ */ +/*! \brief Access SCTP flags from the msgb control buffer */ +#define OSMO_STREAM_SCTP_MSG_FLAGS_NOTIFICATION 0x80 /* sctp_recvmsg() flags=MSG_NOTIFICATION, msgb_data() contains "union sctp_notification*" */ +#define msgb_sctp_msg_flags(msg) (msg)->cb[2] + /*! \brief Access the SCTP PPID from the msgb control buffer */ #define msgb_sctp_ppid(msg) (msg)->cb[3] /*! \brief Access the SCTP Stream ID from the msgb control buffer */ diff --git a/src/stream.c b/src/stream.c index bc209af..b45b730 100644 --- a/src/stream.c +++ b/src/stream.c @@ -1476,6 +1476,7 @@ if (flags & MSG_NOTIFICATION) { union sctp_notification *notif = (union sctp_notification *)msgb_data(msg); LOGP(DLINP, LOGL_DEBUG, "NOTIFICATION %u flags=0x%x\n", notif->sn_header.sn_type, notif->sn_header.sn_flags); + msgb_sctp_msg_flags(msg) = OSMO_STREAM_SCTP_MSG_FLAGS_NOTIFICATION; switch (notif->sn_header.sn_type) { case SCTP_ASSOC_CHANGE: LOGP(DLINP, LOGL_DEBUG, "===> ASSOC CHANGE:"); -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29414 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I0ee94846a15a23950b9d70eaaef1251267296bdd Gerrit-Change-Number: 29414 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-hlr[master]: Debian: bump compatibility level

by osmith

Attention is currently required from: laforge, msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/29381 ) Change subject: Debian: bump compatibility level ...................................................................... Patch Set 5: (1 comment) File debian/compat: https://gerrit.osmocom.org/c/osmo-hlr/+/29381/comment/d15ed3f5_67cb5388 PS5, Line 1: 13 > good point. let's follow up in ... […] follow up here: https://osmocom.org/issues/5685 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/29381 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Id1557cd07b5d28dbb6018cbf972ce41008b65867 Gerrit-Change-Number: 29381 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 13:09:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-hlr[master]: systemd: enable basic hardening

by msuraev

msuraev has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/29379 ) Change subject: systemd: enable basic hardening ...................................................................... systemd: enable basic hardening This ensures that systemd will not allow us to modify /home, /root and /run/user which we shouldn't be doing anyway. See https://www.freedesktop.org/software/systemd/man/systemd.exec.html for details. It should also should silence corresponding lintian warning. Related: OS#4107 Change-Id: Ida5f13bdb9e5bd956c440a381d94eecc18f0b2ef --- M contrib/systemd/osmo-hlr.service 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve msuraev: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/contrib/systemd/osmo-hlr.service b/contrib/systemd/osmo-hlr.service index aa2f281..7ab4279 100644 --- a/contrib/systemd/osmo-hlr.service +++ b/contrib/systemd/osmo-hlr.service @@ -9,6 +9,7 @@ WorkingDirectory=%S/osmocom ExecStart=/usr/bin/osmo-hlr -c /etc/osmocom/osmo-hlr.cfg -l /var/lib/osmocom/hlr.db RestartSec=2 +ProtectHome=true [Install] WantedBy=multi-user.target -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/29379 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ida5f13bdb9e5bd956c440a381d94eecc18f0b2ef Gerrit-Change-Number: 29379 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in osmo-hlr[master]: Debian: bump compatibility level

by osmith

Attention is currently required from: laforge, msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/29381 ) Change subject: Debian: bump compatibility level ...................................................................... Patch Set 5: (1 comment) File debian/compat: https://gerrit.osmocom.org/c/osmo-hlr/+/29381/comment/91b5a00e_64077a22 PS5, Line 1: 13 > According to https://wiki.debian.org/DebianReleases Debian 10 ( […] good point. let's follow up in ... until it's removed however we must make sure that it still builds for debian 10. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/29381 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Id1557cd07b5d28dbb6018cbf972ce41008b65867 Gerrit-Change-Number: 29381 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 13:09:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: ipaccess: Fix writing pcap output to fd=0 (stdin)

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29378 ) Change subject: ipaccess: Fix writing pcap output to fd=0 (stdin) ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/ipaccess/ipaccess-config.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29378/comment/aa180fb7_6ad9f616 PS1, Line 144: e1_set_pcap_fd2(line, -1); /* Disable writing to pcap */ (prefer comment on its own line) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29378 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9ee0a4c51f4f10bf71390f884d67d87b623773df Gerrit-Change-Number: 29378 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 13:02:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: ipaccess: Remove unused stub

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29377 ) Change subject: ipaccess: Remove unused stub ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29377 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I863ccad044960d3ba267fa2bbf3c697abdf596a8 Gerrit-Change-Number: 29377 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 13:00:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022