September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: ipacces-config: override gsm_bts_check_cfg() to void checking unset b...

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29376 ) Change subject: ipacces-config: override gsm_bts_check_cfg() to void checking unset bts configuration ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/29376/comment/7a8d98de_f608197e PS1, Line 7: ipacces-config: override gsm_bts_check_cfg() to void checking unset bts configuration i fail to understand this sentence Patchset: PS1: so, by setting 'weak' in libbsc, ipaccess-config can override? can this be achieved without modifying libbsc? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29376 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I22ff0d22d6dcf9b0f715bfa4e0daeb52c4028308 Gerrit-Change-Number: 29376 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 13:00:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: ipaccess-config: Exit program with error if OML link is dropped

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29375 ) Change subject: ipaccess-config: Exit program with error if OML link is dropped ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic96635f618f2efbe29ca6c59eedd1dc1f90c1a1d Gerrit-Change-Number: 29375 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 12:54:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: ipaccess-config: use available API to set e1inp_line_ops

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29374 ) Change subject: ipaccess-config: use available API to set e1inp_line_ops ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29374 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic0d248fc5d1481ad96f7af20a1a80144137c626a Gerrit-Change-Number: 29374 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 12:53:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: ipaccess-config: Initialize RSL ts driver fd to proper value

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29373 ) Change subject: ipaccess-config: Initialize RSL ts driver fd to proper value ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/ipaccess/ipaccess-config.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29373/comment/717e6345_d4395cb2 PS1, Line 151: rsl_ts->driver.ipaccess.fd.fd = -1; having the reason that is in the commit log as a comment here would be nice -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I19eb23a46f89b96dd8d63742ca2078ecd5c9ab6b Gerrit-Change-Number: 29373 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 12:53:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-hlr[master]: Debian: add osmocom user during package install

by msuraev

Attention is currently required from: osmith, laforge, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/29311 ) Change subject: Debian: add osmocom user during package install ...................................................................... Patch Set 7: (3 comments) File debian/postinst: https://gerrit.osmocom.org/c/osmo-hlr/+/29311/comment/efb8b90d_344020f7 PS7, Line 9: # install. > ...and also to OE as you mentioned. probably here: […] We have to keep our configuration files across (re)installs so DynamicUser= is certainly not an option. Regarding OE I think it's better to create the user/group via separate recipe/config instead of per-service. In case of spec/deb I think it's better to keep it on per-service level with idempotent scripts since we do not have control over which parts (and in what order) of Osmocom stack will be installed by user. https://gerrit.osmocom.org/c/osmo-hlr/+/29311/comment/63f20111_e5bb8565 PS7, Line 29: --no-create-home \ > why --no-create-home, do we already create the directory structure? We use StateDirectory as home so it's automatically created by systemd for us. https://gerrit.osmocom.org/c/osmo-hlr/+/29311/comment/11b48df4_5c18bdec PS7, Line 37: chperms root osmocom 2775 /etc/osmocom > /var/lib/osmocom/hlr.db* also need to be changed from root -> osmocom. […] The permissions for StateDirectory and its content are automatically adjusted by systemd to match unit's User/Group settings - see https://www.freedesktop.org/software/systemd/man/systemd.exec.html -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/29311 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I625c993ab03dfe32976c651acca9c35c33a768e7 Gerrit-Change-Number: 29311 Gerrit-PatchSet: 7 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 12:51:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: ipaccess-config: Initiate missing IPA osmo_link

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29372 ) Change subject: ipaccess-config: Initiate missing IPA osmo_link ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bsc/bts_ipaccess_nanobts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29372/comment/fcd8db87_b92c6716 PS1, Line 619: OSMO_ASSERT(bts->osmo_link); would it make sense to assert this earlier, while using the link, not only when dropping it? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3f63f6827f7c5d7a21ac125b7ca6b35244efbb65 Gerrit-Change-Number: 29372 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 12:51:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: oml: Delay Tx of OPSTART(BBTRANSC) after rx of RSL CONNECT ACK

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29364 ) Change subject: oml: Delay Tx of OPSTART(BBTRANSC) after rx of RSL CONNECT ACK ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/osmo-bsc/bts_ipaccess_nanobts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29364/comment/4aa65602_a5d8e33a PS1, Line 453: LOGPFOH(DNM, LOGL_ERROR, foh, "IPACC RSL Connect ACK received on incorrect object class %d!\n", foh->obj_class); (log string of object class? same below) File src/osmo-bsc/nm_bb_transc_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29364/comment/0107666e_aa660aa2 PS1, Line 254: bb_transc->mo.opstart_sent = false; (patch would look nicer without move of this line) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ief46bad5075b656c13d1f09a0724e33283148236 Gerrit-Change-Number: 29364 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 12:48:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-hlr[master]: systemd: enable basic hardening

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/29379 ) Change subject: systemd: enable basic hardening ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/29379 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ida5f13bdb9e5bd956c440a381d94eecc18f0b2ef Gerrit-Change-Number: 29379 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 12:37:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-hlr[master]: Debian: bump compatibility level

by msuraev

Attention is currently required from: osmith, laforge. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/29381 ) Change subject: Debian: bump compatibility level ...................................................................... Patch Set 5: (1 comment) File debian/compat: https://gerrit.osmocom.org/c/osmo-hlr/+/29381/comment/b9131eb7_3e96508d PS5, Line 1: 13 > We build for debian 10 too in https://obs.osmocom.org, and this is on version 12: […] According to https://wiki.debian.org/DebianReleases Debian 10 ( Buster) is EOL last month. Do we have some kind of policy regarding deprecation of package builds? -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/29381 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Id1557cd07b5d28dbb6018cbf972ce41008b65867 Gerrit-Change-Number: 29381 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 19 Sep 2022 12:37:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in libosmo-abis[master]: ipaccess: Call line->ops->sign_link_down() only if set

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/29371 ) Change subject: ipaccess: Call line->ops->sign_link_down() only if set ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29371 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I666c5bbf157fe604e336df44f7eac098572d42ba Gerrit-Change-Number: 29371 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 12:35:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022