Attention is currently required from: msuraev, dexter.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28846 )
Change subject: Make esme struct shared
......................................................................
Patch Set 22: Code-Review-1
(1 comment)
File include/osmocom/smpp/smpp.h:
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/2d0c3524_fca086cc
PS21, Line 14: esme
> Done
what is happening here? I ask a question, you mark as Done without responding; i ask your feedback again, you mark as Done again without responding. This is not acceptable handling of code review.
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28846
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70
Gerrit-Change-Number: 28846
Gerrit-PatchSet: 22
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Sep 2022 10:21:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin, dexter.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29361 )
Change subject: pcu_sock: check size of primitive
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Fine, but then please take the chance to submit fixes for the linter in a separate patch here, and a […]
in that case it would be nicer to fix linter things "first", before copying the code. i'm still ok with leaving the old code as it is.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29361
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I247c6f4b5a7a22d17a060a558c4ceb9221ca7351
Gerrit-Change-Number: 29361
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Sep 2022 10:16:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment