September 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-gprs[master]: llc: re-define value-string API as static inline functions

by pespin

Attention is currently required from: neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29440 ) Change subject: llc: re-define value-string API as static inline functions ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29440 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I1b3245f62f5182aa91dbad7958d89220f7107337 Gerrit-Change-Number: 29440 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 18:20:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in pysim[laforge/cmd2_2.4]: shell: Use a double asterisk for kwargs

by pespin

Attention is currently required from: markb, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29439 ) Change subject: shell: Use a double asterisk for kwargs ...................................................................... Patch Set 5: (1 comment) Patchset: PS3: > > No problem. […] Seems like unit tests are boken with this patch. Feel free to have a look: https://jenkins.osmocom.org/jenkins/job/gerrit-pysim/2001/a1=default,a2=def… letting someone else which is more involved with this project to see what's going on. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29439 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: laforge/cmd2_2.4 Gerrit-Change-Id: I19d28276e73e7024f64ed693c3b5e37c1344c687 Gerrit-Change-Number: 29439 Gerrit-PatchSet: 5 Gerrit-Owner: markb <markboldyrev(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: markb <markboldyrev(a)gmail.com> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 18:19:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: markb <markboldyrev(a)gmail.com> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-mgw[master]: cosmetic: vty: Fix indentation whitespace

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29441 ) Change subject: cosmetic: vty: Fix indentation whitespace ...................................................................... cosmetic: vty: Fix indentation whitespace Change-Id: I2f42707f815ca58690d86a956118b6661c59fda3 --- M src/libosmo-mgcp/mgcp_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_vty.c b/src/libosmo-mgcp/mgcp_vty.c index 796db85..f6c3c75 100644 --- a/src/libosmo-mgcp/mgcp_vty.c +++ b/src/libosmo-mgcp/mgcp_vty.c @@ -189,7 +189,7 @@ rx_packets->current, rx_bytes->current, VTY_NEWLINE, state->in_stream.err_ts_ctr->current, state->out_stream.err_ts_ctr->current, - VTY_NEWLINE, + VTY_NEWLINE, dropped_packets->current, VTY_NEWLINE, codec->payload_type, codec->rate, codec->channels, VTY_NEWLINE, codec->frame_duration_num, codec->frame_duration_den, -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29441 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I2f42707f815ca58690d86a956118b6661c59fda3 Gerrit-Change-Number: 29441 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in pysim[laforge/cmd2_2.4]: shell: Use a double asterisk for kwargs

by markb

Attention is currently required from: pespin, dexter. markb has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29439 ) Change subject: shell: Use a double asterisk for kwargs ...................................................................... Patch Set 5: (1 comment) Patchset: PS3: > No problem. I specifically meant you to update the first line, which is the one showing up in git log 😊 > > Something like "shell: Fix missing asterisk on kwargs" > > Thanks! Understood; I just added the appropriate change. I am sincerely grateful for your patience. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29439 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: laforge/cmd2_2.4 Gerrit-Change-Id: I19d28276e73e7024f64ed693c3b5e37c1344c687 Gerrit-Change-Number: 29439 Gerrit-PatchSet: 5 Gerrit-Owner: markb <markboldyrev(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 18:14:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: markb <markboldyrev(a)gmail.com> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in pysim[laforge/cmd2_2.4]: shell: Use a double asterisk for kwargs

by markb

Attention is currently required from: markb, dexter. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/29439 to look at the new patch set (#5). Change subject: shell: Use a double asterisk for kwargs ...................................................................... shell: Use a double asterisk for kwargs The missing asterisk on kwargs caused the values there to be erroneously treated as the autocomplete key ID by the cmd2 library. Related: OS#5589 Change-Id: I19d28276e73e7024f64ed693c3b5e37c1344c687 --- M pySim-shell.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/39/29439/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29439 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: laforge/cmd2_2.4 Gerrit-Change-Id: I19d28276e73e7024f64ed693c3b5e37c1344c687 Gerrit-Change-Number: 29439 Gerrit-PatchSet: 5 Gerrit-Owner: markb <markboldyrev(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: markb <markboldyrev(a)gmail.com> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 9 months

1
0
0 0

Change in pysim[laforge/cmd2_2.4]: Use a double asterisk for kwargs

by markb

Attention is currently required from: markb, dexter. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/29439 to look at the new patch set (#4). Change subject: Use a double asterisk for kwargs ...................................................................... Use a double asterisk for kwargs The missing asterisk on kwargs caused the values there to be erroneously treated as the autocomplete key ID by the cmd2 library. Related: OS#5589 Change-Id: I19d28276e73e7024f64ed693c3b5e37c1344c687 --- M pySim-shell.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/39/29439/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29439 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: laforge/cmd2_2.4 Gerrit-Change-Id: I19d28276e73e7024f64ed693c3b5e37c1344c687 Gerrit-Change-Number: 29439 Gerrit-PatchSet: 4 Gerrit-Owner: markb <markboldyrev(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: markb <markboldyrev(a)gmail.com> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 9 months

1
0
0 0

Change in osmo-mgw[master]: cosmetic: vty: Fix indentation whitespace

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29441 ) Change subject: cosmetic: vty: Fix indentation whitespace ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29441 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I2f42707f815ca58690d86a956118b6661c59fda3 Gerrit-Change-Number: 29441 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 18:10:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: Drop Osmux call setup if BTS didn't provide a remote CID

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29435 ) Change subject: Drop Osmux call setup if BTS didn't provide a remote CID ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29435 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia90e8e0d18193d64c0fa0788dbd0eb242a359b61 Gerrit-Change-Number: 29435 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 18:08:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: cosmetic: vty: Fix formatting of if-else brackets

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29436 ) Change subject: cosmetic: vty: Fix formatting of if-else brackets ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29436 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7210616bc293913e5efec14eb52aeafb37f1244f Gerrit-Change-Number: 29436 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 18:08:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: vty: Print Osmux CID on lchans using Osmux

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29437 ) Change subject: vty: Print Osmux CID on lchans using Osmux ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29437 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6829949c888c0bcd989311219e10330bc97b2152 Gerrit-Change-Number: 29437 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 18:08:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022