September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: jobs: enable ttcn3-upf-test

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/29446 ) Change subject: jobs: enable ttcn3-upf-test ...................................................................... jobs: enable ttcn3-upf-test Related: I7a651bb85861de4b2677a731b9f17fa0d790c621 (docker-playground) Change-Id: I5964979b3db86268f6011df0afbee7131557f405 --- M jobs/ttcn3-testsuites.yml 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/46/29446/1 diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index e8420ec..fb2a6ec 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -146,7 +146,6 @@ - ttcn3-upf-test: blocking: "^(ttcn3|TTCN3-.*)-upf-test.*" timer: 00 13 * * * - disabled: true - ttcn3-hnbgw-test: blocking: "^(ttcn3|TTCN3-.*)-hnbgw-test.*" timer: 40 13 * * * -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29446 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5964979b3db86268f6011df0afbee7131557f405 Gerrit-Change-Number: 29446 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in docker-playground[master]: add osmo-upf-master

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/29444 ) Change subject: add osmo-upf-master ...................................................................... add osmo-upf-master Will be used by ttcn3-upf-test in subsequent patch I7a651bb85861de4b2677a731b9f17fa0d790c621. Change-Id: Iceec912eef05bf4903ccc1fc30b0c7362145a1f1 --- A osmo-upf-master/Dockerfile A osmo-upf-master/Makefile A osmo-upf-master/osmo-upf.cfg 3 files changed, 61 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/44/29444/1 diff --git a/osmo-upf-master/Dockerfile b/osmo-upf-master/Dockerfile new file mode 100644 index 0000000..7c5c1e6 --- /dev/null +++ b/osmo-upf-master/Dockerfile @@ -0,0 +1,50 @@ +ARG USER +ARG DISTRO +FROM $USER/$DISTRO-build +# Arguments used after FROM must be specified again +ARG DISTRO + +RUN case "$DISTRO" in \ + debian*) \ + apt-get update && \ + apt-get install -y --no-install-recommends \ + libosmocore-dev \ + libgtpnl-dev \ + libnftables-dev \ + libosmo-pfcp-dev \ + && apt-get clean \ + ;; \ + centos*) \ + dnf install -y \ + "pkgconfig(libgtpnl)" \ + "pkgconfig(libnftables)" \ + "pkgconfig(libosmocore)" \ + "pkgconfig(libosmoctrl)" \ + "pkgconfig(libosmovty)" \ + "pkgconfig(libosmo-pfcp)" \ + ;; \ + esac + +WORKDIR /tmp + +ARG OSMO_UPF_BRANCH="master" + +RUN git clone git://git.osmocom.org/osmo-upf.git +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-upf/+/refs/heads/$OSMO_UPF_… /tmp/commit-osmo-upf + +RUN cd osmo-upf && \ + git fetch && git checkout $OSMO_UPF_BRANCH && \ + (git symbolic-ref -q HEAD && git reset --hard origin/$OSMO_UPF_BRANCH || exit 1); \ + git rev-parse --abbrev-ref HEAD && git rev-parse HEAD && \ + autoreconf -fi && \ + ./configure && \ + make "-j$(nproc)" install + +VOLUME /data + +COPY osmo-upf.cfg /data/osmo-upf.cfg + +WORKDIR /data +CMD ["/bin/sh", "-c", "/usr/local/bin/osmo-upf -c /data/osmo-upf.cfg >/data/osmo-upf.log 2>&1"] + +#EXPOSE diff --git a/osmo-upf-master/Makefile b/osmo-upf-master/Makefile new file mode 100644 index 0000000..3667084 --- /dev/null +++ b/osmo-upf-master/Makefile @@ -0,0 +1,3 @@ +RUN_ARGS?=--rm --network sigtran --ip 172.18.0.23 -v upf-vol:/data + +include ../make/Makefile diff --git a/osmo-upf-master/osmo-upf.cfg b/osmo-upf-master/osmo-upf.cfg new file mode 100644 index 0000000..5ece4b8 --- /dev/null +++ b/osmo-upf-master/osmo-upf.cfg @@ -0,0 +1,8 @@ +log stderr + logging filter all 1 + logging color 1 + logging print category 0 + logging timestamp 0 + logging level set-all notice +gtp + dev create apn23 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29444 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iceec912eef05bf4903ccc1fc30b0c7362145a1f1 Gerrit-Change-Number: 29444 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in docker-playground[master]: add ttcn3-upf-test

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/29445 ) Change subject: add ttcn3-upf-test ...................................................................... add ttcn3-upf-test Related: I43cd55c9395f2c706369afe1a9a7f475be47339f (osmo-ci) Related: I5964979b3db86268f6011df0afbee7131557f405 (osmo-ci) Change-Id: I7a651bb85861de4b2677a731b9f17fa0d790c621 --- A ttcn3-upf-test/Dockerfile A ttcn3-upf-test/Makefile A ttcn3-upf-test/UPF_Tests.cfg A ttcn3-upf-test/jenkins.sh A ttcn3-upf-test/osmo-upf.cfg 5 files changed, 104 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/45/29445/1 diff --git a/ttcn3-upf-test/Dockerfile b/ttcn3-upf-test/Dockerfile new file mode 100644 index 0000000..addc43f --- /dev/null +++ b/ttcn3-upf-test/Dockerfile @@ -0,0 +1,13 @@ +ARG REGISTRY +ARG USER +FROM $REGISTRY/$USER/debian-bullseye-titan +ARG OSMO_TTCN3_BRANCH="master" + +ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit +RUN ttcn3-docker-prepare "$OSMO_TTCN3_BRANCH" upf + +VOLUME /data + +COPY UPF_Tests.cfg /data/UPF_Tests.cfg + +CMD ttcn3-docker-run upf UPF_Tests diff --git a/ttcn3-upf-test/Makefile b/ttcn3-upf-test/Makefile new file mode 100644 index 0000000..207d0f1 --- /dev/null +++ b/ttcn3-upf-test/Makefile @@ -0,0 +1,3 @@ +RUN_ARGS?=-it --sysctl net.ipv6.conf.all.disable_ipv6=0 --network sigtran --ip 172.18.34.202 + +include ../make/Makefile diff --git a/ttcn3-upf-test/UPF_Tests.cfg b/ttcn3-upf-test/UPF_Tests.cfg new file mode 100644 index 0000000..0b794e7 --- /dev/null +++ b/ttcn3-upf-test/UPF_Tests.cfg @@ -0,0 +1,25 @@ +[ORDERED_INCLUDE] +"/osmo-ttcn3-hacks/Common.cfg" +"/osmo-ttcn3-hacks/upf/UPF_Tests.default" + +[LOGGING] +*.JUnitLogger.testsuite_name := "UPF_Tests" + +# Local configuration below + +[LOGGING] + +[TESTPORT_PARAMETERS] +*.UPFVTY.CTRL_HOSTNAME := "172.18.34.20"; +*.STATSVTY.CTRL_HOSTNAME := "172.18.34.20"; + +[MODULE_PARAMETERS] +UPF_Tests.mp_pfcp_ip_upf := "172.18.34.20"; +UPF_Tests.mp_pfcp_ip_local := "172.18.34.203"; + +UPF_Tests.mp_verify_gtp_actions := false; + +[MAIN_CONTROLLER] + +[EXECUTE] +UPF_Tests.control diff --git a/ttcn3-upf-test/jenkins.sh b/ttcn3-upf-test/jenkins.sh new file mode 100755 index 0000000..2fb6d43 --- /dev/null +++ b/ttcn3-upf-test/jenkins.sh @@ -0,0 +1,39 @@ +#!/bin/sh + +. ../jenkins-common.sh +IMAGE_SUFFIX="${IMAGE_SUFFIX:-master}" +docker_images_require \ + "osmo-upf-$IMAGE_SUFFIX" \ + "ttcn3-upf-test" + +set_clean_up_trap +set -e + +mkdir $VOL_BASE_DIR/upf-tester +cp UPF_Tests.cfg $VOL_BASE_DIR/upf-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/upf-tester/UPF_Tests.cfg" + +mkdir $VOL_BASE_DIR/upf +cp osmo-upf.cfg $VOL_BASE_DIR/upf/ + +SUBNET=34 +network_create $SUBNET + +echo Starting container with UPF +docker run --rm \ + $(docker_network_params $SUBNET 20) \ + --ulimit core=-1 \ + -v $VOL_BASE_DIR/upf:/data \ + --name ${BUILD_TAG}-upf -d \ + $DOCKER_ARGS \ + $REPO_USER/osmo-upf-$IMAGE_SUFFIX + +echo Starting container with UPF testsuite +docker run --rm \ + $(docker_network_params $SUBNET 203) \ + --ulimit core=-1 \ + -e "TTCN3_PCAP_PATH=/data" \ + -v $VOL_BASE_DIR/upf-tester:/data \ + --name ${BUILD_TAG}-ttcn3-upf-test \ + $DOCKER_ARGS \ + $REPO_USER/ttcn3-upf-test diff --git a/ttcn3-upf-test/osmo-upf.cfg b/ttcn3-upf-test/osmo-upf.cfg new file mode 100644 index 0000000..39aaeb7 --- /dev/null +++ b/ttcn3-upf-test/osmo-upf.cfg @@ -0,0 +1,24 @@ +log stderr + logging filter all 1 + logging color 1 + logging print category-hex 0 + logging print category 1 + logging print thread-id 0 + logging print extended-timestamp 1 + logging print level 1 + logging print file basename last + logging level set-all debug +log gsmtap 172.18.34.203 + logging level set-all debug + logging filter all 1 +line vty + no login + bind 0.0.0.0 +ctrl + bind 0.0.0.0 +pfcp + local-addr 172.18.34.20 +gtp + mockup +nft + mockup -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29445 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I7a651bb85861de4b2677a731b9f17fa0d790c621 Gerrit-Change-Number: 29445 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in docker-playground[master]: .gitignore vim swp files

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/29443 ) Change subject: .gitignore vim swp files ...................................................................... .gitignore vim swp files Change-Id: I5e67c42271aca9f81711e166324f70663e34cfcf --- M .gitignore 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/43/29443/1 diff --git a/.gitignore b/.gitignore index fe1b979..58a1b04 100644 --- a/.gitignore +++ b/.gitignore @@ -8,3 +8,5 @@ /release-tarball-build-dist/_release_tarballs /release-tarball-build-dist/_temp + +.*.sw? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29443 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5e67c42271aca9f81711e166324f70663e34cfcf Gerrit-Change-Number: 29443 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in libosmo-gprs[master]: llc: make logging category configurable

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29442 ) Change subject: llc: make logging category configurable ...................................................................... llc: make logging category configurable Similar to Icfef6de126304da81120f1d7b212992ead3409aa, let's add osmo_gprs_llc_set_log_cat() allowing the API users to change logging category for libosmo-gprs-llc (DLGLOBAL is default). Change-Id: I9deb794db1c80257ba81523f815232208381bc27 --- M include/osmocom/gprs/llc/llc.h M src/llc/Makefile.am M src/llc/llc_pdu.c A src/llc/misc.c 4 files changed, 36 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/42/29442/1 diff --git a/include/osmocom/gprs/llc/llc.h b/include/osmocom/gprs/llc/llc.h index 4723a4b..510b11c 100644 --- a/include/osmocom/gprs/llc/llc.h +++ b/include/osmocom/gprs/llc/llc.h @@ -145,3 +145,5 @@ int osmo_gprs_llc_pdu_encode(struct msgb *msg, const struct osmo_gprs_llc_pdu_decoded *pdu); uint32_t osmo_gprs_llc_fcs(const uint8_t *data, size_t len); + +void osmo_gprs_llc_set_log_cat(int cat); diff --git a/src/llc/Makefile.am b/src/llc/Makefile.am index e24a3b3..a301a89 100644 --- a/src/llc/Makefile.am +++ b/src/llc/Makefile.am @@ -24,6 +24,7 @@ libosmo_gprs_llc_la_SOURCES = \ crc24.c \ llc_pdu.c \ + misc.c \ $(NULL) libosmo_gprs_llc_la_LDFLAGS = \ diff --git a/src/llc/llc_pdu.c b/src/llc/llc_pdu.c index e55e311..5430377 100644 --- a/src/llc/llc_pdu.c +++ b/src/llc/llc_pdu.c @@ -29,13 +29,12 @@ #include <osmocom/gprs/llc/llc.h> -/* TODO: make logging category configurable */ -#define DLLC DLGLOBAL - #define UI_HDR_LEN 3 #define N202 4 #define CRC24_LENGTH 3 +extern int g_log_cat; + const struct value_string osmo_gprs_llc_sapi_names[] = { { OSMO_GPRS_LLC_SAPI_GMM, "GMM" }, { OSMO_GPRS_LLC_SAPI_TOM2, "TOM2" }, @@ -254,7 +253,7 @@ ctrl[0] |= GPRS_LLC_U_XID; break; default: - LOGP(DLLC, LOGL_ERROR, + LOGP(g_log_cat, LOGL_ERROR, "Unknown UI func=0x%02x\n", pdu->func); return -EINVAL; } @@ -269,7 +268,7 @@ /* 5.5a Message Authentication Code (MAC) field */ if (pdu->flags & OSMO_GPRS_LLC_PDU_F_MAC_PRES) { /* TODO: calculate MAC (see 3GPP TS 43.020) */ - LOGP(DLLC, LOGL_ERROR, + LOGP(g_log_cat, LOGL_ERROR, "Message Authentication Code (MAC) is not implemented\n"); return -ENOTSUP; } @@ -296,7 +295,7 @@ #define check_len(len, text) \ do { \ if (data_len < (len)) { \ - LOGP(DLLC, LOGL_ERROR, "Failed to parse LLC PDU: %s\n", text); \ + LOGP(g_log_cat, LOGL_ERROR, "Failed to parse LLC PDU: %s\n", text); \ return -EINVAL; \ } \ } while (0) @@ -317,7 +316,7 @@ /* 6.2.1 Protocol Discriminator bit (PD): shall be 0 */ if (*addr & 0x80) { - LOGP(DLLC, LOGL_ERROR, "Protocol Discriminator shall be 0\n"); + LOGP(g_log_cat, LOGL_ERROR, "Protocol Discriminator shall be 0\n"); return -EINVAL; } @@ -337,7 +336,7 @@ case 0x0c: case 0x0d: case 0x0f: - LOGP(DLLC, LOGL_ERROR, "Unknown SAPI=%u\n", pdu->sapi); + LOGP(g_log_cat, LOGL_ERROR, "Unknown SAPI=%u\n", pdu->sapi); return -EINVAL; } @@ -486,7 +485,7 @@ pdu->data_len = data_len; break; default: - LOGP(DLLC, LOGL_ERROR, "Unknown U func=0x%02x\n", ctrl[0] & 0x0f); + LOGP(g_log_cat, LOGL_ERROR, "Unknown U func=0x%02x\n", ctrl[0] & 0x0f); return -ENOTSUP; } } diff --git a/src/llc/misc.c b/src/llc/misc.c new file mode 100644 index 0000000..06e2a6c --- /dev/null +++ b/src/llc/misc.c @@ -0,0 +1,25 @@ +/* + * (C) 2022 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> + * Author: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> + * + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <osmocom/core/logging.h> + +int g_log_cat = DLGLOBAL; + +void osmo_gprs_llc_set_log_cat(int cat) +{ + g_log_cat = cat; +} -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29442 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I9deb794db1c80257ba81523f815232208381bc27 Gerrit-Change-Number: 29442 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in libosmo-gprs[master]: llc: implement LLC PDU codec based on code from osmo-sgsn.git

by fixeria

Attention is currently required from: neels, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 ) Change subject: llc: implement LLC PDU codec based on code from osmo-sgsn.git ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > why aren't you fixing the linter wrarnings? I explained a few times already... Will do this one more time: * Acknowledgement vs Acknowledgment - both spellings are technically correct. 3GPP TS 44.064 uses British spelling, the linter suggests the American spelling. In this case I prefer to have the same spelling as in the specs. * const * const - "should" does not mean must. It's a unit test, and I don't really care whether the test vectors end up in RODATA. It would actually be the first time for me using 'const * const', I don't remember anybody strictly requiring this during code review. None of this is critical. I am not going to spend more time on this. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I61d7e2e6d0a8f2cdfc2113e637e447dc428cc70d Gerrit-Change-Number: 29402 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 18:43:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bts[master]: vty: Print Osmux CID on lchans using Osmux

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29438 ) Change subject: vty: Print Osmux CID on lchans using Osmux ...................................................................... Patch Set 1: (2 comments) File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/29438/comment/2b4dddf4_e80ff919 PS1, Line 1952: 02x Unrelated change? https://gerrit.osmocom.org/c/osmo-bts/+/29438/comment/d4749cab_ee7a882d PS1, Line 1955: if (lchan->abis_ip.osmux.use) { Curly braces can be dropped here. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29438 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ide6edefda828e9ce04fbb60cf547857f322d5f40 Gerrit-Change-Number: 29438 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 18:33:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in pysim[laforge/cmd2_2.4]: shell: Use a double asterisk for kwargs

by Mark Boldyrev

Attention is currently required from: laforge, pespin, dexter. Mark Boldyrev has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29439 ) Change subject: shell: Use a double asterisk for kwargs ...................................................................... Patch Set 5: (1 comment) Patchset: PS3: > Seems like unit tests are boken with this patch. Feel free to have a look: > https://jenkins.osmocom.org/jenkins/job/gerrit-pysim/2001/a1=default,a2=def… > > letting someone else which is more involved with this project to see what's going on. I just added laforge to the assignee list since the issue was personally discussed with them elsewhere. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29439 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: laforge/cmd2_2.4 Gerrit-Change-Id: I19d28276e73e7024f64ed693c3b5e37c1344c687 Gerrit-Change-Number: 29439 Gerrit-PatchSet: 5 Gerrit-Owner: Mark Boldyrev <markboldyrev(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 18:32:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Mark Boldyrev <markboldyrev(a)gmail.com> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in pysim[laforge/cmd2_2.4]: shell: Use a double asterisk for kwargs

by fixeria

Attention is currently required from: Mark Boldyrev, laforge, pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29439 ) Change subject: shell: Use a double asterisk for kwargs ...................................................................... Patch Set 5: (1 comment) Patchset: PS3: > Seems like unit tests are boken with this patch. Feel free to have a look: […] You need to modify contrib/jenkins.sh. Currently it installs cmd2==1.5. BTW, there is also: https://cgit.osmocom.org/pysim/log/?h=fixeria/cmd2 which works for me. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29439 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: laforge/cmd2_2.4 Gerrit-Change-Id: I19d28276e73e7024f64ed693c3b5e37c1344c687 Gerrit-Change-Number: 29439 Gerrit-PatchSet: 5 Gerrit-Owner: Mark Boldyrev <markboldyrev(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Mark Boldyrev <markboldyrev(a)gmail.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 18:30:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Mark Boldyrev <markboldyrev(a)gmail.com> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in libosmo-gprs[master]: llc: implement LLC PDU codec based on code from osmo-sgsn.git

by pespin

Attention is currently required from: neels, laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 ) Change subject: llc: implement LLC PDU codec based on code from osmo-sgsn.git ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: why aren't you fixing the linter wrarnings? -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I61d7e2e6d0a8f2cdfc2113e637e447dc428cc70d Gerrit-Change-Number: 29402 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 18:22:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022