September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-mgw[master]: cosmetic: vty: Fix indentation whitespace

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29441 ) Change subject: cosmetic: vty: Fix indentation whitespace ...................................................................... cosmetic: vty: Fix indentation whitespace Change-Id: I2f42707f815ca58690d86a956118b6661c59fda3 --- M src/libosmo-mgcp/mgcp_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/41/29441/1 diff --git a/src/libosmo-mgcp/mgcp_vty.c b/src/libosmo-mgcp/mgcp_vty.c index 796db85..f6c3c75 100644 --- a/src/libosmo-mgcp/mgcp_vty.c +++ b/src/libosmo-mgcp/mgcp_vty.c @@ -189,7 +189,7 @@ rx_packets->current, rx_bytes->current, VTY_NEWLINE, state->in_stream.err_ts_ctr->current, state->out_stream.err_ts_ctr->current, - VTY_NEWLINE, + VTY_NEWLINE, dropped_packets->current, VTY_NEWLINE, codec->payload_type, codec->rate, codec->channels, VTY_NEWLINE, codec->frame_duration_num, codec->frame_duration_den, -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29441 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I2f42707f815ca58690d86a956118b6661c59fda3 Gerrit-Change-Number: 29441 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in pysim[laforge/cmd2_2.4]: Resolve #5589

by pespin

Attention is currently required from: markb, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29439 ) Change subject: Resolve #5589 ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > That is correct. I am new to Gerrit and Redmine and apologize for the inconvenience. […] No problem. I specifically meant you to update the first line, which is the one showing up in git log 😊 Something like "shell: Fix missing asterisk on kwargs" Thanks! -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29439 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: laforge/cmd2_2.4 Gerrit-Change-Id: I19d28276e73e7024f64ed693c3b5e37c1344c687 Gerrit-Change-Number: 29439 Gerrit-PatchSet: 3 Gerrit-Owner: markb <markboldyrev(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: markb <markboldyrev(a)gmail.com> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 18:05:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: markb <markboldyrev(a)gmail.com> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in libosmo-gprs[master]: llc: implement LLC PDU codec based on code from osmo-sgsn.git

by fixeria

Attention is currently required from: neels, laforge, pespin. fixeria has removed Jenkins Builder from this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 ) Change subject: llc: implement LLC PDU codec based on code from osmo-sgsn.git ...................................................................... Removed reviewer Jenkins Builder with the following votes: * Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I61d7e2e6d0a8f2cdfc2113e637e447dc428cc70d Gerrit-Change-Number: 29402 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: deleteReviewer

2 years, 9 months

1
0
0 0

Change in libosmo-gprs[master]: llc: implement LLC PDU codec based on code from osmo-sgsn.git

by fixeria

Attention is currently required from: neels, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 ) Change subject: llc: implement LLC PDU codec based on code from osmo-sgsn.git ...................................................................... Patch Set 3: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I61d7e2e6d0a8f2cdfc2113e637e447dc428cc70d Gerrit-Change-Number: 29402 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 18:05:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in libosmo-gprs[master]: llc: implement LLC PDU codec based on code from osmo-sgsn.git

by Jenkins Builder

Attention is currently required from: neels, pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 ) Change subject: llc: implement LLC PDU codec based on code from osmo-sgsn.git ...................................................................... Patch Set 3: (2 comments) File include/osmocom/gprs/llc/llc.h: Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-gprs-lint-58): https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/b19029b2_a7bd18f6 PS3, Line 135: #define OSMO_GPRS_LLC_PDU_F_ACK_REQ (1 << 2) /* 6.3.5.2 Acknowledgement request bit (A) */ 'Acknowledgement' may be misspelled - perhaps 'Acknowledgment'? File tests/llc_pdu_codec/pdu_codec_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-gprs-lint-58): https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/fb066c00_a515678c PS3, Line 31: static const char *testData[] = { static const char * array should probably be static const char * const -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I61d7e2e6d0a8f2cdfc2113e637e447dc428cc70d Gerrit-Change-Number: 29402 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 18:03:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in libosmo-gprs[master]: llc: re-define value-string API as static inline functions

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29440 ) Change subject: llc: re-define value-string API as static inline functions ...................................................................... llc: re-define value-string API as static inline functions Using static inline functions allows for type checking at compile-time. Change-Id: I1b3245f62f5182aa91dbad7958d89220f7107337 Fixes: I6d0e1a878fb80c57a901da08798620a6ea4471a4 --- M include/osmocom/gprs/llc/llc.h 1 file changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/40/29440/1 diff --git a/include/osmocom/gprs/llc/llc.h b/include/osmocom/gprs/llc/llc.h index b035acc..aa11634 100644 --- a/include/osmocom/gprs/llc/llc.h +++ b/include/osmocom/gprs/llc/llc.h @@ -27,8 +27,10 @@ extern const struct value_string osmo_gprs_llc_frame_fmt_names[]; -#define osmo_gprs_llc_frame_fmt_name(val) \ - get_value_string(osmo_gprs_llc_frame_fmt_names, val) +static inline const char *osmo_gprs_llc_frame_fmt_name(enum osmo_gprs_llc_frame_fmt val) +{ + return get_value_string(osmo_gprs_llc_frame_fmt_names, val); +} /* Section 6.4 Commands and responses */ enum osmo_gprs_llc_frame_func { @@ -52,8 +54,10 @@ extern const struct value_string osmo_gprs_llc_frame_func_names[]; -#define osmo_gprs_llc_frame_func_name(val) \ - get_value_string(osmo_gprs_llc_frame_func_names, val) +static inline const char *osmo_gprs_llc_frame_func_name(enum osmo_gprs_llc_frame_func val) +{ + return get_value_string(osmo_gprs_llc_frame_func_names, val); +} /* Section 6.4.1.6 / Table 6 */ enum osmo_gprs_llc_xid_type { -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29440 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I1b3245f62f5182aa91dbad7958d89220f7107337 Gerrit-Change-Number: 29440 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in libosmo-gprs[master]: llc: add struct value_string osmo_gprs_llc_sapi_names[]

by fixeria

Attention is currently required from: neels, pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29403 to look at the new patch set (#3). Change subject: llc: add struct value_string osmo_gprs_llc_sapi_names[] ...................................................................... llc: add struct value_string osmo_gprs_llc_sapi_names[] Change-Id: I8ae048ab9e6b63697951fa3f74ce671c88328f5f --- M include/osmocom/gprs/llc/llc.h M src/llc/llc_pdu.c 2 files changed, 19 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/03/29403/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29403 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I8ae048ab9e6b63697951fa3f74ce671c88328f5f Gerrit-Change-Number: 29403 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 9 months

1
0
0 0

Change in libosmo-gprs[master]: llc: implement LLC PDU codec based on code from osmo-sgsn.git

by fixeria

Attention is currently required from: neels, pespin. fixeria has uploaded a new patch set (#3). ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 ) Change subject: llc: implement LLC PDU codec based on code from osmo-sgsn.git ...................................................................... llc: implement LLC PDU codec based on code from osmo-sgsn.git osmo-sgsn.git 13ccbc1e6120fe78f6f9f950d7242090920ca41b Change-Id: I61d7e2e6d0a8f2cdfc2113e637e447dc428cc70d --- M configure.ac M include/osmocom/gprs/llc/llc.h M src/llc/llc_pdu.c M tests/Makefile.am A tests/llc_pdu_codec/Makefile.am A tests/llc_pdu_codec/pdu_codec_test.c A tests/llc_pdu_codec/pdu_codec_test.err A tests/llc_pdu_codec/pdu_codec_test.ok M tests/testsuite.at 9 files changed, 626 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/02/29402/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I61d7e2e6d0a8f2cdfc2113e637e447dc428cc70d Gerrit-Change-Number: 29402 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 9 months

1
0
0 0

Change in libosmo-gprs[master]: tests: reorganize llc/rlcmac specific dirs and files

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, neels, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29408 to look at the new patch set (#2). Change subject: tests: reorganize llc/rlcmac specific dirs and files ...................................................................... tests: reorganize llc/rlcmac specific dirs and files Change-Id: I8592cea020dbbf64940266cd6af14b14d34be3a6 --- M configure.ac M tests/Makefile.am R tests/llc/Makefile.am R tests/llc/pdu_codec_test.c R tests/llc/pdu_codec_test.err R tests/llc/pdu_codec_test.ok R tests/rlcmac/Makefile.am R tests/rlcmac/ts_44_018_test.c R tests/rlcmac/ts_44_018_test.err R tests/rlcmac/ts_44_018_test.ok R tests/rlcmac/ts_44_060_test.c R tests/rlcmac/ts_44_060_test.err R tests/rlcmac/ts_44_060_test.ok M tests/testsuite.at D tests/ts_44_060/Makefile.am 15 files changed, 24 insertions(+), 42 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/08/29408/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29408 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I8592cea020dbbf64940266cd6af14b14d34be3a6 Gerrit-Change-Number: 29408 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 9 months

1
0
0 0

Change in libosmo-gprs[master]: llc: implement LLC PDU codec based on code from osmo-sgsn.git

by fixeria

Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 ) Change subject: llc: implement LLC PDU codec based on code from osmo-sgsn.git ...................................................................... Patch Set 2: (6 comments) File src/llc/llc_pdu.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/df71591c_ac7c1ae1 PS2, Line 80: void osmo_gprs_llc_pdu_hdr_dump_buf(const struct osmo_gprs_llc_pdu_decoded *pdu, > Ack, will do in the next patch set. Done https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/066162ca_fcad0f43 PS2, Line 144: addr[0] |= pdu->sapi & 0x0f; > Ack Done https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/36b3be82_eb6cd1a2 PS2, Line 166: OSMO_ASSERT(pdu->sack.len > 0); > hmm, mildly disagree with OSMO_ASSERT() in a library function, would be more polite to return an err […] Done https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/48b67f10_1820e698 PS2, Line 293: check_len(sizeof(*addr), "missing Address field"); > addr being a uint8_t*, sizeof(*addr) is a very elaborate and possibly confusing way to write "1". […] Done https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/bc5ce49e_b540743d PS2, Line 326: check_len(sizeof(*ctrl), "missing Control field"); > s/sizeof(*ctrl)/1 Done File tests/llc_pdu_codec/pdu_codec_test.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/345325ad_425f053a PS2, Line 66: struct msgb *msg = msgb_alloc(1024, "LLC-PDU"); > ... so that the code looks more like Pascal ;) […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I61d7e2e6d0a8f2cdfc2113e637e447dc428cc70d Gerrit-Change-Number: 29402 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 18:02:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022