September 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-gprs[master]: llc: add struct value_string osmo_gprs_llc_sapi_names[]

by laforge

Attention is currently required from: neels, fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29403 ) Change subject: llc: add struct value_string osmo_gprs_llc_sapi_names[] ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29403 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I8ae048ab9e6b63697951fa3f74ce671c88328f5f Gerrit-Change-Number: 29403 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Sep 2022 06:26:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in libosmo-gprs[master]: llc: re-define value-string API as static inline functions

by laforge

Attention is currently required from: neels, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29440 ) Change subject: llc: re-define value-string API as static inline functions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29440 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I1b3245f62f5182aa91dbad7958d89220f7107337 Gerrit-Change-Number: 29440 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Sep 2022 06:26:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-tetra[master]: Support parsing of multiple mac resources in the same timeslot

by laforge

Attention is currently required from: wbokslag. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/29388 ) Change subject: Support parsing of multiple mac resources in the same timeslot ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/29388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: Ic2956a5f10cffe296b76a290a0d16f45461eb2e7 Gerrit-Change-Number: 29388 Gerrit-PatchSet: 5 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Comment-Date: Thu, 22 Sep 2022 06:25:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-tetra[master]: added support for fill bits and basic link defragmentation (also than...

by laforge

Attention is currently required from: wbokslag. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/29387 ) Change subject: added support for fill bits and basic link defragmentation (also thanks to SQ5BPF) ...................................................................... Patch Set 3: (3 comments) File src/tetra_upper_mac.h: https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/fd4e73ca_93018ea3 PS3, Line 13: in > You're right, it's kind of underdocumented. I'll make sure to annotate the fields. […] this probably shows how our practices have evolved during the last decade. using bool in C might not have been advisable with comlers used 10+ years ago, but today it clearly is the right thing. please modify, thanks! File src/tetra_upper_mac.c: https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/7e02e433_691dc283 PS3, Line 44: s > The lower mac allocates a global context structure tetra_cell_data with global pointer tcd. […] OK, then lets keep the global/static variables for now, but add a TODO comment that this actualY should be in some context https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/68417ba3_a33b8cf0 PS3, Line 50: fragslots[i].msgb = msgb_alloc(FRAGSLOT_MSGB_SIZE, "fragslot"); > You're right, I could allocate them on demand, whenever a fragmented resource is encountered on a slot. I'll do that in the next patch set I'm not saying it must be done that way, was just wondering if there was some specific reason. -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/29387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I41c9438b0b12c2fac9dff1b226eec5b33f30fbb4 Gerrit-Change-Number: 29387 Gerrit-PatchSet: 3 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Comment-Date: Thu, 22 Sep 2022 06:24:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: wbokslag <w.bokslag(a)midnightblue.nl> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: RSL: look up lchan by sign_link, not trx, for VAMOS

by neels

neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24378 ) Change subject: RSL: look up lchan by sign_link, not trx, for VAMOS ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24378 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I872a3ed9ce0cdbd9fbe41a750081f54008eece8d Gerrit-Change-Number: 24378 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: speed up py tests: add --fast-shutdown option to osmo-bsc

by neels

neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21206 ) Change subject: speed up py tests: add --fast-shutdown option to osmo-bsc ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I506349c532b13751f674e4b9a132219d823f19e1 Gerrit-Change-Number: 21206 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

2 years, 9 months

1
0
0 0

Change in libosmocore[master]: use osmo_static_string() instead of numerous static buffers

by neels

neels has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/13062 ) Change subject: use osmo_static_string() instead of numerous static buffers ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/13062 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id0eab72fa71630c8eb9edafaa370a41ca16329aa Gerrit-Change-Number: 13062 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

2 years, 9 months

1
0
0 0

Change in osmo-msc[master]: jenkins: always enable -Werror

by neels

neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/12263 ) Change subject: jenkins: always enable -Werror ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/12263 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If7cf70641114482b42b36489ec8562e5c069825b Gerrit-Change-Number: 12263 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

2 years, 9 months

1
0
0 0

Change in libosmocore[master]: NOT FOR MERGE: test ip_port.c tweaks on ARM

by neels

neels has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/13140 ) Change subject: NOT FOR MERGE: test ip_port.c tweaks on ARM ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/13140 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I64e372d73d48641494838feddf2b7ba2189ed7f8 Gerrit-Change-Number: 13140 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

2 years, 9 months

1
0
0 0

Change in libosmocore[master]: add osmo_string_ringbuffer and osmo_static_string() API

by neels

neels has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/13061 ) Change subject: add osmo_string_ringbuffer and osmo_static_string() API ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/13061 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I48f8951de4d209d4cd3ca1aa9ce6137918913125 Gerrit-Change-Number: 13061 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022