September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: lint: accept BE spelling of 'acknowledgement'
by pespin 22 Sep '22

22 Sep '22

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29449 ) Change subject: lint: accept BE spelling of 'acknowledgement' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29449 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia1a08295a7c7ed6a77f0055d66a161423d8f17f0 Gerrit-Change-Number: 29449 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Sep 2022 11:30:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: lint: ignore STATIC_CONST_CHAR_ARRAY
by pespin 22 Sep '22

22 Sep '22

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29448 ) Change subject: lint: ignore STATIC_CONST_CHAR_ARRAY ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: why not following this? what's the rationale behind disabling this? -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29448 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I09eecd9382842293ab231eb9cc92756fbe7723c1 Gerrit-Change-Number: 29448 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Sep 2022 11:29:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: vty: Fix SPEECH_MODE printed with hex prefix but dec value
by pespin 22 Sep '22

22 Sep '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/29450 ) Change subject: vty: Fix SPEECH_MODE printed with hex prefix but dec value ...................................................................... vty: Fix SPEECH_MODE printed with hex prefix but dec value Change-Id: I597ff582f47b00d895611eae8a810fe3ebfe8339 --- M src/common/vty.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/50/29450/1 diff --git a/src/common/vty.c b/src/common/vty.c index ffe4baf..3cd76fb 100644 --- a/src/common/vty.c +++ b/src/common/vty.c @@ -1946,7 +1946,7 @@ } if (lchan->abis_ip.connect_ip) { ia.s_addr = htonl(lchan->abis_ip.connect_ip); - vty_out(vty, " Conn. IP: %s Port %u RTP_TYPE=%u SPEECH_MODE=0x%02u%s", + vty_out(vty, " Conn. IP: %s Port %u RTP_TYPE=%u SPEECH_MODE=0x%02x%s", inet_ntoa(ia), lchan->abis_ip.connect_port, lchan->abis_ip.rtp_payload, lchan->abis_ip.speech_mode, VTY_NEWLINE); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29450 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I597ff582f47b00d895611eae8a810fe3ebfe8339 Gerrit-Change-Number: 29450 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bts[master]: vty: Print Osmux CID on lchans using Osmux
by pespin 22 Sep '22

22 Sep '22

Attention is currently required from: osmith, fixeria. Hello osmith, Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/29438 to look at the new patch set (#2). Change subject: vty: Print Osmux CID on lchans using Osmux ...................................................................... vty: Print Osmux CID on lchans using Osmux Related: SYS#5987 Change-Id: Ide6edefda828e9ce04fbb60cf547857f322d5f40 --- M src/common/vty.c 1 file changed, 12 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/38/29438/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29438 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ide6edefda828e9ce04fbb60cf547857f322d5f40 Gerrit-Change-Number: 29438 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-bts[master]: vty: Print Osmux CID on lchans using Osmux
by pespin 22 Sep '22

22 Sep '22

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29438 ) Change subject: vty: Print Osmux CID on lchans using Osmux ...................................................................... Patch Set 1: (1 comment) File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/29438/comment/54ef7c75_7b235347 PS1, Line 1952: 02x > Unrelated change? I didn't even notice I fixed this. Because I'm realy fixing it, since it had the 0x prefix. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29438 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ide6edefda828e9ce04fbb60cf547857f322d5f40 Gerrit-Change-Number: 29438 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Sep 2022 11:19:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: vty: Print Osmux CID on lchans using Osmux
by osmith 22 Sep '22

22 Sep '22

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29437 ) Change subject: vty: Print Osmux CID on lchans using Osmux ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29437 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6829949c888c0bcd989311219e10330bc97b2152 Gerrit-Change-Number: 29437 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Sep 2022 10:07:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: cosmetic: vty: Fix formatting of if-else brackets
by osmith 22 Sep '22

22 Sep '22

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29436 ) Change subject: cosmetic: vty: Fix formatting of if-else brackets ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29436 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7210616bc293913e5efec14eb52aeafb37f1244f Gerrit-Change-Number: 29436 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Sep 2022 10:03:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: Drop Osmux call setup if BTS didn't provide a remote CID
by osmith 22 Sep '22

22 Sep '22

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29435 ) Change subject: Drop Osmux call setup if BTS didn't provide a remote CID ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29435 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia90e8e0d18193d64c0fa0788dbd0eb242a359b61 Gerrit-Change-Number: 29435 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Sep 2022 10:03:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-gprs[master]: llc: implement LLC PDU codec based on code from osmo-sgsn.git
by osmith 22 Sep '22

22 Sep '22

Attention is currently required from: neels, fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 ) Change subject: llc: implement LLC PDU codec based on code from osmo-sgsn.git ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > I explained a few times already... Will do this one more time: […] linter adjustments: * https://gerrit.osmocom.org/c/osmo-ci/+/29448 * https://gerrit.osmocom.org/c/osmo-ci/+/29449 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I61d7e2e6d0a8f2cdfc2113e637e447dc428cc70d Gerrit-Change-Number: 29402 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Sep 2022 09:49:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-tetra[master]: added support for fill bits and basic link defragmentation (also than...
by wbokslag 22 Sep '22

22 Sep '22

Attention is currently required from: laforge. wbokslag has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/29387 ) Change subject: added support for fill bits and basic link defragmentation (also thanks to SQ5BPF) ...................................................................... Patch Set 5: (3 comments) File src/tetra_upper_mac.h: https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/28754212_63505ba7 PS3, Line 13: in > this probably shows how our practices have evolved during the last decade. […] Done File src/tetra_upper_mac.c: https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/61706a60_d619f989 PS3, Line 44: s > OK, then lets keep the global/static variables for now, but add a TODO comment that this actualY sho […] Done https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/c42479b4_d6d791c3 PS3, Line 50: fragslots[i].msgb = msgb_alloc(FRAGSLOT_MSGB_SIZE, "fragslot"); > > You're right, I could allocate them on demand, whenever a fragmented resource is encountered on a […] I think dynamic allocation is a good idea, since besides saving a few kilobytes of ram, it also removes the requirement of invoking an initialisation function in tetra-rx.c. Current patch set allocates a message buffer when required and frees it when either the mac/end is encountered or when it is aged out. -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/29387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I41c9438b0b12c2fac9dff1b226eec5b33f30fbb4 Gerrit-Change-Number: 29387 Gerrit-PatchSet: 5 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 22 Sep 2022 09:48:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: wbokslag <w.bokslag(a)midnightblue.nl> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

gerrit-log September 2022