September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: bsc: Add testscase & infra to validate Osmux support BTS<->BSC

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010 ) Change subject: bsc: Add testscase & infra to validate Osmux support BTS<->BSC ...................................................................... Patch Set 6: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010/comment/620ed550_d1fe… PS6, Line 13: sides (towards BTS and CN). > I wonder if in general it makes more sense to not replace existing tests with different new tests, a […] IMHO this is not worse than having extra lines for non-executed tests + having misleading names acording to new state of things. File bsc/MSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010/comment/22787bf7_4480… PS6, Line 255: CRCX > MDCX, same 3x below Ack File library/RSL_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010/comment/4344c19a_1337… PS6, Line 2310: //tr_RSL_IE_OSMO_Osmux_CID(osmux_cid); > left this intentionally? Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6e82eb9d995de988b812001e1c4cf6923509de66 Gerrit-Change-Number: 29010 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Sep 2022 09:52:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Add testscase & infra to validate Osmux support BTS<->BSC

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010 ) Change subject: bsc: Add testscase & infra to validate Osmux support BTS<->BSC ...................................................................... Patch Set 6: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010/comment/c74120fb_36a1… PS6, Line 13: sides (towards BTS and CN). I wonder if in general it makes more sense to not replace existing tests with different new tests, as this may lead to confusion when looking at the test history. File bsc/MSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010/comment/67e8260f_d8c3… PS6, Line 255: CRCX MDCX, same 3x below File library/RSL_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010/comment/d1694650_068d… PS6, Line 2310: //tr_RSL_IE_OSMO_Osmux_CID(osmux_cid); left this intentionally? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6e82eb9d995de988b812001e1c4cf6923509de66 Gerrit-Change-Number: 29010 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Sep 2022 09:50:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: Abort if processing SCTP connection without HNB context

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29331 ) Change subject: Abort if processing SCTP connection without HNB context ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I intentionally did not want to ASSERT in my original patch as my branch doesn't fix all of the causes of hnb being NULL. AFAIR the de-registration was only one code path leading to the situation, there was at least one other path, AFAIR? So let's either fix all of those code paths + ASSERT, or not assert. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29331 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I1eedab6f3ac974e942b02eaae41556f87dd8b6ba Gerrit-Change-Number: 29331 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Sep 2022 09:50:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: Abort if processing SCTP connection without HNB context

by laforge

Attention is currently required from: pespin. laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29331 ) Change subject: Abort if processing SCTP connection without HNB context ...................................................................... Removed Code-Review+2 by laforge <laforge(a)osmocom.org> -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29331 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I1eedab6f3ac974e942b02eaae41556f87dd8b6ba Gerrit-Change-Number: 29331 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: deleteVote

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: Don't permit anything but HNB (de)registration until HNB is registered

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29334 ) Change subject: Don't permit anything but HNB (de)registration until HNB is registered ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29334 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iaa62ce89f4ffbff868309bfb8b1df7ebcca5c44a Gerrit-Change-Number: 29334 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Sep 2022 09:48:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: Don't process RUA messages if HNB is not registered

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29333 ) Change subject: Don't process RUA messages if HNB is not registered ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29333 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I85442e8adfefadc3bf3ed795eaef7677eb0b36e9 Gerrit-Change-Number: 29333 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Sep 2022 09:48:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: hnbgw_rx_hnb_deregister: Don't call hnb_context_release()

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29332 ) Change subject: hnbgw_rx_hnb_deregister: Don't call hnb_context_release() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29332 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Id5c4f5c900ea049f54afbf58edb84b4dc00b1dcb Gerrit-Change-Number: 29332 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Sep 2022 09:48:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: Abort if processing SCTP connection without HNB context

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29331 ) Change subject: Abort if processing SCTP connection without HNB context ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29331 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I1eedab6f3ac974e942b02eaae41556f87dd8b6ba Gerrit-Change-Number: 29331 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Sep 2022 09:48:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: hnbgw: Log new SCTP HNB connections

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29330 ) Change subject: hnbgw: Log new SCTP HNB connections ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I07b98ff4c3199eeab11a8c1cfd9ce44ab99bca85 Gerrit-Change-Number: 29330 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Sep 2022 09:48:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: cosmetic: Fix typo in log and whitespace

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29329 ) Change subject: cosmetic: Fix typo in log and whitespace ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29329 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ie2be6937bb0f44ea66397c905c5d380caa2d4cef Gerrit-Change-Number: 29329 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Sep 2022 09:47:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022