September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_hnb_reregister_reuse_sctp_assoc

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29325 ) Change subject: hnbgw: Introduce test TC_hnb_reregister_reuse_sctp_assoc ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7386bd4e786daf2688a68ab174a9d4f0b093a741 Gerrit-Change-Number: 29325 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Sep 2022 10:10:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: hnbgw: Start only needed amount of HNBs emulations

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29328 ) Change subject: hnbgw: Start only needed amount of HNBs emulations ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29328 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id0e1c7423f016989de997e2be10516f4413ac245 Gerrit-Change-Number: 29328 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Sep 2022 10:07:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Add testscase & infra to validate Osmux support BTS<->BSC

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010 ) Change subject: bsc: Add testscase & infra to validate Osmux support BTS<->BSC ...................................................................... Patch Set 7: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010/comment/b80c8891_4c7a… PS6, Line 13: sides (towards BTS and CN). > just because it's not worse than other things doesn't mean it's a good idea either :D but fine with […] sure, but in the end something must be chosen/done :) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6e82eb9d995de988b812001e1c4cf6923509de66 Gerrit-Change-Number: 29010 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Sep 2022 10:04:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bts: Add testscase & infra to validate Osmux support BTS<->BSC

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29070 ) Change subject: bts: Add testscase & infra to validate Osmux support BTS<->BSC ...................................................................... Patch Set 4: (1 comment) File library/RSL_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29070/comment/685df6a4_793c… PS3, Line 2256: ts_RSL_MsgDisc > why was this changed from tr_RSL_MsgDisc? Probably copy-paste artifact while re-implementing it. In any case, it doesn't really matter and it's actually fine passing ts_* since the values are known. SO I think it's totally fine leaving it this way. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29070 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1af23c7a60b05edc3b544f1fea0023f48e89f7a7 Gerrit-Change-Number: 29070 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Sep 2022 10:03:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Add testscase & infra to validate Osmux support BTS<->BSC

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010 ) Change subject: bsc: Add testscase & infra to validate Osmux support BTS<->BSC ...................................................................... Patch Set 7: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010/comment/eed7cc8f_6b3d… PS6, Line 13: sides (towards BTS and CN). > IMHO this is not worse than having extra lines for non-executed tests + having misleading names acor […] just because it's not worse than other things doesn't mean it's a good idea either :D but fine with me -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6e82eb9d995de988b812001e1c4cf6923509de66 Gerrit-Change-Number: 29010 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Sep 2022 10:02:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bts: Add testscase & infra to validate Osmux support BTS<->BSC

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29070 ) Change subject: bts: Add testscase & infra to validate Osmux support BTS<->BSC ...................................................................... Patch Set 3: (1 comment) File library/RSL_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29070/comment/4ddde949_cc7a… PS3, Line 2256: ts_RSL_MsgDisc why was this changed from tr_RSL_MsgDisc? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29070 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1af23c7a60b05edc3b544f1fea0023f48e89f7a7 Gerrit-Change-Number: 29070 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Sep 2022 10:00:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: cosmetic: Fix typo in log and whitespace

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29329 ) Change subject: cosmetic: Fix typo in log and whitespace ...................................................................... cosmetic: Fix typo in log and whitespace Change-Id: Ie2be6937bb0f44ea66397c905c5d380caa2d4cef --- M src/osmo-hnbgw/hnbgw.c 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index 3655855..7aa4e0e 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -246,7 +246,7 @@ return -ENOMEM; /* we store a reference to the HomeNodeB in the msg->dest for the - * benefit of varoius downstream processing functions */ + * benefit of various downstream processing functions */ msg->dst = hnb; rc = osmo_stream_srv_recv(conn, msg); @@ -261,7 +261,6 @@ } else if (rc == 0) { osmo_stream_srv_destroy(conn); rc = -1; - goto out; } else { msgb_put(msg, rc); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29329 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ie2be6937bb0f44ea66397c905c5d380caa2d4cef Gerrit-Change-Number: 29329 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: hnbgw: Log new SCTP HNB connections

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29330 ) Change subject: hnbgw: Log new SCTP HNB connections ...................................................................... hnbgw: Log new SCTP HNB connections Change-Id: I07b98ff4c3199eeab11a8c1cfd9ce44ab99bca85 --- M src/osmo-hnbgw/hnbgw.c 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index 7aa4e0e..5077872 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -375,6 +375,9 @@ struct hnb_gw *gw = osmo_stream_srv_link_get_data(srv); struct hnb_context *ctx; + LOGP(DMAIN, LOGL_INFO, "New HNB SCTP connection %s\n", + osmo_sock_get_name2(fd)); + ctx = hnb_context_alloc(gw, srv, fd); if (!ctx) return -ENOMEM; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I07b98ff4c3199eeab11a8c1cfd9ce44ab99bca85 Gerrit-Change-Number: 29330 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bts: Add testscase & infra to validate Osmux support BTS<->BSC

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29070 to look at the new patch set (#4). Change subject: bts: Add testscase & infra to validate Osmux support BTS<->BSC ...................................................................... bts: Add testscase & infra to validate Osmux support BTS<->BSC Related: SYS#5987 Change-Id: I1af23c7a60b05edc3b544f1fea0023f48e89f7a7 --- M bts/BTS_Tests.ttcn M bts/gen_links.sh M bts/osmo-bts.cfg M bts/regen_makefile.sh M library/OSMUX_Types.ttcn M library/RSL_Types.ttcn 6 files changed, 351 insertions(+), 62 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/70/29070/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29070 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1af23c7a60b05edc3b544f1fea0023f48e89f7a7 Gerrit-Change-Number: 29070 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 9 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Add testscase & infra to validate Osmux support BTS<->BSC

by pespin

Attention is currently required from: osmith. Hello osmith, Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010 to look at the new patch set (#7). Change subject: bsc: Add testscase & infra to validate Osmux support BTS<->BSC ...................................................................... bsc: Add testscase & infra to validate Osmux support BTS<->BSC New TC_assignment_osmux_bts is added which tests Osmux used only BTS<->BSC. Existing TC_assignment_osmux is renamed to TC_assignment_osmux_cn, and a new TC_assignment_osmux is added which tests using Osmux on both sides (towards BTS and CN). Related: SYS#5987 Change-Id: I6e82eb9d995de988b812001e1c4cf6923509de66 --- M bsc/BSC_Tests.ttcn M bsc/BSC_Tests_VAMOS.ttcn M bsc/MSC_ConnectionHandler.ttcn M bsc/expected-results.xml M library/BSSMAP_Templates.ttcn M library/RSL_Types.ttcn 6 files changed, 231 insertions(+), 49 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/10/29010/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6e82eb9d995de988b812001e1c4cf6923509de66 Gerrit-Change-Number: 29010 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022