September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-hnbgw[master]: Don't permit anything but HNB (de)registration until HNB is registered

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29334 to look at the new patch set (#2). Change subject: Don't permit anything but HNB (de)registration until HNB is registered ...................................................................... Don't permit anything but HNB (de)registration until HNB is registered UE registration or other HNBAP procedures should only happen once the HNB is registered. Change-Id: Iaa62ce89f4ffbff868309bfb8b1df7ebcca5c44a --- M src/osmo-hnbgw/hnbgw_hnbap.c 1 file changed, 42 insertions(+), 26 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/34/29334/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29334 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iaa62ce89f4ffbff868309bfb8b1df7ebcca5c44a Gerrit-Change-Number: 29334 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 9 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_hnb_reregister_reuse_sctp_assoc

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29325 to look at the new patch set (#3). Change subject: hnbgw: Introduce test TC_hnb_reregister_reuse_sctp_assoc ...................................................................... hnbgw: Introduce test TC_hnb_reregister_reuse_sctp_assoc Change-Id: I7386bd4e786daf2688a68ab174a9d4f0b093a741 --- M hnbgw/HNBGW_Tests.ttcn M library/hnbap/HNBAP_Templates.ttcn 2 files changed, 36 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/25/29325/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7386bd4e786daf2688a68ab174a9d4f0b093a741 Gerrit-Change-Number: 29325 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: Don't permit anything but HNB (de)registration until HNB is registered

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29334 ) Change subject: Don't permit anything but HNB (de)registration until HNB is registered ...................................................................... Patch Set 1: (1 comment) File src/osmo-hnbgw/hnbgw_hnbap.c: Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-hnbgw-lint-223): https://gerrit.osmocom.org/c/osmo-hnbgw/+/29334/comment/71000d50_da28e65d PS1, Line 560: case HNBAP_ProcedureCode_id_UERegister: /* 8.4 */ please, no space before tabs -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29334 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iaa62ce89f4ffbff868309bfb8b1df7ebcca5c44a Gerrit-Change-Number: 29334 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 13 Sep 2022 09:34:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: Don't permit anything but HNB (de)registration until HNB is registered

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29334 ) Change subject: Don't permit anything but HNB (de)registration until HNB is registered ...................................................................... Don't permit anything but HNB (de)registration until HNB is registered UE registration or other HNBAP procedures should only happen once the HNB is registered. Change-Id: Iaa62ce89f4ffbff868309bfb8b1df7ebcca5c44a --- M src/osmo-hnbgw/hnbgw_hnbap.c 1 file changed, 42 insertions(+), 26 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/34/29334/1 diff --git a/src/osmo-hnbgw/hnbgw_hnbap.c b/src/osmo-hnbgw/hnbgw_hnbap.c index 1d81e83..aee32a0 100644 --- a/src/osmo-hnbgw/hnbgw_hnbap.c +++ b/src/osmo-hnbgw/hnbgw_hnbap.c @@ -535,32 +535,48 @@ { int rc = 0; - switch (imsg->procedureCode) { - case HNBAP_ProcedureCode_id_HNBRegister: /* 8.2 */ - rc = hnbgw_rx_hnb_register_req(hnb, &imsg->value); - break; - case HNBAP_ProcedureCode_id_HNBDe_Register: /* 8.3 */ - rc = hnbgw_rx_hnb_deregister(hnb, &imsg->value); - break; - case HNBAP_ProcedureCode_id_UERegister: /* 8.4 */ - rc = hnbgw_rx_ue_register_req(hnb, &imsg->value); - break; - case HNBAP_ProcedureCode_id_UEDe_Register: /* 8.5 */ - rc = hnbgw_rx_ue_deregister(hnb, &imsg->value); - break; - case HNBAP_ProcedureCode_id_ErrorIndication: /* 8.6 */ - rc = hnbgw_rx_err_ind(hnb, &imsg->value); - break; - case HNBAP_ProcedureCode_id_TNLUpdate: /* 8.9 */ - case HNBAP_ProcedureCode_id_HNBConfigTransfer: /* 8.10 */ - case HNBAP_ProcedureCode_id_RelocationComplete: /* 8.11 */ - case HNBAP_ProcedureCode_id_U_RNTIQuery: /* 8.12 */ - case HNBAP_ProcedureCode_id_privateMessage: - LOGHNB(hnb, DHNBAP, LOGL_NOTICE, "Unimplemented HNBAP Procedure %ld\n", imsg->procedureCode); - break; - default: - LOGHNB(hnb, DHNBAP, LOGL_NOTICE, "Unknown HNBAP Procedure %ld\n", imsg->procedureCode); - break; + if (!hnb->hnb_registered) { + switch (imsg->procedureCode) { + case HNBAP_ProcedureCode_id_HNBRegister: /* 8.2 */ + rc = hnbgw_rx_hnb_register_req(hnb, &imsg->value); + break; + case HNBAP_ProcedureCode_id_HNBDe_Register: /* 8.3 */ + rc = hnbgw_rx_hnb_deregister(hnb, &imsg->value); + break; + default: + LOGHNB(hnb, DHNBAP, LOGL_NOTICE, "HNBAP Procedure %ld not permitted for de-registered HNB\n", + imsg->procedureCode); + break; + } + } else { + switch (imsg->procedureCode) { + case HNBAP_ProcedureCode_id_HNBRegister: /* 8.2 */ + LOGHNB(hnb, DHNBAP, LOGL_NOTICE, + "HNBAP Procedure HNB-Register not permitted for registered HNB\n"); + break; + case HNBAP_ProcedureCode_id_HNBDe_Register: /* 8.3 */ + rc = hnbgw_rx_hnb_deregister(hnb, &imsg->value); + break; + case HNBAP_ProcedureCode_id_UERegister: /* 8.4 */ + rc = hnbgw_rx_ue_register_req(hnb, &imsg->value); + break; + case HNBAP_ProcedureCode_id_UEDe_Register: /* 8.5 */ + rc = hnbgw_rx_ue_deregister(hnb, &imsg->value); + break; + case HNBAP_ProcedureCode_id_ErrorIndication: /* 8.6 */ + rc = hnbgw_rx_err_ind(hnb, &imsg->value); + break; + case HNBAP_ProcedureCode_id_TNLUpdate: /* 8.9 */ + case HNBAP_ProcedureCode_id_HNBConfigTransfer: /* 8.10 */ + case HNBAP_ProcedureCode_id_RelocationComplete: /* 8.11 */ + case HNBAP_ProcedureCode_id_U_RNTIQuery: /* 8.12 */ + case HNBAP_ProcedureCode_id_privateMessage: + LOGHNB(hnb, DHNBAP, LOGL_NOTICE, "Unimplemented HNBAP Procedure %ld\n", imsg->procedureCode); + break; + default: + LOGHNB(hnb, DHNBAP, LOGL_NOTICE, "Unknown HNBAP Procedure %ld\n", imsg->procedureCode); + break; + } } return rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29334 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iaa62ce89f4ffbff868309bfb8b1df7ebcca5c44a Gerrit-Change-Number: 29334 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: Don't process RUA messages if HNB is not registered

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29333 ) Change subject: Don't process RUA messages if HNB is not registered ...................................................................... Don't process RUA messages if HNB is not registered Related: OS#5676 Change-Id: I85442e8adfefadc3bf3ed795eaef7677eb0b36e9 --- M src/osmo-hnbgw/hnbgw.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/33/29333/1 diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index 5b8e05c..3e94e7f 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -273,6 +273,10 @@ rc = hnbgw_hnbap_rx(hnb, msg); break; case IUH_PPI_RUA: + if (!hnb->hnb_registered) { + LOGHNB(hnb, DMAIN, LOGL_NOTICE, "Discarding RUA as HNB is not registered\n"); + goto out; + } hnb->rua_stream = msgb_sctp_stream(msg); rc = hnbgw_rua_rx(hnb, msg); break; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29333 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I85442e8adfefadc3bf3ed795eaef7677eb0b36e9 Gerrit-Change-Number: 29333 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: Abort if processing SCTP connection without HNB context

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29331 ) Change subject: Abort if processing SCTP connection without HNB context ...................................................................... Abort if processing SCTP connection without HNB context It was observed that under some circumstances (after HNBAP HNB-De-Register) we end up crashing because a connection has no HNB assigned to it. Let's explicitly assert if that happens, in order clarify and avoid same sort of thing happening without clear view on what's going on. The issue will be fixed in a follow-up patch. Closes: OS#5676 Change-Id: I1eedab6f3ac974e942b02eaae41556f87dd8b6ba --- M src/osmo-hnbgw/hnbgw.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/31/29331/1 diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index 5077872..5b8e05c 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -245,6 +245,7 @@ if (!msg) return -ENOMEM; + OSMO_ASSERT(hnb); /* we store a reference to the HomeNodeB in the msg->dest for the * benefit of various downstream processing functions */ msg->dst = hnb; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29331 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I1eedab6f3ac974e942b02eaae41556f87dd8b6ba Gerrit-Change-Number: 29331 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: hnbgw_rx_hnb_deregister: Don't call hnb_context_release()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29332 ) Change subject: hnbgw_rx_hnb_deregister: Don't call hnb_context_release() ...................................................................... hnbgw_rx_hnb_deregister: Don't call hnb_context_release() Don't release the HNB context as there's plenty of code that assumes there's always a HNB context associated with a SCTP connection. Instead, simply unset the hnb_registered flag in the context when processing a HNB_DE-REGISTER. Related: OS#5676 Change-Id: Id5c4f5c900ea049f54afbf58edb84b4dc00b1dcb --- M src/osmo-hnbgw/hnbgw_hnbap.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/32/29332/1 diff --git a/src/osmo-hnbgw/hnbgw_hnbap.c b/src/osmo-hnbgw/hnbgw_hnbap.c index 98cec76..1d81e83 100644 --- a/src/osmo-hnbgw/hnbgw_hnbap.c +++ b/src/osmo-hnbgw/hnbgw_hnbap.c @@ -388,7 +388,7 @@ LOGHNB(ctx, DHNBAP, LOGL_DEBUG, "HNB-DE-REGISTER cause=%s\n", hnbap_cause_str(&ies.cause)); hnbap_free_hnbde_registeries(&ies); - hnb_context_release(ctx); + ctx->hnb_registered = false; return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29332 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Id5c4f5c900ea049f54afbf58edb84b4dc00b1dcb Gerrit-Change-Number: 29332 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: cosmetic: Fix typo in log and whitespace

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29329 ) Change subject: cosmetic: Fix typo in log and whitespace ...................................................................... cosmetic: Fix typo in log and whitespace Change-Id: Ie2be6937bb0f44ea66397c905c5d380caa2d4cef --- M src/osmo-hnbgw/hnbgw.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/29/29329/1 diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index 3655855..7aa4e0e 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -246,7 +246,7 @@ return -ENOMEM; /* we store a reference to the HomeNodeB in the msg->dest for the - * benefit of varoius downstream processing functions */ + * benefit of various downstream processing functions */ msg->dst = hnb; rc = osmo_stream_srv_recv(conn, msg); @@ -261,7 +261,6 @@ } else if (rc == 0) { osmo_stream_srv_destroy(conn); rc = -1; - goto out; } else { msgb_put(msg, rc); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29329 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ie2be6937bb0f44ea66397c905c5d380caa2d4cef Gerrit-Change-Number: 29329 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: hnbgw: Log new SCTP HNB connections

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29330 ) Change subject: hnbgw: Log new SCTP HNB connections ...................................................................... hnbgw: Log new SCTP HNB connections Change-Id: I07b98ff4c3199eeab11a8c1cfd9ce44ab99bca85 --- M src/osmo-hnbgw/hnbgw.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/30/29330/1 diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index 7aa4e0e..5077872 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -375,6 +375,9 @@ struct hnb_gw *gw = osmo_stream_srv_link_get_data(srv); struct hnb_context *ctx; + LOGP(DMAIN, LOGL_INFO, "New HNB SCTP connection %s\n", + osmo_sock_get_name2(fd)); + ctx = hnb_context_alloc(gw, srv, fd); if (!ctx) return -ENOMEM; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I07b98ff4c3199eeab11a8c1cfd9ce44ab99bca85 Gerrit-Change-Number: 29330 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-msc[master]: Make esme struct shared

by neels

Attention is currently required from: neels, laforge, dexter. neels has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28846 ) Change subject: Make esme struct shared ...................................................................... Removed Code-Review-1 by neels <nhofmeyr(a)sysmocom.de> -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28846 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70 Gerrit-Change-Number: 28846 Gerrit-PatchSet: 20 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: deleteVote

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022