September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bts[master]: oc2g: Makefile.am Fix typo in LIBOSMONETIF_LIBS
by pespin 12 Sep '22

12 Sep '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/29326 ) Change subject: oc2g: Makefile.am Fix typo in LIBOSMONETIF_LIBS ...................................................................... oc2g: Makefile.am Fix typo in LIBOSMONETIF_LIBS Change-Id: I6d316ffaff0ad7881b694f4d6427434bb9a0684c --- M src/osmo-bts-oc2g/Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/26/29326/1 diff --git a/src/osmo-bts-oc2g/Makefile.am b/src/osmo-bts-oc2g/Makefile.am index 0da40b9..29374ef 100644 --- a/src/osmo-bts-oc2g/Makefile.am +++ b/src/osmo-bts-oc2g/Makefile.am @@ -25,7 +25,7 @@ $(LIBOSMOCTRL_LIBS) \ $(LIBOSMOABIS_LIBS) \ $(LIBOSMOTRAU_LIBS) \ - $(LIBOSMONETIF_CFLAGS) \ + $(LIBOSMONETIF_LIBS) \ $(ORTP_LIBS) \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29326 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6d316ffaff0ad7881b694f4d6427434bb9a0684c Gerrit-Change-Number: 29326 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bts[master]: Introduce Osmux support
by pespin 12 Sep '22

12 Sep '22

Attention is currently required from: dexter. Hello Jenkins Builder, laforge, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/29285 to look at the new patch set (#7). Change subject: Introduce Osmux support ...................................................................... Introduce Osmux support Related: SYS#5987 Requires: libosmo-netif.git Change-Id I632654221826340423e1e97b0f8ed9a2baf6c6c3 Change-Id: Ib80be434c06d07b3611bd18ae25dff8b14a7aad9 --- M TODO-RELEASE M configure.ac A doc/manuals/chapters/osmux_bts.adoc M doc/manuals/osmobts-usermanual.adoc M include/osmo-bts/Makefile.am M include/osmo-bts/bts.h M include/osmo-bts/l1sap.h M include/osmo-bts/lchan.h M include/osmo-bts/logging.h A include/osmo-bts/osmux.h M include/osmo-bts/vty.h M src/common/Makefile.am M src/common/bts.c M src/common/l1sap.c M src/common/lchan.c M src/common/logging.c M src/common/main.c A src/common/osmux.c M src/common/rsl.c M src/common/vty.c M tests/osmo-bts.vty 21 files changed, 895 insertions(+), 46 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/85/29285/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib80be434c06d07b3611bd18ae25dff8b14a7aad9 Gerrit-Change-Number: 29285 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmo-netif[master]: stream: Fix typos in log messages
by dexter 12 Sep '22

12 Sep '22

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29323 ) Change subject: stream: Fix typos in log messages ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: "connection closed with client" sounds a bit strange. I think "connection with client closed" would be better, but since there are more of such lines in the code this might be a separate patch. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29323 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I9e49e222c254c89d182402501024badfd3bf9d9c Gerrit-Change-Number: 29323 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Sep 2022 12:23:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: stream: Fix typos in log messages
by dexter 12 Sep '22

12 Sep '22

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29323 ) Change subject: stream: Fix typos in log messages ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29323 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I9e49e222c254c89d182402501024badfd3bf9d9c Gerrit-Change-Number: 29323 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Sep 2022 12:22:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: Introduce Osmux support
by pespin 12 Sep '22

12 Sep '22

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29285 ) Change subject: Introduce Osmux support ...................................................................... Patch Set 6: (1 comment) File doc/manuals/chapters/osmux_bts.adoc: https://gerrit.osmocom.org/c/osmo-bts/+/29285/comment/b9abccb5_44fea774 PS6, Line 9: will gain support that this BTS supports using Osmux to transfer voice call user > Support is limited to AMR and there's no current plans to change that. […] I meant "will gain knowledge", I'll fix. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib80be434c06d07b3611bd18ae25dff8b14a7aad9 Gerrit-Change-Number: 29285 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Sep 2022 12:08:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: Introduce Osmux support
by pespin 12 Sep '22

12 Sep '22

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29285 ) Change subject: Introduce Osmux support ...................................................................... Patch Set 6: (2 comments) Patchset: PS6: Sorry for pushing lots of versions but somehow the tests are passing fine locally and only failing here. File doc/manuals/chapters/osmux_bts.adoc: https://gerrit.osmocom.org/c/osmo-bts/+/29285/comment/0dd3e840_dd433912 PS6, Line 9: will gain support that this BTS supports using Osmux to transfer voice call user > This sentence sounds a bit odd to me. […] Support is limited to AMR and there's no current plans to change that. For the few MS not supporting AMR, they can use FR/HR/EFR with RTP. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib80be434c06d07b3611bd18ae25dff8b14a7aad9 Gerrit-Change-Number: 29285 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Sep 2022 12:06:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_hnb_reregister_reuse_sctp_assoc
by pespin 12 Sep '22

12 Sep '22

Attention is currently required from: pespin. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29325 to look at the new patch set (#2). Change subject: hnbgw: Introduce test TC_hnb_reregister_reuse_sctp_assoc ...................................................................... hnbgw: Introduce test TC_hnb_reregister_reuse_sctp_assoc Change-Id: I7386bd4e786daf2688a68ab174a9d4f0b093a741 --- M hnbgw/HNBGW_Tests.ttcn M library/hnbap/HNBAP_Templates.ttcn 2 files changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/25/29325/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7386bd4e786daf2688a68ab174a9d4f0b093a741 Gerrit-Change-Number: 29325 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_hnb_reregister_reuse_sctp_assoc
by dexter 12 Sep '22

12 Sep '22

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29325 ) Change subject: hnbgw: Introduce test TC_hnb_reregister_reuse_sctp_assoc ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29325/comment/c8808c9b_0790… PS1, Line 1371: execute(TC_hnb_reregister_reuse_sctp_assoc); I think it should be: execute(TC_hnb_reregister_reuse_sctp_assoc()) (thats also why jenkins build fails.) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7386bd4e786daf2688a68ab174a9d4f0b093a741 Gerrit-Change-Number: 29325 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Sep 2022 12:04:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: Introduce Osmux support
by dexter 12 Sep '22

12 Sep '22

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29285 ) Change subject: Introduce Osmux support ...................................................................... Patch Set 6: Code-Review+1 (2 comments) Patchset: PS6: Looks good to me. (the VTY tests seem to cause the jenkins build to fail) File doc/manuals/chapters/osmux_bts.adoc: https://gerrit.osmocom.org/c/osmo-bts/+/29285/comment/ebe47ab9_af2b7673 PS6, Line 9: will gain support that this BTS supports using Osmux to transfer voice call user This sentence sounds a bit odd to me. I would write "This way, the BSC detects that the BTS supports using Osmux to transfer voice call user data..." The support seems to be limited to AMR for the moment? Maybe mention this separately to make the sentence shorter. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib80be434c06d07b3611bd18ae25dff8b14a7aad9 Gerrit-Change-Number: 29285 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Sep 2022 12:00:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_hnb_reregister_reuse_sctp_assoc
by pespin 12 Sep '22

12 Sep '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29325 ) Change subject: hnbgw: Introduce test TC_hnb_reregister_reuse_sctp_assoc ...................................................................... hnbgw: Introduce test TC_hnb_reregister_reuse_sctp_assoc Change-Id: I7386bd4e786daf2688a68ab174a9d4f0b093a741 --- M hnbgw/HNBGW_Tests.ttcn M library/hnbap/HNBAP_Templates.ttcn 2 files changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/25/29325/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index b440292..b5b0d4f 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -684,6 +684,17 @@ f_shutdown_helper(); } +/* Drop HNBAP conn (HNBAP DEREG) and reconnect it (HNBAP REG) using same SCTP association. + * Related: OS#5676, SYS#6113 */ +testcase TC_hnb_reregister_reuse_sctp_assoc() runs on test_CT { + f_init(); + f_hnbap_register(0); + HNBAP[0].send(ts_HNBAP_HNBDe_Register(ts_HnbapCause(unspecified))); + f_hnbap_register(0); + f_verify_talloc_count(HNBGWVTY, {"struct hnb_context"}, expect_count := 1); + f_shutdown_helper(); +} + /*********************************************************************** * RUA / RANAP Testing ***********************************************************************/ @@ -1355,6 +1366,9 @@ execute(TC_ranap_cs_mo_disconnect()); execute(TC_ranap_ps_mo_disconnect()); execute(TC_ps_rab_assignment()); + + /* Run at the end since it makes osmo-hnbgw <= 1.3.0 crash: OS#5676 */ + execute(TC_hnb_reregister_reuse_sctp_assoc); } } diff --git a/library/hnbap/HNBAP_Templates.ttcn b/library/hnbap/HNBAP_Templates.ttcn index 89edf76..2576d17 100644 --- a/library/hnbap/HNBAP_Templates.ttcn +++ b/library/hnbap/HNBAP_Templates.ttcn @@ -232,4 +232,25 @@ } } +/* 9.1.9 HNB DE-REGISTER */ +template (value) HNBAP_PDU +ts_HNBAP_HNBDe_Register(template (value) Cause cause) := { + initiatingMessage := { + procedureCode := id_HNBDe_Register, + criticality := reject, + value_ := { + HNBDe_Register := { + protocolIEs := { + { + id := HNBAP_Constants.id_Cause, + criticality := ignore, + value_ := { Cause := cause } + } + }, + protocolExtensions := omit /* TODO: BackoffTimer */ + } + } + } +} + } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7386bd4e786daf2688a68ab174a9d4f0b093a741 Gerrit-Change-Number: 29325 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

2025

2024

2023

2022

gerrit-log September 2022