Attention is currently required from: neels.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29003 )
Change subject: optimize: decode PS msgs only when PFCP is enabled
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29003
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ifb57bad6a0d5ff263e4c6c3facc51620e110e7d2
Gerrit-Change-Number: 29003
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Aug 2022 05:54:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29075 )
Change subject: manual: explain the PFCP port
......................................................................
Patch Set 2:
(1 comment)
File doc/manuals/chapters/running.adoc:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/29075/comment/ce9a44fb_63eea54d
PS2, Line 147: optionally supports
if this is a compile-time option, it should be stated here to avoid users assuming they can just always use the below config snippet without using any special compile options.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29075
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I383befb226caa49e4a2577657806aef1ee11faa3
Gerrit-Change-Number: 29075
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Aug 2022 05:53:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: neels.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29074 )
Change subject: manual: add missing bit on the MGCP port
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29074
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ic18180793f0c1497b020e5f4a8cd34d6b519b85f
Gerrit-Change-Number: 29074
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Aug 2022 05:51:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29073 )
Change subject: osmo-hnbgw.cfg example: add pfcp
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Patchset:
PS2:
well, actually we made this optional, right? I think if pfcp support is not enabled in a default build, then the default example config file should also not use it. Feel free to add a separate example config file for that situation.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29073
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I62c4935bcc7f684bfe850f88f1b80e8970e0e098
Gerrit-Change-Number: 29073
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Aug 2022 05:51:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment