August 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: obs: add explicit --git-branch arg

by laforge

Attention is currently required from: osmith, neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29116 ) Change subject: obs: add explicit --git-branch arg ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29116 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I612c18e533542f442e0571927fee8b8be9fb8c2b Gerrit-Change-Number: 29116 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 05:15:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: obs: add libosmo-pfcp, osmo-upf

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29047 ) Change subject: obs: add libosmo-pfcp, osmo-upf ...................................................................... obs: add libosmo-pfcp, osmo-upf Change-Id: I7192f4c9e77035cebb147b8186296bcd741d419b --- M scripts/obs/lib/config.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve neels: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/scripts/obs/lib/config.py b/scripts/obs/lib/config.py index a4a10c5..997fff2 100644 --- a/scripts/obs/lib/config.py +++ b/scripts/obs/lib/config.py @@ -44,6 +44,7 @@ "libosmo-abis", "libosmo-dsp", "libosmo-netif", + "libosmo-pfcp", "libosmo-sccp", "libosmocore", "libsmpp34", @@ -72,6 +73,7 @@ "osmo-sysmon", "osmo-trx", "osmo-uecups", + "osmo-upf", "python/osmo-python-tests", "rtl-sdr", "simtrace2", -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29047 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7192f4c9e77035cebb147b8186296bcd741d419b Gerrit-Change-Number: 29047 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: obs: add libosmo-pfcp, osmo-upf

by laforge

Attention is currently required from: osmith, neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29047 ) Change subject: obs: add libosmo-pfcp, osmo-upf ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29047 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7192f4c9e77035cebb147b8186296bcd741d419b Gerrit-Change-Number: 29047 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 05:13:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmocore[master]: Revert "Add function to guess AF_UNSPEC address"

by msuraev

Attention is currently required from: neels, laforge, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29122 ) Change subject: Revert "Add function to guess AF_UNSPEC address" ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: I disagree - see osmo_ip_str_type(): this function is just convenience wrapper over it. So we should either remove both or keep both of them. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifadd614604cf9d0c2ed1a405493c1c3fcb37ae23 Gerrit-Change-Number: 29122 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 04:54:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: cosmetic: improve usage help of example code

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29086 ) Change subject: cosmetic: improve usage help of example code ...................................................................... Patch Set 10: (1 comment) File examples/sccp_demo_user.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29086/comment/83d9b85b_8c90a043 PS9, Line 124: , > nice catch! Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29086 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I342dc227afbfe6c3540eb3285677c568d2fe3166 Gerrit-Change-Number: 29086 Gerrit-PatchSet: 10 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 04:50:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: cosmetic: improve usage help of example code

by msuraev

msuraev has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29086 ) Change subject: cosmetic: improve usage help of example code ...................................................................... cosmetic: improve usage help of example code * document -C option for example server * move misplaced comma * drop empty #define from example code Change-Id: I342dc227afbfe6c3540eb3285677c568d2fe3166 --- M examples/sccp_demo_user.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/examples/sccp_demo_user.c b/examples/sccp_demo_user.c index 1a4ebac..df6c9af 100644 --- a/examples/sccp_demo_user.c +++ b/examples/sccp_demo_user.c @@ -105,7 +105,6 @@ #define DEFAULT_LOCAL_PORT_CLIENT M3UA_PORT #define DEFAULT_REMOTE_PORT_CLIENT DEFAULT_LOCAL_PORT_SERVER #define DEFAULT_REMOTE_PORT_SERVER DEFAULT_LOCAL_PORT_CLIENT -#define DEFAULT_REMOTE_PORT_SERVER_STR DEFAULT_LOCAL_PORT_CLIENT_STR #define DEFAULT_PC_SERVER 1 #define DEFAULT_PC_CLIENT 23 @@ -116,13 +115,14 @@ "Options:\n" " -p: protocol to use (m3ua, sua, ipa; default is ipa)\n" " -c: Run in client mode (default is server mode)\n" + " -C filename The config file to use\n" " -l: local IP address and SCTP port (default is %s:%d in server mode,\n" " %s:%d in client mode)\n" " -r: remote IP address and SCTP port (default is %s:%d in server mode,\n" " %s:%d in client mode)\n" " -L: local point code (default is %d in server mode, %d in client mode)\n" - " -R: remote point code (default is %d in server mode, %d in client mode)\n", - " -d: LOGMASK (libosmocore log mask string, e.g. -d DLINP,1:DLSS7,2)\n" + " -R: remote point code (default is %d in server mode, %d in client mode)\n" + " -d: LOGMASK (libosmocore log mask string, e.g. -d DLINP,1:DLSS7,2)\n", DEFAULT_LOCAL_ADDRESS_SERVER, DEFAULT_LOCAL_PORT_SERVER, DEFAULT_LOCAL_ADDRESS_CLIENT, DEFAULT_LOCAL_PORT_CLIENT, DEFAULT_REMOTE_ADDRESS_SERVER, DEFAULT_REMOTE_PORT_SERVER, 9 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29086 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I342dc227afbfe6c3540eb3285677c568d2fe3166 Gerrit-Change-Number: 29086 Gerrit-PatchSet: 10 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: SCCP: enforce optional data length limits

by msuraev

Attention is currently required from: neels. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 ) Change subject: SCCP: enforce optional data length limits ...................................................................... Patch Set 5: (1 comment) File src/sccp.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29083/comment/c80251cb_d07e3355 PS4, Line 234: return -EBADSLT; > EBADSLT "Invalid slot"? how about EMSGSIZE Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Icc3bd0a71b29cf61a259c5d97e7dd85beb4397bd Gerrit-Change-Number: 29083 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 04:48:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: Log more data on CR and N-CONNECT

by msuraev

Attention is currently required from: neels. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 ) Change subject: Log more data on CR and N-CONNECT ...................................................................... Patch Set 8: (1 comment) Patchset: PS7: > i'd solve this question by looking at wireshark instead of logging? Those're not mutually exclusive. Although I should try GSMTAP log target to see both at the same place. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d7fc44fde5b900907ec5ebec0450040a764802a Gerrit-Change-Number: 29085 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 04:48:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: add function to check connection existence

by msuraev

Attention is currently required from: neels, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 ) Change subject: SIGTRAN: add function to check connection existence ...................................................................... Patch Set 9: (1 comment) File examples/sccp_test_vty.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29087/comment/35adf953_392149f8 PS8, Line 44: int conn_id = atoi(argv[0]), ret; > please declare 'int ret;' on a separate line Why? I don't recall anything about it from Linux kernel coding style. Having it on the same line makes it easier to read. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 Gerrit-Change-Number: 29087 Gerrit-PatchSet: 9 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 04:47:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: enforce length limits on SCCP Optional Data

by msuraev

Attention is currently required from: neels. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 ) Change subject: SIGTRAN: enforce length limits on SCCP Optional Data ...................................................................... Patch Set 4: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/7f33be80_6ebfb2a4 PS4, Line 7: SIGTRAN: enforce optional data length limits > "enforce length limits on SCCP Optional Data" ? Done File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/5066f7ee_e94b5471 PS4, Line 617: /* optional: hop coun */ > "count" ? Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 04:45:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022