Attention is currently required from: msuraev.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sccp/+/29083
to look at the new patch set (#5).
Change subject: SCCP: enforce optional data length limits
......................................................................
SCCP: enforce optional data length limits
Limit length of optional Data parameter to 130 bytes to conform with ITU-T Rec Q.713 §4.2..§4.5 while receiving SCCP messages.
Related: OS#5579
Change-Id: Icc3bd0a71b29cf61a259c5d97e7dd85beb4397bd
---
M include/osmocom/sccp/sccp_types.h
M src/sccp.c
2 files changed, 29 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/83/29083/5
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29083
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Icc3bd0a71b29cf61a259c5d97e7dd85beb4397bd
Gerrit-Change-Number: 29083
Gerrit-PatchSet: 5
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria, msuraev.
Hello Jenkins Builder, neels,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sccp/+/29087
to look at the new patch set (#9).
Change subject: SIGTRAN: add function to check connection existence
......................................................................
SIGTRAN: add function to check connection existence
Add convenience helper to check if particular connection ID exists and use it to
properly report errors when attempting to send messages over non-existent connections.
Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01
---
M examples/sccp_test_vty.c
M include/osmocom/sigtran/sccp_helpers.h
M src/sccp_helpers.c
M src/sccp_scoc.c
4 files changed, 41 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/87/29087/9
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01
Gerrit-Change-Number: 29087
Gerrit-PatchSet: 9
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: msuraev.
Hello Jenkins Builder, neels,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sccp/+/29084
to look at the new patch set (#5).
Change subject: SIGTRAN: enforce length limits on SCCP Optional Data
......................................................................
SIGTRAN: enforce length limits on SCCP Optional Data
Limit length of optional Data parameter to 130 bytes to conform with ITU-T Rec Q.713 §4.2..§4.5 while sending SCCP messages.
Related: OS#5579
Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a
---
M src/sccp_scoc.c
1 file changed, 31 insertions(+), 15 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/84/29084/5
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a
Gerrit-Change-Number: 29084
Gerrit-PatchSet: 5
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: osmith.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29110 )
Change subject: obs: add README
......................................................................
Patch Set 3:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29110
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I4d1303e0c04e827200b48a9fe4aea3680c9c9f84
Gerrit-Change-Number: 29110
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Aug 2022 02:12:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin, msuraev.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28892 )
Change subject: BSSMAP: make sure we don't try to reset non-existent entity
......................................................................
Patch Set 2: Code-Review-1
(3 comments)
Patchset:
PS2:
in OS#5551 i explain why this fix seems to be not needed.
If there is ever a situation where bssmap_reset == NULL,
we need to find that and fix it.
I currently don't see how that is possible at all.
There is not even uncertainty, race or async things going on, it is simply not possible.
File src/osmo-bsc/bsc_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28892/comment/e679b15c_f951f808
PS2, Line 3393: if (!msc->a.bssmap_reset) {
Wording confusion:
- this is not about "Resetting the BSSMAP interface", it is about sending a BSSMAP Reset message to the peer.
- this is not about an unallocated MSC.
If the MSC is not allocated, above 'if (!msc)' triggers.
If bssmap_reset is NULL, then the RESET message handling FSM instance has not been initialized / already torn down.
The code below is about sending a BSSMAP RESET message, so the log should say something like
"Unable to send BSSMAP RESET message, bssmap_reset FSM not allocated"
But did you actually face a situation like this? Seems unlikely to happen.
File src/osmo-bsc/bssmap_reset.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28892/comment/ef077194_f2e3c53d
PS2, Line 249: LOGP(DMSC, LOGL_ERROR, "Attempt to reset non-existent BSSMAP\n");
No caller should call this function with a NULL argument.
Otherwise we'd need to add such NULL checks to all of the API functions everywhere.
If it is really plausible, then:
Wording confusion: rather "Unable to send BSSMAP RESET message, no FSM instance present"
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28892
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I235bdd42ea82e7b5a1a40f437ca34c49ad239c48
Gerrit-Change-Number: 28892
Gerrit-PatchSet: 2
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Aug 2022 02:09:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin, msuraev, dexter.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28846 )
Change subject: Make esme struct shared
......................................................................
Patch Set 19: Code-Review-1
(4 comments)
File include/osmocom/smpp/smpp.h:
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/75e5796c_038ce042
PS19, Line 14: struct esme {
prefer 'struct smpp_esme' since it is from smpp.h
File include/osmocom/smpp/smpp_smsc.h:
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/eb66d78b_c63ea6c8
PS19, Line 32: struct esme *esme;
just 'struct esme esme;' (non-pointer) to avoid extra talloc,
then smpp_esme_init(&osmo_esme.esme) instead of esme_alloc()
File src/libsmpputil/smpp_smsc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/dcef0350_bd4e35a1
PS19, Line 900: esme->esme = esme_alloc(esme);
...because the esme_alloc() appears to unconditionally take place after talloc(struct osmo_esme) anyway.
File src/utils/Makefile.am:
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/f65950f5_9b47607a
PS19, Line 45: $(top_builddir)/src/libvlr/libvlr.a \
smpp_mirror certainly does not need libvlr.a.
also looks weird to require libmsc.a.
and pull in ASN1C, SIGTRAN and SQLITE3 below...
can you find a way to not pull in all sorts of unrelated dependencies?
just guessing, maybe move the esme implementation from libmsc to libsmpputil?
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28846
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70
Gerrit-Change-Number: 28846
Gerrit-PatchSet: 19
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Aug 2022 01:47:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment