August 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-sccp[master]: SCCP: enforce optional data length limits

by msuraev

Attention is currently required from: neels. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 ) Change subject: SCCP: enforce optional data length limits ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Icc3bd0a71b29cf61a259c5d97e7dd85beb4397bd Gerrit-Change-Number: 29083 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 11:47:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: obs: meaningful error if debian/changelog is empty

by osmith

Attention is currently required from: neels, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29097 ) Change subject: obs: meaningful error if debian/changelog is empty ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ci/+/29097/comment/f54a8fad_0200c113 PS2, Line 9: empty debian/changelog > AFAIK, dpkg would refuse to build a package with empty changelog. […] right. updated the patch to print a more useful error message instead -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I294d844ccccfa12599b6ba1def087e4a32d289e7 Gerrit-Change-Number: 29097 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 09:45:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: obs: meaningful error if debian/changelog is empty

by osmith

Attention is currently required from: osmith, neels. Hello Jenkins Builder, neels, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/29097 to look at the new patch set (#3). Change subject: obs: meaningful error if debian/changelog is empty ...................................................................... obs: meaningful error if debian/changelog is empty If there's an empty debian/changelog, packaging needs to be fixed in the git repository of the project. Print a meaningful error instead of: File "/obs/lib/srcpkg.py", line 68, in get_version_for_feed if ":" in ret: TypeError: argument of type 'NoneType' is not iterable Change-Id: I294d844ccccfa12599b6ba1def087e4a32d289e7 --- M scripts/obs/lib/debian.py M scripts/obs/lib/srcpkg.py 2 files changed, 6 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/97/29097/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I294d844ccccfa12599b6ba1def087e4a32d289e7 Gerrit-Change-Number: 29097 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: obs: add libosmo-gprs

by osmith

Attention is currently required from: laforge, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29096 ) Change subject: obs: add libosmo-gprs ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Patchset: PS5: +2 because this is trivial -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I96f48cfc328f61bcbee98c4675896cc4c4e9a48f Gerrit-Change-Number: 29096 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 09:18:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: obs: tweak logging output

by osmith

Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29117 ) Change subject: obs: tweak logging output ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29117 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I203cb7f0aa21b59b06973e8f329cffdc64aa8d47 Gerrit-Change-Number: 29117 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 09:17:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: obs: add README

by osmith

Attention is currently required from: neels, laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29110 ) Change subject: obs: add README ...................................................................... Patch Set 3: (4 comments) Patchset: PS3: very nice, thanks for adding this! File scripts/obs/README: https://gerrit.osmocom.org/c/osmo-ci/+/29110/comment/35bf3115_76c8b762 PS3, Line 6: apt-get install dh-python meson osc rebar3 There are more dependencies, the debian package names are listed in data/Dockerfile. Maybe just reference that? But I don't have a strong opinion on this, if you think it's useful then let's duplicate it here. https://gerrit.osmocom.org/c/osmo-ci/+/29110/comment/a23675a8_1a32f3bc PS3, Line 26: Easiest is to let osc create one and then edit it: why not provide an example ~/.oscrc instead of these instructions? [general] # apiurl = https://api.opensuse.org apiurl = https://obs.osmocom.org # [https://api.opensuse.org] # user = user-for-opensuse-obs # pass = [https://obs.osmocom.org] user = user-for-osmocom-obs pass = https://gerrit.osmocom.org/c/osmo-ci/+/29110/comment/ebb74a06_d2067198 PS3, Line 35: Replace "api.opensuse.org" with "obs.osmocom.org" in two places: > Isn't the "-A https://lobs.osmocom. […] ack, if using "osc -A https://obs.osmocom.org list ..." it will probably generate an oscrc against that server and the sed isn't needed -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29110 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4d1303e0c04e827200b48a9fe4aea3680c9c9f84 Gerrit-Change-Number: 29110 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 17 Aug 2022 09:15:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: obs: add explicit --git-branch arg

by osmith

Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29116 ) Change subject: obs: add explicit --git-branch arg ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Personally I would find a --git-no-checkout argument more useful, which would for already cloned rep […] ah I just read that part of the README again and you describe how to clone from the local repository, nice -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29116 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I612c18e533542f442e0571927fee8b8be9fb8c2b Gerrit-Change-Number: 29116 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 09:13:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: obs: add explicit --git-branch arg

by osmith

Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29116 ) Change subject: obs: add explicit --git-branch arg ...................................................................... Patch Set 1: (4 comments) Patchset: PS1: Personally I would find a --git-no-checkout argument more useful, which would for already cloned repositories simply not checkout and reset the branch. This has the advantage that one doesn't need to push to a remote git server first and then fetch and checkout as described in your README, but one could just directly edit the files in the cache directory. But I get the downside, that one is then working in two repository directories. So if this is more useful to you, let's add it. (And maybe I'll add the other option in another patch when I need it.) File scripts/obs/lib/__init__.py: https://gerrit.osmocom.org/c/osmo-ci/+/29116/comment/bb520a01_c7e185e2 PS1, Line 20: " named like the feed, checkout this git branch", by default the branch isn't always named like the feed: feed latest -> latest tag feed nightly -> master feed 2022q1 etc. -> 2022q1 so I'd change "named like" in this help string to "based on" File scripts/obs/lib/srcpkg.py: https://gerrit.osmocom.org/c/osmo-ci/+/29116/comment/d1c198be_85a2c303 PS1, Line 125: branch = feed this breaks the logic of checkout_for_feed, if the feed is latest or nightly it isn't the branch name. it should work as expected when just removing the "if not branch:" and "branch = feed" lines https://gerrit.osmocom.org/c/osmo-ci/+/29116/comment/8ab3476e_a6461c13 PS1, Line 139: unrelated -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29116 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I612c18e533542f442e0571927fee8b8be9fb8c2b Gerrit-Change-Number: 29116 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 09:00:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-gprs[master]: configure.ac: do require unused dlopen

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29100 ) Change subject: configure.ac: do require unused dlopen ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > looks like we don't have jenkins build verification yet? This should be done first so we get this fo […] Yep, I thought my https://gerrit.osmocom.org/c/osmo-ci/+/29019 would do this, but apparently some additional configuration is required. I'll talk to Oliver, maybe he has an idea. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29100 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iaf9729156ace5f8dc9134094ab3c0a185c7184d5 Gerrit-Change-Number: 29100 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 17 Aug 2022 08:33:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-sgsn[master]: configure.ac: do not require unused dlsym/dlopen

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/29102 ) Change subject: configure.ac: do not require unused dlsym/dlopen ...................................................................... configure.ac: do not require unused dlsym/dlopen Change-Id: I90b383ed45b27d8b59272116dd81acb72912349d --- M configure.ac 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index caa66d3..64b74e3 100644 --- a/configure.ac +++ b/configure.ac @@ -38,13 +38,6 @@ CFLAGS="$CFLAGS -std=gnu11" dnl checks for libraries -AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) -AC_SUBST(LIBRARY_DL) - -AC_SEARCH_LIBS([dlsym], [dl dld], [LIBRARY_DLSYM="$LIBS";LIBS=""]) -AC_SUBST(LIBRARY_DLSYM) - - PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.7.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.7.0) PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.7.0) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/29102 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I90b383ed45b27d8b59272116dd81acb72912349d Gerrit-Change-Number: 29102 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022