Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28275 )
Change subject: smscb: Tx CBSP FAILURE/RESTART for specific cell when it becomes (un)operational
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File src/osmo-bsc/smscb.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28275/comment/3368d5a7_5affd530
PS1, Line 487: cbsp
I'm not sure we should tell the CBC that the message data was lost. The BSC keeps all of the SMSCB state, so if a BTS/cell restarts, the BSC will re-install all the SMSCB/ETWS state in the cell [or at least it should, and I think we're doing this].
If we send the "data lost" flag, then the CBC will think it needs to re-send the SMSCB/ETWS for the cell in question, which is not true.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28275
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I94f0a1ac3c59cffe5af57f972d5d96fc92281d34
Gerrit-Change-Number: 28275
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 15 Jun 2022 20:43:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28291 )
Change subject: Move all SABP files to library/sabp/
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28291
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibfd0287194c87dcc240590e0835d6205ead194f9
Gerrit-Change-Number: 28291
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 15 Jun 2022 20:34:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment