Attention is currently required from: neels, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28286 )
Change subject: add libosmo-gtlv, moved from osmo-upf.git
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> - I thought it would be quick, but i've already spent hours on that, it is frustrating. […]
I'm not worried about library naming with or without dash, but src/{gsm,sim,...,gtlv} should not suddenly be src/libosmo-gtlv.
The problems you are seeing are more or less all attributed to the fact that the related code was developed outside of libosmocore (and a lot of stuff happened before gerrit in branches or separate repo) to begin with. So if the questions had been clarified early on, it would have been possible to avoid.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28286
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I25ab400f0c5707fdc0d8e480aca19871c2e26e71
Gerrit-Change-Number: 28286
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 16 Jun 2022 13:44:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28292 )
Change subject: Move SABP_Selftest.ttcn under library/sabp
......................................................................
Move SABP_Selftest.ttcn under library/sabp
Same as we already have for RANAP.
Change-Id: If04d973a393153a7cd15429d036f60adeea4b5f9
---
R library/sabp/SABP_Selftest.ttcn
1 file changed, 0 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/cbc/SABP_Selftest.ttcn b/library/sabp/SABP_Selftest.ttcn
similarity index 100%
rename from cbc/SABP_Selftest.ttcn
rename to library/sabp/SABP_Selftest.ttcn
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28292
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If04d973a393153a7cd15429d036f60adeea4b5f9
Gerrit-Change-Number: 28292
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28291 )
Change subject: Move all SABP files to library/sabp/
......................................................................
Move all SABP files to library/sabp/
Let's have all SABP related stuff together in one subdir, not some under
the subdir and some directly under library/.
Change-Id: Ibfd0287194c87dcc240590e0835d6205ead194f9
---
M cbc/gen_links.sh
R library/sabp/SABP_Adapter.ttcn
R library/sabp/SABP_CodecPort.ttcn
R library/sabp/SABP_CodecPort_CtrlFunct.ttcn
R library/sabp/SABP_CodecPort_CtrlFunctDef.cc
5 files changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/cbc/gen_links.sh b/cbc/gen_links.sh
index 075be2f..8b88605 100755
--- a/cbc/gen_links.sh
+++ b/cbc/gen_links.sh
@@ -31,6 +31,7 @@
DIR=../library/sabp
FILES="SABP_CommonDataTypes.asn SABP_Constants.asn SABP_Containers.asn SABP_IEs.asn SABP_PDU_Contents.asn SABP_PDU_Descriptions.asn SABP_Types.ttcn SABP_EncDec.cc SABP_Templates.ttcn "
+FILES+="SABP_CodecPort.ttcn SABP_CodecPort_CtrlFunct.ttcn SABP_CodecPort_CtrlFunctDef.cc SABP_Adapter.ttcn "
gen_links $DIR $FILES
DIR=$BASEDIR/titan.TestPorts.Common_Components.Abstract_Socket/src
@@ -51,7 +52,6 @@
FILES+="BSSMAP_Templates.ttcn "
FILES+="CBSP_Types.ttcn CBSP_Templates.ttcn "
FILES+="CBSP_CodecPort.ttcn CBSP_CodecPort_CtrlFunct.ttcn CBSP_CodecPort_CtrlFunctdef.cc CBSP_Adapter.ttcn "
-FILES+="SABP_CodecPort.ttcn SABP_CodecPort_CtrlFunct.ttcn SABP_CodecPort_CtrlFunctDef.cc SABP_Adapter.ttcn "
gen_links $DIR $FILES
ignore_pp_results
diff --git a/library/SABP_Adapter.ttcn b/library/sabp/SABP_Adapter.ttcn
similarity index 100%
rename from library/SABP_Adapter.ttcn
rename to library/sabp/SABP_Adapter.ttcn
diff --git a/library/SABP_CodecPort.ttcn b/library/sabp/SABP_CodecPort.ttcn
similarity index 100%
rename from library/SABP_CodecPort.ttcn
rename to library/sabp/SABP_CodecPort.ttcn
diff --git a/library/SABP_CodecPort_CtrlFunct.ttcn b/library/sabp/SABP_CodecPort_CtrlFunct.ttcn
similarity index 100%
rename from library/SABP_CodecPort_CtrlFunct.ttcn
rename to library/sabp/SABP_CodecPort_CtrlFunct.ttcn
diff --git a/library/SABP_CodecPort_CtrlFunctDef.cc b/library/sabp/SABP_CodecPort_CtrlFunctDef.cc
similarity index 100%
rename from library/SABP_CodecPort_CtrlFunctDef.cc
rename to library/sabp/SABP_CodecPort_CtrlFunctDef.cc
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28291
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibfd0287194c87dcc240590e0835d6205ead194f9
Gerrit-Change-Number: 28291
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged