June 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: Move RUA_Emulation under library/rua/

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28290 ) Change subject: Move RUA_Emulation under library/rua/ ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28290 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I22bc9b53675e1f8e6b7cd834b743aa90304b522e Gerrit-Change-Number: 28290 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jun 2022 20:34:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in docker-playground[master]: debian-bullseye-titan: Update libfftranscode 0.3->0.5

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28294 ) Change subject: debian-bullseye-titan: Update libfftranscode 0.3->0.5 ...................................................................... debian-bullseye-titan: Update libfftranscode 0.3->0.5 New version is needed for SBcAP support. Related: OS#4945 Change-Id: Ifcbd01e8ff4d00dbf1413e4d80a60e3e038d1661 --- M debian-bullseye-titan/Dockerfile 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian-bullseye-titan/Dockerfile b/debian-bullseye-titan/Dockerfile index 5ee3a06..125f02b 100644 --- a/debian-bullseye-titan/Dockerfile +++ b/debian-bullseye-titan/Dockerfile @@ -48,9 +48,9 @@ RUN apt-get update && \ apt-get -y install wget RUN DPKG_ARCH="$(dpkg --print-architecture)" && export $DPKG_ARCH && \ - wget https://ftp.osmocom.org/binaries/libfftranscode/libfftranscode0_0.3_${DPKG_… && \ - wget https://ftp.osmocom.org/binaries/libfftranscode/libfftranscode-dev_0.3_${DP… && \ - dpkg -i ./libfftranscode0_0.3_${DPKG_ARCH}.deb ./libfftranscode-dev_0.3_${DPKG_ARCH}.deb && \ + wget https://ftp.osmocom.org/binaries/libfftranscode/libfftranscode0_0.5_${DPKG_… && \ + wget https://ftp.osmocom.org/binaries/libfftranscode/libfftranscode-dev_0.5_${DP… && \ + dpkg -i ./libfftranscode0_0.5_${DPKG_ARCH}.deb ./libfftranscode-dev_0.5_${DPKG_ARCH}.deb && \ apt install --fix-broken && \ rm libfftranscode*.deb -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28294 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ifcbd01e8ff4d00dbf1413e4d80a60e3e038d1661 Gerrit-Change-Number: 28294 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in docker-playground[master]: debian-bullseye-titan: Update libfftranscode 0.3->0.5

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28294 ) Change subject: debian-bullseye-titan: Update libfftranscode 0.3->0.5 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28294 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ifcbd01e8ff4d00dbf1413e4d80a60e3e038d1661 Gerrit-Change-Number: 28294 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jun 2022 20:33:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: stats: track TCH/SDCCH lchans reaching fully-established state

by laforge

Attention is currently required from: iedemam. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28295 ) Change subject: stats: track TCH/SDCCH lchans reaching fully-established state ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28295 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I417940ad9479719f5324fb12d45883cd3cb2c578 Gerrit-Change-Number: 28295 Gerrit-PatchSet: 1 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Comment-Date: Wed, 15 Jun 2022 20:33:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: stats: track TCH/SDCCH lchans reaching fully-established state

by iedemam

iedemam has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28295 ) Change subject: stats: track TCH/SDCCH lchans reaching fully-established state ...................................................................... stats: track TCH/SDCCH lchans reaching fully-established state When calculating average lchan duration based on the new stats for BTS_CTR_CHAN_{TCH,SDCCH}_ACTIVE_MILLISECONDS_TOTAL there are discrepancies which emerge. Specificially in bandwidth-constrained environments, there are still-unknown failure states which can occur that cause the TCH or SDCCH activity count to increment but zero milliseconds of activity on the lchan to accumulate. This portrays a failure as a success. These new fully-established stats are intended to provide a more accurate denominator when calculating average lchan duration as they are incremented in proximity to the duration timestamp initialization. Change-Id: I417940ad9479719f5324fb12d45883cd3cb2c578 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bts.c M src/osmo-bsc/lchan_fsm.c 3 files changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/95/28295/1 diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index 66cf68f..13e10e3 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -62,6 +62,8 @@ BTS_CTR_CHAN_ACT_NACK, BTS_CTR_CHAN_TCH_ACTIVE_MILLISECONDS_TOTAL, BTS_CTR_CHAN_SDCCH_ACTIVE_MILLISECONDS_TOTAL, + BTS_CTR_CHAN_TCH_FULLY_ESTABLISHED, + BTS_CTR_CHAN_SDCCH_FULLY_ESTABLISHED, BTS_CTR_RSL_UNKNOWN, BTS_CTR_RSL_IPA_NACK, BTS_CTR_RSL_DELETE_IND, diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index d0adb2a..6d88ebc 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -1160,6 +1160,12 @@ [BTS_CTR_CHAN_SDCCH_ACTIVE_MILLISECONDS_TOTAL] = \ { "chan_sdcch:active_milliseconds:total", "Cumulative number of milliseconds of SDCCH channel activity" }, + [BTS_CTR_CHAN_TCH_FULLY_ESTABLISHED] = \ + { "chan_tch:fully_established", + "Number of TCH channels which have reached the fully established state" }, + [BTS_CTR_CHAN_SDCCH_FULLY_ESTABLISHED] = \ + { "chan_sdcch:fully_established", + "Number of SDCCH channels which have reached the fully established state" }, [BTS_CTR_RSL_UNKNOWN] = \ { "rsl:unknown", "Number of unknown/unsupported RSL messages received from BTS" }, diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index 2d566b6..41b7ae7 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -208,6 +208,19 @@ osmo_clock_gettime(CLOCK_MONOTONIC, &lchan->active_start); lchan->active_stored = lchan->active_start; + /* Increment rate counters tracking fully established lchans. */ + switch (lchan->type) { + case GSM_LCHAN_TCH_H: + case GSM_LCHAN_TCH_F: + rate_ctr_inc(rate_ctr_group_get_ctr(lchan->ts->trx->bts->bts_ctrs, BTS_CTR_CHAN_TCH_FULLY_ESTABLISHED)); + break; + case GSM_LCHAN_SDCCH: + rate_ctr_inc(rate_ctr_group_get_ctr(lchan->ts->trx->bts->bts_ctrs, BTS_CTR_CHAN_SDCCH_FULLY_ESTABLISHED)); + break; + default: + break; + } + switch (lchan->activate.info.activ_for) { case ACTIVATE_FOR_MS_CHANNEL_REQUEST: /* No signalling to do here, MS is free to use the channel, and should go on to connect -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28295 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I417940ad9479719f5324fb12d45883cd3cb2c578 Gerrit-Change-Number: 28295 Gerrit-PatchSet: 1 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in docker-playground[master]: debian-bullseye-titan: Update libfftranscode 0.3->0.5

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/28294 to look at the new patch set (#2). Change subject: debian-bullseye-titan: Update libfftranscode 0.3->0.5 ...................................................................... debian-bullseye-titan: Update libfftranscode 0.3->0.5 New version is needed for SBcAP support. Related: OS#4945 Change-Id: Ifcbd01e8ff4d00dbf1413e4d80a60e3e038d1661 --- M debian-bullseye-titan/Dockerfile 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/94/28294/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28294 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ifcbd01e8ff4d00dbf1413e4d80a60e3e038d1661 Gerrit-Change-Number: 28294 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in docker-playground[master]: debian-bullseye-titan: Update libfftranscode 0.3->0.5

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/28294 ) Change subject: debian-bullseye-titan: Update libfftranscode 0.3->0.5 ...................................................................... debian-bullseye-titan: Update libfftranscode 0.3->0.5 Change-Id: Ifcbd01e8ff4d00dbf1413e4d80a60e3e038d1661 --- M debian-bullseye-titan/Dockerfile 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/94/28294/1 diff --git a/debian-bullseye-titan/Dockerfile b/debian-bullseye-titan/Dockerfile index 5ee3a06..125f02b 100644 --- a/debian-bullseye-titan/Dockerfile +++ b/debian-bullseye-titan/Dockerfile @@ -48,9 +48,9 @@ RUN apt-get update && \ apt-get -y install wget RUN DPKG_ARCH="$(dpkg --print-architecture)" && export $DPKG_ARCH && \ - wget https://ftp.osmocom.org/binaries/libfftranscode/libfftranscode0_0.3_${DPKG_… && \ - wget https://ftp.osmocom.org/binaries/libfftranscode/libfftranscode-dev_0.3_${DP… && \ - dpkg -i ./libfftranscode0_0.3_${DPKG_ARCH}.deb ./libfftranscode-dev_0.3_${DPKG_ARCH}.deb && \ + wget https://ftp.osmocom.org/binaries/libfftranscode/libfftranscode0_0.5_${DPKG_… && \ + wget https://ftp.osmocom.org/binaries/libfftranscode/libfftranscode-dev_0.5_${DP… && \ + dpkg -i ./libfftranscode0_0.5_${DPKG_ARCH}.deb ./libfftranscode-dev_0.5_${DPKG_ARCH}.deb && \ apt install --fix-broken && \ rm libfftranscode*.deb -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28294 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ifcbd01e8ff4d00dbf1413e4d80a60e3e038d1661 Gerrit-Change-Number: 28294 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: Move all SABP files to library/sabp/

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28291 ) Change subject: Move all SABP files to library/sabp/ ...................................................................... Move all SABP files to library/sabp/ Let's have all SABP related stuff together in one subdir, not some under the subdir and some directly under library/. Change-Id: Ibfd0287194c87dcc240590e0835d6205ead194f9 --- M cbc/gen_links.sh R library/sabp/SABP_Adapter.ttcn R library/sabp/SABP_CodecPort.ttcn R library/sabp/SABP_CodecPort_CtrlFunct.ttcn R library/sabp/SABP_CodecPort_CtrlFunctDef.cc 5 files changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/91/28291/1 diff --git a/cbc/gen_links.sh b/cbc/gen_links.sh index 075be2f..8b88605 100755 --- a/cbc/gen_links.sh +++ b/cbc/gen_links.sh @@ -31,6 +31,7 @@ DIR=../library/sabp FILES="SABP_CommonDataTypes.asn SABP_Constants.asn SABP_Containers.asn SABP_IEs.asn SABP_PDU_Contents.asn SABP_PDU_Descriptions.asn SABP_Types.ttcn SABP_EncDec.cc SABP_Templates.ttcn " +FILES+="SABP_CodecPort.ttcn SABP_CodecPort_CtrlFunct.ttcn SABP_CodecPort_CtrlFunctDef.cc SABP_Adapter.ttcn " gen_links $DIR $FILES DIR=$BASEDIR/titan.TestPorts.Common_Components.Abstract_Socket/src @@ -51,7 +52,6 @@ FILES+="BSSMAP_Templates.ttcn " FILES+="CBSP_Types.ttcn CBSP_Templates.ttcn " FILES+="CBSP_CodecPort.ttcn CBSP_CodecPort_CtrlFunct.ttcn CBSP_CodecPort_CtrlFunctdef.cc CBSP_Adapter.ttcn " -FILES+="SABP_CodecPort.ttcn SABP_CodecPort_CtrlFunct.ttcn SABP_CodecPort_CtrlFunctDef.cc SABP_Adapter.ttcn " gen_links $DIR $FILES ignore_pp_results diff --git a/library/SABP_Adapter.ttcn b/library/sabp/SABP_Adapter.ttcn similarity index 100% rename from library/SABP_Adapter.ttcn rename to library/sabp/SABP_Adapter.ttcn diff --git a/library/SABP_CodecPort.ttcn b/library/sabp/SABP_CodecPort.ttcn similarity index 100% rename from library/SABP_CodecPort.ttcn rename to library/sabp/SABP_CodecPort.ttcn diff --git a/library/SABP_CodecPort_CtrlFunct.ttcn b/library/sabp/SABP_CodecPort_CtrlFunct.ttcn similarity index 100% rename from library/SABP_CodecPort_CtrlFunct.ttcn rename to library/sabp/SABP_CodecPort_CtrlFunct.ttcn diff --git a/library/SABP_CodecPort_CtrlFunctDef.cc b/library/sabp/SABP_CodecPort_CtrlFunctDef.cc similarity index 100% rename from library/SABP_CodecPort_CtrlFunctDef.cc rename to library/sabp/SABP_CodecPort_CtrlFunctDef.cc -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28291 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibfd0287194c87dcc240590e0835d6205ead194f9 Gerrit-Change-Number: 28291 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: Move SABP_Selftest.ttcn under library/sabp

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28292 ) Change subject: Move SABP_Selftest.ttcn under library/sabp ...................................................................... Move SABP_Selftest.ttcn under library/sabp Same as we already have for RANAP. Change-Id: If04d973a393153a7cd15429d036f60adeea4b5f9 --- R library/sabp/SABP_Selftest.ttcn 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/92/28292/1 diff --git a/cbc/SABP_Selftest.ttcn b/library/sabp/SABP_Selftest.ttcn similarity index 100% rename from cbc/SABP_Selftest.ttcn rename to library/sabp/SABP_Selftest.ttcn -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28292 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If04d973a393153a7cd15429d036f60adeea4b5f9 Gerrit-Change-Number: 28292 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: SABP: Add regen_makefile.sh

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28293 ) Change subject: SABP: Add regen_makefile.sh ...................................................................... SABP: Add regen_makefile.sh Other similar libraries also have it. Change-Id: I74b31c041b254713b95821ff166640465ccd1409 --- A library/sabp/regen_makefile.sh 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/93/28293/1 diff --git a/library/sabp/regen_makefile.sh b/library/sabp/regen_makefile.sh new file mode 100755 index 0000000..382fbd5 --- /dev/null +++ b/library/sabp/regen_makefile.sh @@ -0,0 +1,9 @@ +#!/bin/sh + +FILES="*.asn *.ttcn SABP_EncDec.cc" + +../../regen-makefile.sh $FILES + +sed -i -e '/^CPPFLAGS/ s/$/ `pkg-config --cflags libfftranscode`/' Makefile +sed -i -e '/^LDFLAGS/ s/$/ `pkg-config --libs libfftranscode`/' Makefile +sed -i -e '/^LINUX_LIBS/ s/$/ `pkg-config --libs libfftranscode`/' Makefile -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28293 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I74b31c041b254713b95821ff166640465ccd1409 Gerrit-Change-Number: 28293 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2022