June 2022 - gerrit-log - lists.osmocom.org

Change in osmo-hnbgw[master]: mgw_fsm: Simplify cleanup paths

by pespin

Attention is currently required from: pespin, dexter. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28284 to look at the new patch set (#2). Change subject: mgw_fsm: Simplify cleanup paths ...................................................................... mgw_fsm: Simplify cleanup paths Let's have a unified way of freeing the FSM instance once it was allocated, otherwise it's far more difficult to understand and maintain. Change-Id: I8883e737fa112cff57834abae7ef272388a54edb --- M src/osmo-hnbgw/mgw_fsm.c 1 file changed, 34 insertions(+), 43 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/84/28284/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28284 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I8883e737fa112cff57834abae7ef272388a54edb Gerrit-Change-Number: 28284 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in osmo-hnbgw[master]: mgw_fsm: Fix error path accessing uninitialized fsm ptr

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28283 ) Change subject: mgw_fsm: Fix error path accessing uninitialized fsm ptr ...................................................................... mgw_fsm: Fix error path accessing uninitialized fsm ptr The error handling of the error path was wrong. Let's remove the "fi" variable to avoid more of such errors. Furthermore, add an assert to clarify for the reader that the map->mgw_fi will be freed before allocating a new FSM instance below. Change-Id: I9d3bca552bfa77f5e18f75bedad8d422f74df1f8 --- M src/osmo-hnbgw/mgw_fsm.c 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/src/osmo-hnbgw/mgw_fsm.c b/src/osmo-hnbgw/mgw_fsm.c index 2b7484f..1360849 100644 --- a/src/osmo-hnbgw/mgw_fsm.c +++ b/src/osmo-hnbgw/mgw_fsm.c @@ -658,7 +658,6 @@ int handle_rab_ass_req(struct hnbgw_context_map *map, struct osmo_prim_hdr *oph, ranap_message *message) { static bool initialized = false; - struct osmo_fsm_inst *fi; struct mgw_fsm_priv *mgw_fsm_priv; struct osmo_sockaddr addr; struct osmo_sockaddr_str addr_str; @@ -683,7 +682,8 @@ LOGPFSML(map->mgw_fi, LOGL_ERROR, "mgw_fsm_alloc_and_handle_rab_ass_req() unable to handle RAB-AssignmentRequest!\n"); - osmo_fsm_inst_state_chg(fi, MGW_ST_FAILURE, 0, 0); + osmo_fsm_inst_state_chg(map->mgw_fi, MGW_ST_FAILURE, 0, 0); + OSMO_ASSERT(map->mgw_fi == NULL); } mgw_fsm_priv = talloc_zero(map, struct mgw_fsm_priv); @@ -723,9 +723,8 @@ /* Allocate the FSM and start it. */ mgw_fsm_priv->map = map; snprintf(fsm_name, sizeof(fsm_name), "mgw-fsm-%u-%u", map->rua_ctx_id, mgw_fsm_priv->rab_id); - fi = osmo_fsm_inst_alloc(&mgw_fsm, map, mgw_fsm_priv, LOGL_DEBUG, fsm_name); - map->mgw_fi = fi; - mgw_fsm_state_chg(fi, MGW_ST_CRCX_HNB); + map->mgw_fi = osmo_fsm_inst_alloc(&mgw_fsm, map, mgw_fsm_priv, LOGL_DEBUG, fsm_name); + mgw_fsm_state_chg(map->mgw_fi, MGW_ST_CRCX_HNB); return 0; error: -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28283 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I9d3bca552bfa77f5e18f75bedad8d422f74df1f8 Gerrit-Change-Number: 28283 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-upf[master]: move libosmo-gtlv to libosmocore.git

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28287 ) Change subject: move libosmo-gtlv to libosmocore.git ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28287 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Id72cdf94da60d4b6d09d0044c74e672c4412c15d Gerrit-Change-Number: 28287 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jun 2022 09:48:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-hnbgw[master]: mgw_fsm: Simplify cleanup paths

by fixeria

Attention is currently required from: pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28284 ) Change subject: mgw_fsm: Simplify cleanup paths ...................................................................... Patch Set 1: (2 comments) File src/osmo-hnbgw/mgw_fsm.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28284/comment/fde0a44a_742c4232 PS1, Line 158: mgw_fsm_alloc_and_handle_rab_ass_req This is not valid anymore and should be removed. LOGPFSML() will provide enough context for logging messages. https://gerrit.osmocom.org/c/osmo-hnbgw/+/28284/comment/0ed3223a_643f9541 PS1, Line 167: mgw_fsm_alloc_and_handle_rab_ass_req Same here. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28284 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I8883e737fa112cff57834abae7ef272388a54edb Gerrit-Change-Number: 28284 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jun 2022 09:36:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: cosmetic tweak in Makefile.am

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28285 ) Change subject: cosmetic tweak in Makefile.am ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I141e502ffbb1a45f9751943d47766bdfbf77484a Gerrit-Change-Number: 28285 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jun 2022 09:21:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-hnbgw[master]: mgw_fsm: Fix error path accessing uninitialized fsm ptr

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28283 ) Change subject: mgw_fsm: Fix error path accessing uninitialized fsm ptr ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28283 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I9d3bca552bfa77f5e18f75bedad8d422f74df1f8 Gerrit-Change-Number: 28283 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jun 2022 09:18:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in pysim[master]: cards: populate ADM1 key reference member

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28278 ) Change subject: cards: populate ADM1 key reference member ...................................................................... Patch Set 1: (3 comments) Commit Message: https://gerrit.osmocom.org/c/pysim/+/28278/comment/2ecf7bc9_1f32ac36 PS1, Line 9: speficy specify? https://gerrit.osmocom.org/c/pysim/+/28278/comment/ef6424be_a56e3edd PS1, Line 10: inherets inherits File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/28278/comment/16360fd8_1e3bf294 PS1, Line 350: print("NOW") This looks like a debugging leftover that should have been removed. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28278 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I96af395b1832f4462a6043cca3bb3812fddac612 Gerrit-Change-Number: 28278 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jun 2022 09:17:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: Expand VTY option which controls use of TCH for signalling

by fixeria

Attention is currently required from: iedemam, neels, laforge, pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28276 ) Change subject: Expand VTY option which controls use of TCH for signalling ...................................................................... Patch Set 5: Code-Review-1 (2 comments) File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/f34745a7_1e9413ef PS5, Line 568: chan_alloc_allow Why are you removing this part? It's still a channel allocator specific option, right? https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/84e3e321_db602deb PS5, Line 582: !strcmp(argv[0], "0") argv[0] can not be "0" or "1" anymore (because you've changed the command vector from '0|1' to 'never|voice|always'). You should add an alias for backwards-compatibility, `grep ALIAS_DEPRECATED` for examples. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28276 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4459941ddad4e4a3bec8409b180d9a23a735e640 Gerrit-Change-Number: 28276 Gerrit-PatchSet: 5 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jun 2022 09:14:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: add libosmo-gtlv, moved from osmo-upf.git

by neels

Attention is currently required from: laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28286 ) Change subject: add libosmo-gtlv, moved from osmo-upf.git ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > I don't like mixing conventions in a single project (here: libosmocore), sorry :/ up to what level does this hold? I assume I have to move the per-subdir Makefile.am that we have in all other osmo.gits to the single toplevel Makefile.am scheme that is in libosmocore.git. I can rename tests/libosmo-gtlv to tests/gtlv. Do I have to remove the dash from "libosmo-gtlv"? It would match libosmogsm, libosmovty and the others in libosmocore.git, but it would not match libosmo-pfcp, libosmo-sccp, libosmo-abis, etc. I'd have to also remove the dash in the places that use libosmo-gtlv. The dash was fine in osmo-upf.git, I'd like to keep it. All of the above is functionally invisible gruntwork. Can I still change my mind and rather move libosmo-gtlv to libosmo-pfcp.git? Or, what about a separate libosmo-gtlv.git? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28286 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I25ab400f0c5707fdc0d8e480aca19871c2e26e71 Gerrit-Change-Number: 28286 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 14 Jun 2022 22:10:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: add libosmo-gtlv, moved from osmo-upf.git

by neels

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/28286 to look at the new patch set (#2). Change subject: add libosmo-gtlv, moved from osmo-upf.git ...................................................................... add libosmo-gtlv, moved from osmo-upf.git libosmo-gtlv does not strictly conform to the libosmocore Makefile.am structure, because it was first added in osmo-upf.git, and because we use other Makefile.am conventions outside of libosmocore.git: - use of SUBDIRS instead of single top level Makefile.am - name of libosmo-gtlv with a dash, other libs here omit a dash. - name of src dirs being "libosmo-gtlv" instead of just "gtlv". I hope that code review agrees with this choice of rather keeping the code conforming to our conventions that we established later, and not strictly changing to follow "legacy" conventions in libosmocore.git. Pasting initial libosmo-gtlv commit logs from osmo-upf.git: (1) TLV skeleton traversal: An all new TLV parser supporting: - Any size of T and L (determined by callback function), - "Grouped IEs", so that an IE payload is a nested IE structure, - optional/mandatory/multi-occurence IEs, - decoding unordered tags (or enforcing strict order). Will be used for PFCP message decoding and encoding, a T16L16V protocol which requires above features. Upcoming patches add - translating PDUs to plain C structs and vice versa - TLV generator to reduce repetition a in protocol definition - TLIV capability Previously, the way we deal with TLVs causes a lot of code re-implementation: the TL decoding is taken care of by the API, but for encoding, we essentially re-implement each protocol and each encoded message in the individual programs. This API is an improvement in that we only once implement the TL coding (or just use osmo_t8l8v_cfg / osmo_t16l16v_cfg), get symmetric de- and encoding of the TL, and only need to deal with the value part of each IE. The common pattern of - store TL preliminarily, - write V data and - update L after V is complete is conveniently done by osmo_gtlv_put_update_tl(). (2) Decoding and encoding user data: Add osmo_gtlv_coding: describe the value part of a TLV (decode and encode), describe a struct with its members, and get/put readily decoded structs from/to a raw PDU, directly. With osmo_gtlv_coding defined for a protocol's tags, we only deal with encoded PDUs or fully decoded C structs, no TLV related re-implementations clutter up the message handling code. A usage example is given in gtlv_dec_enc_test. The first real use will be the PFCP protocol in osmo-upf.git. With osmo_gtlv_coding, there still is a lot of monkey work involved in describing the decoded structs. A subsequent patch adds a generator for osmo_gtlv_coding and message structs from tag value lists. (3) TLIV support: During code review, it was indicated that some TLV protocols that we will likely deal with in the near future also employ an I, an instance value of a tag. Add TLIV support. A usage example for a manually implemented TLIV structure is found in tests/libosmo-gtlv/gtlv_test.c. A usage example for a generated TLIV protocol is found in tests/libosmo-gtlv/test_tliv/. Related: OS#5599 Related: Id72cdf94da60d4b6d09d0044c74e672c4412c15d (osmo-upf) Change-Id: I25ab400f0c5707fdc0d8e480aca19871c2e26e71 --- M Makefile.am M configure.ac M include/Makefile.am A include/osmocom/gtlv/gtlv.h A include/osmocom/gtlv/gtlv_dec_enc.h A include/osmocom/gtlv/gtlv_gen.h A libosmo-gtlv.pc.in A src/libosmo-gtlv/Makefile.am A src/libosmo-gtlv/gtlv.c A src/libosmo-gtlv/gtlv_dec_enc.c A src/libosmo-gtlv/gtlv_gen.c M tests/Makefile.am A tests/libosmo-gtlv/Makefile.am A tests/libosmo-gtlv/gtlv_dec_enc_test.c A tests/libosmo-gtlv/gtlv_dec_enc_test.ok A tests/libosmo-gtlv/gtlv_test.c A tests/libosmo-gtlv/gtlv_test.ok A tests/libosmo-gtlv/test_gtlv_gen/Makefile.am A tests/libosmo-gtlv/test_gtlv_gen/gen__myproto_ies_auto.c A tests/libosmo-gtlv/test_gtlv_gen/gtlv_gen_test.c A tests/libosmo-gtlv/test_gtlv_gen/gtlv_gen_test.ok A tests/libosmo-gtlv/test_gtlv_gen/myproto_ies_custom.c A tests/libosmo-gtlv/test_gtlv_gen/myproto_ies_custom.h A tests/libosmo-gtlv/test_tliv/Makefile.am A tests/libosmo-gtlv/test_tliv/gen__myproto_ies_auto.c A tests/libosmo-gtlv/test_tliv/myproto_ies_custom.c A tests/libosmo-gtlv/test_tliv/myproto_ies_custom.h A tests/libosmo-gtlv/test_tliv/tliv_test.c A tests/libosmo-gtlv/test_tliv/tliv_test.ok M tests/testsuite.at 30 files changed, 4,780 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/86/28286/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28286 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I25ab400f0c5707fdc0d8e480aca19871c2e26e71 Gerrit-Change-Number: 28286 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2022