June 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: Expand VTY option which controls use of TCH for signalling

by iedemam

Attention is currently required from: neels, laforge, pespin, fixeria, dexter. iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28276 ) Change subject: Expand VTY option which controls use of TCH for signalling ...................................................................... Patch Set 5: (2 comments) File include/osmocom/bsc/bts.h: https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/65277dc1_14f22274 PS4, Line 524: chan_alloc_allow_tch_for_signalling > cosmetic: I'd rename it to "tch_for_signalling_policy" or something like that which makes it more cl […] Done File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/f1bfae62_997c3ccd PS4, Line 568: DEFUN_ATTR > it might be nice to add a backwards-compatibility alias for the (0|1) so old config files still pars […] Agreed. This should be in place already, perhaps I've not gotten it correct though. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28276 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4459941ddad4e4a3bec8409b180d9a23a735e640 Gerrit-Change-Number: 28276 Gerrit-PatchSet: 5 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jun 2022 20:18:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: Expand VTY option which controls use of TCH for signalling

by iedemam

Attention is currently required from: iedemam, neels, pespin, fixeria, dexter. Hello Jenkins Builder, neels, laforge, fixeria, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/28276 to look at the new patch set (#5). Change subject: Expand VTY option which controls use of TCH for signalling ...................................................................... Expand VTY option which controls use of TCH for signalling For statistical clarity and site tuning, it is sometimes desirable to completely disable the use of TCH for signaling. In the existing version of this VTY command, there is no way to accomplish this. We can only restrict TCH for signaling non-voice related actions. This patch adds the ability to completely disable signaling on TCH. Change-Id: I4459941ddad4e4a3bec8409b180d9a23a735e640 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_vty.c M tests/osmo-bsc.vty 5 files changed, 43 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/76/28276/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28276 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4459941ddad4e4a3bec8409b180d9a23a735e640 Gerrit-Change-Number: 28276 Gerrit-PatchSet: 5 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in pysim[master]: cards: populate ADM1 key reference member

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28278 ) Change subject: cards: populate ADM1 key reference member ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28278 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I96af395b1832f4462a6043cca3bb3812fddac612 Gerrit-Change-Number: 28278 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jun 2022 19:58:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in pysim[master]: pySim-shell: set default ADM key reference

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/28277 ) Change subject: pySim-shell: set default ADM key reference ...................................................................... pySim-shell: set default ADM key reference ETSI TS 102 221, Table 9.3 specifies 0x0A as default key reference for ADM1. Lets make sure pySim-shell uses this key-reference if the card is a generic UICC. Change-Id: I8a96244269dc6619f39a5369502b15b83740ee45 --- M pySim-shell.py 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim-shell.py b/pySim-shell.py index f498dea..e52c4ef 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -83,16 +83,26 @@ print("Card not readable!") return None, None + generic_card = False card = card_detect("auto", scc) if card is None: print("Warning: Could not detect card type - assuming a generic card type...") card = SimCard(scc) + generic_card = True profile = CardProfile.pick(scc) if profile is None: print("Unsupported card type!") return None, card + # ETSI TS 102 221, Table 9.3 specifies a default for the PIN key + # references, however card manufactures may still decide to pick an + # arbitrary key reference. In case we run on a generic card class that is + # detected as an UICC, we will pick the key reference that is officially + # specified. + if generic_card and isinstance(profile, CardProfileUICC): + card._adm_chv_num = 0x0A + print("Info: Card is of type: %s" % str(profile)) # FIXME: This shouln't be here, the profile should add the applications, -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28277 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8a96244269dc6619f39a5369502b15b83740ee45 Gerrit-Change-Number: 28277 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in pysim[master]: pySim-shell: set default ADM key reference

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28277 ) Change subject: pySim-shell: set default ADM key reference ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28277 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8a96244269dc6619f39a5369502b15b83740ee45 Gerrit-Change-Number: 28277 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jun 2022 19:57:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-hnbgw[master]: mgw_fsm: Fix error path accessing uninitialized fsm ptr

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28283 ) Change subject: mgw_fsm: Fix error path accessing uninitialized fsm ptr ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28283 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I9d3bca552bfa77f5e18f75bedad8d422f74df1f8 Gerrit-Change-Number: 28283 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jun 2022 19:56:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-hnbgw[master]: mgw_fsm: Change macro to not use local variables implicitly

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28282 ) Change subject: mgw_fsm: Change macro to not use local variables implicitly ...................................................................... mgw_fsm: Change macro to not use local variables implicitly This is misleading for readers since it may access variables which may be uninitialized or in a wrong state. Furthermore, we want to pass some other variable name in a follow up patch. This effectively allows the compiler to warn about uninitialized used of a fi var in line 661. Change-Id: Id694f51bb2918fd27da87b3f4a905727cd7f5de6 --- M src/osmo-hnbgw/mgw_fsm.c 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-hnbgw/mgw_fsm.c b/src/osmo-hnbgw/mgw_fsm.c index 5dd613f..2b7484f 100644 --- a/src/osmo-hnbgw/mgw_fsm.c +++ b/src/osmo-hnbgw/mgw_fsm.c @@ -134,7 +134,7 @@ [MGW_ST_CRCX_MSC] = {.T = -1004 }, }; -#define mgw_fsm_state_chg(state) \ +#define mgw_fsm_state_chg(fi, state) \ osmo_tdef_fsm_inst_state_chg(fi, state, mgw_fsm_timeouts, mgw_fsm_T_defs, -1) static void mgw_fsm_crcx_hnb_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state) @@ -206,7 +206,7 @@ return; } - mgw_fsm_state_chg(MGW_ST_ASSIGN); + mgw_fsm_state_chg(fi, MGW_ST_ASSIGN); return; default: OSMO_ASSERT(false); @@ -237,7 +237,7 @@ { switch (event) { case MGW_EV_RAB_ASS_RESP: - mgw_fsm_state_chg(MGW_ST_MDCX_HNB); + mgw_fsm_state_chg(fi, MGW_ST_MDCX_HNB); return; default: OSMO_ASSERT(false); @@ -325,7 +325,7 @@ osmo_fsm_inst_state_chg(fi, MGW_ST_FAILURE, 0, 0); return; } - mgw_fsm_state_chg(MGW_ST_CRCX_MSC); + mgw_fsm_state_chg(fi, MGW_ST_CRCX_MSC); return; default: OSMO_ASSERT(false); @@ -725,7 +725,7 @@ snprintf(fsm_name, sizeof(fsm_name), "mgw-fsm-%u-%u", map->rua_ctx_id, mgw_fsm_priv->rab_id); fi = osmo_fsm_inst_alloc(&mgw_fsm, map, mgw_fsm_priv, LOGL_DEBUG, fsm_name); map->mgw_fi = fi; - mgw_fsm_state_chg(MGW_ST_CRCX_HNB); + mgw_fsm_state_chg(fi, MGW_ST_CRCX_HNB); return 0; error: -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28282 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Id694f51bb2918fd27da87b3f4a905727cd7f5de6 Gerrit-Change-Number: 28282 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-hnbgw[master]: mgw_fsm: Mark structs as static const

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28279 ) Change subject: mgw_fsm: Mark structs as static const ...................................................................... mgw_fsm: Mark structs as static const Change-Id: Ie62f28587c08296429c0dabda7b6add67ffa010c --- M src/osmo-hnbgw/mgw_fsm.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-hnbgw/mgw_fsm.c b/src/osmo-hnbgw/mgw_fsm.c index b84d87e..e71624b 100644 --- a/src/osmo-hnbgw/mgw_fsm.c +++ b/src/osmo-hnbgw/mgw_fsm.c @@ -122,12 +122,12 @@ uint16_t msc_rtp_port; }; -struct osmo_tdef mgw_tdefs[] = { +static const struct osmo_tdef mgw_tdefs[] = { {.T = -2427, .default_val = 5, .desc = "timeout for MGCP response from MGW" }, { } }; -struct osmo_tdef_state_timeout mgw_fsm_timeouts[32] = { +static const struct osmo_tdef_state_timeout mgw_fsm_timeouts[32] = { [MGW_ST_CRCX_HNB] = {.T = -1001 }, [MGW_ST_ASSIGN] = {.T = -1002 }, [MGW_ST_MDCX_HNB] = {.T = -1003 }, -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ie62f28587c08296429c0dabda7b6add67ffa010c Gerrit-Change-Number: 28279 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-hnbgw[master]: mgw_fsm: Improve logging

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28280 ) Change subject: mgw_fsm: Improve logging ...................................................................... mgw_fsm: Improve logging Change-Id: I14785b6bc798c3bae8c552bccb55ca4fa9f2f416 --- M src/osmo-hnbgw/mgw_fsm.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-hnbgw/mgw_fsm.c b/src/osmo-hnbgw/mgw_fsm.c index e71624b..1974e33 100644 --- a/src/osmo-hnbgw/mgw_fsm.c +++ b/src/osmo-hnbgw/mgw_fsm.c @@ -176,7 +176,7 @@ case MGW_EV_MGCP_OK: mgw_info = osmo_mgcpc_ep_ci_get_rtp_info(mgw_fsm_priv->mgcpc_ep_ci_hnb); if (!mgw_info) { - LOGPFSML(fi, LOGL_ERROR, "Got no response from MGW\n"); + LOGPFSML(fi, LOGL_ERROR, "Got no RTP info response from MGW\n"); osmo_fsm_inst_state_chg(fi, MGW_ST_FAILURE, 0, 0); return; } @@ -321,7 +321,7 @@ case MGW_EV_MGCP_OK: mgw_info = osmo_mgcpc_ep_ci_get_rtp_info(mgw_fsm_priv->mgcpc_ep_ci_hnb); if (!mgw_info) { - LOGPFSML(fi, LOGL_ERROR, "Got no response from MGW\n"); + LOGPFSML(fi, LOGL_ERROR, "Got no RTP info response from MGW\n"); osmo_fsm_inst_state_chg(fi, MGW_ST_FAILURE, 0, 0); return; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28280 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I14785b6bc798c3bae8c552bccb55ca4fa9f2f416 Gerrit-Change-Number: 28280 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-hnbgw[master]: cosmetic: mgw_fsm: Fix typo in log

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28281 ) Change subject: cosmetic: mgw_fsm: Fix typo in log ...................................................................... cosmetic: mgw_fsm: Fix typo in log Change-Id: I80aa61a288ab37c51510af67c784498f5949fc50 --- M src/osmo-hnbgw/mgw_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-hnbgw/mgw_fsm.c b/src/osmo-hnbgw/mgw_fsm.c index 1974e33..5dd613f 100644 --- a/src/osmo-hnbgw/mgw_fsm.c +++ b/src/osmo-hnbgw/mgw_fsm.c @@ -672,7 +672,7 @@ initialized = true; } - /* The RTP stream negortiation usually begins with a RAB-AssignmentRequest and ends with an IU-Release, however + /* The RTP stream negotiation usually begins with a RAB-AssignmentRequest and ends with an IU-Release, however * it may also be thet the MSC decides to release the RAB with a dedicated RAB-AssignmentRequest that contains * a ReleaseList. In this case an FSM will already be present. */ if (map->mgw_fi) { -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28281 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I80aa61a288ab37c51510af67c784498f5949fc50 Gerrit-Change-Number: 28281 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2022