June 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: Expand VTY option which controls use of TCH for signalling

by iedemam

Attention is currently required from: iedemam, neels, laforge, dexter. Hello Jenkins Builder, neels, laforge, fixeria, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/28276 to look at the new patch set (#6). Change subject: Expand VTY option which controls use of TCH for signalling ...................................................................... Expand VTY option which controls use of TCH for signalling For statistical clarity and site tuning, it is sometimes desirable to completely disable the use of TCH for signaling. In the existing version of this VTY command, there is no way to accomplish this. We can only restrict TCH for signaling non-voice related actions. This patch deprecates 'allow-tch-for-signalling (0|1)' and adds 'tch-signalling-policy (never|voice|always)' to provide more options. Change-Id: I4459941ddad4e4a3bec8409b180d9a23a735e640 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_vty.c M tests/osmo-bsc.vty 5 files changed, 65 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/76/28276/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28276 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4459941ddad4e4a3bec8409b180d9a23a735e640 Gerrit-Change-Number: 28276 Gerrit-PatchSet: 6 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix race conditions in TC_imm_ass_pre_{ts,chan}_ack_dyn_ts

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28289 ) Change subject: BSC_Tests: fix race conditions in TC_imm_ass_pre_{ts,chan}_ack_dyn_ts ...................................................................... BSC_Tests: fix race conditions in TC_imm_ass_pre_{ts,chan}_ack_dyn_ts The TC_imm_ass_pre_chan_ack_dyn_ts sporadically fails on Jenkins. Similar to [1], this is happening because the VTY command setting the 'immediate-assignment' strategy back to 'post-chan-ack' is being sent/processed earlier than the CHANnel REQ message. TC_imm_ass_pre_ts_ack_dyn_ts is likely affected too, also fix it. Change-Id: I1e38142d29d0fa2946a858eac13319aa05b42aa3 Related: [1] I38cd31041741b69eb15098a089b4d4b6b918ffd4 --- M bsc/BSC_Tests.ttcn 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 8de3dcb..200fd5b 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -11081,9 +11081,6 @@ var uint8_t ra := 2; f_ipa_tx(ts_RSL_CHAN_RQD(int2oct(ra, 1), fn)); - /* (set bts 0 cfg back to default) */ - f_vty_set_imm_ass(BSCVTY); - /* Expect the dyn TS to deactivate PDCH first */ f_exp_ipa_rx(tr_RSL_RF_CHAN_REL(chan_nr)); f_ipa_tx(ts_RSL_RF_CHAN_REL_ACK(chan_nr)); @@ -11116,6 +11113,9 @@ dt.sccp_conn_id := rx_c_ind.connectionId; BSSAP.send(ts_BSSAP_CONNECT_res(rx_c_ind.connectionId)); + /* (set bts 0 cfg back to default) */ + f_vty_set_imm_ass(BSCVTY); + f_sleep(1.0); f_perform_clear_test_ct(dt); f_shutdown_helper(); @@ -11153,9 +11153,6 @@ var uint8_t ra := 2; f_ipa_tx(ts_RSL_CHAN_RQD(int2oct(ra, 1), fn)); - /* (set bts 0 cfg back to default) */ - f_vty_set_imm_ass(BSCVTY); - /* Expect the dyn TS to deactivate PDCH first */ f_exp_ipa_rx(tr_RSL_RF_CHAN_REL(chan_nr)); @@ -11189,6 +11186,9 @@ dt.sccp_conn_id := rx_c_ind.connectionId; BSSAP.send(ts_BSSAP_CONNECT_res(rx_c_ind.connectionId)); + /* (set bts 0 cfg back to default) */ + f_vty_set_imm_ass(BSCVTY); + f_sleep(1.0); f_perform_clear_test_ct(dt); f_shutdown_helper(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28289 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1e38142d29d0fa2946a858eac13319aa05b42aa3 Gerrit-Change-Number: 28289 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: remove redundant f_init()/f_sleep() calls

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28288 ) Change subject: BSC_Tests: remove redundant f_init()/f_sleep() calls ...................................................................... BSC_Tests: remove redundant f_init()/f_sleep() calls Calling f_init() more than once does not make sense. Change-Id: I625763b03c78835f6c4a80edd40cb3572411f7a2 --- M bsc/BSC_Tests.ttcn 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 8a7d465..8de3dcb 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -11074,9 +11074,6 @@ var RSL_Message chan_act; var RSL_Message imm_ass; - f_init(1, false); - f_sleep(1.0); - f_vty_set_imm_ass(BSCVTY, 0, "pre-chan-ack"); /* RA containing reason=LU */ @@ -11149,9 +11146,6 @@ var RSL_Message chan_act; var RSL_Message imm_ass; - f_init(1, false); - f_sleep(1.0); - f_vty_set_imm_ass(BSCVTY, 0, "pre-ts-ack"); /* RA containing reason=LU */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28288 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I625763b03c78835f6c4a80edd40cb3572411f7a2 Gerrit-Change-Number: 28288 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: remove redundant f_init()/f_sleep() calls

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28288 ) Change subject: BSC_Tests: remove redundant f_init()/f_sleep() calls ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: 1+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28288 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I625763b03c78835f6c4a80edd40cb3572411f7a2 Gerrit-Change-Number: 28288 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jun 2022 10:19:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix race conditions in TC_imm_ass_pre_{ts,chan}_ack_dyn_ts

by pespin

Attention is currently required from: neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28289 ) Change subject: BSC_Tests: fix race conditions in TC_imm_ass_pre_{ts,chan}_ack_dyn_ts ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28289 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1e38142d29d0fa2946a858eac13319aa05b42aa3 Gerrit-Change-Number: 28289 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jun 2022 10:14:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: remove redundant f_init()/f_sleep() calls

by pespin

Attention is currently required from: neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28288 ) Change subject: BSC_Tests: remove redundant f_init()/f_sleep() calls ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28288 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I625763b03c78835f6c4a80edd40cb3572411f7a2 Gerrit-Change-Number: 28288 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jun 2022 10:13:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: Expand VTY option which controls use of TCH for signalling

by pespin

Attention is currently required from: iedemam, neels, laforge, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28276 ) Change subject: Expand VTY option which controls use of TCH for signalling ...................................................................... Patch Set 5: (3 comments) File include/osmocom/bsc/bts.h: https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/d595fb3a_7c21e1d8 PS5, Line 263: BTS_TCH_SIGNALLING_NEVER, Maybe NEVER->NONE and ALWAYS->ALL would be more meanginful, but not really sure about it, so letting you decide here. File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/07dfc2cc_922ff066 PS5, Line 2177: /* else: Emergency calls will be put on a free TCH/H or TCH/F directly We should probably discuss this. If you currently select BTS_TCH_SIGNALLING_NEVER in your patch, you would be skipping the path to assign a TCH directly for an emergency call, which is probably something you want to do even if you chose BTS_TCH_SIGNALLING_NEVER. It may make more sense to rename it to BTS_TCH_SIGNALLING_EMERGENCY_CALL. If you still want to really have a NEVER option for whatever reason, then better add an EMERGENCY_CALL one too? https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/70c35a95_1bb163cb PS5, Line 2181: if (bts->tch_for_signalling_policy == BTS_TCH_SIGNALLING_ALWAYS If you don't mind, this would be probably more readable, since the same check is done first: if (bts->tch_for_signalling_policy == BTS_TCH_SIGNALLING_ALWAYS || (bts->tch_for_signalling_policy == BTS_TCH_SIGNALLING_VOICE && gsm_chreq_reason_is_voicecall(rqd->reason))) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28276 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4459941ddad4e4a3bec8409b180d9a23a735e640 Gerrit-Change-Number: 28276 Gerrit-PatchSet: 5 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jun 2022 10:12:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: add libosmo-gtlv, moved from osmo-upf.git

by pespin

Attention is currently required from: neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28286 ) Change subject: add libosmo-gtlv, moved from osmo-upf.git ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: I agree with @laforge, let's keep same structure for all libs: > I can rename tests/libosmo-gtlv to tests/gtlv. Yes > Do I have to remove the dash from "libosmo-gtlv"? Yes > I'd have to also remove the dash in the places that use libosmo-gtlv. The dash was fine in osmo-upf.git, I'd like to keep it. You still need to do modifications there to drop libosmo-gtlv from the repo, so that can be done at the same time. I think it's fine keeping it here in libosmocore, changing the above should be pretty quick. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28286 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I25ab400f0c5707fdc0d8e480aca19871c2e26e71 Gerrit-Change-Number: 28286 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 15 Jun 2022 10:04:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-hnbgw[master]: mgw_fsm: Simplify cleanup paths

by fixeria

Attention is currently required from: pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28284 ) Change subject: mgw_fsm: Simplify cleanup paths ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File src/osmo-hnbgw/mgw_fsm.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28284/comment/80c697c1_7cfa4f1a PS1, Line 158: mgw_fsm_alloc_and_handle_rab_ass_req > This is not valid anymore and should be removed. […] Done https://gerrit.osmocom.org/c/osmo-hnbgw/+/28284/comment/477ca6e2_684dea34 PS1, Line 167: mgw_fsm_alloc_and_handle_rab_ass_req > Same here. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28284 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I8883e737fa112cff57834abae7ef272388a54edb Gerrit-Change-Number: 28284 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jun 2022 09:58:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: cosmetic tweak in Makefile.am

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28285 ) Change subject: cosmetic tweak in Makefile.am ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File Makefile.am: https://gerrit.osmocom.org/c/libosmocore/+/28285/comment/b7f86d82_de91786f PS1, Line 7: src/vty \ I wonder why we do have 2 level subdirs here instead of putting those inside src/Makefile.am. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I141e502ffbb1a45f9751943d47766bdfbf77484a Gerrit-Change-Number: 28285 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jun 2022 09:58:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2022