Attention is currently required from: laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28286 ) Change subject: add libosmo-gtlv, moved from osmo-upf.git ...................................................................... Patch Set 2: (1 comment) Patchset: PS1:

I don't like mixing conventions in a single project (here: libosmocore), sorry :/ up to what level does this hold?

I assume I have to move the per-subdir Makefile.am that we have in all other osmo.gits to the single toplevel Makefile.am scheme that is in libosmocore.git. I can rename tests/libosmo-gtlv to tests/gtlv. Do I have to remove the dash from "libosmo-gtlv"? It would match libosmogsm, libosmovty and the others in libosmocore.git, but it would not match libosmo-pfcp, libosmo-sccp, libosmo-abis, etc. I'd have to also remove the dash in the places that use libosmo-gtlv. The dash was fine in osmo-upf.git, I'd like to keep it. All of the above is functionally invisible gruntwork. Can I still change my mind and rather move libosmo-gtlv to libosmo-pfcp.git? Or, what about a separate libosmo-gtlv.git? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28286 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I25ab400f0c5707fdc0d8e480aca19871c2e26e71 Gerrit-Change-Number: 28286 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Tue, 14 Jun 2022 22:10:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Gerrit-MessageType: comment