June 2022 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: cosmetic tweak in Makefile.am

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28285 ) Change subject: cosmetic tweak in Makefile.am ...................................................................... cosmetic tweak in Makefile.am Change-Id: I141e502ffbb1a45f9751943d47766bdfbf77484a --- M Makefile.am 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve diff --git a/Makefile.am b/Makefile.am index ab2aad9..b3663ba 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,7 +1,22 @@ ACLOCAL_AMFLAGS = -I m4 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -SUBDIRS = include src src/vty src/codec src/gsm src/coding src/gb src/ctrl src/sim src/pseudotalloc src/usb utils tapset tests +SUBDIRS = \ + include \ + src \ + src/vty \ + src/codec \ + src/gsm \ + src/coding \ + src/gb \ + src/ctrl \ + src/sim \ + src/pseudotalloc \ + src/usb \ + utils \ + tapset \ + tests \ + $(NULL) pkgconfigdir = $(libdir)/pkgconfig pkgconfig_DATA = libosmocore.pc libosmocodec.pc libosmovty.pc libosmogsm.pc \ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I141e502ffbb1a45f9751943d47766bdfbf77484a Gerrit-Change-Number: 28285 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: cosmetic tweak in Makefile.am

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28285 ) Change subject: cosmetic tweak in Makefile.am ...................................................................... Patch Set 1: (1 comment) File Makefile.am: https://gerrit.osmocom.org/c/libosmocore/+/28285/comment/c8d4fd5d_3d7200ec PS1, Line 7: src/vty \ > I wonder why we do have 2 level subdirs here instead of putting those inside src/Makefile.am. I wonder the same -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I141e502ffbb1a45f9751943d47766bdfbf77484a Gerrit-Change-Number: 28285 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jun 2022 11:14:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Fix trailing whitespace

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28303 ) Change subject: cbc: Fix trailing whitespace ...................................................................... cbc: Fix trailing whitespace Change-Id: Ie54a6f6b9aea84ae1ec67ca34a34dd171f2e0177 --- M cbc/CBC_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/cbc/CBC_Tests.ttcn b/cbc/CBC_Tests.ttcn index e76e61e..44ce2bb 100644 --- a/cbc/CBC_Tests.ttcn +++ b/cbc/CBC_Tests.ttcn @@ -109,7 +109,7 @@ } }; for (var integer i := 0; i < lengthof(inp.content); i := i+1) { - ret.smscb_message.payload.payload_encoded.pages := + ret.smscb_message.payload.payload_encoded.pages := ret.smscb_message.payload.payload_encoded.pages & { f_cbs2ecbe_page(inp.content[i]) }; } return ret; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28303 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie54a6f6b9aea84ae1ec67ca34a34dd171f2e0177 Gerrit-Change-Number: 28303 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-cbc[master]: src/Makefile: Reformat files one per line

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28297 ) Change subject: src/Makefile: Reformat files one per line ...................................................................... src/Makefile: Reformat files one per line Change-Id: I666d6cd1461117397e05ac573c834a82abb2807d --- M src/Makefile.am 1 file changed, 21 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/Makefile.am b/src/Makefile.am index edac0c3..6f82a54 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -5,14 +5,30 @@ $(COVERAGE_CFLAGS) AM_LDFLAGS=$(COVERAGE_LDFLAGS) -EXTRA_DIST = cbc_data.h cbsp_server.h charset.h internal.h rest_it_op.h +EXTRA_DIST = \ + cbc_data.h \ + cbsp_server.h \ + charset.h \ + internal.h \ + rest_it_op.h \ + $(NULL) bin_PROGRAMS = osmo-cbc -osmo_cbc_SOURCES = cbc_main.c cbc_data.c cbc_vty.c cbsp_server.c cbsp_server_fsm.c \ - rest_api.c charset.c message_handling.c rest_it_op.c \ - smscb_peer_fsm.c smscb_message_fsm.c +osmo_cbc_SOURCES = \ + cbc_main.c \ + cbc_data.c \ + cbc_vty.c \ + cbsp_server.c \ + cbsp_server_fsm.c \ + rest_api.c \ + charset.c \ + message_handling.c \ + rest_it_op.c \ + smscb_peer_fsm.c \ + smscb_message_fsm.c \ + $(NULL) + osmo_cbc_LDADD = $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) $(LIBOSMOVTY_LIBS) \ $(LIBOSMONETIF_LIBS) \ $(ULFIUS_LIBS) $(JANSSON_LIBS) $(ORCANIA_LIBS) - -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28297 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I666d6cd1461117397e05ac573c834a82abb2807d Gerrit-Change-Number: 28297 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-cbc[master]: vty. Fix several typos and missing param descriptions

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28296 ) Change subject: vty. Fix several typos and missing param descriptions ...................................................................... vty. Fix several typos and missing param descriptions Change-Id: I798ba4663247018a61d6f392961af11871c6152b --- M src/cbc_vty.c 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/cbc_vty.c b/src/cbc_vty.c index b45fbd4..5d154c6 100644 --- a/src/cbc_vty.c +++ b/src/cbc_vty.c @@ -395,8 +395,8 @@ DEFUN(cfg_ecbe_local_port, cfg_ecbe_local_port_cmd, "local-port <0-65535>", - "Local TCP port for ECBE RESET Interface\n" - "Local TCP port for ECBE RESET Interface\n") + "Local TCP port for ECBE REST Interface\n" + "Local TCP port for ECBE REST Interface\n") { g_cbc->config.ecbe.local_port = atoi(argv[0]); return CMD_SUCCESS; @@ -407,7 +407,8 @@ DEFUN(cfg_cbc_peer, cfg_cbc_peer_cmd, "peer NAME", - "Remote Peer\n") + "Remote Peer\n" + "Name identifying the peer\n") { struct cbc_peer *peer; @@ -424,7 +425,8 @@ DEFUN(cfg_cbc_no_peer, cfg_cbc_no_peer_cmd, "no peer NAME", - NO_STR "Remote Peer\n") + NO_STR "Remote Peer\n" + "Name identifying the peer\n") { struct cbc_peer *peer; -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28296 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I798ba4663247018a61d6f392961af11871c6152b Gerrit-Change-Number: 28296 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: add libosmo-gtlv, moved from osmo-upf.git

by neels

neels has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28286 ) Change subject: add libosmo-gtlv, moved from osmo-upf.git ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28286 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I25ab400f0c5707fdc0d8e480aca19871c2e26e71 Gerrit-Change-Number: 28286 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: add libosmo-gtlv, moved from osmo-upf.git

by neels

Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28286 ) Change subject: add libosmo-gtlv, moved from osmo-upf.git ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > I'm not worried about library naming with or without dash, but src/{gsm,sim,... […] developing a new library in libosmocore would significantly increase the development cycle (recompilation, managing patches), and it could mean that an unstable API that is still in flux is subject to libosmocore's backwards compatibility promises. Developing new libraries in osmo-upf.git was the right choice from my POV. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28286 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I25ab400f0c5707fdc0d8e480aca19871c2e26e71 Gerrit-Change-Number: 28286 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jun 2022 10:28:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-hnbgw[master]: mgw_fsm: Simplify cleanup paths

by dexter

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28284 ) Change subject: mgw_fsm: Simplify cleanup paths ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28284 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I8883e737fa112cff57834abae7ef272388a54edb Gerrit-Change-Number: 28284 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jun 2022 09:47:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Improve CBSP port configuration

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28304 ) Change subject: cbc: Improve CBSP port configuration ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28304 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia7c599faa2101180089085c6cf5d483d2325ecac Gerrit-Change-Number: 28304 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jun 2022 09:04:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Fix trailing whitespace

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28303 ) Change subject: cbc: Fix trailing whitespace ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28303 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie54a6f6b9aea84ae1ec67ca34a34dd171f2e0177 Gerrit-Change-Number: 28303 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jun 2022 09:03:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2022