June 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-pfcp[master]: add generic PFCP CP peer implementation

by neels

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/28317 to look at the new patch set (#2). Change subject: add generic PFCP CP peer implementation ...................................................................... add generic PFCP CP peer implementation Will be used by osmo-hnbgw, our first PFCP Control Plane entity. The implementation is generic enough that it can be re-used by other CP entities. Related: SYS#5895 Change-Id: If8c5f69f596ea6ba8bd1723f4dc57b91d3799795 --- M include/osmocom/pfcp/Makefile.am A include/osmocom/pfcp/pfcp_cp_peer.h M src/libosmo-pfcp/Makefile.am A src/libosmo-pfcp/pfcp_cp_peer.c 4 files changed, 469 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/17/28317/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/28317 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: If8c5f69f596ea6ba8bd1723f4dc57b91d3799795 Gerrit-Change-Number: 28317 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in libosmo-pfcp[master]: add generic PFCP CP peer implementation

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/28317 ) Change subject: add generic PFCP CP peer implementation ...................................................................... add generic PFCP CP peer implementation Will be used by osmo-hnbgw, our first PFCP Control Plane entity. The implementation is generic enough that it can be re-used by other CP entities. Related: SYS#5895 Change-Id: If8c5f69f596ea6ba8bd1723f4dc57b91d3799795 --- M include/osmocom/pfcp/Makefile.am A include/osmocom/pfcp/pfcp_cp_peer.h M src/libosmo-pfcp/Makefile.am A src/libosmo-pfcp/pfcp_cp_peer.c 4 files changed, 469 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/17/28317/1 diff --git a/include/osmocom/pfcp/Makefile.am b/include/osmocom/pfcp/Makefile.am index 5d2db19..898113f 100644 --- a/include/osmocom/pfcp/Makefile.am +++ b/include/osmocom/pfcp/Makefile.am @@ -5,6 +5,7 @@ pfcp_msg.h \ pfcp_proto.h \ pfcp_strs.h \ + pfcp_cp_peer.h \ $(NULL) pfcpdir = $(includedir)/osmocom/pfcp diff --git a/include/osmocom/pfcp/pfcp_cp_peer.h b/include/osmocom/pfcp/pfcp_cp_peer.h new file mode 100644 index 0000000..8c6e448 --- /dev/null +++ b/include/osmocom/pfcp/pfcp_cp_peer.h @@ -0,0 +1,63 @@ +/* + * (C) 2021-2022 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> + * All Rights Reserved. + * + * Author: Neels Janosch Hofmeyr <nhofmeyr(a)sysmocom.de> + * + * SPDX-License-Identifier: GPL-2.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * + */ + +#pragma once + +#include <stdint.h> +#include <stdbool.h> + +#include <osmocom/core/socket.h> +#include <osmocom/core/use_count.h> +#include <osmocom/pfcp/pfcp_proto.h> + +struct osmo_fsm_inst; +struct osmo_pfcp_endpoint; +struct osmo_pfcp_cp_peer; + +typedef void (*osmo_pfcp_cp_peer_assoc_cb)(struct osmo_pfcp_cp_peer *cp_peer, bool associated); + +struct osmo_pfcp_cp_peer { + struct osmo_fsm_inst *fi; + struct osmo_pfcp_endpoint *ep; + struct osmo_sockaddr remote_addr; + uint64_t next_seid_state; + + /* If non-NULL, called whenever the peer completes a PFCP Association, and when it loses association. + * Argument associated == true means the peer has just associated; + * associated == false means the association has been lost. */ + osmo_pfcp_cp_peer_assoc_cb assoc_cb; + /* Application private data for assoc_cb, in case ep->priv does not suffice. */ + void *priv; + + struct osmo_use_count use_count; + struct osmo_use_count_entry use_count_buf[128]; +}; + +struct osmo_pfcp_cp_peer *osmo_pfcp_cp_peer_alloc(void *ctx, + struct osmo_pfcp_endpoint *ep, + const struct osmo_sockaddr *remote_addr); +int osmo_pfcp_cp_peer_associate(struct osmo_pfcp_cp_peer *cp_peer); +bool osmo_pfcp_cp_peer_is_associated(const struct osmo_pfcp_cp_peer *cp_peer); +struct osmo_pfcp_msg *osmo_pfcp_cp_peer_new_msg_tx(struct osmo_pfcp_cp_peer *cp_peer, + enum osmo_pfcp_message_type msg_type); +void osmo_pfcp_cp_peer_set_msg_ctx(struct osmo_pfcp_cp_peer *cp_peer, struct osmo_pfcp_msg *m); diff --git a/src/libosmo-pfcp/Makefile.am b/src/libosmo-pfcp/Makefile.am index 1f4b80f..a1e9904 100644 --- a/src/libosmo-pfcp/Makefile.am +++ b/src/libosmo-pfcp/Makefile.am @@ -28,6 +28,7 @@ pfcp_ies_custom.c \ pfcp_msg.c \ pfcp_strs.c \ + pfcp_cp_peer.c \ \ pfcp_ies_auto.c \ $(NULL) diff --git a/src/libosmo-pfcp/pfcp_cp_peer.c b/src/libosmo-pfcp/pfcp_cp_peer.c new file mode 100644 index 0000000..a6146b0 --- /dev/null +++ b/src/libosmo-pfcp/pfcp_cp_peer.c @@ -0,0 +1,404 @@ +/* + * (C) 2021-2022 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> + * All Rights Reserved. + * + * Author: Neels Janosch Hofmeyr <nhofmeyr(a)sysmocom.de> + * + * SPDX-License-Identifier: GPL-2.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * + */ + +#include <errno.h> + +#include <osmocom/core/utils.h> +#include <osmocom/core/fsm.h> +#include <osmocom/core/tdef.h> + +#include <osmocom/pfcp/pfcp_endpoint.h> +#include <osmocom/pfcp/pfcp_cp_peer.h> + +#define LOG_CP_PEER(CP_PEER, LOGLEVEL, FMT, ARGS...) \ + LOGPFSML((CP_PEER)->fi, LOGLEVEL, FMT, ##ARGS) + +enum pfcp_cp_peer_fsm_state { + PFCP_CP_PEER_ST_DISABLED, + PFCP_CP_PEER_ST_WAIT_ASSOC_SETUP_RESP, + PFCP_CP_PEER_ST_WAIT_RETRY, + PFCP_CP_PEER_ST_ASSOCIATED, + PFCP_CP_PEER_ST_GRACEFUL_RELEASE, + PFCP_CP_PEER_ST_WAIT_USE_COUNT, +}; + +enum pfcp_cp_peer_fsm_event { + PFCP_CP_PEER_EV_RX_ASSOC_SETUP_RESP, + PFCP_CP_PEER_EV_RX_ASSOC_UPDATE_REQ, + PFCP_CP_PEER_EV_USE_COUNT_ZERO, +}; + +static const struct value_string pfcp_cp_peer_fsm_event_names[] = { + OSMO_VALUE_STRING(PFCP_CP_PEER_EV_RX_ASSOC_SETUP_RESP), + OSMO_VALUE_STRING(PFCP_CP_PEER_EV_RX_ASSOC_UPDATE_REQ), + OSMO_VALUE_STRING(PFCP_CP_PEER_EV_USE_COUNT_ZERO), + {} +}; + +static struct osmo_fsm pfcp_cp_peer_fsm; + +static const struct osmo_tdef_state_timeout pfcp_cp_peer_fsm_timeouts[32] = { + [PFCP_CP_PEER_ST_WAIT_RETRY] = { .T = -26 }, + /* PFCP_CP_PEER_ST_WAIT_ASSOC_SETUP_RESP is terminated by the on_pfcp_assoc_resp() callback */ + [PFCP_CP_PEER_ST_GRACEFUL_RELEASE] = { .T = -21 }, +}; + +/* Transition to a state, using the T timer defined in pfcp_cp_peer_fsm_timeouts. + * Assumes local variable fi exists. */ +#define osmo_pfcp_cp_peer_fsm_state_chg(state) \ + osmo_tdef_fsm_inst_state_chg(fi, state, \ + pfcp_cp_peer_fsm_timeouts, \ + osmo_pfcp_tdefs, \ + 5) + +static int pfcp_cp_peer_use_cb(struct osmo_use_count_entry *e, int32_t old_use_count, const char *file, int line) +{ + struct osmo_pfcp_cp_peer *cp_peer = e->use_count->talloc_object; + + if (!e->use) + return -EINVAL; + + LOGPFSMSLSRC(cp_peer->fi, DLPFCP, LOGL_DEBUG, file, line, + "%s %s: now used by %s\n", + e->count > old_use_count ? "+" : "-", e->use, + osmo_use_count_to_str_c(OTC_SELECT, &cp_peer->use_count)); + + if (e->count < 0) + return -ERANGE; + + if (osmo_use_count_total(&cp_peer->use_count) == 0) + osmo_fsm_inst_dispatch(cp_peer->fi, PFCP_CP_PEER_EV_USE_COUNT_ZERO, NULL); + return 0; +} + +/* Allocate PFCP CP peer FSM and start sending PFCP Association Setup Request messages to remote_addr, using endpoint + * ep. As soon as a successful response is received, change to state PFCP_CP_PEER_ST_ASSOCIATED. + */ +struct osmo_pfcp_cp_peer *osmo_pfcp_cp_peer_alloc(void *ctx, + struct osmo_pfcp_endpoint *ep, + const struct osmo_sockaddr *remote_addr) +{ + struct osmo_pfcp_cp_peer *cp_peer; + struct osmo_fsm_inst *fi = osmo_fsm_inst_alloc(&pfcp_cp_peer_fsm, ctx, NULL, LOGL_DEBUG, NULL); + OSMO_ASSERT(fi); + + cp_peer = talloc(fi, struct osmo_pfcp_cp_peer); + OSMO_ASSERT(cp_peer); + fi->priv = cp_peer; + *cp_peer = (struct osmo_pfcp_cp_peer){ + .fi = fi, + .ep = ep, + .remote_addr = *remote_addr, + .use_count = { + .talloc_object = cp_peer, + .use_cb = pfcp_cp_peer_use_cb, + }, + }; + osmo_use_count_make_static_entries(&cp_peer->use_count, cp_peer->use_count_buf, ARRAY_SIZE(cp_peer->use_count_buf)); + + osmo_fsm_inst_update_id_f_sanitize(fi, '-', osmo_sockaddr_to_str_c(OTC_SELECT, &cp_peer->remote_addr)); + return cp_peer; +} + +int osmo_pfcp_cp_peer_associate(struct osmo_pfcp_cp_peer *cp_peer) +{ + struct osmo_fsm_inst *fi = cp_peer->fi; + + switch (fi->state) { + case PFCP_CP_PEER_ST_DISABLED: + case PFCP_CP_PEER_ST_WAIT_RETRY: + /* Idling. Send Association Setup Request now. */ + return osmo_pfcp_cp_peer_fsm_state_chg(PFCP_CP_PEER_ST_WAIT_ASSOC_SETUP_RESP); + default: + /* Already associated, or busy associating. */ + return 0; + case PFCP_CP_PEER_ST_WAIT_USE_COUNT: + /* Already asked to deallocate. */ + return -ENOLINK; + } + return 0; +} + +static int pfcp_cp_peer_fsm_timer_cb(struct osmo_fsm_inst *fi) +{ + switch (fi->state) { + + case PFCP_CP_PEER_ST_WAIT_RETRY: + osmo_pfcp_cp_peer_fsm_state_chg(PFCP_CP_PEER_ST_WAIT_ASSOC_SETUP_RESP); + return 0; + + default: + return 1; + } +} + +static int on_pfcp_assoc_resp(struct osmo_pfcp_msg *req, struct osmo_pfcp_msg *rx_resp, const char *errmsg); + +/* Send PFCP Association Setup Request */ +static void pfcp_cp_peer_wait_assoc_setup_resp_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state) +{ + struct osmo_pfcp_cp_peer *cp_peer = fi->priv; + struct osmo_pfcp_msg *m; + + m = osmo_pfcp_cp_peer_new_msg_tx(cp_peer, OSMO_PFCP_MSGT_ASSOC_SETUP_REQ); + m->ies.assoc_setup_req.recovery_time_stamp = cp_peer->ep->recovery_time_stamp; + + m->ies.assoc_setup_req.cp_function_features_present = true; + osmo_pfcp_bits_set(m->ies.assoc_setup_req.cp_function_features.bits, OSMO_PFCP_CP_FEAT_BUNDL, true); + + m->ctx.resp_cb = on_pfcp_assoc_resp; + + LOG_CP_PEER(cp_peer, LOGL_NOTICE, "Associating with %s...\n", + osmo_sockaddr_to_str_c(OTC_SELECT, &cp_peer->remote_addr)); + + if (osmo_pfcp_endpoint_tx(cp_peer->ep, m)) { + LOG_CP_PEER(cp_peer, LOGL_ERROR, "Failed to transmit PFCP Association Setup Request to UPF at %s\n", + osmo_sockaddr_to_str_c(OTC_SELECT, &cp_peer->remote_addr)); + osmo_pfcp_cp_peer_fsm_state_chg(PFCP_CP_PEER_ST_WAIT_RETRY); + } +} + +static int on_pfcp_assoc_resp(struct osmo_pfcp_msg *req, struct osmo_pfcp_msg *rx_resp, const char *errmsg) +{ + struct osmo_fsm_inst *fi = req->ctx.peer_fi; + struct osmo_pfcp_cp_peer *cp_peer = fi->priv; + enum osmo_pfcp_cause *cause; + + if (!rx_resp) { + LOG_CP_PEER(cp_peer, LOGL_ERROR, "Error: PFCP Association Setup Response: %s\n", + errmsg ? : "no response received"); + goto assoc_failed; + } + + cause = osmo_pfcp_msg_cause(rx_resp); + if (!cause) { + LOG_CP_PEER(cp_peer, LOGL_ERROR, "Invalid PFCP Association Setup Response: no Cause value\n"); + goto assoc_failed; + } + if (*cause != OSMO_PFCP_CAUSE_REQUEST_ACCEPTED) { + LOG_CP_PEER(cp_peer, LOGL_ERROR, "UPF rejected PFCP Association Setup Request with Cause: %s\n", + osmo_pfcp_cause_str(*cause)); + goto assoc_failed; + } + + osmo_fsm_inst_dispatch(fi, PFCP_CP_PEER_EV_RX_ASSOC_SETUP_RESP, rx_resp); + return 0; + +assoc_failed: + osmo_pfcp_cp_peer_fsm_state_chg(PFCP_CP_PEER_ST_WAIT_RETRY); + return 0; +} + +static void pfcp_cp_peer_wait_assoc_setup_resp_action(struct osmo_fsm_inst *fi, uint32_t event, void *data) +{ + switch (event) { + + case PFCP_CP_PEER_EV_RX_ASSOC_SETUP_RESP: + osmo_pfcp_cp_peer_fsm_state_chg(PFCP_CP_PEER_ST_ASSOCIATED); + break; + + default: + OSMO_ASSERT(false); + } +} + +static void pfcp_cp_peer_associated_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state) +{ + struct osmo_pfcp_cp_peer *cp_peer = fi->priv; + LOG_CP_PEER(cp_peer, LOGL_NOTICE, "Associated with UPF %s\n", + osmo_sockaddr_to_str_c(OTC_SELECT, &cp_peer->remote_addr)); + if (cp_peer->assoc_cb) + cp_peer->assoc_cb(cp_peer, true); +} + +static void pfcp_cp_peer_associated_action(struct osmo_fsm_inst *fi, uint32_t event, void *data) +{ + struct osmo_pfcp_cp_peer *cp_peer = fi->priv; + + switch (event) { + + case PFCP_CP_PEER_EV_RX_ASSOC_UPDATE_REQ: + LOG_CP_PEER(cp_peer, LOGL_ERROR, "PFCP Association Update Request is not implemented\n"); + break; + + default: + OSMO_ASSERT(false); + } +} + +static void pfcp_cp_peer_associated_onleave(struct osmo_fsm_inst *fi, uint32_t next_state) +{ + struct osmo_pfcp_cp_peer *cp_peer = fi->priv; + LOG_CP_PEER(cp_peer, LOGL_NOTICE, "Disassociating from UPF %s\n", + osmo_sockaddr_to_str_c(OTC_SELECT, &cp_peer->remote_addr)); + if (cp_peer->assoc_cb) + cp_peer->assoc_cb(cp_peer, false); +} + +static void pfcp_cp_peer_graceful_release_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state) +{ + struct osmo_pfcp_cp_peer *cp_peer = fi->priv; + LOG_CP_PEER(cp_peer, LOGL_ERROR, "PFCP graceful release is not implemented\n"); +} + +static void pfcp_cp_peer_graceful_release_action(struct osmo_fsm_inst *fi, uint32_t event, void *data) +{ + struct osmo_pfcp_cp_peer *cp_peer = fi->priv; + LOG_CP_PEER(cp_peer, LOGL_ERROR, "PFCP graceful release is not implemented\n"); +} + +static void pfcp_cp_peer_wait_use_count_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state) +{ + struct osmo_pfcp_cp_peer *cp_peer = fi->priv; + if (!osmo_use_count_total(&cp_peer->use_count)) + osmo_fsm_inst_term(fi, OSMO_FSM_TERM_REGULAR, NULL); +} + +static void pfcp_cp_peer_allstate_action(struct osmo_fsm_inst *fi, uint32_t event, void *data) +{ + switch (event) { + case PFCP_CP_PEER_EV_USE_COUNT_ZERO: + switch (fi->state) { + default: + /* still busy, ignore. */ + return; + case PFCP_CP_PEER_ST_WAIT_USE_COUNT: + /* Waiting for deallocation; now there are no more users, deallocate. */ + osmo_fsm_inst_term(fi, OSMO_FSM_TERM_REGULAR, NULL); + return; + } + default: + OSMO_ASSERT(false); + } +} + +#define S(x) (1 << (x)) + +static const struct osmo_fsm_state pfcp_cp_peer_fsm_states[] = { + [PFCP_CP_PEER_ST_DISABLED] = { + .name = "disabled", + .out_state_mask = 0 + | S(PFCP_CP_PEER_ST_WAIT_ASSOC_SETUP_RESP) + | S(PFCP_CP_PEER_ST_WAIT_USE_COUNT) + , + }, + [PFCP_CP_PEER_ST_WAIT_ASSOC_SETUP_RESP] = { + .name = "wait_assoc_setup_resp", + .in_event_mask = 0 + | S(PFCP_CP_PEER_EV_RX_ASSOC_SETUP_RESP) + , + .out_state_mask = 0 + | S(PFCP_CP_PEER_ST_ASSOCIATED) + | S(PFCP_CP_PEER_ST_WAIT_RETRY) + | S(PFCP_CP_PEER_ST_WAIT_USE_COUNT) + , + .onenter = pfcp_cp_peer_wait_assoc_setup_resp_onenter, + .action = pfcp_cp_peer_wait_assoc_setup_resp_action, + }, + [PFCP_CP_PEER_ST_WAIT_RETRY] = { + .name = "wait_retry", + .out_state_mask = 0 + | S(PFCP_CP_PEER_ST_WAIT_ASSOC_SETUP_RESP) + | S(PFCP_CP_PEER_ST_WAIT_USE_COUNT) + , + }, + [PFCP_CP_PEER_ST_ASSOCIATED] = { + .name = "associated", + .in_event_mask = 0 + | S(PFCP_CP_PEER_EV_RX_ASSOC_UPDATE_REQ) + , + .out_state_mask = 0 + | S(PFCP_CP_PEER_ST_WAIT_ASSOC_SETUP_RESP) + | S(PFCP_CP_PEER_ST_GRACEFUL_RELEASE) + | S(PFCP_CP_PEER_ST_WAIT_USE_COUNT) + , + .onenter = pfcp_cp_peer_associated_onenter, + .action = pfcp_cp_peer_associated_action, + .onleave = pfcp_cp_peer_associated_onleave, + }, + [PFCP_CP_PEER_ST_GRACEFUL_RELEASE] = { + .name = "graceful_release", + .in_event_mask = 0 + , + .out_state_mask = 0 + | S(PFCP_CP_PEER_ST_WAIT_RETRY) + | S(PFCP_CP_PEER_ST_WAIT_USE_COUNT) + , + .onenter = pfcp_cp_peer_graceful_release_onenter, + .action = pfcp_cp_peer_graceful_release_action, + }, + [PFCP_CP_PEER_ST_WAIT_USE_COUNT] = { + .name = "wait_use_count", + .in_event_mask = 0 + | S(PFCP_CP_PEER_EV_USE_COUNT_ZERO) + , + .onenter = pfcp_cp_peer_wait_use_count_onenter, + }, +}; + +static struct osmo_fsm pfcp_cp_peer_fsm = { + .name = "pfcp_cp_peer", + .states = pfcp_cp_peer_fsm_states, + .num_states = ARRAY_SIZE(pfcp_cp_peer_fsm_states), + .log_subsys = DLPFCP, + .event_names = pfcp_cp_peer_fsm_event_names, + .timer_cb = pfcp_cp_peer_fsm_timer_cb, + .allstate_action = pfcp_cp_peer_allstate_action, + .allstate_event_mask = 0 + | S(PFCP_CP_PEER_EV_USE_COUNT_ZERO) + , +}; + +static __attribute__((constructor)) void pfcp_cp_peer_fsm_register(void) +{ + OSMO_ASSERT(osmo_fsm_register(&pfcp_cp_peer_fsm) == 0); +} + +bool osmo_pfcp_cp_peer_is_associated(const struct osmo_pfcp_cp_peer *cp_peer) +{ + return cp_peer && cp_peer->fi->state == PFCP_CP_PEER_ST_ASSOCIATED; +} + +void osmo_pfcp_cp_peer_set_msg_ctx(struct osmo_pfcp_cp_peer *cp_peer, struct osmo_pfcp_msg *m) +{ + if (m->ctx.peer_fi) + return; + + m->ctx.peer_fi = cp_peer->fi; + + m->ctx.peer_use_count = &cp_peer->use_count; + m->ctx.peer_use_token = (m->rx ? "PFCPrx" : "PFCPtx"); + osmo_use_count_get_put(m->ctx.peer_use_count, m->ctx.peer_use_token, 1); +} + +struct osmo_pfcp_msg *osmo_pfcp_cp_peer_new_msg_tx(struct osmo_pfcp_cp_peer *cp_peer, + enum osmo_pfcp_message_type msg_type) +{ + struct osmo_pfcp_msg *m; + m = osmo_pfcp_msg_alloc_tx(cp_peer->ep, &cp_peer->remote_addr, &cp_peer->ep->cfg.local_node_id, NULL, + msg_type); + if (!m) + return m; + osmo_pfcp_cp_peer_set_msg_ctx(cp_peer, m); + return m; +} -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/28317 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: If8c5f69f596ea6ba8bd1723f4dc57b91d3799795 Gerrit-Change-Number: 28317 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-hlr[master]: Fix db_subscr_create() not returning -EEXIST expected by VTY subscrib...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/28316 ) Change subject: Fix db_subscr_create() not returning -EEXIST expected by VTY subscriber create cmd ...................................................................... Fix db_subscr_create() not returning -EEXIST expected by VTY subscriber create cmd As a result, the -EEXIST code path printing a specific error for inserting already existing subscribers was not being triggered. Change-Id: Id24dc6e0ff5115c8c9025404dd7296250d2b03ee --- M src/db_hlr.c M tests/db/db_test.c M tests/db/db_test.err 3 files changed, 14 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/16/28316/1 diff --git a/src/db_hlr.c b/src/db_hlr.c index 591908f..540daac 100644 --- a/src/db_hlr.c +++ b/src/db_hlr.c @@ -45,7 +45,8 @@ * \param[in,out] dbc database context. * \param[in] imsi ASCII string of IMSI digits, is validated. * \param[in] flags Bitmask of DB_SUBSCR_FLAG_*. - * \returns 0 on success, -EINVAL on invalid IMSI, -EIO on database error. + * \returns 0 on success, -EINVAL on invalid IMSI, -EEXIST if subscriber with + * provided imsi already exists, -EIO on other database errors. */ int db_subscr_create(struct db_context *dbc, const char *imsi, uint8_t flags) { @@ -73,6 +74,8 @@ if (rc != SQLITE_DONE) { LOGHLR(imsi, LOGL_ERROR, "Cannot create subscriber: SQL error: (%d) %s\n", rc, sqlite3_errmsg(dbc->db)); + if (rc == SQLITE_CONSTRAINT_UNIQUE) + return -EEXIST; return -EIO; } diff --git a/tests/db/db_test.c b/tests/db/db_test.c index 00434cf..246b7db 100644 --- a/tests/db/db_test.c +++ b/tests/db/db_test.c @@ -262,13 +262,13 @@ ASSERT_RC(db_subscr_create(dbc, imsi2, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS), 0); ASSERT_SEL(imsi, imsi2, 0); id2 = g_subscr.id; - ASSERT_RC(db_subscr_create(dbc, imsi0, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS), -EIO); + ASSERT_RC(db_subscr_create(dbc, imsi0, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS), -EEXIST); ASSERT_SEL(imsi, imsi0, 0); - ASSERT_RC(db_subscr_create(dbc, imsi1, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS), -EIO); - ASSERT_RC(db_subscr_create(dbc, imsi1, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS), -EIO); + ASSERT_RC(db_subscr_create(dbc, imsi1, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS), -EEXIST); + ASSERT_RC(db_subscr_create(dbc, imsi1, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS), -EEXIST); ASSERT_SEL(imsi, imsi1, 0); - ASSERT_RC(db_subscr_create(dbc, imsi2, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS), -EIO); - ASSERT_RC(db_subscr_create(dbc, imsi2, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS), -EIO); + ASSERT_RC(db_subscr_create(dbc, imsi2, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS), -EEXIST); + ASSERT_RC(db_subscr_create(dbc, imsi2, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS), -EEXIST); ASSERT_SEL(imsi, imsi2, 0); ASSERT_RC(db_subscr_create(dbc, "123456789 000003", DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS), -EINVAL); diff --git a/tests/db/db_test.err b/tests/db/db_test.err index ddf6d00..186af77 100644 --- a/tests/db/db_test.err +++ b/tests/db/db_test.err @@ -27,7 +27,7 @@ .imsi = '123456789000002', } -db_subscr_create(dbc, imsi0, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS) --> -EIO +db_subscr_create(dbc, imsi0, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS) --> -EEXIST DAUC IMSI='123456789000000': Cannot create subscriber: SQL error: (2067) UNIQUE constraint failed: subscriber.imsi db_subscr_get_by_imsi(dbc, imsi0, &g_subscr) --> 0 @@ -36,10 +36,10 @@ .imsi = '123456789000000', } -db_subscr_create(dbc, imsi1, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS) --> -EIO +db_subscr_create(dbc, imsi1, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS) --> -EEXIST DAUC IMSI='123456789000001': Cannot create subscriber: SQL error: (2067) UNIQUE constraint failed: subscriber.imsi -db_subscr_create(dbc, imsi1, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS) --> -EIO +db_subscr_create(dbc, imsi1, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS) --> -EEXIST DAUC IMSI='123456789000001': Cannot create subscriber: SQL error: (2067) UNIQUE constraint failed: subscriber.imsi db_subscr_get_by_imsi(dbc, imsi1, &g_subscr) --> 0 @@ -48,10 +48,10 @@ .imsi = '123456789000001', } -db_subscr_create(dbc, imsi2, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS) --> -EIO +db_subscr_create(dbc, imsi2, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS) --> -EEXIST DAUC IMSI='123456789000002': Cannot create subscriber: SQL error: (2067) UNIQUE constraint failed: subscriber.imsi -db_subscr_create(dbc, imsi2, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS) --> -EIO +db_subscr_create(dbc, imsi2, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS) --> -EEXIST DAUC IMSI='123456789000002': Cannot create subscriber: SQL error: (2067) UNIQUE constraint failed: subscriber.imsi db_subscr_get_by_imsi(dbc, imsi2, &g_subscr) --> 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/28316 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Id24dc6e0ff5115c8c9025404dd7296250d2b03ee Gerrit-Change-Number: 28316 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-hlr[master]: tests/ctrl: Move ERROR test scenario to proper file

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/28315 ) Change subject: tests/ctrl: Move ERROR test scenario to proper file ...................................................................... tests/ctrl: Move ERROR test scenario to proper file Change-Id: I26ba561c22c40877d99f2aed27be2df9faaa4bec --- M tests/test_subscriber.ctrl M tests/test_subscriber_errors.ctrl 2 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/15/28315/1 diff --git a/tests/test_subscriber.ctrl b/tests/test_subscriber.ctrl index 4cefa4d..756e888 100644 --- a/tests/test_subscriber.ctrl +++ b/tests/test_subscriber.ctrl @@ -610,5 +610,3 @@ periodic_rau_tau_timer 0 lmsi 00000000 -GET 101 subscriber.by-id-0x0123.info -ERROR 101 Invalid value part of 'by-xxx-value' selector. diff --git a/tests/test_subscriber_errors.ctrl b/tests/test_subscriber_errors.ctrl index 991d3df..0c5b587 100644 --- a/tests/test_subscriber_errors.ctrl +++ b/tests/test_subscriber_errors.ctrl @@ -105,3 +105,6 @@ ERROR 46 Invalid value part of 'by-xxx-value' selector. GET 47 subscriber.by-imsi-1234567890123456.cs-enabled ERROR 47 Invalid value part of 'by-xxx-value' selector. + +GET 48 subscriber.by-id-0x0123.info +ERROR 48 Invalid value part of 'by-xxx-value' selector. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/28315 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I26ba561c22c40877d99f2aed27be2df9faaa4bec Gerrit-Change-Number: 28315 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-upf[master]: implement GTPv1-U ECHO response

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28312 ) Change subject: implement GTPv1-U ECHO response ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-upf/upf_gtpu_echo.c: https://gerrit.osmocom.org/c/osmo-upf/+/28312/comment/0efeb719_4e7aa644 PS1, Line 61: msg = msgb_alloc_headroom(1024, 128, "GTP-echo-resp"); Would be good having this in a tx_echo_resp function. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28312 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I135370a7723e2c667ec681f50c21107cde63ea5b Gerrit-Change-Number: 28312 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jun 2022 15:22:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-upf[master]: add contrib/set_cap_net_admin.sh

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28311 ) Change subject: add contrib/set_cap_net_admin.sh ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Not sure what's the purpose of having this here? -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28311 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: If31c304e2602d3c37d5d8a5a2705417b2fc4686c Gerrit-Change-Number: 28311 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jun 2022 15:18:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-upf[master]: add osmo-pfcp-tool

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28310 ) Change subject: add osmo-pfcp-tool ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28310 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I34a80d43a14c7b68952c7d337d8042d6f28ceae7 Gerrit-Change-Number: 28310 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jun 2022 15:18:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-upf[master]: add nft

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28309 ) Change subject: add nft ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28309 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic0d319eb4f98cd51a5999c804c4203ab0bdda650 Gerrit-Change-Number: 28309 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jun 2022 15:16:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-upf[master]: add osmo-upf

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28308 ) Change subject: add osmo-upf ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28308 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I745bcbde6859004c41ddbfd2558036bf9a2d1de2 Gerrit-Change-Number: 28308 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jun 2022 15:16:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-upf[master]: move libosmo-pfcp to libosmo-pfcp.git

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28306 ) Change subject: move libosmo-pfcp to libosmo-pfcp.git ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28306 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I1464cdd846b00707b0abba9126aa5bb784b7caf1 Gerrit-Change-Number: 28306 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jun 2022 15:15:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2022