June 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-sccp[master]: [cosmetic] sccp_scoc: Fix typo in comment

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/28321 ) Change subject: [cosmetic] sccp_scoc: Fix typo in comment ...................................................................... [cosmetic] sccp_scoc: Fix typo in comment Change-Id: I26168658b58250f58c3616e51010b969df8029a4 --- M src/sccp_scoc.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/21/28321/1 diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c index f3f7a38..5e2cbdd 100644 --- a/src/sccp_scoc.c +++ b/src/sccp_scoc.c @@ -807,7 +807,7 @@ /*********************************************************************** - * Actual SCCP Connection Oriented Control (SCOC) Finite Stte Machine + * Actual SCCP Connection Oriented Control (SCOC) Finite State Machine ***********************************************************************/ /* Figure C.2/Q.714 (sheet 1 of 7) and C.3/Q.714 (sheet 1 of 6) */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/28321 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I26168658b58250f58c3616e51010b969df8029a4 Gerrit-Change-Number: 28321 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in libosmo-sccp[master]: [cosmetic] sccp_scoc.c: fix comments about corresponding SCCP msg types

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/28320 ) Change subject: [cosmetic] sccp_scoc.c: fix comments about corresponding SCCP msg types ...................................................................... [cosmetic] sccp_scoc.c: fix comments about corresponding SCCP msg types Change-Id: I0d7a81f72147f8022ddadfe28d04679097dfa492 --- M src/sccp_scoc.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/20/28320/1 diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c index 5f109b3..f3f7a38 100644 --- a/src/sccp_scoc.c +++ b/src/sccp_scoc.c @@ -615,7 +615,7 @@ xua_msg_add_data(xua, SUA_IEI_DATA, msgb_l2len(prim->oph.msg), msgb_l2(prim->oph.msg)); break; - case SUA_CO_RELRE: /* Release Request == SCCP REL */ + case SUA_CO_RELRE: /* Release Request == SCCP RLSD */ if (!prim) goto prim_needed; xua->hdr = XUA_HDR(SUA_MSGC_CO, SUA_CO_RELRE); @@ -628,7 +628,7 @@ xua_msg_add_data(xua, SUA_IEI_DATA, msgb_l2len(prim->oph.msg), msgb_l2(prim->oph.msg)); break; - case SUA_CO_RELCO: /* Release Confirm == SCCP RLSD */ + case SUA_CO_RELCO: /* Release Confirm == SCCP RLC */ xua->hdr = XUA_HDR(SUA_MSGC_CO, SUA_CO_RELCO); xua_msg_add_u32(xua, SUA_IEI_ROUTE_CTX, conn->inst->route_ctx); xua_msg_add_u32(xua, SUA_IEI_DEST_REF, conn->remote_ref); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/28320 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0d7a81f72147f8022ddadfe28d04679097dfa492 Gerrit-Change-Number: 28320 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-upf[master]: add pfcp_endpoint

by neels

Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28244 ) Change subject: add pfcp_endpoint ...................................................................... Patch Set 4: (2 comments) File include/osmocom/pfcp/pfcp_endpoint.h: https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/a59e5f12_e07e366e PS3, Line 77: osmo_pfcp_endpoint_cb set_msg_ctx; > agreed there are various function pointers in osmocom code that are not named *_cb, in: struct osmo_fsm_state, struct osmo_fsm, struct vlr_ops, struct call_leg (in sipcon), struct sccp_ran_ops, struct convert_cpu_context, struct e1inp_driver, to name some. my personal choice is to not add _cb. https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/eba31e39_22fd1ccd PS3, Line 104: > In general, the question is whether 'struct osmo_pfcp_endpoint' is supposed to be publicly exposed t […] every time i have written API with opaque structs, i have regretted it from the extensive work required to introduce API functions for every little detail. Any ABI breakage is fixed by simple recompilation. Examples of public structs in osmocom are: struct osmo_fsm, struct osmo_fsm_inst, struct log_info, struct msgb, struct rate_ctr*, struct stat_item*, struct osmo_fd, struct osmo_tdef, struct mgcp_client_conf, struct sccp_connection, to name some. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28244 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic8d42e201b63064a71b40ca45a5a40e29941e8ac Gerrit-Change-Number: 28244 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jun 2022 20:09:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-hlr[master]: ctrl: Introduce CTRL command subscriber.by-*.msisdn

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/28319 ) Change subject: ctrl: Introduce CTRL command subscriber.by-*.msisdn ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/28319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I5f2e807859f7e28e0984c8dc37edc69319fd8e10 Gerrit-Change-Number: 28319 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jun 2022 19:55:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-hlr[master]: ctrl: Introduce cmd SET subscriber.create <imsi>

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/28318 ) Change subject: ctrl: Introduce cmd SET subscriber.create <imsi> ...................................................................... Patch Set 3: (1 comment) File src/ctrl.c: https://gerrit.osmocom.org/c/osmo-hlr/+/28318/comment/8e9ff124_354787c1 PS3, Line 223: LOGL_ERROR Why ERROR? INFO maybe? -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/28318 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Id1b760cd07712245a0eeabaac7891bce93c1fe8e Gerrit-Change-Number: 28318 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jun 2022 19:53:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-hlr[master]: ctrl: Introduce cmd SET subscriber.create <imsi>

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/28318 ) Change subject: ctrl: Introduce cmd SET subscriber.create <imsi> ...................................................................... Patch Set 3: Code-Review-1 (1 comment) File src/logging.c: https://gerrit.osmocom.org/c/osmo-hlr/+/28318/comment/91f142df_2300d39b PS3, Line 47: DDGSM Copy-pasted from DDGSM, please update both name and description. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/28318 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Id1b760cd07712245a0eeabaac7891bce93c1fe8e Gerrit-Change-Number: 28318 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jun 2022 19:53:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-hlr[master]: Fix db_subscr_create() not returning -EEXIST expected by VTY subscrib...

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/28316 ) Change subject: Fix db_subscr_create() not returning -EEXIST expected by VTY subscriber create cmd ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/28316 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Id24dc6e0ff5115c8c9025404dd7296250d2b03ee Gerrit-Change-Number: 28316 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jun 2022 19:34:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-hlr[master]: tests/ctrl: Move ERROR test scenario to proper file

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/28315 ) Change subject: tests/ctrl: Move ERROR test scenario to proper file ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/28315 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I26ba561c22c40877d99f2aed27be2df9faaa4bec Gerrit-Change-Number: 28315 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jun 2022 19:32:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-hlr[master]: tests: Allow specyfing specific ctrl test to run

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/28314 ) Change subject: tests: Allow specyfing specific ctrl test to run ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/28314 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I3b01edfb22197f4d46bd24e15bdcd37ea0382e4a Gerrit-Change-Number: 28314 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jun 2022 19:32:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-hlr[master]: ctrl: Mark function as static

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/28313 ) Change subject: ctrl: Mark function as static ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/28313 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ieb956fb855752cfbe83d11aa0326685229a115e3 Gerrit-Change-Number: 28313 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jun 2022 19:31:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2022