June 2022 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: vty: command.c: Add assert

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28301 ) Change subject: vty: command.c: Add assert ...................................................................... vty: command.c: Add assert a program being developed right now crashed at this point, without providing any meaningful information on where did it crash. Change-Id: Ia14f43142e7409f72eb9efd5c9131bea5eed6e82 --- M src/vty/command.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/vty/command.c b/src/vty/command.c index 2a8942d..d7b8026 100644 --- a/src/vty/command.c +++ b/src/vty/command.c @@ -1092,6 +1092,7 @@ static vector cmd_node_vector(vector v, enum node_type ntype) { struct cmd_node *cnode = vector_slot(v, ntype); + OSMO_ASSERT(cnode != NULL); return cnode->cmd_vector; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia14f43142e7409f72eb9efd5c9131bea5eed6e82 Gerrit-Change-Number: 28301 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: vty: command.c: Add assert

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28301 ) Change subject: vty: command.c: Add assert ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia14f43142e7409f72eb9efd5c9131bea5eed6e82 Gerrit-Change-Number: 28301 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jun 2022 20:27:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: smscb: Tx CBSP FAILURE/RESTART for specific cell when it becomes (un)...

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28275 ) Change subject: smscb: Tx CBSP FAILURE/RESTART for specific cell when it becomes (un)operational ...................................................................... smscb: Tx CBSP FAILURE/RESTART for specific cell when it becomes (un)operational This way the CBSP peers knows the state of specific cells and can avoid sending messages to unoperative ones, etc. Related: SYS#5910 Change-Id: I94f0a1ac3c59cffe5af57f972d5d96fc92281d34 --- M src/osmo-bsc/smscb.c 1 file changed, 50 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/smscb.c b/src/osmo-bsc/smscb.c index 7507703..0e9049f 100644 --- a/src/osmo-bsc/smscb.c +++ b/src/osmo-bsc/smscb.c @@ -476,6 +476,54 @@ return cbsp_tx_decoded(cbc, cbsp); } +/* transmit a CBSP RESTART-INDICATION message stating a cell is operative again */ +int cbsp_tx_restart_bts(struct bsc_cbc_link *cbc, bool is_emerg, struct gsm_bts *bts) +{ + struct osmo_cbsp_decoded *cbsp = osmo_cbsp_decoded_alloc(cbc, CBSP_MSGT_RESTART); + struct osmo_cbsp_cell_ent cell_ent; + + if (is_emerg) + cbsp->u.restart.bcast_msg_type = 0x01; + cbsp->u.restart.recovery_ind = 0x00; /* message data available */ + cbsp->u.restart.cell_list.id_discr = CELL_IDENT_LAC_AND_CI; + + cell_ent = (struct osmo_cbsp_cell_ent){ + .cell_id = { + .lac_and_ci = { + .lac = bts->location_area_code, + .ci = bts->cell_identity, + } + } + }; + llist_add(&cell_ent.list, &cbsp->u.restart.cell_list.list); + + return cbsp_tx_decoded(cbc, cbsp); +} + +/* transmit a CBSP FAILURE-INDICATION message stating all message data was lost for one cell */ +int cbsp_tx_failure_bts(struct bsc_cbc_link *cbc, bool is_emerg, struct gsm_bts *bts) +{ + struct osmo_cbsp_decoded *cbsp = osmo_cbsp_decoded_alloc(cbc, CBSP_MSGT_FAILURE); + struct osmo_cbsp_fail_ent fail_ent; + + if (is_emerg) + cbsp->u.failure.bcast_msg_type = 0x01; + + fail_ent = (struct osmo_cbsp_fail_ent){ + .id_discr = CELL_IDENT_LAC_AND_CI, + .cell_id = { + .lac_and_ci = { + .lac = bts->location_area_code, + .ci = bts->cell_identity, + } + }, + .cause = OSMO_CBSP_CAUSE_CELL_BROADCAST_NOT_OPERATIONAL + }; + llist_add(&fail_ent.list, &cbsp->u.failure.fail_list); + + return cbsp_tx_decoded(cbc, cbsp); +} + /* transmit a CBSP KEEPALIVE COMPLETE to the CBC */ static int tx_cbsp_keepalive_compl(struct bsc_cbc_link *cbc) { @@ -1093,12 +1141,14 @@ bts_cbch_timer_schedule(trx->bts); /* Start ETWS/PWS Primary Notification, if active */ bts_etws_bootstrap(trx->bts); + cbsp_tx_restart_bts(bts->network->cbc, false, bts); } } else { if (osmo_timer_pending(&bts->cbch_timer)) { /* If timer is ongoing it means CBCH was available */ LOG_BTS(bts, DCBS, LOGL_INFO, "BTS becomes unavailable for CBCH\n"); osmo_timer_del(&bts->cbch_timer); + cbsp_tx_failure_bts(bts->network->cbc, false, bts); } /* else: CBCH was already unavailable before */ } return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28275 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I94f0a1ac3c59cffe5af57f972d5d96fc92281d34 Gerrit-Change-Number: 28275 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: smscb: Tx CBSP FAILURE/RESTART for specific cell when it becomes (un)...

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28275 ) Change subject: smscb: Tx CBSP FAILURE/RESTART for specific cell when it becomes (un)operational ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28275 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I94f0a1ac3c59cffe5af57f972d5d96fc92281d34 Gerrit-Change-Number: 28275 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jun 2022 20:27:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc-cbsp: Test BTS Failure+Restart when BTS becomes (un)available

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28273 ) Change subject: bsc-cbsp: Test BTS Failure+Restart when BTS becomes (un)available ...................................................................... bsc-cbsp: Test BTS Failure+Restart when BTS becomes (un)available Related: SYS#5910 Change-Id: I35ddde7bc2e39d35c301f1153416b549ba1630cd --- M bsc/BSC_Tests_CBSP.ttcn M library/CBSP_Templates.ttcn 2 files changed, 89 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/BSC_Tests_CBSP.ttcn b/bsc/BSC_Tests_CBSP.ttcn index a933b24..53f7fbc 100644 --- a/bsc/BSC_Tests_CBSP.ttcn +++ b/bsc/BSC_Tests_CBSP.ttcn @@ -40,6 +40,10 @@ import from Osmocom_VTY_Functions all; import from TELNETasp_PortType all; +import from Osmocom_CTRL_Functions all; +import from Osmocom_CTRL_Types all; +import from Osmocom_CTRL_Adapter all; + modulepar { charstring mp_cbc_ip := "127.0.0.1"; charstring mp_cbc_ip6 := "::1"; @@ -47,6 +51,8 @@ charstring mp_bsc_cbsp_ip := "127.0.0.1"; charstring mp_bsc_cbsp_ip6 := "::1"; integer mp_bsc_cbsp_port := 48050; + /* port number to which to establish the IPA CTRL connection */ + integer mp_bsc_ctrl_port := 4249; /* BTS 0: 001-01-1-0 with CBCH * BTS 1: 001-01-1-1 with CBCH @@ -536,6 +542,75 @@ setverdict(pass); } +/* Test if a LAC_CI FAILURE Ind is sent when TRX holding the CBCH is locked + * (becomes unavailable). LAC_CI RESTART Ind should be sent when the TRX becomes + * unlocked again. */ +testcase TC_cbsp_cell_rflock_failure_restart() runs on cbsp_test_CT { + var template CBSP_PDU rx; + + g_pars := valueof(ts_CBSP_Pars_default(false, 0, 0)); + f_init(); + + /* Lock the TRX, CBCH should become unavailable and BSC send FAILURE */ + f_ctrl_set(IPA_CTRL, "bts.0.trx.0.rf_locked", "1"); + + rx := tr_CBSP_FAILURE({CBSP_FailureListItem_LAC_CI(bssmap_lac_ci(mp_cgi_bts0), + CBSP_CAUSE_CB_NOT_OPERATIONAL)}, + CBSP_BC_MSGT_CBS); + alt { + [] CBSP[0].receive(tr_CBSP_Recv(g_cbsp_conn_id[0], rx)) { + setverdict(pass); + } + [] CBSP[0].receive(tr_CBSP_Recv(g_cbsp_conn_id[0], ?)) { + setverdict(fail, "Received unexpected CBSP"); + mtc.stop; + } + } + + /* Unlock the TRX, CBCH should become available and BSC send RESTART */ + f_ctrl_set(IPA_CTRL, "bts.0.trx.0.rf_locked", "0"); + rx := tr_CBSP_RESTART(ts_BSSMAP_CIL_LAC_CI({bssmap_lac_ci(mp_cgi_bts0)}), + CBSP_BC_MSGT_CBS, ?); + alt { + [] CBSP[0].receive(tr_CBSP_Recv(g_cbsp_conn_id[0], rx)) { + setverdict(pass); + } + [] CBSP[0].receive(tr_CBSP_Recv(g_cbsp_conn_id[0], ?)) { + setverdict(fail, "Received unexpected CBSP"); + mtc.stop; + } + } + + setverdict(pass); +} + +/* Test if a LAC_CI FAILURE Ind is sent when conn of TRX holding the CBCH goes down. */ +testcase TC_cbsp_cell_rsl_down_failure() runs on cbsp_test_CT { + var template CBSP_PDU rx; + + g_pars := valueof(ts_CBSP_Pars_default(false, 0, 0)); + f_init(); + + /* Drop RSL link of the TRX holding the CBCH: */ + f_ipa_rsl_stop(bts[0][0].rsl); + + rx := tr_CBSP_FAILURE({CBSP_FailureListItem_LAC_CI(bssmap_lac_ci(mp_cgi_bts0), + CBSP_CAUSE_CB_NOT_OPERATIONAL)}, + CBSP_BC_MSGT_CBS); + alt { + [] CBSP[0].receive(tr_CBSP_Recv(g_cbsp_conn_id[0], rx)) { + setverdict(pass); + } + [] CBSP[0].receive(tr_CBSP_Recv(g_cbsp_conn_id[0], ?)) { + setverdict(fail, "Received unexpected CBSP"); + mtc.stop; + } + } + + /* TODO: call f_init() again to reconnect? */ + setverdict(pass); +} + testcase TC_cbsp_write() runs on cbsp_test_CT { var template (value) CBSP_PDU tx; var CBSP_IEs pages := {f_gen_page()}; @@ -1081,6 +1156,8 @@ execute( TC_cbsp_bsc_client() ); execute( TC_cbsp_bsc_client_ipv6() ); execute( TC_cbsp_reset_bss() ); + execute( TC_cbsp_cell_rflock_failure_restart() ); + execute( TC_cbsp_cell_rsl_down_failure() ); /* test various different types of Cell Identities */ execute( TC_cbsp_write_bss() ); diff --git a/library/CBSP_Templates.ttcn b/library/CBSP_Templates.ttcn index d166bcf..2d70256 100644 --- a/library/CBSP_Templates.ttcn +++ b/library/CBSP_Templates.ttcn @@ -134,6 +134,18 @@ list := items }}); +template (present) CBSP_FailureListItem CBSP_FailureListItem_LAC_CI( + template (present) BSSMAP_FIELD_CellIdentification_LAC_CI lac_ci := ?, + template (present) CBSP_Cause cause := ?) := +{ + spare1_4 := '0000'B, + cell_id_discr := '0001'B, + cell_id := { + cI_LAC_CI := lac_ci + }, + cause := cause +}; + template (value) CBSP_IE ts_CbspNumComplList(template (value) CBSP_IE_NumBcastComplList list) := ts_CBSP_IE(CBSP_IEI_NUM_BCAST_COMPL_LIST, {num_bcast_compl_list := list}); template CBSP_IE tr_CbspNumComplList(template CBSP_IE_NumBcastComplList list := ?) := -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28273 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I35ddde7bc2e39d35c301f1153416b549ba1630cd Gerrit-Change-Number: 28273 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc-cbsp: Test BTS Failure+Restart when BTS becomes (un)available

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28273 ) Change subject: bsc-cbsp: Test BTS Failure+Restart when BTS becomes (un)available ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28273 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I35ddde7bc2e39d35c301f1153416b549ba1630cd Gerrit-Change-Number: 28273 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jun 2022 20:27:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: stats: track TCH/SDCCH lchans reaching fully-established state

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28295 ) Change subject: stats: track TCH/SDCCH lchans reaching fully-established state ...................................................................... stats: track TCH/SDCCH lchans reaching fully-established state When calculating average lchan duration based on the new stats for BTS_CTR_CHAN_{TCH,SDCCH}_ACTIVE_MILLISECONDS_TOTAL there are discrepancies which emerge. Specificially in bandwidth-constrained environments, there are still-unknown failure states which can occur that cause the TCH or SDCCH activity count to increment but zero milliseconds of activity on the lchan to accumulate. This portrays a failure as a success. These new fully-established stats are intended to provide a more accurate denominator when calculating average lchan duration as they are incremented in proximity to the duration timestamp initialization. Change-Id: I417940ad9479719f5324fb12d45883cd3cb2c578 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bts.c M src/osmo-bsc/lchan_fsm.c 3 files changed, 21 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index a26bdbd..8abcf13 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -62,6 +62,8 @@ BTS_CTR_CHAN_ACT_NACK, BTS_CTR_CHAN_TCH_ACTIVE_MILLISECONDS_TOTAL, BTS_CTR_CHAN_SDCCH_ACTIVE_MILLISECONDS_TOTAL, + BTS_CTR_CHAN_TCH_FULLY_ESTABLISHED, + BTS_CTR_CHAN_SDCCH_FULLY_ESTABLISHED, BTS_CTR_RSL_UNKNOWN, BTS_CTR_RSL_IPA_NACK, BTS_CTR_RSL_DELETE_IND, diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 4f8a3e1..2f66611 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -1155,6 +1155,12 @@ [BTS_CTR_CHAN_SDCCH_ACTIVE_MILLISECONDS_TOTAL] = \ { "chan_sdcch:active_milliseconds:total", "Cumulative number of milliseconds of SDCCH channel activity" }, + [BTS_CTR_CHAN_TCH_FULLY_ESTABLISHED] = \ + { "chan_tch:fully_established", + "Number of TCH channels which have reached the fully established state" }, + [BTS_CTR_CHAN_SDCCH_FULLY_ESTABLISHED] = \ + { "chan_sdcch:fully_established", + "Number of SDCCH channels which have reached the fully established state" }, [BTS_CTR_RSL_UNKNOWN] = \ { "rsl:unknown", "Number of unknown/unsupported RSL messages received from BTS" }, diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index 2d566b6..41b7ae7 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -208,6 +208,19 @@ osmo_clock_gettime(CLOCK_MONOTONIC, &lchan->active_start); lchan->active_stored = lchan->active_start; + /* Increment rate counters tracking fully established lchans. */ + switch (lchan->type) { + case GSM_LCHAN_TCH_H: + case GSM_LCHAN_TCH_F: + rate_ctr_inc(rate_ctr_group_get_ctr(lchan->ts->trx->bts->bts_ctrs, BTS_CTR_CHAN_TCH_FULLY_ESTABLISHED)); + break; + case GSM_LCHAN_SDCCH: + rate_ctr_inc(rate_ctr_group_get_ctr(lchan->ts->trx->bts->bts_ctrs, BTS_CTR_CHAN_SDCCH_FULLY_ESTABLISHED)); + break; + default: + break; + } + switch (lchan->activate.info.activ_for) { case ACTIVATE_FOR_MS_CHANNEL_REQUEST: /* No signalling to do here, MS is free to use the channel, and should go on to connect -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28295 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I417940ad9479719f5324fb12d45883cd3cb2c578 Gerrit-Change-Number: 28295 Gerrit-PatchSet: 2 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: stats: track TCH/SDCCH lchans reaching fully-established state

by laforge

Attention is currently required from: iedemam. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28295 ) Change subject: stats: track TCH/SDCCH lchans reaching fully-established state ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28295 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I417940ad9479719f5324fb12d45883cd3cb2c578 Gerrit-Change-Number: 28295 Gerrit-PatchSet: 1 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Comment-Date: Fri, 17 Jun 2022 20:26:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-cbc[master]: cbsp_server: Reorder logged message

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28302 ) Change subject: cbsp_server: Reorder logged message ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ic444c749476bb1626df5494c00021c5e1a9f24b9 Gerrit-Change-Number: 28302 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jun 2022 20:25:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-cbc[master]: Rework cbsp_cbc_create() params

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28299 ) Change subject: Rework cbsp_cbc_create() params ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28299 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ia2362757275e7cbce82b64c7c2a0798276d964c3 Gerrit-Change-Number: 28299 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Jun 2022 20:25:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2022