Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28256 )
Change subject: Move all SMSCB/CBC vty code to its own file
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
is this purely cosmetic? might deserve a mention in the commitlog. Is there some follow-up code coming that depends on this? Curious as to why you thought it's worth to move the code around :)
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28256
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ifc7d1693d745dd2a3c31e3ee9610d8c634b50812
Gerrit-Change-Number: 28256
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 10 Jun 2022 05:00:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28254 )
Change subject: hnodeb: Test passing unordered list of RFCIs
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28254
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib8961630a1ebe6f6bfee5af0889aa129e491cb2b
Gerrit-Change-Number: 28254
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 10 Jun 2022 04:58:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28255 )
Change subject: hnodeb: Fix passing pars to f_start_handler()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28255
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I05bb47dc12b4544a6f2d4fc1fadc9e68da374f8b
Gerrit-Change-Number: 28255
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 10 Jun 2022 04:56:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/28250 )
Change subject: llsk: Validate received SAPI versions at startup
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File include/osmocom/hnodeb/hnodeb.h:
https://gerrit.osmocom.org/c/osmo-hnodeb/+/28250/comment/e03e50a4_cda93b3b
PS1, Line 95: uint16_t sapi_version_iuh;
might again make a nice sub-struct for llsk.sapi_version.{iuh,gtp,audio}. Just saying, not a requirement...
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/28250
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnodeb
Gerrit-Branch: master
Gerrit-Change-Id: I172abfee3bfadb383aa6bce6fe76306291c7cd7f
Gerrit-Change-Number: 28250
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 10 Jun 2022 04:55:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Karsten Ohme.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28248 )
Change subject: APDU parsing support for GlobalPlatform
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
quite interesting. Do you have any idea what it is using this for? After all, there is no requirement in 3GPP that a SIM/USIM/UICC must be a java card or that it must support global platform?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28248
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib734fc852e7b63b9efdc414adccbd796a572eb55
Gerrit-Change-Number: 28248
Gerrit-PatchSet: 1
Gerrit-Owner: Karsten Ohme <wider.stand(a)gmx.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Karsten Ohme <wider.stand(a)gmx.de>
Gerrit-Comment-Date: Fri, 10 Jun 2022 04:53:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment