Attention is currently required from: neels, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28245 )
Change subject: install libosmo-gtlv, libosmo-pfcp
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Patchset:
PS1:
> Personally, I don't see a need to spend time on moving code between repositories. […]
It is a difficult question, and as neels has pointed out, one that has not really been properly resolved in our overall repository structure.
* the libosmo-mgcp-client example is not applicable, as it really is only needed by code talking to osmo-mgw; likewise libosmo-gsup in osmo-hlr.git. Those are both fine, IMHO.
* we do have other "strange" examples like osmo-stp being in libosmo-sccp.git. This is odd and should have been done properly from the start, as cleaning this up later means touching every bit of our infrastructure (from packaging recipes to OBS jobs, jenkins jobs and finally ansible playbooks, sysmoNITB stuff, etc.).
So if we already know that libosmo-pfcp is [in the osmocom universe] only used internally by UPF or to talk to osmo-upf [or maybe some other upf] it is fine to keep it in osmo-upf.git. This reflects the MGCP-client, GSUP-client or even libgtp/ggsn situation.
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28245
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I9f4651b6bee457583aba99052dc82bbf675515e6
Gerrit-Change-Number: 28245
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 10 Jun 2022 04:12:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28260 )
Change subject: cgit: more verbose logging format in access.log
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28260
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Iee684c8732410971719044b281a4e810fe0f7945
Gerrit-Change-Number: 28260
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 10 Jun 2022 04:03:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels.
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/28112 )
Change subject: Don't check rtp timestamps if we are not patching timestamps.
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> the motivation is to reduce CPU load?
It was more to stop such profuse "spamming" of vty/syslog at log level notice, which happens with the Ericsson RBS. But @laforge is right, better to find out why this is happening.
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/28112
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I889fce4c86cffdcbb74b17cd36ccda89c034a824
Gerrit-Change-Number: 28112
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 10 Jun 2022 02:03:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment