June 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: hnodeb: Test passing unordered list of RFCIs

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28254 to look at the new patch set (#2). Change subject: hnodeb: Test passing unordered list of RFCIs ...................................................................... hnodeb: Test passing unordered list of RFCIs This feature is available since Audio SAPI version 1, which was recently added. Let's update the test to cover this feature. Related: SYS#5516 Change-Id: Ib8961630a1ebe6f6bfee5af0889aa129e491cb2b --- M hnodeb/HNB_Tests.ttcn 1 file changed, 27 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/54/28254/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28254 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib8961630a1ebe6f6bfee5af0889aa129e491cb2b Gerrit-Change-Number: 28254 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: hnodeb: Fix passing pars to f_start_handler()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28255 ) Change subject: hnodeb: Fix passing pars to f_start_handler() ...................................................................... hnodeb: Fix passing pars to f_start_handler() isvalue() returns false when the template is not omit, which is unexpected in this code path. Let's explicitly test against "omit" here. Change-Id: I05bb47dc12b4544a6f2d4fc1fadc9e68da374f8b --- M hnodeb/HNB_Tests.ttcn 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/55/28255/1 diff --git a/hnodeb/HNB_Tests.ttcn b/hnodeb/HNB_Tests.ttcn index a58e203..24feab8 100644 --- a/hnodeb/HNB_Tests.ttcn +++ b/hnodeb/HNB_Tests.ttcn @@ -174,10 +174,10 @@ function f_start_handler(void_fn fn, template (omit) TestHdlrParams pars_tmpl := omit) runs on test_CT return HNBGW_ConnHdlr { var TestHdlrParams pars; - if (isvalue(pars)) { - pars := valueof(pars_tmpl); - } else { + if (istemplatekind(pars_tmpl, "omit")) { pars := valueof(f_gen_test_hdlr_pars()); + } else { + pars := valueof(pars_tmpl); } return f_start_handler_run(f_start_handler_create(pars), fn, pars); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28255 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I05bb47dc12b4544a6f2d4fc1fadc9e68da374f8b Gerrit-Change-Number: 28255 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: hnodeb: Update primitives to audio SAPI version 1

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28253 ) Change subject: hnodeb: Update primitives to audio SAPI version 1 ...................................................................... hnodeb: Update primitives to audio SAPI version 1 Audio SAPI version 1 has been added recently in osmo-hnodeb.git I860d18b80c1041bf63a1570d435e0568c0f6b01b. Let's update our HNBLLIF emulation to support and use it. Related: SYS#5516 Change-Id: I9af56f5e6a70b350f2fffa2e04be384d101b52ed --- M hnodeb/HNBGW_ConnectionHandler.ttcn M library/HNBLLIF_Templates.ttcn M library/HNBLLIF_Types.ttcn 3 files changed, 19 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/53/28253/1 diff --git a/hnodeb/HNBGW_ConnectionHandler.ttcn b/hnodeb/HNBGW_ConnectionHandler.ttcn index a92ac9e..6ce2faf 100644 --- a/hnodeb/HNBGW_ConnectionHandler.ttcn +++ b/hnodeb/HNBGW_ConnectionHandler.ttcn @@ -177,7 +177,7 @@ hnbllif_sk_path := HNBLL_SOCK_DEFAULT, hnbllif_sapi_iuh_version := 0, hnbllif_sapi_gtp_version := 0, - hnbllif_sapi_audio_version := 0, + hnbllif_sapi_audio_version := 1, hnbgw_addr := "127.0.0.1", hnodeb_addr := "127.0.0.1", hnbgw_port := 29169, diff --git a/library/HNBLLIF_Templates.ttcn b/library/HNBLLIF_Templates.ttcn index 6aee659..5333215 100644 --- a/library/HNBLLIF_Templates.ttcn +++ b/library/HNBLLIF_Templates.ttcn @@ -275,6 +275,17 @@ return ss; } +private function f_rfcis_default() return HNBLLIF_AUDIO_RFCIs +{ + var HNBLLIF_AUDIO_RFCIs rfcis; + + for (var integer i := 0; i < HNBLLIF_MAX_RFCIS; i := i + 1) { + rfcis[i] := i; + } + + return rfcis; +} + template (value) HNBLLIF_Message ts_HNBLLIF_AUDIO_CONN_ESTABLISH_REQ(template (value) uint32_t context_id, template (value) uint16_t remote_rtp_port, template (value) HNBLLIF_AddrType remote_rtp_address_type, @@ -286,7 +297,8 @@ template (value) uint8_t num_subflows := 3, template (value) HNBLLIF_AUDIO_SubflowSizes subflow_sizes := f_subflow_sizes_default(), template (value) uint8_t IPTIs_present := 0, - template (value) HNBLLIF_AUDIO_IPTIs IPTIs := IPTIs_default) := { + template (value) HNBLLIF_AUDIO_IPTIs IPTIs := IPTIs_default, + template (value) HNBLLIF_AUDIO_RFCIs rfci := f_rfcis_default()) := { sapi := HNBLL_IF_SAPI_AUDIO, u := { audio := { @@ -308,7 +320,8 @@ num_subflows := num_subflows, subflow_sizes := subflow_sizes, IPTIs_present := IPTIs_present, - IPTIs := IPTIs + IPTIs := IPTIs, + rfci := rfci } } } diff --git a/library/HNBLLIF_Types.ttcn b/library/HNBLLIF_Types.ttcn index fa44f11..375a026 100644 --- a/library/HNBLLIF_Types.ttcn +++ b/library/HNBLLIF_Types.ttcn @@ -246,6 +246,7 @@ type record length(HNBLLIF_MAX_RFCIS) of uint8_t HNBLLIF_AUDIO_IPTIs; type record length(HNBLLIF_MAX_SUBFLOWS) of uint16_t HNBLLIF_AUDIO_RFCI_SubflowSizes; type record length(HNBLLIF_MAX_RFCIS) of HNBLLIF_AUDIO_RFCI_SubflowSizes HNBLLIF_AUDIO_SubflowSizes; +type record length(HNBLLIF_MAX_RFCIS) of uint8_t HNBLLIF_AUDIO_RFCIs; /* CONN_ESTABLISH */ type record HNBLLIF_AUDIO_conn_establish_req { @@ -261,7 +262,8 @@ uint8_t num_subflows, HNBLLIF_AUDIO_SubflowSizes subflow_sizes, uint8_t IPTIs_present, /* 1=present; 0=not present */ - HNBLLIF_AUDIO_IPTIs IPTIs /* values range 0-15, 4 bits */ + HNBLLIF_AUDIO_IPTIs IPTIs, /* values range 0-15, 4 bits */ + HNBLLIF_AUDIO_RFCIs rfci } with { variant "" }; type record HNBLLIF_AUDIO_conn_establish_cnf { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9af56f5e6a70b350f2fffa2e04be384d101b52ed Gerrit-Change-Number: 28253 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: hnodeb: Allow setting hnbllif sapi versions

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28252 ) Change subject: hnodeb: Allow setting hnbllif sapi versions ...................................................................... hnodeb: Allow setting hnbllif sapi versions Version 1 of audio SAPI will be used in follow-up patch. Related: SYS#5516 Change-Id: I24d757d3dfa4148537db49d70c525e1a81836426 --- M hnodeb/HNBGW_ConnectionHandler.ttcn M hnodeb/HNB_Tests.ttcn 2 files changed, 19 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/52/28252/1 diff --git a/hnodeb/HNBGW_ConnectionHandler.ttcn b/hnodeb/HNBGW_ConnectionHandler.ttcn index 6b06437..a92ac9e 100644 --- a/hnodeb/HNBGW_ConnectionHandler.ttcn +++ b/hnodeb/HNBGW_ConnectionHandler.ttcn @@ -106,19 +106,20 @@ f_HNBGW_ConnHdlr_init_vty(); /* Connect to HNB on LLSK and do HELLO ping-pong */ - f_start_hnbllif(LLSK, id & "-LLSK", g_pars.hnbllif_sk_path, g_llsk_conn_id); + f_start_hnbllif(LLSK, id & "-LLSK", g_pars, g_llsk_conn_id); } -function f_start_hnbllif(HNBLLIF_CODEC_PT pt, charstring id, charstring hnbllif_sk_path, out integer hnbllif_conn_id) { +function f_start_hnbllif(HNBLLIF_CODEC_PT pt, charstring id, TestHdlrParams pars, + out integer hnbllif_conn_id) { timer T := 2.0; var HNBLLIF_send_data sd; var HNBLLIF_Message last_hello_cnf; - if (hnbllif_sk_path == "") { + if (pars.hnbllif_sk_path == "") { hnbllif_conn_id := -1; return; } - hnbllif_conn_id := f_hnbllif_connect(pt, hnbllif_sk_path); + hnbllif_conn_id := f_hnbllif_connect(pt, pars.hnbllif_sk_path); T.start; pt.send(t_SD_HNBLLIF(hnbllif_conn_id, ts_HNBLLIF_CTL_HELLO_REQ(HNBLL_IF_SAPI_CTL, HNBLLIF_Types.mp_hnbllif_version))); @@ -128,23 +129,23 @@ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for HNBLLIF HELLO.REQ SAPI=CTL"); } } - pt.send(t_SD_HNBLLIF(hnbllif_conn_id, ts_HNBLLIF_CTL_HELLO_REQ(HNBLL_IF_SAPI_IUH, 0))); + pt.send(t_SD_HNBLLIF(hnbllif_conn_id, ts_HNBLLIF_CTL_HELLO_REQ(HNBLL_IF_SAPI_IUH, pars.hnbllif_sapi_iuh_version))); alt { - [] as_hnbllif_hello_cnf(pt, hnbllif_conn_id, last_hello_cnf, HNBLL_IF_SAPI_IUH, 0); + [] as_hnbllif_hello_cnf(pt, hnbllif_conn_id, last_hello_cnf, HNBLL_IF_SAPI_IUH, pars.hnbllif_sapi_iuh_version); [] T.timeout { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for HNBLLIF HELLO.REQ SAPI=IUH"); } } - pt.send(t_SD_HNBLLIF(hnbllif_conn_id, ts_HNBLLIF_CTL_HELLO_REQ(HNBLL_IF_SAPI_AUDIO, 0))); + pt.send(t_SD_HNBLLIF(hnbllif_conn_id, ts_HNBLLIF_CTL_HELLO_REQ(HNBLL_IF_SAPI_AUDIO, pars.hnbllif_sapi_audio_version))); alt { - [] as_hnbllif_hello_cnf(pt, hnbllif_conn_id, last_hello_cnf, HNBLL_IF_SAPI_AUDIO, 0); + [] as_hnbllif_hello_cnf(pt, hnbllif_conn_id, last_hello_cnf, HNBLL_IF_SAPI_AUDIO, pars.hnbllif_sapi_audio_version); [] T.timeout { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for HNBLLIF HELLO.REQ SAPI=AUDIO"); } } - pt.send(t_SD_HNBLLIF(hnbllif_conn_id, ts_HNBLLIF_CTL_HELLO_REQ(HNBLL_IF_SAPI_GTP, 0))); + pt.send(t_SD_HNBLLIF(hnbllif_conn_id, ts_HNBLLIF_CTL_HELLO_REQ(HNBLL_IF_SAPI_GTP, pars.hnbllif_sapi_gtp_version))); alt { - [] as_hnbllif_hello_cnf(pt, hnbllif_conn_id, last_hello_cnf, HNBLL_IF_SAPI_GTP, 0); + [] as_hnbllif_hello_cnf(pt, hnbllif_conn_id, last_hello_cnf, HNBLL_IF_SAPI_GTP, pars.hnbllif_sapi_gtp_version); [] T.timeout { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for HNBLLIF HELLO.REQ SAPI=GTP"); } @@ -153,6 +154,9 @@ type record TestHdlrParams { charstring hnbllif_sk_path, /* "" means don't connect */ + uint16_t hnbllif_sapi_iuh_version, + uint16_t hnbllif_sapi_gtp_version, + uint16_t hnbllif_sapi_audio_version, charstring hnbgw_addr, charstring hnodeb_addr, integer hnbgw_port, @@ -171,6 +175,9 @@ * f_gen_test_hdlr_pars() instead in order to get a configuration. */ template (value) TestHdlrParams t_def_TestHdlrPars := { hnbllif_sk_path := HNBLL_SOCK_DEFAULT, + hnbllif_sapi_iuh_version := 0, + hnbllif_sapi_gtp_version := 0, + hnbllif_sapi_audio_version := 0, hnbgw_addr := "127.0.0.1", hnodeb_addr := "127.0.0.1", hnbgw_port := 29169, diff --git a/hnodeb/HNB_Tests.ttcn b/hnodeb/HNB_Tests.ttcn index a58e203..3925e60 100644 --- a/hnodeb/HNB_Tests.ttcn +++ b/hnodeb/HNB_Tests.ttcn @@ -113,9 +113,9 @@ f_vty_transceive(HNBVTY, "enable"); } -private function f_init_hnbllif() runs on test_CT { +private function f_init_hnbllif(TestHdlrParams pars) runs on test_CT { map(self:LLSK, system:LLSK); - f_start_hnbllif(LLSK, testcasename(), mp_hnbllif_sk_path, g_llsk_conn_id); + f_start_hnbllif(LLSK, testcasename(), pars, g_llsk_conn_id); } /* global initialization function */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28252 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I24d757d3dfa4148537db49d70c525e1a81836426 Gerrit-Change-Number: 28252 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: hnodeb: Test passing unordered list of RFCIs

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28254 ) Change subject: hnodeb: Test passing unordered list of RFCIs ...................................................................... hnodeb: Test passing unordered list of RFCIs This feature is available since Audio SAPI version 1, which was recently added. Let's update the test to cover this feature. Related: SYS#5516 Change-Id: Ib8961630a1ebe6f6bfee5af0889aa129e491cb2b --- M hnodeb/HNB_Tests.ttcn 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/54/28254/1 diff --git a/hnodeb/HNB_Tests.ttcn b/hnodeb/HNB_Tests.ttcn index 3925e60..82b34d1 100644 --- a/hnodeb/HNB_Tests.ttcn +++ b/hnodeb/HNB_Tests.ttcn @@ -300,6 +300,13 @@ timer Tu; var uint32_t audio_conn_id; var IuUP_FQC fqc := IuUP_FQC_GOOD; + var HNBLLIF_AUDIO_RFCIs rfcis; + + /* generate some unordered RFCI list of 3 elements (the default): */ + rfcis[0] := 1; rfcis[1] := 2; rfcis[2] := 0; + for (var integer i := 3; i < HNBLLIF_MAX_RFCIS; i := i + 1) { + rfcis[i] := 0; + } rtp_payload := f_rnd_octstring(6); f_HNBGW_rtpem_activate(rtp_payload); @@ -323,7 +330,8 @@ /* Now LLSK provides the remote TransportLayerAddress from RabAssReq and asks SUT to provide a local address: */ LLSK.send(f_llsk_tx(ts_HNBLLIF_AUDIO_CONN_ESTABLISH_REQ(context_id, g_pars.hnbgw_rtp_port, HNBLL_IF_ADDR_TYPE_IPV4, - f_HNBLLIF_Addr(HNBLL_IF_ADDR_TYPE_IPV4, g_pars.hnbgw_addr)))); + f_HNBLLIF_Addr(HNBLL_IF_ADDR_TYPE_IPV4, g_pars.hnbgw_addr), + rfci := rfcis))); LLSK.receive(f_llsk_rx(tr_HNBLLIF_AUDIO_CONN_ESTABLISH_CNF(context_id, ?, 0, ?, HNBLL_IF_ADDR_TYPE_IPV4, ?))) -> value sd; audio_conn_id := sd.data.u.audio.u.conn_establish.u.cnf.audio_conn_id; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28254 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib8961630a1ebe6f6bfee5af0889aa129e491cb2b Gerrit-Change-Number: 28254 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-bsc-nat[master]: subscr_conn_fsm: refactor timeouts

by pespin

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28249 ) Change subject: subscr_conn_fsm: refactor timeouts ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28249 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Ib34e6ccc34901ebc37d2dbe347d9644cb70921ca Gerrit-Change-Number: 28249 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Jun 2022 10:01:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc-nat[master]: subscr_conn_fsm: refactor timeouts

by pespin

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28249 ) Change subject: subscr_conn_fsm: refactor timeouts ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc-nat/bsc_nat.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28249/comment/1f14ef6f_79bc4717 PS2, Line 31: struct osmo_tdef g_bsc_nat_tdefs[] = { > Done @fixeria it cannot be static const since it is initialized. In the case where there are several instances of this tdef it indeed makes sense to have one const and then duplicate it in memory for each instance (we do that in several places), but in here there's no use in doing that since anyway there's only 1 instance, so it's fine resetting/changing values in it directly. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28249 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Ib34e6ccc34901ebc37d2dbe347d9644cb70921ca Gerrit-Change-Number: 28249 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Jun 2022 10:01:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc-nat[master]: subscr_conn_fsm: refactor timeouts

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28249 ) Change subject: subscr_conn_fsm: refactor timeouts ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc-nat/bsc_nat.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28249/comment/6652222c_caac6cf1 PS2, Line 31: struct osmo_tdef g_bsc_nat_tdefs[] = { > Done set to static. Using static const seems wrong, osmo_tdefs_reset() changes it. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28249 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Ib34e6ccc34901ebc37d2dbe347d9644cb70921ca Gerrit-Change-Number: 28249 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Jun 2022 10:00:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc-nat[master]: subscr_conn_fsm: refactor timeouts

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28249 ) Change subject: subscr_conn_fsm: refactor timeouts ...................................................................... Patch Set 2: (2 comments) File src/osmo-bsc-nat/bsc_nat.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28249/comment/9b510b58_b4fec569 PS2, Line 31: struct osmo_tdef g_bsc_nat_tdefs[] = { > static Done https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28249/comment/b7fcdb53_6e141801 PS2, Line 37: struct osmo_tdef_group g_bsc_nat_tdef_group[] = { > where is this used? src/osmo-bsc-nat/vty.c:83: osmo_tdef_vty_groups_init(CONFIG_NODE, g_bsc_nat_tdef_group); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28249 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Ib34e6ccc34901ebc37d2dbe347d9644cb70921ca Gerrit-Change-Number: 28249 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Jun 2022 09:53:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc-nat[master]: subscr_conn_fsm: refactor timeouts

by osmith

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28249 to look at the new patch set (#3). Change subject: subscr_conn_fsm: refactor timeouts ...................................................................... subscr_conn_fsm: refactor timeouts Use osmo_tdef_state_timeout instead of passing timers every time. Rename g_mgw_tdefs to g_bsc_nat_tdefs and add the new TDEF_ASS_COMPL there, so the TDEF_MGCP can be used in subscr_conn_fsm and by mgcp client without duplicating it. Related: SYS#5560 Change-Id: Ib34e6ccc34901ebc37d2dbe347d9644cb70921ca --- M include/osmocom/bsc_nat/bsc_nat.h M src/osmo-bsc-nat/bsc_nat.c M src/osmo-bsc-nat/subscr_conn_fsm.c 3 files changed, 42 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/49/28249/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28249 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Ib34e6ccc34901ebc37d2dbe347d9644cb70921ca Gerrit-Change-Number: 28249 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2022