June 2022 - gerrit-log - lists.osmocom.org

Change in osmo-upf[master]: add pfcp_endpoint
by pespin 08 Jun '22

08 Jun '22

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28244 ) Change subject: add pfcp_endpoint ...................................................................... Patch Set 3: (14 comments) File include/osmocom/pfcp/pfcp_endpoint.h: https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/af4b7e80_6a8b3623 PS3, Line 46: * \param req If m is a PFCP Response to an earlier Request, req is that request message. */ otherwise NULL? https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/1affc898_45259753 PS3, Line 51: struct osmo_pfcp_endpoint { osmo_pfcp_endp seems like it's going to be a typing/reading change worth it ;) https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/d546a61b_ef4e0142 PS3, Line 77: osmo_pfcp_endpoint_cb set_msg_ctx; can we call all these callbacks with _cb at the end? https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/35f7180e_1416176a PS3, Line 99: int osmo_pfcp_endpoint_tx(struct osmo_pfcp_endpoint *ep, struct osmo_pfcp_msg *m); something more meaningful like "pfcp_msg" instead of "m" may be worth a change. https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/95ea74dc_d876c9b8 PS3, Line 104: In general I'm missing some APIs to set callbaks, local_node_id, etc. File src/libosmo-pfcp/pfcp_endpoint.c: https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/cc33a298_f66517f2 PS3, Line 42: struct osmo_pfcp_msg *m; Doesn't m already have a backpointer to ep? May make more sense to just have that one. https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/3937e30a_9642a8b2 PS3, Line 44: struct osmo_timer_list t1; This can be probably optimized to be only 1 timer per list, by moving them to the end of the list when transmitting. https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/666950be_1d455595 PS3, Line 73: int osmo_pfcp_queue_destructor(struct osmo_pfcp_queue_entry *qe) why is the destructor not static? https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/fa7cf025_76293f47 PS3, Line 81: { .T = -19, .default_val = 15, .unit = OSMO_TDEF_S, why some timers have names and some don't? https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/53eeee82_dfbaa664 PS3, Line 122: /* time() returns seconds since 1970 (UNIX epoch), but the recovery_time_stamp is coded in the NTP format, which is you can check open5gs code, iirc some stuff exists to handle ntp timestamps and I also added some bits for Gy interface. https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/88bfb347_466a7bef PS3, Line 139: unsigned int ep_t1(struct osmo_pfcp_endpoint *ep) static https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/5003a26e_76020902 PS3, Line 144: unsigned int ep_keep_resp(struct osmo_pfcp_endpoint *ep) static https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/6b21310a_656371d0 PS3, Line 177: static void pfcp_queue_timer_cb(void *data) Maybe rename to contain "expiry" in it? https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/19fc2ff0_ed14639d PS3, Line 182: if (qe->m->is_response) { I see you are basically putting together in the same list 2 different things: * List of transmitted request messages (in order to retransmit them at interval times). * List of transmitted response messages (no retrans happening, only keeping them in order to match and resend when a retransmit req arrives). I don't see the point in having them in the same list, because they are looked up and used at different scenarios. Having it in different lists means you don't need to loop over all requests+reposnses every time, only about the important subset (req or resp). See for instance how libgtp does it, since I believe it's the same system as in GTP. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28244 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic8d42e201b63064a71b40ca45a5a40e29941e8ac Gerrit-Change-Number: 28244 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Jun 2022 18:47:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-upf[master]: install libosmo-gtlv, libosmo-pfcp
by pespin 08 Jun '22

08 Jun '22

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28245 ) Change subject: install libosmo-gtlv, libosmo-pfcp ...................................................................... Patch Set 3: (1 comment) Patchset: PS1: > my opinion is i don't mind either way. […] We already discussed some of this and I think it was already agreed we definetly didn't want to move more protocol specific libs inside libosmocore. Is libosmo-tlv used somewhere outside libosmo-pfcp internal code? If the answer is no, simply move everything inside libosmo-pfcp.git. If the answer is yes, or you plan to use it somewhere else, then I'm fine with moving libosmo-tlv as a different shared object inside libosmocore.git, but still keeping libosmo-pfcp outside of libosmocore.git. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I9f4651b6bee457583aba99052dc82bbf675515e6 Gerrit-Change-Number: 28245 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Jun 2022 18:27:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in docker-playground[master]: ttcn3-bsc-test/jenkins-sccplite.sh: fix missing osmo-bts-omldummy logs
by fixeria 08 Jun '22

08 Jun '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/28247 ) Change subject: ttcn3-bsc-test/jenkins-sccplite.sh: fix missing osmo-bts-omldummy logs ...................................................................... ttcn3-bsc-test/jenkins-sccplite.sh: fix missing osmo-bts-omldummy logs Change-Id: I823c34a754701dc71cd52df0ca660bd8fe3c02ab --- M ttcn3-bsc-test/jenkins-sccplite.sh 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/47/28247/1 diff --git a/ttcn3-bsc-test/jenkins-sccplite.sh b/ttcn3-bsc-test/jenkins-sccplite.sh index e231a6f..3d2b70d 100755 --- a/ttcn3-bsc-test/jenkins-sccplite.sh +++ b/ttcn3-bsc-test/jenkins-sccplite.sh @@ -20,6 +20,8 @@ mkdir $VOL_BASE_DIR/bsc cp sccplite/osmo-bsc.cfg $VOL_BASE_DIR/bsc/ +mkdir $VOL_BASE_DIR/bts-omldummy + SUBNET=12 network_create $SUBNET @@ -40,6 +42,7 @@ docker run --rm \ $(docker_network_params $SUBNET 10$1) \ --ulimit core=-1 \ + -v $VOL_BASE_DIR/bts-omldummy:/data \ --name ${BUILD_TAG}-bts$1 -d \ $DOCKER_ARGS \ $REPO_USER/osmo-bts-$IMAGE_SUFFIX \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28247 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I823c34a754701dc71cd52df0ca660bd8fe3c02ab Gerrit-Change-Number: 28247 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in docker-playground[master]: ttcn3-bsc-test/jenkins-sccplite.sh: configure 4 TRX for BTS2
by fixeria 08 Jun '22

08 Jun '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/28246 ) Change subject: ttcn3-bsc-test/jenkins-sccplite.sh: configure 4 TRX for BTS2 ...................................................................... ttcn3-bsc-test/jenkins-sccplite.sh: configure 4 TRX for BTS2 This is another fixup for [1]. I didn't notice that the sccplite variant of ttcn3-bsc-test has its own copy of jenkins.sh. Change-Id: I21219724adbeda4166963b4940b08aad281a62cb Fixes: [1] Iba4fbd5c9ed59783df4ac64e68b2beef73a812ff Related: SYS#5460 --- M ttcn3-bsc-test/jenkins-sccplite.sh 1 file changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/46/28246/1 diff --git a/ttcn3-bsc-test/jenkins-sccplite.sh b/ttcn3-bsc-test/jenkins-sccplite.sh index 5ba4925..e231a6f 100755 --- a/ttcn3-bsc-test/jenkins-sccplite.sh +++ b/ttcn3-bsc-test/jenkins-sccplite.sh @@ -34,15 +34,16 @@ BTS_FEATURES="-fCCN,EGPRS,GPRS,IPv6_NSVC,PAGING_COORDINATION" -for i in `seq 0 2`; do - echo Starting container with OML for BTS$i +for i in "0 1" "1 1" "2 4"; do + set -- $i # convert the {BTS, TRXN} "tuple" into the param args $1 $2 + echo "Starting container with OML for BTS$1 (TRXN = $2)" docker run --rm \ - $(docker_network_params $SUBNET 10$i) \ + $(docker_network_params $SUBNET 10$1) \ --ulimit core=-1 \ - --name ${BUILD_TAG}-bts$i -d \ + --name ${BUILD_TAG}-bts$1 -d \ $DOCKER_ARGS \ $REPO_USER/osmo-bts-$IMAGE_SUFFIX \ - /bin/sh -c "/usr/local/bin/respawn.sh osmo-bts-omldummy $BTS_FEATURES 172.18.12.20 $((i + 1234)) 1 >>/data/osmo-bts-omldummy-${i}.log 2>&1" + /bin/sh -c "/usr/local/bin/respawn.sh osmo-bts-omldummy $BTS_FEATURES 172.18.12.20 $(($1 + 1234)) $2 >>/data/osmo-bts-omldummy-$1.log 2>&1" done echo Starting container with BSC testsuite -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28246 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I21219724adbeda4166963b4940b08aad281a62cb Gerrit-Change-Number: 28246 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-upf[master]: add pfcp_endpoint
by neels 08 Jun '22

08 Jun '22

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-upf/+/28244 to look at the new patch set (#3). Change subject: add pfcp_endpoint ...................................................................... add pfcp_endpoint Related: SYS#5599 Change-Id: Ic8d42e201b63064a71b40ca45a5a40e29941e8ac --- M include/osmocom/pfcp/Makefile.am A include/osmocom/pfcp/pfcp_endpoint.h M include/osmocom/pfcp/pfcp_msg.h M src/libosmo-pfcp/Makefile.am A src/libosmo-pfcp/pfcp_endpoint.c 5 files changed, 574 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/44/28244/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28244 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic8d42e201b63064a71b40ca45a5a40e29941e8ac Gerrit-Change-Number: 28244 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-bsc-nat[master]: Add subscr_conn_fsm
by neels 08 Jun '22

08 Jun '22

Attention is currently required from: osmith, laforge, pespin, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712 ) Change subject: Add subscr_conn_fsm ...................................................................... Patch Set 6: (1 comment) File src/osmo-bsc-nat/bssap_conn.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/3d82ef53_f80adb7f PS6, Line 228: (1 blank line) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I7e491aada6f5db0eb35ef2039869c6ba07f9ca3b Gerrit-Change-Number: 27712 Gerrit-PatchSet: 6 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Jun 2022 17:14:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-bsc-nat[master]: Add subscr_conn_fsm
by neels 08 Jun '22

08 Jun '22

Attention is currently required from: osmith, laforge, pespin, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712 ) Change subject: Add subscr_conn_fsm ...................................................................... Patch Set 6: Code-Review+2 (2 comments) File include/osmocom/bsc_nat/subscr_conn_fsm.h: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/c6fc3f01_d5ed874e PS6, Line 31: (doesn't the linter complain about trailing blank lines?) File src/osmo-bsc-nat/bssap_conn.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/04835439_e1639fc9 PS4, Line 47: uint8_t tag = tag_order[i]; > I've looked at the osmo-hnbgw implementation, it's for ASN.1. […] Pau is correct that it would indeed be possible to copy the part leading up to the changed IE and then copy the remaining part after the changed IE (or even memmove in the existing buffer), but i think it would be more code than the current patch set. i like the simplicity of the current patch set. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I7e491aada6f5db0eb35ef2039869c6ba07f9ca3b Gerrit-Change-Number: 27712 Gerrit-PatchSet: 6 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Jun 2022 17:09:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-upf[master]: install libosmo-gtlv, libosmo-pfcp
by neels 08 Jun '22

08 Jun '22

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28245 ) Change subject: install libosmo-gtlv, libosmo-pfcp ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > you mean create a new git repos? […] my opinion is i don't mind either way. the least effort is not moving it around. What is the motivation for a separate repos? -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I9f4651b6bee457583aba99052dc82bbf675515e6 Gerrit-Change-Number: 28245 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Jun 2022 16:56:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-upf[master]: install libosmo-gtlv, libosmo-pfcp
by neels 08 Jun '22

08 Jun '22

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28245 ) Change subject: install libosmo-gtlv, libosmo-pfcp ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > I'm not really sure we should be installing those shared objects from within osmo-upf.git. […] you mean create a new git repos? The other idea we were discussing was moving libosmo-tlv and libosmo-pfcp to libosmocore.git -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I9f4651b6bee457583aba99052dc82bbf675515e6 Gerrit-Change-Number: 28245 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Jun 2022 16:50:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-upf[master]: add pfcp_endpoint
by neels 08 Jun '22

08 Jun '22

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-upf/+/28244 to look at the new patch set (#2). Change subject: add pfcp_endpoint ...................................................................... add pfcp_endpoint Related: SYS#5599 Change-Id: Ic8d42e201b63064a71b40ca45a5a40e29941e8ac --- M include/osmocom/pfcp/Makefile.am A include/osmocom/pfcp/pfcp_endpoint.h M include/osmocom/pfcp/pfcp_msg.h M src/libosmo-pfcp/Makefile.am A src/libosmo-pfcp/pfcp_endpoint.c 5 files changed, 574 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/44/28244/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28244 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic8d42e201b63064a71b40ca45a5a40e29941e8ac Gerrit-Change-Number: 28244 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

2025

2024

2023

2022

gerrit-log June 2022