March 2022 - gerrit-log - lists.osmocom.org

Change in osmo-gsm-manuals[master]: common: gb-ns2: add chapter Gb/NS maintenance

by lynxis lazus

Attention is currently required from: pespin, daniel, lynxis lazus. Hello Jenkins Builder, laforge, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 to look at the new patch set (#6). Change subject: common: gb-ns2: add chapter Gb/NS maintenance ...................................................................... common: gb-ns2: add chapter Gb/NS maintenance Add chapter to describe common maintenance Change-Id: I5571001a127c933397a4bc26e85410288d50fc2f --- A common/chapters/gb-ns2-maintenance.adoc A common/chapters/gb-ns2-nsvc-states-alive.dot A common/chapters/gb-ns2-nsvc-states-reset-block.dot 3 files changed, 130 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/87/24687/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I5571001a127c933397a4bc26e85410288d50fc2f Gerrit-Change-Number: 24687 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmo-gsm-manuals[master]: common: gb-ns2: add chapter Gb/NS maintenance

by lynxis lazus

Attention is currently required from: pespin, daniel, lynxis lazus. Hello Jenkins Builder, laforge, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 to look at the new patch set (#5). Change subject: common: gb-ns2: add chapter Gb/NS maintenance ...................................................................... common: gb-ns2: add chapter Gb/NS maintenance Add chapter to describe common maintenance Change-Id: I5571001a127c933397a4bc26e85410288d50fc2f --- A common/chapters/gb-ns2-maintenance.adoc A common/chapters/gb-ns2-nsvc-states-alive.dot A common/chapters/gb-ns2-nsvc-states-reset-block.dot 3 files changed, 130 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/87/24687/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I5571001a127c933397a4bc26e85410288d50fc2f Gerrit-Change-Number: 24687 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ggsn: Introduce test TC_addr_pool_exhaustion

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27350 ) Change subject: ggsn: Introduce test TC_addr_pool_exhaustion ...................................................................... ggsn: Introduce test TC_addr_pool_exhaustion Related: OS#5469 Related: https://github.com/open5gs/open5gs/pull/1397 Change-Id: Iee24384b35f9277475b02cb59bf04cd6c9f23b1c --- M ggsn_tests/GGSN_Tests.ttcn 1 file changed, 103 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index 58a12a6..05d335a 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -1975,6 +1975,107 @@ setverdict(pass); } + /* Test callocation of PDP contexts until reaching addr pool exhaustion */ + type record of OCT4 TEIClist; + testcase TC_addr_pool_exhaustion() runs on GT_CT { + var Gtp1cUnitdata udc; + var Gtp1uUnitdata udu; + var PdpContext ctx; + timer T_next := 0.005; + var integer next_req_ctx := 0; + var integer rx_resp_ctx := 0; + var integer num_ctx; + var boolean cont_req := true; + var CreatePDPContextResponse cpr; + var TEIClist teic_list := {}; + var integer teic; + + f_init(); + + T_default.start(120.0); + + T_next.start; + alt { + [DIAMETER_PROC.checkstate("Connected")] as_DIA_CCR(INITIAL_REQUEST) { repeat; } + [] pingpong(); + [] T_next.timeout { + if (cont_req) { + if (next_req_ctx - rx_resp_ctx < 100) { /* if we have too many in progress, wait a bit to continue */ + ctx := valueof(t_DefinePDP(f_rnd_imsi('26242'H), f_rnd_msisdn('1234'O), c_ApnInternet, valueof(t_EuaIPv4Dyn))); + ctx.nsapi := '0001'B; + ctx.teic := int2oct(next_req_ctx+1, 4); /* +1: skip TEIC=0 */ + ctx.teid := int2oct(next_req_ctx+1, 4); /* +1: skip TEID=0 */ + f_send_gtpc(ts_GTPC_CreatePDP(g_peer_c, g_c_seq_nr, ctx.imsi, g_restart_ctr, + ctx.teid, ctx.teic, ctx.nsapi, + ctx.eua, ctx.apn, g_sgsn_ip_c, g_sgsn_ip_u, + ctx.msisdn, ctx.pco_req, ctx.ratType, + ctx.uli)); + next_req_ctx := next_req_ctx + 1; + } + T_next.start; + } + repeat; + } + [] GTPC.receive(tr_GTPC_MsgType(g_peer_c, createPDPContextResponse, ?)) -> value udc { + cpr := udc.gtpc.gtpc_pdu.createPDPContextResponse; + + if (cpr.cause.causevalue == '80'O) { + teic_list := teic_list & {cpr.teidControlPlane.teidControlPlane}; + } else { + if (cont_req == true) { + num_ctx := rx_resp_ctx; + log("Successfully created ", num_ctx, " PDP contexts before exhausting the pool"); + setverdict(pass); + } + cont_req := false; + } + rx_resp_ctx := rx_resp_ctx + 1; + if (not cont_req and next_req_ctx == rx_resp_ctx) { + break; + } else { + repeat; + } + } + [] GTPC.receive { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Rx Unexpected GTPC"); } + [] GTPU.receive { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Rx Unexpected GTPU"); } + } + + /* Let's close them now: */ + next_req_ctx := 0; + rx_resp_ctx := 0; + T_next.start; + alt { + [DIAMETER_PROC.checkstate("Connected")] as_DIA_CCR(TERMINATION_REQUEST) { repeat; } + [] pingpong(); + [] T_next.timeout { + f_send_gtpc(ts_GTPC_DeletePDP(g_peer_c, g_c_seq_nr, teic_list[next_req_ctx], '0001'B, '1'B)); + next_req_ctx := next_req_ctx + 1; + if (next_req_ctx < num_ctx) { + T_next.start; + } + repeat; + } + [] GTPC.receive(tr_GTPC_MsgType(g_peer_c, deletePDPContextResponse, ?)) -> value udc { + teic := oct2int(udc.gtpc.teid); + if (not match(teic, (1 .. num_ctx))) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + "Rx Unexpected TEIC"); + } + rx_resp_ctx := rx_resp_ctx + 1; + if (rx_resp_ctx < num_ctx) { + repeat; + } + setverdict(pass); + } + [] GTPC.receive { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Rx Unexpected GTPC"); } + [] GTPU.receive { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Rx Unexpected GTPU"); } + } + T_next.stop; + + T_default.stop; + setverdict(pass); + } + control { execute(TC_pdp4_act_deact()); execute(TC_pdp4_act_deact_ipcp()); @@ -2019,5 +2120,7 @@ execute(TC_pdp_act_restart_ctr_echo()); execute(TC_lots_of_concurrent_pdp_ctx()); + /* Keep at the end, crashes older osmo-ggsn versions (OS#5469): */ + execute(TC_addr_pool_exhaustion()); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27350 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iee24384b35f9277475b02cb59bf04cd6c9f23b1c Gerrit-Change-Number: 27350 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ggsn: Introduce test TC_addr_pool_exhaustion

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27350 ) Change subject: ggsn: Introduce test TC_addr_pool_exhaustion ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27350 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iee24384b35f9277475b02cb59bf04cd6c9f23b1c Gerrit-Change-Number: 27350 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 01 Mar 2022 16:48:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in pysim[master]: pySim-shell: Add 'decode_hex' command for transparent + linear EF

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/27335 ) Change subject: pySim-shell: Add 'decode_hex' command for transparent + linear EF ...................................................................... pySim-shell: Add 'decode_hex' command for transparent + linear EF These commands can be used to decode a user-provided hex-string, instead of decoding the data read from the file. This is useful for quickly manually decoding some values read from other locations, such as e.g. copy+pasted from a eSIM profile in ASN.1 value notation. Change-Id: I81f73bce2c26e3e5dfc7538d223bb2d2483c7fa0 --- M docs/shell.rst M pySim/filesystem.py 2 files changed, 36 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/docs/shell.rst b/docs/shell.rst index f24dc93..2c8da84 100644 --- a/docs/shell.rst +++ b/docs/shell.rst @@ -384,6 +384,13 @@ This allows for easy interactive modification of records. +decode_hex +~~~~~~~~~~ +.. argparse:: + :module: pySim.filesystem + :func: LinFixedEF.ShellCommands.dec_hex_parser + + Transparent EF commands ----------------------- @@ -460,6 +467,13 @@ This allows for easy interactive modification of file contents. +decode_hex +~~~~~~~~~~ +.. argparse:: + :module: pySim.filesystem + :func: TransparentEF.ShellCommands.dec_hex_parser + + BER-TLV EF commands ------------------- diff --git a/pySim/filesystem.py b/pySim/filesystem.py index f8b86c5..5bbd57b 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -526,6 +526,17 @@ def __init__(self): super().__init__() + dec_hex_parser = argparse.ArgumentParser() + dec_hex_parser.add_argument('--oneline', action='store_true', + help='No JSON pretty-printing, dump as a single line') + dec_hex_parser.add_argument('HEXSTR', help='Hex-string of encoded data to decode') + + @cmd2.with_argparser(dec_hex_parser) + def do_decode_hex(self, opts): + """Decode command-line provided hex-string as if it was read from the file.""" + data = self._cmd.rs.selected_file.decode_hex(opts.HEXSTR) + self._cmd.poutput_json(data, opts.oneline) + read_bin_parser = argparse.ArgumentParser() read_bin_parser.add_argument( '--offset', type=int, default=0, help='Byte offset for start of read') @@ -738,6 +749,17 @@ def __init__(self, **kwargs): super().__init__(**kwargs) + dec_hex_parser = argparse.ArgumentParser() + dec_hex_parser.add_argument('--oneline', action='store_true', + help='No JSON pretty-printing, dump as a single line') + dec_hex_parser.add_argument('HEXSTR', help='Hex-string of encoded data to decode') + + @cmd2.with_argparser(dec_hex_parser) + def do_decode_hex(self, opts): + """Decode command-line provided hex-string as if it was read from the file.""" + data = self._cmd.rs.selected_file.decode_record_hex(opts.HEXSTR) + self._cmd.poutput_json(data, opts.oneline) + read_rec_parser = argparse.ArgumentParser() read_rec_parser.add_argument( 'record_nr', type=int, help='Number of record to be read') -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27335 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I81f73bce2c26e3e5dfc7538d223bb2d2483c7fa0 Gerrit-Change-Number: 27335 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in pysim[master]: pySim-shell: Add 'decode_hex' command for transparent + linear EF

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27335 ) Change subject: pySim-shell: Add 'decode_hex' command for transparent + linear EF ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27335 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I81f73bce2c26e3e5dfc7538d223bb2d2483c7fa0 Gerrit-Change-Number: 27335 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 01 Mar 2022 16:48:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: New stats for lchan life duration.

by laforge

Attention is currently required from: iedemam. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 ) Change subject: New stats for lchan life duration. ...................................................................... Patch Set 12: Code-Review+1 (1 comment) Patchset: PS12: I'd be happy to see this patch moving ahead, but with the unit tests failing, that's of course not an option... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 12 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Comment-Date: Tue, 01 Mar 2022 16:36:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: inter-BSC HO in: expect codecs in HO Request ACK

by laforge

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27311 ) Change subject: bsc: inter-BSC HO in: expect codecs in HO Request ACK ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27311 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib2b4e27be241e2a92c0c3bffdf906bf22c09352b Gerrit-Change-Number: 27311 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 01 Mar 2022 16:35:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-gsm-manuals[master]: common: gb-ns2: add chapter Gb/NS maintenance

by laforge

Attention is currently required from: pespin, daniel, lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 ) Change subject: common: gb-ns2: add chapter Gb/NS maintenance ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I5571001a127c933397a4bc26e85410288d50fc2f Gerrit-Change-Number: 24687 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 01 Mar 2022 16:35:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-gsm-manuals[master]: common: gb-ns2: add chapter Gb/NS maintenance

by laforge

Attention is currently required from: pespin, daniel, lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 ) Change subject: common: gb-ns2: add chapter Gb/NS maintenance ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: asciidoc: WARNING: gb.adoc: line 28: callout refers to non-existent list item 1234 asciidoc: WARNING: gb.adoc: line 28: callout refers to non-existent list item 1235 ../build/Makefile.asciidoc.inc:90: recipe for target 'test-usermanual.check' failed -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I5571001a127c933397a4bc26e85410288d50fc2f Gerrit-Change-Number: 24687 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 01 Mar 2022 16:35:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

2024

2023

2022

gerrit-log March 2022