March 2022 - gerrit-log - lists.osmocom.org

Change in meta-telephony[laforge/nightly]: osmo-ggsn: rebase libgtp-queue_depth_32.patch

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/meta-telephony/+/27358 ) Change subject: osmo-ggsn: rebase libgtp-queue_depth_32.patch ...................................................................... osmo-ggsn: rebase libgtp-queue_depth_32.patch Adjust to change in osmo-ggsn I6034b0fab2b2e5962314c2fca2f893246ce5cf4f ("libgtp: Define retransmit QUEUE_SIZE relative to PDP_MAX (increase)"). Fix for: Applying patch libgtp-queue_depth_32.patch patching file gtp/queue.h Hunk #1 FAILED at 19. Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 --- M recipes-osmocom/osmo-ggsn/files/libgtp-queue_depth_32.patch 1 file changed, 32 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/58/27358/1 diff --git a/recipes-osmocom/osmo-ggsn/files/libgtp-queue_depth_32.patch b/recipes-osmocom/osmo-ggsn/files/libgtp-queue_depth_32.patch index 52bc37b..99e5dd5 100644 --- a/recipes-osmocom/osmo-ggsn/files/libgtp-queue_depth_32.patch +++ b/recipes-osmocom/osmo-ggsn/files/libgtp-queue_depth_32.patch @@ -1,13 +1,34 @@ -diff --git a/gtp/queue.h b/gtp/queue.h -index 556b6ef..d59a1a3 100644 ---- a/gtp/queue.h -+++ b/gtp/queue.h -@@ -19,7 +19,7 @@ +From 295d85927658a734cf544e03abd28ec33c5bfb2c Mon Sep 17 00:00:00 2001 +From: Oliver Smith <osmith(a)sysmocom.de> +Date: Wed, 2 Mar 2022 11:24:31 +0100 +Subject: [PATCH] libgtp: reduce queue depth to 32 + +Set PDP_MAX to 16 and QUEUE_SIZE to 32 (QUEUE_SIZE is PDP_MAX * 2, see +gtp/queue.h). Harald explained why: + + libgtp statically allocates immensely large queues for packet + re-transmissions by default, way too much to run OsmoSGSN or + OpenGGSN/OsmoGGSN on the small ARM926EJS of sysmoBTS 1002. + +Related: https://gerrit.osmocom.org/c/meta-telephony/+/4092/2#message-8ec2174fac6c0b… +Change-Id: I97d5db8f2def4d628a6c4e67c27f07c7200b94d4 +--- + gtp/pdp.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/gtp/pdp.h b/gtp/pdp.h +index 4dcdde46..5db08af3 100644 +--- a/gtp/pdp.h ++++ b/gtp/pdp.h +@@ -24,7 +24,7 @@ struct gsn_t; + #define LOGPDPX(ss, level, pdp, fmt, args...) \ + LOGP(ss, level, "PDP(%s:%u): " fmt, imsi_gtp2str(&(pdp)->imsi), (pdp)->nsapi, ## args) - #define QUEUE_DEBUG 0 /* Print debug information */ +-#define PDP_MAX 1024 /* Max number of PDP contexts */ ++#define PDP_MAX 16 /* Max number of PDP contexts */ + #define PDP_MAXNSAPI 16 /* Max number of NSAPI */ --#define QUEUE_SIZE 1024 /* Size of retransmission queue */ -+#define QUEUE_SIZE 32 /* Size of retransmission queue */ - #define QUEUE_HASH_SIZE 65536 /* Size of hash table (2^16) */ - - struct qmsg_t { /* Holder for queued packets */ + #define PDP_EUA_ORG_IETF 0xF1 +-- +2.30.2 + -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 Gerrit-Change-Number: 27358 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: New stats for lchan life duration.

by iedemam

Attention is currently required from: laforge. iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 ) Change subject: New stats for lchan life duration. ...................................................................... Patch Set 12: (1 comment) Patchset: PS12: > I'd be happy to see this patch moving ahead, but with the unit tests failing, that's of course not a […] Thanks for the confidence boost. I have two other things on my plate at the moment but will be back to this as soon as I can. It really would be a huge feature for us. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 12 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 02 Mar 2022 10:15:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: bitvec2freq_list(): fix handling of E-GSM ARFCNs

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27356 ) Change subject: bitvec2freq_list(): fix handling of E-GSM ARFCNs ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: > What? It's there. Next line after the 'Change-Id'. my bad, sorry. I would usually have expected it above the Change-Id and hence my brain stopped parsing at that line :( File src/osmo-bsc/system_information.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27356/comment/d3a17f61_83061227 PS1, Line 508: && bts->c0->arfcn >= 1 && bts->c0->arfcn <= 124) : pgsm = true; > This is also an option, yes. […] I think it's confusing that we have a variable whether or not we are in the PGSM case, but it is true even in a non-PGSM case. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I17739e6845cd84e2a81bc406dd532541f7c52cb6 Gerrit-Change-Number: 27356 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 09:45:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: bitvec2freq_list(): determine empty set by checking the ARFCN count

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27357 ) Change subject: bitvec2freq_list(): determine empty set by checking the ARFCN count ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > IMHO, this is what holger would have called "sideways development". […] I find it cleaner to relay on the counter ('arfcns' in this case) to check if the set is empty, rather than checking one of the resulting values ('max'). There is no advantage of this method, it just makes the code easier to read. But in general, I don't care. This patch can be abandoned. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I29ca51461beec053bcb8b8210f0ad24bb8c7765f Gerrit-Change-Number: 27357 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 02 Mar 2022 09:27:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: bitvec2freq_list(): fix handling of E-GSM ARFCNs

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27356 ) Change subject: bitvec2freq_list(): fix handling of E-GSM ARFCNs ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: > also, missing Related: SYS#.... What? It's there. Next line after the 'Change-Id'. File src/osmo-bsc/system_information.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27356/comment/9c82b989_d970bae6 PS1, Line 508: && bts->c0->arfcn >= 1 && bts->c0->arfcn <= 124) : pgsm = true; > isn't this the true bug? PGSM is primary GSM, and not E-GSM 900. […] This is also an option, yes. Currently we assume that all ARFCNs are in P-GSM, and fall-back to other encodings if we find an out-of-range (i.e. E-GSM) value. https://gerrit.osmocom.org/c/osmo-bsc/+/27356/comment/34f9fd24_f1d4a737 PS1, Line 522: / > how are we attempting to use a different format here? we return an error. I am adding an 'if' statement right after the 'for' loop (see line 532), which checks rc. If it's 0, then we return 0. If not, then we fall-back to other encoding formats. I can change it to do 'goto foo_bar' instead of setting rc to -ERANGE. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I17739e6845cd84e2a81bc406dd532541f7c52cb6 Gerrit-Change-Number: 27356 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 09:21:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: bitvec2freq_list(): fix handling of E-GSM ARFCNs

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27356 ) Change subject: bitvec2freq_list(): fix handling of E-GSM ARFCNs ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: also, missing Related: SYS#.... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I17739e6845cd84e2a81bc406dd532541f7c52cb6 Gerrit-Change-Number: 27356 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 09:14:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: bitvec2freq_list(): determine empty set by checking the ARFCN count

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27357 ) Change subject: bitvec2freq_list(): determine empty set by checking the ARFCN count ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: IMHO, this is what holger would have called "sideways development". It changes something without improving it ("moving forward"). If there's a clear advantage of your method, please explain it in the changelog. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I29ca51461beec053bcb8b8210f0ad24bb8c7765f Gerrit-Change-Number: 27357 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 09:14:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: bitvec2freq_list(): fix handling of E-GSM ARFCNs

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27356 ) Change subject: bitvec2freq_list(): fix handling of E-GSM ARFCNs ...................................................................... Patch Set 1: Code-Review-1 (3 comments) Patchset: PS1: this is the kind of issue where a clear-cut unit test showing the bug should be introduced first, and then the bug should be fixed in a follow-up commit, demonstrating that the unit test now passes. I don't see immediately how his commit fixes anything - all it does is to return error values to the caller and log something, but it's not immediately obvious how an alternative encoding is chosen. File src/osmo-bsc/system_information.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27356/comment/14e3e6ae_1cdc5154 PS1, Line 508: && bts->c0->arfcn >= 1 && bts->c0->arfcn <= 124) : pgsm = true; isn't this the true bug? PGSM is primary GSM, and not E-GSM 900. So the pgsm flag should never be set in a situation where E-GSM channels are used. Maybe we should not just check for c0->arfcn but iterate over all channels and set pgsm only true if all of them are within the P-GSM range? https://gerrit.osmocom.org/c/osmo-bsc/+/27356/comment/a9653cb1_024d2227 PS1, Line 522: / how are we attempting to use a different format here? we return an error. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I17739e6845cd84e2a81bc406dd532541f7c52cb6 Gerrit-Change-Number: 27356 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 09:13:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: bitvec2freq_list(): fix handling of E-GSM ARFCNs

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27356 ) Change subject: bitvec2freq_list(): fix handling of E-GSM ARFCNs ...................................................................... bitvec2freq_list(): fix handling of E-GSM ARFCNs According to 3GPP TS 44.018, section 10.5.2.1b.2, only ARFCN values in range 1..124 can be encoded using the 'bit map 0' format. Before this patch, ARFCN values belonging to E-GSM band (0, 975..1023) were ignored in bitvec2freq_list(), and thus not present in the resulting Cell Channel Description IE. Let's fix this by falling back to other encoding formats. Change-Id: I17739e6845cd84e2a81bc406dd532541f7c52cb6 Related: SYS#5854 --- M src/osmo-bsc/system_information.c 1 file changed, 17 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/56/27356/1 diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index 974af3a..885bdd3 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -512,14 +512,25 @@ chan_list[0] = 0; for (i = 0; i < bv->data_len*8; i++) { - if (i >= 1 && i <= 124 - && bitvec_get_bit_pos(bv, i)) { - rc = freq_list_bm0_set_arfcn(chan_list, i); - if (rc < 0) - return rc; + if (!bitvec_get_bit_pos(bv, i)) + continue; + /* According to 3GPP TS 44.018, section 10.5.2.1b.2, only the + * ARFCN values in range 1..124 can be encoded using this format. */ + if (i == 0 || i > 124) { + LOGP(DRR, LOGL_DEBUG, "ARFCN %d exceeds the range 1..124, " + "so we cannot use the 'bit map 0' format\n", i); + /* Attempt to use a different encoding format */ + memset(chan_list, 0, 16); + rc = -ERANGE; + break; } + rc = freq_list_bm0_set_arfcn(chan_list, i); + if (rc < 0) + return rc; } - return 0; + + if (rc == 0) + return 0; } for (i = 0; i < bv->data_len*8; i++) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I17739e6845cd84e2a81bc406dd532541f7c52cb6 Gerrit-Change-Number: 27356 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: bitvec2freq_list(): determine empty set by checking the ARFCN count

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27357 ) Change subject: bitvec2freq_list(): determine empty set by checking the ARFCN count ...................................................................... bitvec2freq_list(): determine empty set by checking the ARFCN count Change-Id: I29ca51461beec053bcb8b8210f0ad24bb8c7765f Related: SYS#5854 --- M src/osmo-bsc/system_information.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/57/27357/1 diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index 885bdd3..b5198dd 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -564,7 +564,7 @@ max = i; } - if (max == -1) { + if (arfcns == 0) { /* Empty set, use 'bit map 0 format' */ chan_list[0] = 0; return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I29ca51461beec053bcb8b8210f0ad24bb8c7765f Gerrit-Change-Number: 27357 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022